BaseNotificationTraitTest::via_custom_notifiation_exist() - Code Metrics - Inspection of "End phpunti test" - thecodingmachine/laravel-server-monitor-plugin-notification-by-host - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bcdbf3...5b3224 )

by Marc

created 2017-12-22 10:59 UTC

via_custom_notifiation_exist() B

↳ Parent: BaseNotificationTraitTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	35
Code Lines	20

Duplication

Lines	35
Ratio	100 %

Importance

Changes

Metric	Value
dl	35
loc	35
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	20
nc	1
nop	0

<?php
namespace TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications;

use TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckFailed;
use TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckSucceeded;
use TheCodingMachine\ServerMonitorPluginNotificationByHost\Test\TestCase;
use Spatie\ServerMonitor\Models\Check;
use Spatie\ServerMonitor\Models\Enums\CheckStatus;
use Spatie\ServerMonitor\Models\Host;

class BaseNotificationTraitTest extends TestCase
{


    /**
     * @var \TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifiable
     */
    private $notifiable;

    public function setUp() {
        parent::setUp();
        $this->notifiable = new Notifiable();

    }

    /** @test */
    function via() {


        $checks = ['diskspace'];

        $host = Host::create([
            'name' => 'test',
            'port' => 22,
        ]);

        $host->checks()->saveMany(collect($checks)->map(function (string $checkName) {
            return new Check([
                'type' => $checkName,
                'status' => CheckStatus::NOT_YET_CHECKED,
            ]);
        }));

        $event = new \Spatie\ServerMonitor\Events\CheckSucceeded($host->checks()->first());
        $this->notifiable->setEvent($event);

        $check = new CheckFailed();
        $result = $check->via($this->notifiable);
        $this->assertSame('slack', $result[0]);
    }

    /** @test */
    function via_custom() {


        $checks = ['diskspace'];

        $host = Host::create([
            'name' => 'test2',
            'port' => 22,
        ]);

        $host->checks()->saveMany(collect($checks)->map(function (string $checkName) {
            return new Check([
                'type' => $checkName,
                'status' => CheckStatus::NOT_YET_CHECKED,
            ]);
        }));

        $event = new \Spatie\ServerMonitor\Events\CheckSucceeded($host->checks()->first());
        $this->notifiable->setEvent($event);

        $host = $this->notifiable->getEvent()->check->host()->first();
        $notifications =  [
            'TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckSucceeded' =>
                [
                    'channels' => ['mail']
                ],
            'configuration' => ['mail' => [ 'to' => ['[email protected]'] ]]
        ];

        $host->setCustomProperty('notifications', $notifications);

        $host->save();

        $check = new CheckFailed();
        $result = $check->via($this->notifiable);
        $this->assertCount(0, $result);
    }

    /** @test */
    function via_custom_notifiation_exist() {


        $checks = ['diskspace'];

        $host = Host::create([
            'name' => 'test',
            'port' => 22,
        ]);

        $host->checks()->saveMany(collect($checks)->map(function (string $checkName) {
            return new Check([
                'type' => $checkName,
                'status' => CheckStatus::NOT_YET_CHECKED,
            ]);
        }));

        $event = new \Spatie\ServerMonitor\Events\CheckSucceeded($host->checks()->first());
        $this->notifiable->setEvent($event);

        $host = $this->notifiable->getEvent()->check->host()->first();
        $notifications =  [
            'TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckFailed' =>
                [
                    'channels' => ['mail']
                ],
            'configuration' => ['mail' => [ 'to' => ['[email protected]'] ]]
        ];

        $host->setCustomProperty('notifications', $notifications);

        $host->save();

        $check = new CheckFailed();
        $result = $check->via($this->notifiable);
        $this->assertSame('mail', $result[0]);
    }
}


1		<?php
2		namespace TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications;
3
4		use TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckFailed;
5		use TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckSucceeded;
6		use TheCodingMachine\ServerMonitorPluginNotificationByHost\Test\TestCase;
7		use Spatie\ServerMonitor\Models\Check;
8		use Spatie\ServerMonitor\Models\Enums\CheckStatus;
9		use Spatie\ServerMonitor\Models\Host;
10
11		class BaseNotificationTraitTest extends TestCase
12		{
13
14
15		/**
16		* @var \TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifiable
17		*/
18		private $notifiable;
19
20		public function setUp() {
21		parent::setUp();
22		$this->notifiable = new Notifiable();
23
24		}
25
26		/** @test */
27		function via() {
		0 ignored issues – show Best Practice introduced 2017-12-22 11:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28
29		$checks = ['diskspace'];
30
31		$host = Host::create([
32		'name' => 'test',
33		'port' => 22,
34		]);
35
36		$host->checks()->saveMany(collect($checks)->map(function (string $checkName) {
37		return new Check([
38		'type' => $checkName,
39		'status' => CheckStatus::NOT_YET_CHECKED,
40		]);
41		}));
42
43		$event = new \Spatie\ServerMonitor\Events\CheckSucceeded($host->checks()->first());
44		$this->notifiable->setEvent($event);
45
46		$check = new CheckFailed();
47		$result = $check->via($this->notifiable);
48		$this->assertSame('slack', $result[0]);
49		}
50
51		/** @test */
52	View Code Duplication	function via_custom() {
		0 ignored issues – show Best Practice introduced 2017-12-22 11:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2017-12-22 11:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53
54		$checks = ['diskspace'];
55
56		$host = Host::create([
57		'name' => 'test2',
58		'port' => 22,
59		]);
60
61		$host->checks()->saveMany(collect($checks)->map(function (string $checkName) {
62		return new Check([
63		'type' => $checkName,
64		'status' => CheckStatus::NOT_YET_CHECKED,
65		]);
66		}));
67
68		$event = new \Spatie\ServerMonitor\Events\CheckSucceeded($host->checks()->first());
69		$this->notifiable->setEvent($event);
70
71		$host = $this->notifiable->getEvent()->check->host()->first();
72		$notifications = [
73		'TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckSucceeded' =>
74		[
75		'channels' => ['mail']
76		],
77		'configuration' => ['mail' => [ 'to' => ['[email protected]'] ]]
78		];
79
80		$host->setCustomProperty('notifications', $notifications);
81
82		$host->save();
83
84		$check = new CheckFailed();
85		$result = $check->via($this->notifiable);
86		$this->assertCount(0, $result);
87		}
88
89		/** @test */
90	View Code Duplication	function via_custom_notifiation_exist() {
		0 ignored issues – show Best Practice introduced 2017-12-22 11:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2017-12-22 11:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91
92		$checks = ['diskspace'];
93
94		$host = Host::create([
95		'name' => 'test',
96		'port' => 22,
97		]);
98
99		$host->checks()->saveMany(collect($checks)->map(function (string $checkName) {
100		return new Check([
101		'type' => $checkName,
102		'status' => CheckStatus::NOT_YET_CHECKED,
103		]);
104		}));
105
106		$event = new \Spatie\ServerMonitor\Events\CheckSucceeded($host->checks()->first());
107		$this->notifiable->setEvent($event);
108
109		$host = $this->notifiable->getEvent()->check->host()->first();
110		$notifications = [
111		'TheCodingMachine\ServerMonitorPluginNotificationByHost\Notifications\Notifications\CheckFailed' =>
112		[
113		'channels' => ['mail']
114		],
115		'configuration' => ['mail' => [ 'to' => ['[email protected]'] ]]
116		];
117
118		$host->setCustomProperty('notifications', $notifications);
119
120		$host->save();
121
122		$check = new CheckFailed();
123		$result = $check->via($this->notifiable);
124		$this->assertSame('mail', $result[0]);
125		}
126		}
127

thecodingmachine / laravel-server-monitor-plugin-notification-by-host

Push — master ( bcdbf3...5b3224 )

via_custom_notifiation_exist() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like