Mouf\Html\Utils\WebLibraryManager\WebLibraryManagerValidator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	validateClass()	0	31	6

<?php
namespace Mouf\Html\Utils\WebLibraryManager;

use Mouf\Validator\MoufStaticValidatorInterface;
use Mouf\Composer\ComposerService;
use Mouf\Validator\MoufValidatorResult;
use Mouf\MoufManager;

/**
 * This validator is in charge of checking that "component" packages have matching weblibraries
 * declared in Mouf.
 * 
 * @author David Négrier
 */
class WebLibraryManagerValidator implements MoufStaticValidatorInterface {
	
	/**
	 * Runs the validation of the class.
	 * Returns a MoufValidatorResult explaining the result.
	 *
	 * @return MoufValidatorResult
	 */
	static function validateClass() {

It is generally recommended to explicitly declare the visibility for methods.

		$composerService = new ComposerService();
		$packages = $composerService->getLocalPackagesOrderedByDependencies();
		
		$componentViolations = array();
		$moufManager = MoufManager::getMoufManager();
		
		foreach ($packages as $package) {
			/* @var $package PackageInterface */
			if ($package->getType() == "component") {
				$extra = $package->getExtra();
				 
				if (isset($extra['component']['name'])) {
					$packageName = $extra['component']['name'];
				} else {
					$packageName = explode('/', $package->getName())[1];
				}
	
				if (!$moufManager->has("component.".$packageName)) {
					$componentViolations[] = $packageName;
				}
			}
		}

		if (!$componentViolations) {

The expression $componentViolations of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			return new MoufValidatorResult(MoufValidatorResult::SUCCESS, "<b>WebLibraryManager: </b>No missing WebLibrary for Bower or Components packages.");
		} else {
			return new MoufValidatorResult(MoufValidatorResult::ERROR, "<b>WebLibraryManager: </b>Missing matching WebLibrary for package(s) ".implode(', ', $componentViolations).
				"<div><a href='".MOUF_URL."assetsIntegration/fixAll' class='btn btn-success'>Click here to create all web-libraries matching these packages</a></div>");
		}
	}
}