TheCodingMachine\Funky\ExtensionDefinition

Complexity

Total Complexity

15

Size/Duplication

Total Lines	90
Duplicated Lines	33.33 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	22	22	6
C	buildExtensionCode()	7	51	8
A	getInjections()	0	5	1

<?php


namespace TheCodingMachine\Funky;

use ReflectionMethod;
use TheCodingMachine\Funky\Annotations\Extension;
use TheCodingMachine\Funky\Injections\Injection;

class ExtensionDefinition extends AbstractDefinition
{
    public function __construct(ReflectionMethod $reflectionMethod, Extension $annotation)

This method seems to be duplicated in your project.

    {
        if (!$reflectionMethod->isPublic()) {
            throw BadModifierException::mustBePublic($reflectionMethod, '@Extension');
        }
        if (!$reflectionMethod->isStatic()) {
            throw BadModifierException::mustBeStatic($reflectionMethod, '@Extension');
        }

        if ($annotation->isFromMethodName()) {
            $this->name = $reflectionMethod->getName();
        } elseif ($annotation->isFromType()) {
            $returnType = $reflectionMethod->getReturnType();
            if ($returnType === null) {
                throw UnknownTypeException::create($reflectionMethod);
            }
            $this->name = (string) $returnType;
        } else {
            $this->name = (string) $annotation->getName();
        }

        parent::__construct($reflectionMethod);
    }

    public function buildExtensionCode(string $functionName) : string
    {
        $returnTypeCode = '';
        $returnType = $this->reflectionMethod->getReturnType();
        if ($returnType) {

This code seems to be duplicated across your project.

            if ($returnType->isBuiltin()) {
                $returnTypeCode = ': '.$this->reflectionMethod->getReturnType();
            } else {
                $returnTypeCode = ': \\'.$this->reflectionMethod->getReturnType();
            }
        }

        $parameters = $this->reflectionMethod->getParameters();

        $previousParameterCode = '';
        $previousTypeCode = '';
        if (count($parameters) >= 1) {
            $previousParameter = $this->reflectionMethod->getParameters()[0];
            $previousType = $previousParameter->getType();
            if ($previousType) {
                if ($previousType->isBuiltin()) {
                    $previousTypeCode = (string) $previousType.' ';
                } else {
                    $previousTypeCode = '\\'.(string) $previousType.' ';
                }
            }
            $previousParameterCode = ', '.$previousTypeCode.'$previous';
            if ($previousParameter->isDefaultValueAvailable()) {
                $previousParameterCode .= ' = '.var_export($previousParameter->getDefaultValue(), true);
            }
        }


        return sprintf(
            <<<EOF
    public static function %s(ContainerInterface \$container%s)%s
    {
        return %s::%s(%s%s);
    }
    
EOF
            ,
            $functionName,
            $previousParameterCode,
            $returnTypeCode,
            '\\'.$this->reflectionMethod->getDeclaringClass()->getName(),
            $this->reflectionMethod->getName(),
            $previousParameterCode ? '$previous': '',
            implode('', array_map(function (Injection $injection) {
                return ', '.$injection->getCode();
            }, $this->getInjections()))
        );
    }

    /**
     * Returns a list of services to be injected.
     *
     * @return Injection[]
     */
    private function getInjections(): array
    {
        $parameters = $this->getReflectionMethod()->getParameters();
        array_shift($parameters);
        return array_map([$this, 'mapParameterToInjection'], $parameters);
    }
}