FileSystem::rmdir() - Code Metrics - Inspection of "First version with compiled factories and support..." - thecodingmachine/funky - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by David

created 2017-11-03 12:26 UTC

FileSystem::rmdir() B

↳ Parent: FileSystem

Complexity

Conditions	6
Paths	5

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	9
nc	5
nop	1
dl	0
loc	14
rs	8.8571
c	0
b	0
f	0

<?php
namespace TheCodingMachine\Funky\Utils;

use TheCodingMachine\Funky\IoException;

class FileSystem
{
    public static function mkdir(string $dir, int $mode = 0777): void
    {
        if (is_dir($dir)) {
            return;
        }

        if (true !== @mkdir($dir, $mode, true)) {
            $error = error_get_last();
            if (!is_dir($dir)) {
                // The directory was not created by a concurrent process. Let's throw an exception with a developer friendly error message if we have one
                if ($error) {

                    throw IoException::cannotCreateDirectory($dir, $error['message']);
                }
                throw IoException::cannotCreateDirectory($dir, 'unknown error');
            }
        }
    }

    public static function rmdir(string $dir): void
    {
        if (is_dir($dir)) {
            $objects = scandir($dir);
            foreach ($objects as $object) {
                if ($object !== "." && $object !== "..") {
                    if (is_dir($dir. '/' .$object)) {
                        self::rmdir($dir. '/' .$object);
                    } else {
                        unlink($dir. '/' .$object);
                    }
                }
            }
            rmdir($dir);
        }
    }
}


1			<?php
2			namespace TheCodingMachine\Funky\Utils;
3
4			use TheCodingMachine\Funky\IoException;
5
6			class FileSystem
7			{
8			public static function mkdir(string $dir, int $mode = 0777): void
9			{
10			if (is_dir($dir)) {
11			return;
12			}
13
14			if (true !== @mkdir($dir, $mode, true)) {
15			$error = error_get_last();
16			if (!is_dir($dir)) {
17			// The directory was not created by a concurrent process. Let's throw an exception with a developer friendly error message if we have one
18			if ($error) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-03 12:28 UTC by Report Bug Copy Issue Report The expression `$error` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
19			throw IoException::cannotCreateDirectory($dir, $error['message']);
20			}
21			throw IoException::cannotCreateDirectory($dir, 'unknown error');
22			}
23			}
24			}
25
26			public static function rmdir(string $dir): void
27			{
28			if (is_dir($dir)) {
29			$objects = scandir($dir);
30			foreach ($objects as $object) {
31			if ($object !== "." && $object !== "..") {
32			if (is_dir($dir. '/' .$object)) {
33			self::rmdir($dir. '/' .$object);
34			} else {
35			unlink($dir. '/' .$object);
36			}
37			}
38			}
39			rmdir($dir);
40			}
41			}
42			}
43

thecodingmachine / funky

Pull Request — master (#1)

FileSystem::rmdir() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like