Drupal\easy_entity_reader\Converters\ImageItemConverter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	convert()	0	23	5
A	canConvert()	0	4	1

<?php

namespace Drupal\easy_entity_reader\Converters;

use Drupal\Core\Field\FieldItemInterface;
use Drupal\easy_entity_reader\EntityWrapper;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\image\Plugin\Field\FieldType\ImageItem;
use Drupal\easy_entity_reader\CompositeArrayAccess;

/**
 * Convert image class to value.
 *
 * Class DefaultConverter.
 */
class ImageItemConverter implements ConverterInterface
{
    /**
     * @var EntityWrapper
     */
    private $entityWrapper;

    /**
     * @var EntityTypeManagerInterface
     */
    private $entityManager;

    /**
     * @param EntityWrapper              $entityWrapper
     * @param EntityTypeManagerInterface $entityManager
     */
    public function __construct(EntityWrapper $entityWrapper,
        EntityTypeManagerInterface $entityManager)
    {
        $this->entityWrapper = $entityWrapper;
        $this->entityManager = $entityManager;
    }

    /**
     * @param FieldItemInterface $value
     */
    public function convert(FieldItemInterface $value)
    {
        $values = $value->getValue();
        $type = str_replace('default:', '', $value->getParent()->getSettings()['handler']);

It seems like you code against a concrete implementation and not the interface Drupal\Core\TypedData\TraversableTypedDataInterface as the method getSettings() does only exist in the following implementations of said interface: Drupal\Core\Field\ChangedFieldItemList, Drupal\Core\Field\EntityReferenceFieldItemList, Drupal\Core\Field\FieldItemBase, Drupal\Core\Field\FieldItemList, Drupal\Core\Field\Plugin\Field\FieldType\BooleanItem, Drupal\Core\Field\Plugin\Field\FieldType\ChangedItem, Drupal\Core\Field\Plugin\Field\FieldType\CreatedItem, Drupal\Core\Field\Plugin\Field\FieldType\DecimalItem, Drupal\Core\Field\Plugin\Field\FieldType\EmailItem, Drupal\Core\Field\Plugin\Field\FieldType\EntityReferenceItem, Drupal\Core\Field\Plugin\Field\FieldType\FloatItem, Drupal\Core\Field\Plugin\Field\FieldType\IntegerItem, Drupal\Core\Field\Plugin\Field\FieldType\LanguageItem, Drupal\Core\Field\Plugin\Field\FieldType\MapItem, Drupal\Core\Field\Plugin\Field\FieldType\NumericItemBase, Drupal\Core\Field\Plugin\Field\FieldType\PasswordItem, Drupal\Core\Field\Plugin\Field\FieldType\StringItem, Drupal\Core\Field\Plugin\Field\FieldType\StringItemBase, Drupal\Core\Field\Plugin\Field\FieldType\StringLongItem, Drupal\Core\Field\Plugin\Field\FieldType\TimestampItem, Drupal\Core\Field\Plugin\Field\FieldType\UriItem, Drupal\Core\Field\Plugin\Field\FieldType\UuidItem, Drupal\comment\CommentFieldItemList, Drupal\comment\Plugin\Field\FieldType\CommentItem, Drupal\content_moderation\Plugin\Field\ModerationStateFieldItemList, Drupal\datetime\Plugin\Field\FieldType\DateTimeFieldItemList, Drupal\datetime\Plugin\Field\FieldType\DateTimeItem, Drupal\datetime_range\Plugin\Field\FieldType\DateRangeFieldItemList, Drupal\datetime_range\Plugin\Field\FieldType\DateRangeItem, Drupal\entity_reference\ConfigurableEntityReferenceItem, Drupal\entity_test\Plugin\Field\FieldType\AutoIncrementingTestItem, Drupal\entity_test\Plugin\Field\FieldType\ChangedTestItem, Drupal\entity_test\Plugin\Field\FieldType\FieldTestItem, Drupal\entity_test\Plugin\Field\FieldType\ShapeItem, Drupal\entity_test\Plugin\Field\FieldType\ShapeItemRequired, Drupal\field_collection\Plugin\Field\FieldType\FieldCollection, Drupal\field_test\Plugin\Field\FieldType\HiddenTestItem, Drupal\field_test\Plugin\Field\FieldType\TestItem, Drupal\field_test\Plugin\Field\FieldType\TestItemWithDependencies, Drupal\field_test\Plugin\Field\FieldType\TestItemWithPreconfiguredOptions, Drupal\field_test\Plugin\Field\FieldType\TestObjectItem, Drupal\file\Plugin\Field\FieldType\FileFieldItemList, Drupal\file\Plugin\Field\FieldType\FileItem, Drupal\image\Plugin\Field\FieldType\ImageItem, Drupal\language\DefaultLanguageItem, Drupal\link\Plugin\Field\FieldType\LinkItem, Drupal\options\Plugin\Field\FieldType\ListFloatItem, Drupal\options\Plugin\Field\FieldType\ListIntegerItem, Drupal\options\Plugin\Field\FieldType\ListItemBase, Drupal\options\Plugin\Field\FieldType\ListStringItem, Drupal\path\Plugin\Field\FieldType\PathFieldItemList, Drupal\path\Plugin\Field\FieldType\PathItem, Drupal\telephone\Plugin\Field\FieldType\TelephoneItem, Drupal\text\Plugin\Field\FieldType\TextItem, Drupal\text\Plugin\Field\FieldType\TextItemBase, Drupal\text\Plugin\Field\FieldType\TextLongItem, Drupal\text\Plugin\Field\FieldType\TextWithSummaryItem, Drupal\user\UserNameItem.

        $node = $this->entityManager->getStorage($type)->load($values['target_id']);

        $frontArray = [];
        if (isset($values['alt'])) {
            $frontArray['alt'] = $values['alt'];
        }
        if (isset($values['title'])) {
            $frontArray['title'] = $values['title'];
        }
        if (isset($values['width'])) {
            $frontArray['width'] = $values['width'];
        }
        if (isset($values['height'])) {
            $frontArray['height'] = $values['height'];
        }
        $wrap = $this->entityWrapper->wrap($node);

It seems like $node defined by $this->entityManager->getStorage($type)->load($values['target_id']) on line 46 can be null; however, Drupal\easy_entity_reader\EntityWrapper::wrap() does not accept null, maybe add an additional type check?

        return new CompositeArrayAccess([$frontArray, $wrap]);
    }

    /**
     * Returns whether the FieldItemInterface can be converted or not.
     *
     * @param FieldItemInterface $value
     *
     * @return bool
     */
    public function canConvert(FieldItemInterface $value) : bool
    {
        return $value instanceof ImageItem;
    }
}