View GitHub Repository database.tdbm

Schedule Inspection
Subscribe
Completed
Pull Request — 4.2 (#129)
by
unknown
04:05
created

TDBMInheritanceException::extendException()   A

↳ Parent: TDBMInheritanceException

Complexity

Conditions 4
Paths 4

Size

Total Lines 14
Code Lines 8

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 14
rs 9.2
c 0
b 0
f 0
cc 4
eloc 8
nc 4
nop 3
1 
<?php
2 
namespace Mouf\Database\TDBM;
3 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
 * Exception thrown when TDBM cannot find a straight path between supposedly inherited tables.

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
class TDBMInheritanceException extends TDBMException

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
    public static function create(array $tables) : TDBMInheritanceException

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
        return new self(sprintf('The tables (%s) cannot be linked by an inheritance relationship. Does your data set contains multiple children for one parent row? (multiple inheritance is not supported by TDBM)', implode(', ', $tables)));

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    public static function extendException(TDBMInheritanceException $e, TDBMService $tdbmService, array $beanData)

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
        $pks = [];

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
        foreach ($beanData as $table => $row) {

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
            $primaryKeyColumns = $tdbmService->getPrimaryKeyColumns($table);

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
            foreach ($primaryKeyColumns as $columnName) {

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The expression $primaryKeyColumns of type string|array is not guaranteed to be traversable. How about adding an additional type check?
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
There are different options of fixing this problem.


  1. If you want to be on the safe side, you can add an additional type-check:
    

    $collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }

    

    

    2. 

  2. If you are sure that the expression is traversable, you might want to add a
doc comment cast to improve IDE auto-completion and static analysis:
    

    /** @var array $collection */
$collection = json_decode($data, true);

foreach ($collection as $item) { /** .. */ }

    

    

    3. 

  3. Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.
    

    4. 



                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
                if ($row[$columnName] !== null) {

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
                    $pks[] = $table.".".$columnName.' => '.var_export($row[$columnName], true);

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
                }

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
            }

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
        throw new self($e->getMessage()." (row in error: ".implode(', ', $pks).")", 0, $e);

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    29