Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
29 | class InnerResultIterator implements \Iterator, \Countable, \ArrayAccess |
||
30 | { |
||
31 | /** |
||
32 | * @var Statement |
||
33 | */ |
||
34 | protected $statement; |
||
35 | |||
36 | protected $fetchStarted = false; |
||
37 | private $objectStorage; |
||
38 | private $className; |
||
39 | |||
40 | private $tdbmService; |
||
41 | private $magicSql; |
||
42 | private $parameters; |
||
43 | private $limit; |
||
44 | private $offset; |
||
45 | private $columnDescriptors; |
||
46 | private $magicQuery; |
||
47 | |||
48 | /** |
||
49 | * The key of the current retrieved object. |
||
50 | * |
||
51 | * @var int |
||
52 | */ |
||
53 | protected $key = -1; |
||
54 | |||
55 | protected $current = null; |
||
56 | |||
57 | private $databasePlatform; |
||
58 | |||
59 | View Code Duplication | public function __construct($magicSql, array $parameters, $limit, $offset, array $columnDescriptors, $objectStorage, $className, TDBMService $tdbmService, MagicQuery $magicQuery) |
|
72 | |||
73 | protected function executeQuery() |
||
82 | |||
83 | /** |
||
84 | * Counts found records (this is the number of records fetched, taking into account the LIMIT and OFFSET settings). |
||
85 | * |
||
86 | * @return int |
||
87 | */ |
||
88 | public function count() |
||
96 | |||
97 | /** |
||
98 | * Fetches record at current cursor. |
||
99 | * |
||
100 | * @return AbstractTDBMObject|null |
||
101 | */ |
||
102 | public function current() |
||
106 | |||
107 | /** |
||
108 | * Returns the current result's key. |
||
109 | * |
||
110 | * @return int |
||
111 | */ |
||
112 | public function key() |
||
116 | |||
117 | /** |
||
118 | * Advances the cursor to the next result. |
||
119 | * Casts the database result into one (or several) beans. |
||
120 | */ |
||
121 | public function next() |
||
180 | |||
181 | /** |
||
182 | * Moves the cursor to the beginning of the result set. |
||
183 | */ |
||
184 | public function rewind() |
||
190 | /** |
||
191 | * Checks if the cursor is reading a valid result. |
||
192 | * |
||
193 | * @return bool |
||
194 | */ |
||
195 | public function valid() |
||
199 | |||
200 | /** |
||
201 | * Whether a offset exists. |
||
202 | * |
||
203 | * @link http://php.net/manual/en/arrayaccess.offsetexists.php |
||
204 | * |
||
205 | * @param mixed $offset <p> |
||
206 | * An offset to check for. |
||
207 | * </p> |
||
208 | * |
||
209 | * @return bool true on success or false on failure. |
||
210 | * </p> |
||
211 | * <p> |
||
212 | * The return value will be casted to boolean if non-boolean was returned. |
||
213 | * |
||
214 | * @since 5.0.0 |
||
215 | */ |
||
216 | public function offsetExists($offset) |
||
220 | |||
221 | /** |
||
222 | * Offset to retrieve. |
||
223 | * |
||
224 | * @link http://php.net/manual/en/arrayaccess.offsetget.php |
||
225 | * |
||
226 | * @param mixed $offset <p> |
||
227 | * The offset to retrieve. |
||
228 | * </p> |
||
229 | * |
||
230 | * @return mixed Can return all value types. |
||
231 | * |
||
232 | * @since 5.0.0 |
||
233 | */ |
||
234 | public function offsetGet($offset) |
||
238 | |||
239 | /** |
||
240 | * Offset to set. |
||
241 | * |
||
242 | * @link http://php.net/manual/en/arrayaccess.offsetset.php |
||
243 | * |
||
244 | * @param mixed $offset <p> |
||
245 | * The offset to assign the value to. |
||
246 | * </p> |
||
247 | * @param mixed $value <p> |
||
248 | * The value to set. |
||
249 | * </p> |
||
250 | * |
||
251 | * @since 5.0.0 |
||
252 | */ |
||
253 | public function offsetSet($offset, $value) |
||
257 | |||
258 | /** |
||
259 | * Offset to unset. |
||
260 | * |
||
261 | * @link http://php.net/manual/en/arrayaccess.offsetunset.php |
||
262 | * |
||
263 | * @param mixed $offset <p> |
||
264 | * The offset to unset. |
||
265 | * </p> |
||
266 | * |
||
267 | * @since 5.0.0 |
||
268 | */ |
||
269 | public function offsetUnset($offset) |
||
273 | } |
||
274 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.