thecodingmachine / database.tdbm

src/Mouf/Database/TDBM/Filters/GreaterFilter.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	 * @param string $columnName
 	 * @param string $value
 	 */
-	public function __construct($tableName=null, $columnName=null, $value=null) {
+	public function __construct($tableName = null, $columnName = null, $value = null) {
 		$this->tableName = $tableName;
 		$this->columnName = $columnName;
 		$this->value = $value;

src/Mouf/Database/TDBM/Filters/GreaterOrEqualFilter.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	 * @param string $columnName
 	 * @param string $value
 	 */
-	public function __construct($tableName=null, $columnName=null, $value=null) {
+	public function __construct($tableName = null, $columnName = null, $value = null) {
 		$this->tableName = $tableName;
 		$this->columnName = $columnName;
 		$this->value = $value;

src/Mouf/Database/TDBM/Filters/LessFilter.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	 * @param string $columnName
 	 * @param string $value
 	 */
-	public function __construct($tableName=null, $columnName=null, $value=null) {
+	public function __construct($tableName = null, $columnName = null, $value = null) {
 		$this->tableName = $tableName;
 		$this->columnName = $columnName;
 		$this->value = $value;

src/Mouf/Database/TDBM/Filters/LessOrEqualFilter.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	 * @param string $columnName
 	 * @param string $value
 	 */
-	public function __construct($tableName=null, $columnName=null, $value=null) {
+	public function __construct($tableName = null, $columnName = null, $value = null) {
 		$this->tableName = $tableName;
 		$this->columnName = $columnName;
 		$this->value = $value;

src/Mouf/Database/TDBM/Filters/LikeFilter.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	 * @param string $columnName
 	 * @param string $value
 	 */
-	public function __construct($tableName=null, $columnName=null, $value=null) {
+	public function __construct($tableName = null, $columnName = null, $value = null) {
 		$this->tableName = $tableName;
 		$this->columnName = $columnName;
 		$this->value = $value;

src/Mouf/Database/TDBM/Filters/OrderBySQLString.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 namespace Mouf\Database\TDBM\Filters;
 
-use Mouf\Database\DBConnection\ConnectionInterface;
-
 /*
  Copyright (C) 2006-2011 David Négrier - THE CODING MACHINE
 

Spacing +11 added lines, -11 removed lines

@@ -60,7 +60,7 @@ 
 	 * 
 	 * @param string $sqlString
 	 */
-	public function __construct($sqlString=null) {
+	public function __construct($sqlString = null) {
 		$this->sqlString = $sqlString;
 	}
 	
@@ -88,8 +88,8 @@ 
 			$result = -1;
 			while (true) {
 				$result = strrpos($phrase, "'", $result+1);
-				if ($result===false) {
-					if ($sentence!='')
+				if ($result === false) {
+					if ($sentence != '')
 					$sentence .= ',';
 					$sentence .= $phrase;
 
@@ -105,7 +105,7 @@ 
 				{
 					$valid_result = true;
 					//echo '-'.$phrase{$result-1}.'-';
-					if ($result>0 && $phrase{$result-1}=='\\') {
+					if ($result>0 && $phrase{$result-1} == '\\') {
 						$valid_result = false;
 					}
 					if ($valid_result)
@@ -133,33 +133,33 @@ 
 		// First, let's remove all the stuff in quotes:
 
 		// Let's remove all the \' found
-		$work_str = str_replace("\\'",'',$this->sqlString);
+		$work_str = str_replace("\\'", '', $this->sqlString);
 		// Now, let's split the string using '
 		$work_table = explode("'", $work_str);
 
-		if (count($work_table)==0)
+		if (count($work_table) == 0)
 		return '';
 
 		// if we start with a ', let's remove the first text
-		if (strstr($work_str,"'")===0)
+		if (strstr($work_str, "'") === 0)
 		array_shift($work_table);
 			
-		if (count($work_table)==0)
+		if (count($work_table) == 0)
 		return '';
 
 		// Now, let's take only the stuff outside the quotes.
 		$work_str2 = '';
 
-		$i=0;
+		$i = 0;
 		foreach ($work_table as $str_fragment) {
-			if (($i % 2) == 0)
+			if (($i%2) == 0)
 			$work_str2 .= $str_fragment.' ';
 			$i++;
 		}
 
 		// Now, let's run a regexp to find all the strings matching the pattern xxx.yyy
 		//preg_match_all('/(\w+)\.(?:\w+)/', $work_str2,$capture_result);
-		preg_match_all('/([a-zA-Z_](?:[a-zA-Z0-9_]*))\.(?:[a-zA-Z_](?:[a-zA-Z0-9_]*))/', $work_str2,$capture_result);
+		preg_match_all('/([a-zA-Z_](?:[a-zA-Z0-9_]*))\.(?:[a-zA-Z_](?:[a-zA-Z0-9_]*))/', $work_str2, $capture_result);
 
 		$tables_used = $capture_result[1];
 		// remove doubles:

Braces +19 added lines, -14 removed lines

@@ -89,8 +89,9 @@ 
 			while (true) {
 				$result = strrpos($phrase, "'", $result+1);
 				if ($result===false) {
-					if ($sentence!='')
-					$sentence .= ',';
+					if ($sentence!='') {
+										$sentence .= ',';
+					}
 					$sentence .= $phrase;
 
 					if ($is_inside_quotes) {
@@ -100,16 +101,16 @@ 
 						$sentence = '';
 						break;
 					}
-				}
-				else
+				} else
 				{
 					$valid_result = true;
 					//echo '-'.$phrase{$result-1}.'-';
 					if ($result>0 && $phrase{$result-1}=='\\') {
 						$valid_result = false;
 					}
-					if ($valid_result)
-					$is_inside_quotes = !$is_inside_quotes;
+					if ($valid_result) {
+										$is_inside_quotes = !$is_inside_quotes;
+					}
 				}
 			}
 
@@ -137,23 +138,27 @@ 
 		// Now, let's split the string using '
 		$work_table = explode("'", $work_str);
 
-		if (count($work_table)==0)
-		return '';
+		if (count($work_table)==0) {
+				return '';
+		}
 
 		// if we start with a ', let's remove the first text
-		if (strstr($work_str,"'")===0)
-		array_shift($work_table);
+		if (strstr($work_str,"'")===0) {
+				array_shift($work_table);
+		}
 			
-		if (count($work_table)==0)
-		return '';
+		if (count($work_table)==0) {
+				return '';
+		}
 
 		// Now, let's take only the stuff outside the quotes.
 		$work_str2 = '';
 
 		$i=0;
 		foreach ($work_table as $str_fragment) {
-			if (($i % 2) == 0)
-			$work_str2 .= $str_fragment.' ';
+			if (($i % 2) == 0) {
+						$work_str2 .= $str_fragment.' ';
+			}
 			$i++;
 		}
 

src/Mouf/Database/TDBM/DisplayNode.php

Spacing +14 added lines, -14 removed lines

@@ -33,8 +33,8 @@ 
 	public static $box_height = 30;
 	public static $interspace_width = 10;
 	public static $interspace_height = 50;
-	public static $text_height=13;
-	public static $border =2;
+	public static $text_height = 13;
+	public static $border = 2;
 
 
 	private $parent_node;
@@ -46,7 +46,7 @@ 
 
 	public $width;
 
-	public function __construct($table_name, $parent_node=null, $link_type=null, $keyParent=null, $keyNode=null) {
+	public function __construct($table_name, $parent_node = null, $link_type = null, $keyParent = null, $keyNode = null) {
 		$this->table_name = $table_name;
 		if ($parent_node !== null) {
 			$this->parent_node = $parent_node;
@@ -83,7 +83,7 @@ 
 	}
 
 	public function computeWidth() {
-		if (!is_array($this->children) || count($this->children)==0) {
+		if (!is_array($this->children) || count($this->children) == 0) {
 			$this->width = 1;
 			return 1;
 		} else {
@@ -97,13 +97,13 @@ 
 	}
 
 	public function computeDepth($my_depth) {
-		if (!is_array($this->children) || count($this->children)==0) {
+		if (!is_array($this->children) || count($this->children) == 0) {
 			return $my_depth+1;
 		} else {
 			$max = 0;
 			foreach ($this->children as $child) {
-				$depth = $my_depth + $child->computeDepth($my_depth);
-				if ($depth > $max) {
+				$depth = $my_depth+$child->computeDepth($my_depth);
+				if ($depth>$max) {
 					$max = $depth;
 				}
 			}
@@ -113,23 +113,23 @@ 
 
 	public function draw($x, $y, $left_px, $top_px) {
 
-		$mybox_width_px = $this->width*DisplayNode::$box_width + ($this->width-1)*DisplayNode::$interspace_width;
-		$my_x_px = $left_px + DisplayNode::$left_start + $x*(DisplayNode::$box_width + DisplayNode::$interspace_width);
-		$my_y_px = $top_px + DisplayNode::$top_start + $y*(DisplayNode::$box_height + DisplayNode::$interspace_height);
+		$mybox_width_px = $this->width*DisplayNode::$box_width+($this->width-1)*DisplayNode::$interspace_width;
+		$my_x_px = $left_px+DisplayNode::$left_start+$x*(DisplayNode::$box_width+DisplayNode::$interspace_width);
+		$my_y_px = $top_px+DisplayNode::$top_start+$y*(DisplayNode::$box_height+DisplayNode::$interspace_height);
 
 		// White background first
 		$str = "<div style='position:absolute; left:".$my_x_px."px; top:".$my_y_px."px; width:".$mybox_width_px."px; height:".DisplayNode::$box_height."; background-color:gray; color: white; text-align:center; border:".DisplayNode::$border."px solid black'>\n<b>".$this->table_name."</b></div>";
 
 		if ($this->keyParent != null) {
-			$my_x_px_line = $my_x_px + DisplayNode::$box_width/2;
-			$my_y_px_line = $my_y_px - DisplayNode::$interspace_height;
+			$my_x_px_line = $my_x_px+DisplayNode::$box_width/2;
+			$my_y_px_line = $my_y_px-DisplayNode::$interspace_height;
 			$str .= "<div style='position:absolute; left:".$my_x_px_line."px; top:".($my_y_px_line+DisplayNode::$border)."px; width:2px; height:".(DisplayNode::$interspace_height-DisplayNode::$border)."; background-color:black; '></div>\n";
 
-			$top_key = ($this->link_type=='1*')?'* fk:':'1 pk:';
+			$top_key = ($this->link_type == '1*') ? '* fk:' : '1 pk:';
 			$top_key .= '<i>'.$this->keyParent.'</i>';
 
 
-			$bottom_key = ($this->link_type=='*1')?'* fk:':'1 pk:';
+			$bottom_key = ($this->link_type == '*1') ? '* fk:' : '1 pk:';
 			$bottom_key .= '<i>'.$this->keyParent.'</i>';
 
 			$str .= "<div style='position:absolute; left:".($my_x_px_line+2)."px; top:".($my_y_px_line+DisplayNode::$border*2)."px; background-color:#EEEEEE; font-size: 10px'>$top_key</div>\n";

Braces +1 added lines, -2 removed lines

@@ -67,8 +67,7 @@
 			if ($this->link_type == "*1")
 			{
 				echo "Table $this->table_name points to table ".$this->parent_node->table_name." through its foreign key on column $this->keyNode that points to column $this->keyParent<br />";
-			}
-			else if ($this->link_type == "1*")
+			} else if ($this->link_type == "1*")
 			{
 				echo "Table $this->table_name is pointed by table ".$this->parent_node->table_name." by its foreign key on column $this->keyParent that points to column $this->keyNode<br />";
 			}

src/Mouf/Database/TDBM/TDBMObject.php

Braces +30 added lines, -23 removed lines

@@ -263,10 +263,11 @@ 
 				// Let's try to be accurate in error reporting. The checkColumnExist returns an array of closest matches.
 				$result_array = $column_exist;
 				
-				if (count($result_array)==1)
-				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant this column: '".$result_array[0]."'";
-				else
-				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant one of those columns: '".implode("', '",$result_array)."'";
+				if (count($result_array)==1) {
+								$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant this column: '".$result_array[0]."'";
+				} else {
+								$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant one of those columns: '".implode("', '",$result_array)."'";
+				}
 	
 	
 				throw new TDBMException($str);
@@ -348,10 +349,11 @@ 
 			if (count($pk_array)>1 && !$pk_set) {
 				$msg = "Error! You did not set the primary keys for the new object of type '$this->db_table_name'. TDBM usually assumes that the primary key is automatically set by the DB engine to the maximum value in the database. However, in this case, the '$this->db_table_name' table has a primary key on multiple columns. TDBM would be unable to find back this record after save. Please specify the primary keys for all new objects of kind '$this->db_table_name'.";
 
-				if (!$this->tdbmService->isProgramExiting())
-				throw new TDBMException($msg);
-				else
-				trigger_error($msg, E_USER_ERROR);
+				if (!$this->tdbmService->isProgramExiting()) {
+								throw new TDBMException($msg);
+				} else {
+								trigger_error($msg, E_USER_ERROR);
+				}
 			}
 			
 			$sql = 'INSERT INTO '.$this->db_connection->escapeDBItem($this->db_table_name).
@@ -360,8 +362,9 @@ 
 
 			$first = true;
 			foreach ($this->db_row as $key=>$value) {
-				if (!$first)
-				$sql .= ',';
+				if (!$first) {
+								$sql .= ',';
+				}
 				$sql .= $this->db_connection->quoteSmart($value);
 				$first=false;
 			}
@@ -378,9 +381,9 @@ 
 				//	trigger_error("program exiting");
 				trigger_error($e->getMessage(), E_USER_ERROR);
 
-				if (!$this->tdbmService->isProgramExiting())
-				throw $e;
-				else
+				if (!$this->tdbmService->isProgramExiting()) {
+								throw $e;
+				} else
 				{
 					trigger_error($e->getMessage(), E_USER_ERROR);
 				}
@@ -447,8 +450,9 @@ 
 
 			$first = true;
 			foreach ($this->db_row as $key=>$value) {
-				if (!$first)
-				$sql .= ',';
+				if (!$first) {
+								$sql .= ',';
+				}
 				$sql .= $this->db_connection->escapeDBItem($key)." = ".$this->db_connection->quoteSmart($value);
 				$first=false;
 			}
@@ -456,10 +460,11 @@ 
 			try {
 				$this->db_connection->exec($sql);
 			} catch (TDBMException $e) {
-				if (!$this->tdbmService->isProgramExiting())
-				throw $e;
-				else
-				trigger_error($e->getMessage(), E_USER_ERROR);
+				if (!$this->tdbmService->isProgramExiting()) {
+								throw $e;
+				} else {
+								trigger_error($e->getMessage(), E_USER_ERROR);
+				}
 			}
 
 			// Let's remove this object from the $new_objects static table.
@@ -490,11 +495,13 @@ 
 	 *
 	 */
 	public function discardChanges() {
-		if ($this->TDBMObject_state == "new")
-		throw new TDBMException("You cannot call discardChanges() on an object that has been created with getNewObject and that has not yet been saved.");
+		if ($this->TDBMObject_state == "new") {
+				throw new TDBMException("You cannot call discardChanges() on an object that has been created with getNewObject and that has not yet been saved.");
+		}
 
-		if ($this->TDBMObject_state == "deleted")
-		throw new TDBMException("You cannot call discardChanges() on an object that has been deleted.");
+		if ($this->TDBMObject_state == "deleted") {
+				throw new TDBMException("You cannot call discardChanges() on an object that has been deleted.");
+		}
 			
 		$this->db_modified_state = false;
 		$this->TDBMObject_state = "not loaded";

Doc Comments +9 added lines, -2 removed lines

@@ -145,7 +145,7 @@ 
 	 * false if an explicit call to save() is required.
 	 *
 	 * @param unknown_type $autoSave
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function setAutoSaveMode($autoSave) {
 		$this->db_autosave = $autoSave;
@@ -255,6 +255,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $var
+	 */
 	public function __get($var) {
 		$this->_dbLoadIfNotLoaded();
 
@@ -307,6 +310,10 @@ 
 		return isset($this->db_row[$var]);
 	}
 	
+	/**
+	 * @param string $var
+	 * @param string|null $value
+	 */
 	public function __set($var, $value) {
 		$this->_dbLoadIfNotLoaded();
 
@@ -525,7 +532,7 @@ 
 	 *
 	 * @param unknown_type $func_name
 	 * @param unknown_type $values
-	 * @return unknown
+	 * @return TDBMObjectArray
 	 */
 	public function __call($func_name, $values) {
 

Indentation +16 added lines, -16 removed lines

@@ -563,46 +563,46 @@
 	}
 	
 		/**
-	 * Implements array behaviour for our object.
-	 * 
-	 * @param string $offset
-	 * @param string $value
-	 */
+		 * Implements array behaviour for our object.
+		 * 
+		 * @param string $offset
+		 * @param string $value
+		 */
 	public function offsetSet($offset, $value) {
 		$this->__set($offset, $value);
-    }
+	}
 	/**
 	 * Implements array behaviour for our object.
 	 * 
 	 * @param string $offset
 	 */
-    public function offsetExists($offset) {
-    	$this->_dbLoadIfNotLoaded();
-        return isset($this->db_row[$offset]);
-    }
+	public function offsetExists($offset) {
+		$this->_dbLoadIfNotLoaded();
+		return isset($this->db_row[$offset]);
+	}
 	/**
 	 * Implements array behaviour for our object.
 	 * 
 	 * @param string $offset
 	 */
-    public function offsetUnset($offset) {
+	public function offsetUnset($offset) {
 		$this->__set($offset, null);
-    }
+	}
 	/**
 	 * Implements array behaviour for our object.
 	 * 
 	 * @param string $offset
 	 */
-    public function offsetGet($offset) {
-        return $this->__get($offset);
-    }
+	public function offsetGet($offset) {
+		return $this->__get($offset);
+	}
 	
 	private $_validIterator = false;
 	/**
 	 * Implements iterator behaviour for our object (so we can each column).
 	 */
 	public function rewind() {
-    	$this->_dbLoadIfNotLoaded();
+		$this->_dbLoadIfNotLoaded();
 		if (count($this->db_row)>0) {
 			$this->_validIterator = true;
 		} else {

Spacing +27 added lines, -27 removed lines

@@ -113,7 +113,7 @@ 
 	 * @param string $table_name
 	 * @param mixed $id
 	 */
-	public function __construct(TDBMService $tdbmService, $table_name, $id=false) {
+	public function __construct(TDBMService $tdbmService, $table_name, $id = false) {
 		$this->tdbmService = $tdbmService;
 		$this->db_connection = $this->tdbmService->getConnection();
 		$this->db_table_name = $table_name;
@@ -159,7 +159,7 @@ 
 	 * $TDBMObject_state = "loaded" when the object is cached in memory.
 	 * @return string
 	 */
-	public function getTDBMObjectState(){
+	public function getTDBMObjectState() {
 		return $this->TDBMObject_state;
 	}
 	
@@ -171,7 +171,7 @@ 
 	 * $TDBMObject_state = "loaded" when the object is cached in memory.
 	 * @param string $state
 	 */
-	public function setTDBMObjectState($state){
+	public function setTDBMObjectState($state) {
 		$this->TDBMObject_state = $state;	
 	}
 	
@@ -184,8 +184,8 @@ 
 	 */
 	public function loadFromRow($row) {
 		foreach ($row as $key=>$value) {
-			if (strpos($key, 'tdbm_reserved_col_')!==0) {
-				$this->db_row[$key]=$value;
+			if (strpos($key, 'tdbm_reserved_col_') !== 0) {
+				$this->db_row[$key] = $value;
 			}
 		}
 
@@ -219,24 +219,24 @@ 
 			// Now for the object_id
 			$object_id = $this->TDBMObject_id;
 			// If there is only one primary key:
-			if (count($pk_table)==1) {
+			if (count($pk_table) == 1) {
 				$sql_where = $this->db_connection->escapeDBItem($pk_table[0])."=".$this->db_connection->quoteSmart($this->TDBMObject_id);
 			} else {
 				$ids = unserialize($object_id);
-				$i=0;
+				$i = 0;
 				$sql_where_array = array();
 				foreach ($pk_table as $pk) {
 					$sql_where_array[] = $this->db_connection->escapeDBItem($pk)."=".$this->db_connection->quoteSmart($ids[$i]);
 					$i++;
 				}
-				$sql_where = implode(" AND ",$sql_where_array);
+				$sql_where = implode(" AND ", $sql_where_array);
 			}
 
 			$sql = "SELECT * FROM ".$this->db_connection->escapeDBItem($this->db_table_name)." WHERE ".$sql_where;
 			$result = $this->db_connection->query($sql);
 
 
-			if ($result->rowCount()==0)
+			if ($result->rowCount() == 0)
 			{
 				throw new TDBMException("Could not retrieve object from table \"$this->db_table_name\" with ID \"".$this->TDBMObject_id."\".");
 			}
@@ -247,8 +247,8 @@ 
 			$result = null;
 				
 			$this->db_row = array();
-			foreach ($fullCaseRow[0] as $key=>$value)  {
-				$this->db_row[$this->db_connection->toStandardCaseColumn($key)]=$value;
+			foreach ($fullCaseRow[0] as $key=>$value) {
+				$this->db_row[$this->db_connection->toStandardCaseColumn($key)] = $value;
 			}
 			
 			$this->TDBMObject_state = "loaded";
@@ -280,10 +280,10 @@ 
 				// Let's try to be accurate in error reporting. The checkColumnExist returns an array of closest matches.
 				$result_array = $column_exist;
 				
-				if (count($result_array)==1)
+				if (count($result_array) == 1)
 				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant this column: '".$result_array[0]."'";
 				else
-				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant one of those columns: '".implode("', '",$result_array)."'";
+				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant one of those columns: '".implode("', '", $result_array)."'";
 	
 	
 				throw new TDBMException($str);
@@ -356,8 +356,8 @@ 
 			$pk_array = $this->getPrimaryKey();
 			
 			foreach ($pk_array as $pk) {
-				if (isset($this->db_row[$pk]) && $this->db_row[$pk]!==null) {
-					$pk_set=true;
+				if (isset($this->db_row[$pk]) && $this->db_row[$pk] !== null) {
+					$pk_set = true;
 				}
 			}
 			// if there are many columns for the PK, and none is set, we have no way to find the object back!
@@ -380,7 +380,7 @@ 
 				if (!$first)
 				$sql .= ',';
 				$sql .= $this->db_connection->quoteSmart($value);
-				$first=false;
+				$first = false;
 			}
 			$sql .= ')';
 
@@ -408,12 +408,12 @@ 
 
 			// If there is only one column for the primary key, and if it has not been filled, let's find it.
 			// We assume this is the biggest ID in the database
-			if (count($pk_array)==1 && !$pk_set) {
+			if (count($pk_array) == 1 && !$pk_set) {
 				// FIXME: for PostgreSQL or MSSQL, the getInsertId call is not thread safe
 				// We should start a transaction before the insert
-				$this->TDBMObject_id = $this->db_connection->getInsertId($this->db_table_name,$pk_array[0]);
+				$this->TDBMObject_id = $this->db_connection->getInsertId($this->db_table_name, $pk_array[0]);
 				$this->db_row[$pk_array[0]] = $this->TDBMObject_id;
-			} elseif (count($pk_array)==1 && $pk_set) {
+			} elseif (count($pk_array) == 1 && $pk_set) {
 				$this->TDBMObject_id = $this->db_row[$pk_array[0]];
 			}
 
@@ -440,24 +440,24 @@ 
 			
 			// Let's add this object to the list of objects in cache.
 			$this->tdbmService->_addToCache($this);
-		} else if ($this->TDBMObject_state == "loaded" && $this->db_modified_state==true) {
+		} else if ($this->TDBMObject_state == "loaded" && $this->db_modified_state == true) {
 			//$primary_key = $this->getPrimaryKey();
 			// Let's first get the primary keys
 			$pk_table = $this->getPrimaryKey();
 			// Now for the object_id
 			$object_id = $this->TDBMObject_id;
 			// If there is only one primary key:
-			if (count($pk_table)==1) {
+			if (count($pk_table) == 1) {
 				$sql_where = $this->db_connection->escapeDBItem($pk_table[0])."=".$this->db_connection->quoteSmart($this->TDBMObject_id);
 			} else {
 				$ids = unserialize($object_id);
-				$i=0;
+				$i = 0;
 				$sql_where_array = array();
 				foreach ($pk_table as $pk) {
 					$sql_where_array[] = $this->db_connection->escapeDBItem($pk)."=".$this->db_connection->quoteSmart($ids[$i]);
 					$i++;
 				}
-				$sql_where = implode(" AND ",$sql_where_array);
+				$sql_where = implode(" AND ", $sql_where_array);
 			}
 
 			$sql = 'UPDATE '.$this->db_connection->escapeDBItem($this->db_table_name).' SET ';
@@ -467,7 +467,7 @@ 
 				if (!$first)
 				$sql .= ',';
 				$sql .= $this->db_connection->escapeDBItem($key)." = ".$this->db_connection->quoteSmart($value);
-				$first=false;
+				$first = false;
 			}
 			$sql .= ' WHERE '.$sql_where/*$primary_key."='".$this->db_row[$primary_key]."'"*/;
 			try {
@@ -529,8 +529,8 @@ 
 	 */
 	public function __call($func_name, $values) {
 
-		if (strpos($func_name,"get_") === 0) {
-			$table = substr($func_name,4);
+		if (strpos($func_name, "get_") === 0) {
+			$table = substr($func_name, 4);
 		} else {
 			throw new TDBMException("Method ".$func_name." not found");
 		}
@@ -640,7 +640,7 @@ 
 	 * Implement the unique JsonSerializable method
 	 * @return array
 	 */
-	public function jsonSerialize(){
+	public function jsonSerialize() {
 		$this->_dbLoadIfNotLoaded();
 		return $this->db_row;
 	}

src/Mouf/Database/TDBM/Utils/TDBMDaoGenerator.php

Braces +4 added lines, -3 removed lines

@@ -426,7 +426,7 @@ 
 				$defaultSort = $data['column_name'];
 				if (count($matches == 3)){
 					$defaultSortDirection = $matches[2];
-				}else{
+				} else{
 					$defaultSortDirection = 'ASC';
 				}
 			}
@@ -836,8 +836,9 @@ 
 	public static function toCamelCase($str) {
 		$str = strtoupper(substr($str,0,1)).substr($str,1);
 		while (true) {
-			if (strpos($str, "_") === false && strpos($str, " ") === false)
-				break;
+			if (strpos($str, "_") === false && strpos($str, " ") === false) {
+							break;
+			}
 				
 			$pos = strpos($str, "_");
 			if ($pos === false) {

Doc Comments +8 added lines, -5 removed lines

@@ -124,7 +124,7 @@ 
 	/**
 	 * Generates in one method call the daos and the beans for one table.
 	 * 
-	 * @param $tableName
+	 * @param string $tableName
 	 */
 	public function generateDaoAndBean($tableName) {
 		//$baseClassName = TDBMDaoGenerator::toSingular(TDBMDaoGenerator::toCamelCase($tableName));
@@ -427,6 +427,10 @@ 
 	 * @param string $fileName The file that will be written (without the directory)
 	 * @param string $className The name of the class
 	 * @param string $tableName The name of the table
+	 * @param string $baseFileName
+	 * @param string $beanFileName
+	 * @param string $baseClassName
+	 * @param string $beanClassName
 	 */
 	public function generateDao($fileName, $baseFileName, $beanFileName, $className, $baseClassName, $beanClassName, $tableName) {
 		$info = $this->dbConnection->getTableInfo($tableName);
@@ -697,7 +701,7 @@ 
 	/**
 	 * Generates the factory bean.
 	 * 
-	 * @param $tableList
+	 * @param string[] $tableList
 	 */
 	private function generateFactory($tableList) {
 		// For each table, let's write a property.
@@ -763,7 +767,6 @@ 
 	 * Transforms the property name in a setter name.
 	 * For instance, phone => getPhone or name => getName
 	 *
-	 * @param string $methodName
 	 * @return string
 	 */
 	public static function getSetterNameForPropertyName($propertyName) {
@@ -843,7 +846,7 @@ 
 	 * Tries to put string to the singular form (if it is plural).
 	 * Obviously, this can't be perfect, be we do the best we can.
 	 * 
-	 * @param $str string
+	 * @param string $str string
 	 * @return string
 	 */
 	public static function toSingular($str) {
@@ -864,7 +867,7 @@ 
 	 * Put the first letter of the string in lower case.
 	 * Very useful to transform a class name into a variable name.
 	 * 
-	 * @param $str string
+	 * @param string $str string
 	 * @return string
 	 */
 	public static function toVariableName($str) {

Indentation +7 added lines, -7 removed lines

@@ -114,9 +114,9 @@ 
 		// Ok, let's return the list of all tables.
 		// These will be used by the calling script to create Mouf instances.
 		$root = simplexml_load_string("<tdbm></tdbm>");
-    	foreach ($tableList as $table) {
-    		$root->addChild("table", $table);
-    	}
+		foreach ($tableList as $table) {
+			$root->addChild("table", $table);
+		}
 		
 		return $root;
 	}
@@ -132,10 +132,10 @@ 
 		$beanName = $this->getBeanNameFromTableName($tableName);
 		$baseBeanName = $this->getBaseBeanNameFromTableName($tableName);
 
-        $connection = $this->dbConnection;
-        if ($connection instanceof CachedConnection){
-            $connection->cacheService->purgeAll();
-        }
+		$connection = $this->dbConnection;
+		if ($connection instanceof CachedConnection){
+			$connection->cacheService->purgeAll();
+		}
 		
 		$this->generateBean($beanName.".php", $beanName, $baseBeanName.".php", $baseBeanName, $tableName);
 		$this->generateDao($daoName.".php", $daoName."Base.php", $beanName.".php", $daoName, $daoName."Base", $beanName, $tableName);

Spacing +17 added lines, -17 removed lines

@@ -133,7 +133,7 @@ 
 		$baseBeanName = $this->getBaseBeanNameFromTableName($tableName);
 
         $connection = $this->dbConnection;
-        if ($connection instanceof CachedConnection){
+        if ($connection instanceof CachedConnection) {
             $connection->cacheService->purgeAll();
         }
 		
@@ -231,7 +231,7 @@ 
 		if($date === null)
 			return null;
 		else
-			return strtotime($date'.($this->storeInUtc?'.\' UTC\'':'').');
+			return strtotime($date'.($this->storeInUtc ? '.\' UTC\'' : '').');
 	}
 	
 	/**
@@ -321,7 +321,7 @@ 
 		if ($this->'.$array["col1"].' == null) {
 			return null;
 		}
-		return $this->tdbmService->getObject("'.$array["table2"].'", $this->'.$array["col1"].', "'.str_replace("\\","\\\\",$this->beanNamespace).'\\\\'.$referencedBeanName.'", true);
+		return $this->tdbmService->getObject("'.$array["table2"].'", $this->'.$array["col1"].', "'.str_replace("\\", "\\\\", $this->beanNamespace).'\\\\'.$referencedBeanName.'", true);
 	}
 	
 	/**
@@ -340,10 +340,10 @@ 
 		
 		// Now, let's implement the shortcuts to the getter of objects.
 		// Shortcuts are used to save typing. They are available only if a referenced table is referenced only once by our tables.
-		foreach($referencedTablesList as $referrencedTable=>$number) {
+		foreach ($referencedTablesList as $referrencedTable=>$number) {
 			if ($number == 1) {
 				foreach ($constraints as $array) {
-					if ($array['table2'] ==$referrencedTable) {
+					if ($array['table2'] == $referrencedTable) {
 						$columnName = $array['col1'];
 						$targetColumnName = $array['col2'];
 						break;
@@ -374,7 +374,7 @@ 
 		if ($this->'.$array["col1"].' == null) {
 			return null;
 		}
-		return $this->tdbmService->getObject("'.$array["table2"].'", $this->'.$array["col1"].', "'.str_replace("\\","\\\\",$this->beanNamespace).'\\\\'.$referencedBeanName.'");
+		return $this->tdbmService->getObject("'.$array["table2"].'", $this->'.$array["col1"].', "'.str_replace("\\", "\\\\", $this->beanNamespace).'\\\\'.$referencedBeanName.'");
 	}
 	
 	/**
@@ -416,7 +416,7 @@ 
 {
 
 }";
-			file_put_contents($this->beanDirectory.$fileName ,$str);
+			file_put_contents($this->beanDirectory.$fileName, $str);
 			@chmod($this->beanDirectory.$fileName, 0664);
 		}
 	}
@@ -434,11 +434,11 @@ 
 		foreach ($info as $index => $data) {
 			$comments = $data['column_comment'];
 			$matches = array();
-			if (preg_match('/@defaultSort(\((desc|asc)\))*/', $comments, $matches) != 0){
+			if (preg_match('/@defaultSort(\((desc|asc)\))*/', $comments, $matches) != 0) {
 				$defaultSort = $data['column_name'];
-				if (count($matches == 3)){
+				if (count($matches == 3)) {
 					$defaultSortDirection = $matches[2];
-				}else{
+				} else {
 					$defaultSortDirection = 'ASC';
 				}
 			}
@@ -667,7 +667,7 @@ 
 
 		
 
-		file_put_contents($this->daoDirectory.$baseFileName ,$str);
+		file_put_contents($this->daoDirectory.$baseFileName, $str);
 		@chmod($this->daoDirectory.$baseFileName, 0664);
 		
 		// Now, let's generate the "editable" class
@@ -689,7 +689,7 @@ 
 {
 
 }";
-			file_put_contents($this->daoDirectory.$fileName ,$str);
+			file_put_contents($this->daoDirectory.$fileName, $str);
 			@chmod($this->daoDirectory.$fileName, 0664);
 		}
 	}
@@ -756,7 +756,7 @@ 
 ?>';
 		
 		//$daoDirectory = dirname(__FILE__)."/../../../../../dao/";
-		file_put_contents($this->daoDirectory.$this->daoFactoryClassName.'.php' ,$str);
+		file_put_contents($this->daoDirectory.$this->daoFactoryClassName.'.php', $str);
 	}
 	
 	/**
@@ -823,7 +823,7 @@ 
 	 * @return string
 	 */
 	public static function toCamelCase($str) {
-		$str = strtoupper(substr($str,0,1)).substr($str,1);
+		$str = strtoupper(substr($str, 0, 1)).substr($str, 1);
 		while (true) {
 			if (strpos($str, "_") === false && strpos($str, " ") === false)
 				break;
@@ -832,9 +832,9 @@ 
 			if ($pos === false) {
 				$pos = strpos($str, " ");
 			}
-			$before = substr($str,0,$pos);
-			$after = substr($str,$pos+1);
-			$str = $before.strtoupper(substr($after,0,1)).substr($after,1);
+			$before = substr($str, 0, $pos);
+			$after = substr($str, $pos+1);
+			$str = $before.strtoupper(substr($after, 0, 1)).substr($after, 1);
 		}
 		return $str;
 	}