thecodingmachine / database.tdbm

src/Mouf/Database/TDBM/Utils/BeanDescriptor.php

Indentation +625 added lines, -625 removed lines

@@ -16,241 +16,241 @@ 
  */
 class BeanDescriptor implements BeanDescriptorInterface
 {
-    /**
-     * @var Table
-     */
-    private $table;
-
-    /**
-     * @var SchemaAnalyzer
-     */
-    private $schemaAnalyzer;
-
-    /**
-     * @var Schema
-     */
-    private $schema;
-
-    /**
-     * @var AbstractBeanPropertyDescriptor[]
-     */
-    private $beanPropertyDescriptors = [];
-
-    /**
-     * @var TDBMSchemaAnalyzer
-     */
-    private $tdbmSchemaAnalyzer;
-
-    /**
-     * @var NamingStrategyInterface
-     */
-    private $namingStrategy;
-
-    /**
-     * @param Table $table
-     * @param SchemaAnalyzer $schemaAnalyzer
-     * @param Schema $schema
-     * @param TDBMSchemaAnalyzer $tdbmSchemaAnalyzer
-     * @param NamingStrategyInterface $namingStrategy
-     */
-    public function __construct(Table $table, SchemaAnalyzer $schemaAnalyzer, Schema $schema, TDBMSchemaAnalyzer $tdbmSchemaAnalyzer, NamingStrategyInterface $namingStrategy)
-    {
-        $this->table = $table;
-        $this->schemaAnalyzer = $schemaAnalyzer;
-        $this->schema = $schema;
-        $this->tdbmSchemaAnalyzer = $tdbmSchemaAnalyzer;
-        $this->namingStrategy = $namingStrategy;
-        $this->initBeanPropertyDescriptors();
-    }
-
-    private function initBeanPropertyDescriptors()
-    {
-        $this->beanPropertyDescriptors = $this->getProperties($this->table);
-    }
-
-    /**
-     * Returns the foreign-key the column is part of, if any. null otherwise.
-     *
-     * @param Table  $table
-     * @param Column $column
-     *
-     * @return ForeignKeyConstraint|null
-     */
-    private function isPartOfForeignKey(Table $table, Column $column)
-    {
-        $localColumnName = $column->getName();
-        foreach ($table->getForeignKeys() as $foreignKey) {
-            foreach ($foreignKey->getColumns() as $columnName) {
-                if ($columnName === $localColumnName) {
-                    return $foreignKey;
-                }
-            }
-        }
-
-        return;
-    }
-
-    /**
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    public function getBeanPropertyDescriptors()
-    {
-        return $this->beanPropertyDescriptors;
-    }
-
-    /**
-     * Returns the list of columns that are not nullable and not autogenerated for a given table and its parent.
-     *
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    public function getConstructorProperties()
-    {
-        $constructorProperties = array_filter($this->beanPropertyDescriptors, function (AbstractBeanPropertyDescriptor $property) {
-            return $property->isCompulsory();
-        });
-
-        return $constructorProperties;
-    }
-
-    /**
-     * Returns the list of columns that have default values for a given table.
-     *
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    public function getPropertiesWithDefault()
-    {
-        $properties = $this->getPropertiesForTable($this->table);
-        $defaultProperties = array_filter($properties, function (AbstractBeanPropertyDescriptor $property) {
-            return $property->hasDefault();
-        });
-
-        return $defaultProperties;
-    }
-
-    /**
-     * Returns the list of properties exposed as getters and setters in this class.
-     *
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    public function getExposedProperties(): array
-    {
-        $exposedProperties = array_filter($this->beanPropertyDescriptors, function (AbstractBeanPropertyDescriptor $property) {
-            return $property->getTable()->getName() == $this->table->getName();
-        });
-
-        return $exposedProperties;
-    }
-
-    /**
-     * Returns the list of properties for this table (including parent tables).
-     *
-     * @param Table $table
-     *
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    private function getProperties(Table $table)
-    {
-        $parentRelationship = $this->schemaAnalyzer->getParentRelationship($table->getName());
-        if ($parentRelationship) {
-            $parentTable = $this->schema->getTable($parentRelationship->getForeignTableName());
-            $properties = $this->getProperties($parentTable);
-            // we merge properties by overriding property names.
-            $localProperties = $this->getPropertiesForTable($table);
-            foreach ($localProperties as $name => $property) {
-                // We do not override properties if this is a primary key!
-                if ($property->isPrimaryKey()) {
-                    continue;
-                }
-                $properties[$name] = $property;
-            }
-        } else {
-            $properties = $this->getPropertiesForTable($table);
-        }
-
-        return $properties;
-    }
-
-    /**
-     * Returns the list of properties for this table (ignoring parent tables).
-     *
-     * @param Table $table
-     *
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    private function getPropertiesForTable(Table $table)
-    {
-        $parentRelationship = $this->schemaAnalyzer->getParentRelationship($table->getName());
-        if ($parentRelationship) {
-            $ignoreColumns = $parentRelationship->getLocalColumns();
-        } else {
-            $ignoreColumns = [];
-        }
-
-        $beanPropertyDescriptors = [];
-
-        foreach ($table->getColumns() as $column) {
-            if (array_search($column->getName(), $ignoreColumns) !== false) {
-                continue;
-            }
-
-            $fk = $this->isPartOfForeignKey($table, $column);
-            if ($fk !== null) {
-                // Check that previously added descriptors are not added on same FK (can happen with multi key FK).
-                foreach ($beanPropertyDescriptors as $beanDescriptor) {
-                    if ($beanDescriptor instanceof ObjectBeanPropertyDescriptor && $beanDescriptor->getForeignKey() === $fk) {
-                        continue 2;
-                    }
-                }
-                // Check that this property is not an inheritance relationship
-                $parentRelationship = $this->schemaAnalyzer->getParentRelationship($table->getName());
-                if ($parentRelationship === $fk) {
-                    continue;
-                }
-
-                $beanPropertyDescriptors[] = new ObjectBeanPropertyDescriptor($table, $fk, $this->schemaAnalyzer, $this->namingStrategy);
-            } else {
-                $beanPropertyDescriptors[] = new ScalarBeanPropertyDescriptor($table, $column, $this->namingStrategy);
-            }
-        }
-
-        // Now, let's get the name of all properties and let's check there is no duplicate.
-        /** @var $names AbstractBeanPropertyDescriptor[] */
-        $names = [];
-        foreach ($beanPropertyDescriptors as $beanDescriptor) {
-            $name = $beanDescriptor->getUpperCamelCaseName();
-            if (isset($names[$name])) {
-                $names[$name]->useAlternativeName();
-                $beanDescriptor->useAlternativeName();
-            } else {
-                $names[$name] = $beanDescriptor;
-            }
-        }
-
-        // Final check (throw exceptions if problem arises)
-        $names = [];
-        foreach ($beanPropertyDescriptors as $beanDescriptor) {
-            $name = $beanDescriptor->getUpperCamelCaseName();
-            if (isset($names[$name])) {
-                throw new TDBMException('Unsolvable name conflict while generating method name');
-            } else {
-                $names[$name] = $beanDescriptor;
-            }
-        }
-
-        // Last step, let's rebuild the list with a map:
-        $beanPropertyDescriptorsMap = [];
-        foreach ($beanPropertyDescriptors as $beanDescriptor) {
-            $beanPropertyDescriptorsMap[$beanDescriptor->getLowerCamelCaseName()] = $beanDescriptor;
-        }
-
-        return $beanPropertyDescriptorsMap;
-    }
-
-    private function generateBeanConstructor() : string
-    {
-        $constructorProperties = $this->getConstructorProperties();
-
-        $constructorCode = '    /**
+	/**
+	 * @var Table
+	 */
+	private $table;
+
+	/**
+	 * @var SchemaAnalyzer
+	 */
+	private $schemaAnalyzer;
+
+	/**
+	 * @var Schema
+	 */
+	private $schema;
+
+	/**
+	 * @var AbstractBeanPropertyDescriptor[]
+	 */
+	private $beanPropertyDescriptors = [];
+
+	/**
+	 * @var TDBMSchemaAnalyzer
+	 */
+	private $tdbmSchemaAnalyzer;
+
+	/**
+	 * @var NamingStrategyInterface
+	 */
+	private $namingStrategy;
+
+	/**
+	 * @param Table $table
+	 * @param SchemaAnalyzer $schemaAnalyzer
+	 * @param Schema $schema
+	 * @param TDBMSchemaAnalyzer $tdbmSchemaAnalyzer
+	 * @param NamingStrategyInterface $namingStrategy
+	 */
+	public function __construct(Table $table, SchemaAnalyzer $schemaAnalyzer, Schema $schema, TDBMSchemaAnalyzer $tdbmSchemaAnalyzer, NamingStrategyInterface $namingStrategy)
+	{
+		$this->table = $table;
+		$this->schemaAnalyzer = $schemaAnalyzer;
+		$this->schema = $schema;
+		$this->tdbmSchemaAnalyzer = $tdbmSchemaAnalyzer;
+		$this->namingStrategy = $namingStrategy;
+		$this->initBeanPropertyDescriptors();
+	}
+
+	private function initBeanPropertyDescriptors()
+	{
+		$this->beanPropertyDescriptors = $this->getProperties($this->table);
+	}
+
+	/**
+	 * Returns the foreign-key the column is part of, if any. null otherwise.
+	 *
+	 * @param Table  $table
+	 * @param Column $column
+	 *
+	 * @return ForeignKeyConstraint|null
+	 */
+	private function isPartOfForeignKey(Table $table, Column $column)
+	{
+		$localColumnName = $column->getName();
+		foreach ($table->getForeignKeys() as $foreignKey) {
+			foreach ($foreignKey->getColumns() as $columnName) {
+				if ($columnName === $localColumnName) {
+					return $foreignKey;
+				}
+			}
+		}
+
+		return;
+	}
+
+	/**
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	public function getBeanPropertyDescriptors()
+	{
+		return $this->beanPropertyDescriptors;
+	}
+
+	/**
+	 * Returns the list of columns that are not nullable and not autogenerated for a given table and its parent.
+	 *
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	public function getConstructorProperties()
+	{
+		$constructorProperties = array_filter($this->beanPropertyDescriptors, function (AbstractBeanPropertyDescriptor $property) {
+			return $property->isCompulsory();
+		});
+
+		return $constructorProperties;
+	}
+
+	/**
+	 * Returns the list of columns that have default values for a given table.
+	 *
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	public function getPropertiesWithDefault()
+	{
+		$properties = $this->getPropertiesForTable($this->table);
+		$defaultProperties = array_filter($properties, function (AbstractBeanPropertyDescriptor $property) {
+			return $property->hasDefault();
+		});
+
+		return $defaultProperties;
+	}
+
+	/**
+	 * Returns the list of properties exposed as getters and setters in this class.
+	 *
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	public function getExposedProperties(): array
+	{
+		$exposedProperties = array_filter($this->beanPropertyDescriptors, function (AbstractBeanPropertyDescriptor $property) {
+			return $property->getTable()->getName() == $this->table->getName();
+		});
+
+		return $exposedProperties;
+	}
+
+	/**
+	 * Returns the list of properties for this table (including parent tables).
+	 *
+	 * @param Table $table
+	 *
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	private function getProperties(Table $table)
+	{
+		$parentRelationship = $this->schemaAnalyzer->getParentRelationship($table->getName());
+		if ($parentRelationship) {
+			$parentTable = $this->schema->getTable($parentRelationship->getForeignTableName());
+			$properties = $this->getProperties($parentTable);
+			// we merge properties by overriding property names.
+			$localProperties = $this->getPropertiesForTable($table);
+			foreach ($localProperties as $name => $property) {
+				// We do not override properties if this is a primary key!
+				if ($property->isPrimaryKey()) {
+					continue;
+				}
+				$properties[$name] = $property;
+			}
+		} else {
+			$properties = $this->getPropertiesForTable($table);
+		}
+
+		return $properties;
+	}
+
+	/**
+	 * Returns the list of properties for this table (ignoring parent tables).
+	 *
+	 * @param Table $table
+	 *
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	private function getPropertiesForTable(Table $table)
+	{
+		$parentRelationship = $this->schemaAnalyzer->getParentRelationship($table->getName());
+		if ($parentRelationship) {
+			$ignoreColumns = $parentRelationship->getLocalColumns();
+		} else {
+			$ignoreColumns = [];
+		}
+
+		$beanPropertyDescriptors = [];
+
+		foreach ($table->getColumns() as $column) {
+			if (array_search($column->getName(), $ignoreColumns) !== false) {
+				continue;
+			}
+
+			$fk = $this->isPartOfForeignKey($table, $column);
+			if ($fk !== null) {
+				// Check that previously added descriptors are not added on same FK (can happen with multi key FK).
+				foreach ($beanPropertyDescriptors as $beanDescriptor) {
+					if ($beanDescriptor instanceof ObjectBeanPropertyDescriptor && $beanDescriptor->getForeignKey() === $fk) {
+						continue 2;
+					}
+				}
+				// Check that this property is not an inheritance relationship
+				$parentRelationship = $this->schemaAnalyzer->getParentRelationship($table->getName());
+				if ($parentRelationship === $fk) {
+					continue;
+				}
+
+				$beanPropertyDescriptors[] = new ObjectBeanPropertyDescriptor($table, $fk, $this->schemaAnalyzer, $this->namingStrategy);
+			} else {
+				$beanPropertyDescriptors[] = new ScalarBeanPropertyDescriptor($table, $column, $this->namingStrategy);
+			}
+		}
+
+		// Now, let's get the name of all properties and let's check there is no duplicate.
+		/** @var $names AbstractBeanPropertyDescriptor[] */
+		$names = [];
+		foreach ($beanPropertyDescriptors as $beanDescriptor) {
+			$name = $beanDescriptor->getUpperCamelCaseName();
+			if (isset($names[$name])) {
+				$names[$name]->useAlternativeName();
+				$beanDescriptor->useAlternativeName();
+			} else {
+				$names[$name] = $beanDescriptor;
+			}
+		}
+
+		// Final check (throw exceptions if problem arises)
+		$names = [];
+		foreach ($beanPropertyDescriptors as $beanDescriptor) {
+			$name = $beanDescriptor->getUpperCamelCaseName();
+			if (isset($names[$name])) {
+				throw new TDBMException('Unsolvable name conflict while generating method name');
+			} else {
+				$names[$name] = $beanDescriptor;
+			}
+		}
+
+		// Last step, let's rebuild the list with a map:
+		$beanPropertyDescriptorsMap = [];
+		foreach ($beanPropertyDescriptors as $beanDescriptor) {
+			$beanPropertyDescriptorsMap[$beanDescriptor->getLowerCamelCaseName()] = $beanDescriptor;
+		}
+
+		return $beanPropertyDescriptorsMap;
+	}
+
+	private function generateBeanConstructor() : string
+	{
+		$constructorProperties = $this->getConstructorProperties();
+
+		$constructorCode = '    /**
      * The constructor takes all compulsory arguments.
      *
 %s
@@ -260,110 +260,110 @@ 
 %s%s    }
     ';
 
-        $paramAnnotations = [];
-        $arguments = [];
-        $assigns = [];
-        $parentConstructorArguments = [];
-
-        foreach ($constructorProperties as $property) {
-            $className = $property->getClassName();
-            if ($className) {
-                $arguments[] = $className.' '.$property->getVariableName();
-            } else {
-                $arguments[] = $property->getVariableName();
-            }
-            $paramAnnotations[] = $property->getParamAnnotation();
-            if ($property->getTable()->getName() === $this->table->getName()) {
-                $assigns[] = $property->getConstructorAssignCode()."\n";
-            } else {
-                $parentConstructorArguments[] = $property->getVariableName();
-            }
-        }
-
-        $parentConstructorCode = sprintf("        parent::__construct(%s);\n", implode(', ', $parentConstructorArguments));
-
-        foreach ($this->getPropertiesWithDefault() as $property) {
-            $assigns[] = $property->assignToDefaultCode()."\n";
-        }
-
-        return sprintf($constructorCode, implode("\n", $paramAnnotations), implode(', ', $arguments), $parentConstructorCode, implode('', $assigns));
-    }
-
-    public function getDirectForeignKeysDescriptors(): array
-    {
-        $fks = $this->tdbmSchemaAnalyzer->getIncomingForeignKeys($this->table->getName());
-
-        $descriptors = [];
-
-        foreach ($fks as $fk) {
-            $descriptors[] = new DirectForeignKeyMethodDescriptor($fk, $this->table, $this->namingStrategy);
-        }
-
-        return $descriptors;
-    }
-
-    private function getPivotTableDescriptors(): array
-    {
-        $descs = [];
-        foreach ($this->schemaAnalyzer->detectJunctionTables(true) as $table) {
-            // There are exactly 2 FKs since this is a pivot table.
-            $fks = array_values($table->getForeignKeys());
-
-            if ($fks[0]->getForeignTableName() === $this->table->getName()) {
-                list($localFk, $remoteFk) = $fks;
-            } elseif ($fks[1]->getForeignTableName() === $this->table->getName()) {
-                list($remoteFk, $localFk) = $fks;
-            } else {
-                continue;
-            }
-
-            $descs[] = new PivotTableMethodsDescriptor($table, $localFk, $remoteFk, $this->namingStrategy);
-        }
-
-        return $descs;
-    }
-
-    /**
-     * Returns the list of method descriptors (and applies the alternative name if needed).
-     *
-     * @return MethodDescriptorInterface[]
-     */
-    private function getMethodDescriptors(): array
-    {
-        $directForeignKeyDescriptors = $this->getDirectForeignKeysDescriptors();
-        $pivotTableDescriptors = $this->getPivotTableDescriptors();
-
-        $descriptors = array_merge($directForeignKeyDescriptors, $pivotTableDescriptors);
-
-        // Descriptors by method names
-        $descriptorsByMethodName = [];
-
-        foreach ($descriptors as $descriptor) {
-            $descriptorsByMethodName[$descriptor->getName()][] = $descriptor;
-        }
-
-        foreach ($descriptorsByMethodName as $descriptorsForMethodName) {
-            if (count($descriptorsForMethodName) > 1) {
-                foreach ($descriptorsForMethodName as $descriptor) {
-                    $descriptor->useAlternativeName();
-                }
-            }
-        }
-
-        return $descriptors;
-    }
-
-    public function generateJsonSerialize(): string
-    {
-        $tableName = $this->table->getName();
-        $parentFk = $this->schemaAnalyzer->getParentRelationship($tableName);
-        if ($parentFk !== null) {
-            $initializer = '$array = parent::jsonSerialize($stopRecursion);';
-        } else {
-            $initializer = '$array = [];';
-        }
-
-        $str = '
+		$paramAnnotations = [];
+		$arguments = [];
+		$assigns = [];
+		$parentConstructorArguments = [];
+
+		foreach ($constructorProperties as $property) {
+			$className = $property->getClassName();
+			if ($className) {
+				$arguments[] = $className.' '.$property->getVariableName();
+			} else {
+				$arguments[] = $property->getVariableName();
+			}
+			$paramAnnotations[] = $property->getParamAnnotation();
+			if ($property->getTable()->getName() === $this->table->getName()) {
+				$assigns[] = $property->getConstructorAssignCode()."\n";
+			} else {
+				$parentConstructorArguments[] = $property->getVariableName();
+			}
+		}
+
+		$parentConstructorCode = sprintf("        parent::__construct(%s);\n", implode(', ', $parentConstructorArguments));
+
+		foreach ($this->getPropertiesWithDefault() as $property) {
+			$assigns[] = $property->assignToDefaultCode()."\n";
+		}
+
+		return sprintf($constructorCode, implode("\n", $paramAnnotations), implode(', ', $arguments), $parentConstructorCode, implode('', $assigns));
+	}
+
+	public function getDirectForeignKeysDescriptors(): array
+	{
+		$fks = $this->tdbmSchemaAnalyzer->getIncomingForeignKeys($this->table->getName());
+
+		$descriptors = [];
+
+		foreach ($fks as $fk) {
+			$descriptors[] = new DirectForeignKeyMethodDescriptor($fk, $this->table, $this->namingStrategy);
+		}
+
+		return $descriptors;
+	}
+
+	private function getPivotTableDescriptors(): array
+	{
+		$descs = [];
+		foreach ($this->schemaAnalyzer->detectJunctionTables(true) as $table) {
+			// There are exactly 2 FKs since this is a pivot table.
+			$fks = array_values($table->getForeignKeys());
+
+			if ($fks[0]->getForeignTableName() === $this->table->getName()) {
+				list($localFk, $remoteFk) = $fks;
+			} elseif ($fks[1]->getForeignTableName() === $this->table->getName()) {
+				list($remoteFk, $localFk) = $fks;
+			} else {
+				continue;
+			}
+
+			$descs[] = new PivotTableMethodsDescriptor($table, $localFk, $remoteFk, $this->namingStrategy);
+		}
+
+		return $descs;
+	}
+
+	/**
+	 * Returns the list of method descriptors (and applies the alternative name if needed).
+	 *
+	 * @return MethodDescriptorInterface[]
+	 */
+	private function getMethodDescriptors(): array
+	{
+		$directForeignKeyDescriptors = $this->getDirectForeignKeysDescriptors();
+		$pivotTableDescriptors = $this->getPivotTableDescriptors();
+
+		$descriptors = array_merge($directForeignKeyDescriptors, $pivotTableDescriptors);
+
+		// Descriptors by method names
+		$descriptorsByMethodName = [];
+
+		foreach ($descriptors as $descriptor) {
+			$descriptorsByMethodName[$descriptor->getName()][] = $descriptor;
+		}
+
+		foreach ($descriptorsByMethodName as $descriptorsForMethodName) {
+			if (count($descriptorsForMethodName) > 1) {
+				foreach ($descriptorsForMethodName as $descriptor) {
+					$descriptor->useAlternativeName();
+				}
+			}
+		}
+
+		return $descriptors;
+	}
+
+	public function generateJsonSerialize(): string
+	{
+		$tableName = $this->table->getName();
+		$parentFk = $this->schemaAnalyzer->getParentRelationship($tableName);
+		if ($parentFk !== null) {
+			$initializer = '$array = parent::jsonSerialize($stopRecursion);';
+		} else {
+			$initializer = '$array = [];';
+		}
+
+		$str = '
     /**
      * Serializes the object for JSON encoding.
      *
@@ -379,77 +379,77 @@ 
     }
 ';
 
-        $propertiesCode = '';
-        foreach ($this->beanPropertyDescriptors as $beanPropertyDescriptor) {
-            $propertiesCode .= $beanPropertyDescriptor->getJsonSerializeCode();
-        }
-
-        // Many2many relationships
-        $methodsCode = '';
-        foreach ($this->getMethodDescriptors() as $methodDescriptor) {
-            $methodsCode .= $methodDescriptor->getJsonSerializeCode();
-        }
-
-        return sprintf($str, $initializer, $propertiesCode, $methodsCode);
-    }
-
-    /**
-     * Returns as an array the class we need to extend from and the list of use statements.
-     *
-     * @param ForeignKeyConstraint|null $parentFk
-     * @return array
-     */
-    private function generateExtendsAndUseStatements(ForeignKeyConstraint $parentFk = null): array
-    {
-        $classes = [];
-        if ($parentFk !== null) {
-            $extends = $this->namingStrategy->getBeanClassName($parentFk->getForeignTableName());
-            $classes[] = $extends;
-        }
-
-        foreach ($this->getBeanPropertyDescriptors() as $beanPropertyDescriptor) {
-            $className = $beanPropertyDescriptor->getClassName();
-            if (null !== $className) {
-                $classes[] = $beanPropertyDescriptor->getClassName();
-            }
-        }
-
-        foreach ($this->getMethodDescriptors() as $descriptor) {
-            $classes = array_merge($classes, $descriptor->getUsedClasses());
-        }
-
-        $classes = array_unique($classes);
-
-        return $classes;
-    }
-
-    /**
-     * Writes the PHP bean file with all getters and setters from the table passed in parameter.
-     *
-     * @param string $beannamespace The namespace of the bean
-     * @return string
-     */
-    public function generatePhpCode($beannamespace): string
-    {
-        $tableName = $this->table->getName();
-        $baseClassName = $this->namingStrategy->getBaseBeanClassName($tableName);
-        $className = $this->namingStrategy->getBeanClassName($tableName);
-        $parentFk = $this->schemaAnalyzer->getParentRelationship($this->table->getName());
-
-        $classes = $this->generateExtendsAndUseStatements($parentFk);
-
-        $uses = array_map(function ($className) use ($beannamespace) {
-            return 'use '.$beannamespace.'\\'.$className.";\n";
-        }, $classes);
-        $use = implode('', $uses);
-
-        $extends = $this->getExtendedBeanClassName();
-        if ($extends === null) {
-            $extends = 'AbstractTDBMObject';
-            $use .= "use Mouf\\Database\\TDBM\\AbstractTDBMObject;\n";
-        }
-
-        $str = "<?php
+		$propertiesCode = '';
+		foreach ($this->beanPropertyDescriptors as $beanPropertyDescriptor) {
+			$propertiesCode .= $beanPropertyDescriptor->getJsonSerializeCode();
+		}
+
+		// Many2many relationships
+		$methodsCode = '';
+		foreach ($this->getMethodDescriptors() as $methodDescriptor) {
+			$methodsCode .= $methodDescriptor->getJsonSerializeCode();
+		}
+
+		return sprintf($str, $initializer, $propertiesCode, $methodsCode);
+	}
+
+	/**
+	 * Returns as an array the class we need to extend from and the list of use statements.
+	 *
+	 * @param ForeignKeyConstraint|null $parentFk
+	 * @return array
+	 */
+	private function generateExtendsAndUseStatements(ForeignKeyConstraint $parentFk = null): array
+	{
+		$classes = [];
+		if ($parentFk !== null) {
+			$extends = $this->namingStrategy->getBeanClassName($parentFk->getForeignTableName());
+			$classes[] = $extends;
+		}
+
+		foreach ($this->getBeanPropertyDescriptors() as $beanPropertyDescriptor) {
+			$className = $beanPropertyDescriptor->getClassName();
+			if (null !== $className) {
+				$classes[] = $beanPropertyDescriptor->getClassName();
+			}
+		}
+
+		foreach ($this->getMethodDescriptors() as $descriptor) {
+			$classes = array_merge($classes, $descriptor->getUsedClasses());
+		}
+
+		$classes = array_unique($classes);
+
+		return $classes;
+	}
+
+	/**
+	 * Writes the PHP bean file with all getters and setters from the table passed in parameter.
+	 *
+	 * @param string $beannamespace The namespace of the bean
+	 * @return string
+	 */
+	public function generatePhpCode($beannamespace): string
+	{
+		$tableName = $this->table->getName();
+		$baseClassName = $this->namingStrategy->getBaseBeanClassName($tableName);
+		$className = $this->namingStrategy->getBeanClassName($tableName);
+		$parentFk = $this->schemaAnalyzer->getParentRelationship($this->table->getName());
+
+		$classes = $this->generateExtendsAndUseStatements($parentFk);
+
+		$uses = array_map(function ($className) use ($beannamespace) {
+			return 'use '.$beannamespace.'\\'.$className.";\n";
+		}, $classes);
+		$use = implode('', $uses);
+
+		$extends = $this->getExtendedBeanClassName();
+		if ($extends === null) {
+			$extends = 'AbstractTDBMObject';
+			$use .= "use Mouf\\Database\\TDBM\\AbstractTDBMObject;\n";
+		}
+
+		$str = "<?php
 namespace {$beannamespace}\\Generated;
 
 use Mouf\\Database\\TDBM\\ResultIterator;
@@ -469,125 +469,125 @@ 
 {
 ";
 
-        $str .= $this->generateBeanConstructor();
+		$str .= $this->generateBeanConstructor();
 
-        foreach ($this->getExposedProperties() as $property) {
-            $str .= $property->getGetterSetterCode();
-        }
+		foreach ($this->getExposedProperties() as $property) {
+			$str .= $property->getGetterSetterCode();
+		}
 
-        foreach ($this->getMethodDescriptors() as $methodDescriptor) {
-            $str .= $methodDescriptor->getCode();
-        }
-        $str .= $this->generateJsonSerialize();
+		foreach ($this->getMethodDescriptors() as $methodDescriptor) {
+			$str .= $methodDescriptor->getCode();
+		}
+		$str .= $this->generateJsonSerialize();
 
-        $str .= $this->generateGetUsedTablesCode();
+		$str .= $this->generateGetUsedTablesCode();
 
-        $str .= $this->generateOnDeleteCode();
+		$str .= $this->generateOnDeleteCode();
 
-        $str .= '}
+		$str .= '}
 ';
 
-        return $str;
-    }
-
-    /**
-     * @param string $beanNamespace
-     * @param string $beanClassName
-     *
-     * @return array first element: list of used beans, second item: PHP code as a string
-     */
-    public function generateFindByDaoCode($beanNamespace, $beanClassName)
-    {
-        $code = '';
-        $usedBeans = [];
-        foreach ($this->table->getIndexes() as $index) {
-            if (!$index->isPrimary()) {
-                list($usedBeansForIndex, $codeForIndex) = $this->generateFindByDaoCodeForIndex($index, $beanNamespace, $beanClassName);
-                $code .= $codeForIndex;
-                $usedBeans = array_merge($usedBeans, $usedBeansForIndex);
-            }
-        }
-
-        return [$usedBeans, $code];
-    }
-
-    /**
-     * @param Index  $index
-     * @param string $beanNamespace
-     * @param string $beanClassName
-     *
-     * @return array first element: list of used beans, second item: PHP code as a string
-     */
-    private function generateFindByDaoCodeForIndex(Index $index, $beanNamespace, $beanClassName)
-    {
-        $columns = $index->getColumns();
-        $usedBeans = [];
-
-        /*
+		return $str;
+	}
+
+	/**
+	 * @param string $beanNamespace
+	 * @param string $beanClassName
+	 *
+	 * @return array first element: list of used beans, second item: PHP code as a string
+	 */
+	public function generateFindByDaoCode($beanNamespace, $beanClassName)
+	{
+		$code = '';
+		$usedBeans = [];
+		foreach ($this->table->getIndexes() as $index) {
+			if (!$index->isPrimary()) {
+				list($usedBeansForIndex, $codeForIndex) = $this->generateFindByDaoCodeForIndex($index, $beanNamespace, $beanClassName);
+				$code .= $codeForIndex;
+				$usedBeans = array_merge($usedBeans, $usedBeansForIndex);
+			}
+		}
+
+		return [$usedBeans, $code];
+	}
+
+	/**
+	 * @param Index  $index
+	 * @param string $beanNamespace
+	 * @param string $beanClassName
+	 *
+	 * @return array first element: list of used beans, second item: PHP code as a string
+	 */
+	private function generateFindByDaoCodeForIndex(Index $index, $beanNamespace, $beanClassName)
+	{
+		$columns = $index->getColumns();
+		$usedBeans = [];
+
+		/*
          * The list of elements building this index (expressed as columns or foreign keys)
          * @var AbstractBeanPropertyDescriptor[]
          */
-        $elements = [];
-
-        foreach ($columns as $column) {
-            $fk = $this->isPartOfForeignKey($this->table, $this->table->getColumn($column));
-            if ($fk !== null) {
-                if (!in_array($fk, $elements)) {
-                    $elements[] = new ObjectBeanPropertyDescriptor($this->table, $fk, $this->schemaAnalyzer, $this->namingStrategy);
-                }
-            } else {
-                $elements[] = new ScalarBeanPropertyDescriptor($this->table, $this->table->getColumn($column), $this->namingStrategy);
-            }
-        }
-
-        // If the index is actually only a foreign key, let's bypass it entirely.
-        if (count($elements) === 1 && $elements[0] instanceof ObjectBeanPropertyDescriptor) {
-            return [[], ''];
-        }
-
-        $methodNameComponent = [];
-        $functionParameters = [];
-        $first = true;
-        foreach ($elements as $element) {
-            $methodNameComponent[] = $element->getUpperCamelCaseName();
-            $functionParameter = $element->getClassName();
-            if ($functionParameter) {
-                $usedBeans[] = $beanNamespace.'\\'.$functionParameter;
-                $functionParameter .= ' ';
-            }
-            $functionParameter .= $element->getVariableName();
-            if ($first) {
-                $first = false;
-            } else {
-                $functionParameter .= ' = null';
-            }
-            $functionParameters[] = $functionParameter;
-        }
-
-        $functionParametersString = implode(', ', $functionParameters);
-
-        $count = 0;
-
-        $params = [];
-        $filterArrayCode = '';
-        $commentArguments = [];
-        foreach ($elements as $element) {
-            $params[] = $element->getParamAnnotation();
-            if ($element instanceof ScalarBeanPropertyDescriptor) {
-                $filterArrayCode .= '            '.var_export($element->getColumnName(), true).' => '.$element->getVariableName().",\n";
-            } else {
-                ++$count;
-                $filterArrayCode .= '            '.$count.' => '.$element->getVariableName().",\n";
-            }
-            $commentArguments[] = substr($element->getVariableName(), 1);
-        }
-        $paramsString = implode("\n", $params);
-
-        if ($index->isUnique()) {
-            $methodName = 'findOneBy'.implode('And', $methodNameComponent);
-            $returnType = "{$beanClassName}";
-
-            $code = "
+		$elements = [];
+
+		foreach ($columns as $column) {
+			$fk = $this->isPartOfForeignKey($this->table, $this->table->getColumn($column));
+			if ($fk !== null) {
+				if (!in_array($fk, $elements)) {
+					$elements[] = new ObjectBeanPropertyDescriptor($this->table, $fk, $this->schemaAnalyzer, $this->namingStrategy);
+				}
+			} else {
+				$elements[] = new ScalarBeanPropertyDescriptor($this->table, $this->table->getColumn($column), $this->namingStrategy);
+			}
+		}
+
+		// If the index is actually only a foreign key, let's bypass it entirely.
+		if (count($elements) === 1 && $elements[0] instanceof ObjectBeanPropertyDescriptor) {
+			return [[], ''];
+		}
+
+		$methodNameComponent = [];
+		$functionParameters = [];
+		$first = true;
+		foreach ($elements as $element) {
+			$methodNameComponent[] = $element->getUpperCamelCaseName();
+			$functionParameter = $element->getClassName();
+			if ($functionParameter) {
+				$usedBeans[] = $beanNamespace.'\\'.$functionParameter;
+				$functionParameter .= ' ';
+			}
+			$functionParameter .= $element->getVariableName();
+			if ($first) {
+				$first = false;
+			} else {
+				$functionParameter .= ' = null';
+			}
+			$functionParameters[] = $functionParameter;
+		}
+
+		$functionParametersString = implode(', ', $functionParameters);
+
+		$count = 0;
+
+		$params = [];
+		$filterArrayCode = '';
+		$commentArguments = [];
+		foreach ($elements as $element) {
+			$params[] = $element->getParamAnnotation();
+			if ($element instanceof ScalarBeanPropertyDescriptor) {
+				$filterArrayCode .= '            '.var_export($element->getColumnName(), true).' => '.$element->getVariableName().",\n";
+			} else {
+				++$count;
+				$filterArrayCode .= '            '.$count.' => '.$element->getVariableName().",\n";
+			}
+			$commentArguments[] = substr($element->getVariableName(), 1);
+		}
+		$paramsString = implode("\n", $params);
+
+		if ($index->isUnique()) {
+			$methodName = 'findOneBy'.implode('And', $methodNameComponent);
+			$returnType = "{$beanClassName}";
+
+			$code = "
     /**
      * Get a $beanClassName filtered by ".implode(', ', $commentArguments).".
      *
@@ -602,11 +602,11 @@ 
         return \$this->findOne(\$filter, [], \$additionalTablesFetch);
     }
 ";
-        } else {
-            $methodName = 'findBy'.implode('And', $methodNameComponent);
-            $returnType = "{$beanClassName}[]|ResultIterator|ResultArray";
+		} else {
+			$methodName = 'findBy'.implode('And', $methodNameComponent);
+			$returnType = "{$beanClassName}[]|ResultIterator|ResultArray";
 
-            $code = "
+			$code = "
     /**
      * Get a list of $beanClassName filtered by ".implode(', ', $commentArguments).".
      *
@@ -623,29 +623,29 @@ 
         return \$this->find(\$filter, [], \$orderBy, \$additionalTablesFetch, \$mode);
     }
 ";
-        }
-
-        return [$usedBeans, $code];
-    }
-
-    /**
-     * Generates the code for the getUsedTable protected method.
-     *
-     * @return string
-     */
-    private function generateGetUsedTablesCode()
-    {
-        $hasParentRelationship = $this->schemaAnalyzer->getParentRelationship($this->table->getName()) !== null;
-        if ($hasParentRelationship) {
-            $code = sprintf('        $tables = parent::getUsedTables();
+		}
+
+		return [$usedBeans, $code];
+	}
+
+	/**
+	 * Generates the code for the getUsedTable protected method.
+	 *
+	 * @return string
+	 */
+	private function generateGetUsedTablesCode()
+	{
+		$hasParentRelationship = $this->schemaAnalyzer->getParentRelationship($this->table->getName()) !== null;
+		if ($hasParentRelationship) {
+			$code = sprintf('        $tables = parent::getUsedTables();
         $tables[] = %s;
 
         return $tables;', var_export($this->table->getName(), true));
-        } else {
-            $code = sprintf('        return [ %s ];', var_export($this->table->getName(), true));
-        }
+		} else {
+			$code = sprintf('        return [ %s ];', var_export($this->table->getName(), true));
+		}
 
-        return sprintf('
+		return sprintf('
     /**
      * Returns an array of used tables by this bean (from parent to child relationship).
      *
@@ -656,20 +656,20 @@ 
 %s
     }
 ', $code);
-    }
-
-    private function generateOnDeleteCode()
-    {
-        $code = '';
-        $relationships = $this->getPropertiesForTable($this->table);
-        foreach ($relationships as $relationship) {
-            if ($relationship instanceof ObjectBeanPropertyDescriptor) {
-                $code .= sprintf('        $this->setRef('.var_export($relationship->getForeignKey()->getName(), true).', null, '.var_export($this->table->getName(), true).");\n");
-            }
-        }
-
-        if ($code) {
-            return sprintf('
+	}
+
+	private function generateOnDeleteCode()
+	{
+		$code = '';
+		$relationships = $this->getPropertiesForTable($this->table);
+		foreach ($relationships as $relationship) {
+			if ($relationship instanceof ObjectBeanPropertyDescriptor) {
+				$code .= sprintf('        $this->setRef('.var_export($relationship->getForeignKey()->getName(), true).', null, '.var_export($this->table->getName(), true).");\n");
+			}
+		}
+
+		if ($code) {
+			return sprintf('
     /**
      * Method called when the bean is removed from database.
      *
@@ -679,73 +679,73 @@ 
         parent::onDelete();
 %s    }
 ', $code);
-        }
-
-        return '';
-    }
-
-    /**
-     * Returns the bean class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getBeanClassName() : string
-    {
-        return $this->namingStrategy->getBeanClassName($this->table->getName());
-    }
-
-    /**
-     * Returns the base bean class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getBaseBeanClassName() : string
-    {
-        return $this->namingStrategy->getBaseBeanClassName($this->table->getName());
-    }
-
-    /**
-     * Returns the DAO class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getDaoClassName() : string
-    {
-        return $this->namingStrategy->getDaoClassName($this->table->getName());
-    }
-
-    /**
-     * Returns the base DAO class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getBaseDaoClassName() : string
-    {
-        return $this->namingStrategy->getBaseDaoClassName($this->table->getName());
-    }
-
-    /**
-     * Returns the table used to build this bean.
-     *
-     * @return Table
-     */
-    public function getTable(): Table
-    {
-        return $this->table;
-    }
-
-    /**
-     * Returns the extended bean class name (without the namespace), or null if the bean is not extended.
-     *
-     * @return string
-     */
-    public function getExtendedBeanClassName(): ?string
-    {
-        $parentFk = $this->schemaAnalyzer->getParentRelationship($this->table->getName());
-        if ($parentFk !== null) {
-            return $this->namingStrategy->getBeanClassName($parentFk->getForeignTableName());
-        } else {
-            return null;
-        }
-    }
+		}
+
+		return '';
+	}
+
+	/**
+	 * Returns the bean class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getBeanClassName() : string
+	{
+		return $this->namingStrategy->getBeanClassName($this->table->getName());
+	}
+
+	/**
+	 * Returns the base bean class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getBaseBeanClassName() : string
+	{
+		return $this->namingStrategy->getBaseBeanClassName($this->table->getName());
+	}
+
+	/**
+	 * Returns the DAO class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getDaoClassName() : string
+	{
+		return $this->namingStrategy->getDaoClassName($this->table->getName());
+	}
+
+	/**
+	 * Returns the base DAO class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getBaseDaoClassName() : string
+	{
+		return $this->namingStrategy->getBaseDaoClassName($this->table->getName());
+	}
+
+	/**
+	 * Returns the table used to build this bean.
+	 *
+	 * @return Table
+	 */
+	public function getTable(): Table
+	{
+		return $this->table;
+	}
+
+	/**
+	 * Returns the extended bean class name (without the namespace), or null if the bean is not extended.
+	 *
+	 * @return string
+	 */
+	public function getExtendedBeanClassName(): ?string
+	{
+		$parentFk = $this->schemaAnalyzer->getParentRelationship($this->table->getName());
+		if ($parentFk !== null) {
+			return $this->namingStrategy->getBeanClassName($parentFk->getForeignTableName());
+		} else {
+			return null;
+		}
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -105,7 +105,7 @@ 
      */
     public function getConstructorProperties()
     {
-        $constructorProperties = array_filter($this->beanPropertyDescriptors, function (AbstractBeanPropertyDescriptor $property) {
+        $constructorProperties = array_filter($this->beanPropertyDescriptors, function(AbstractBeanPropertyDescriptor $property) {
             return $property->isCompulsory();
         });
 
@@ -120,7 +120,7 @@ 
     public function getPropertiesWithDefault()
     {
         $properties = $this->getPropertiesForTable($this->table);
-        $defaultProperties = array_filter($properties, function (AbstractBeanPropertyDescriptor $property) {
+        $defaultProperties = array_filter($properties, function(AbstractBeanPropertyDescriptor $property) {
             return $property->hasDefault();
         });
 
@@ -134,7 +134,7 @@ 
      */
     public function getExposedProperties(): array
     {
-        $exposedProperties = array_filter($this->beanPropertyDescriptors, function (AbstractBeanPropertyDescriptor $property) {
+        $exposedProperties = array_filter($this->beanPropertyDescriptors, function(AbstractBeanPropertyDescriptor $property) {
             return $property->getTable()->getName() == $this->table->getName();
         });
 
@@ -343,7 +343,7 @@ 
         }
 
         foreach ($descriptorsByMethodName as $descriptorsForMethodName) {
-            if (count($descriptorsForMethodName) > 1) {
+            if (count($descriptorsForMethodName)>1) {
                 foreach ($descriptorsForMethodName as $descriptor) {
                     $descriptor->useAlternativeName();
                 }
@@ -438,7 +438,7 @@ 
 
         $classes = $this->generateExtendsAndUseStatements($parentFk);
 
-        $uses = array_map(function ($className) use ($beannamespace) {
+        $uses = array_map(function($className) use ($beannamespace) {
             return 'use '.$beannamespace.'\\'.$className.";\n";
         }, $classes);
         $use = implode('', $uses);
@@ -739,7 +739,7 @@ 
      *
      * @return string
      */
-    public function getExtendedBeanClassName(): ?string
+    public function getExtendedBeanClassName(): ? string
     {
         $parentFk = $this->schemaAnalyzer->getParentRelationship($this->table->getName());
         if ($parentFk !== null) {

src/Mouf/Database/TDBM/Utils/BeanDescriptorInterface.php

Indentation +48 added lines, -48 removed lines

@@ -9,52 +9,52 @@
  */
 interface BeanDescriptorInterface
 {
-    /**
-     * Returns the table used to build this bean.
-     *
-     * @return Table
-     */
-    public function getTable() : Table;
-
-    /**
-     * Returns the bean class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getBeanClassName(): string;
-
-    /**
-     * Returns the base bean class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getBaseBeanClassName(): string;
-
-    /**
-     * Returns the extended bean class name (without the namespace), or null if the bean is not extended.
-     *
-     * @return null|string
-     */
-    public function getExtendedBeanClassName(): ?string;
-
-    /**
-     * Returns the DAO class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getDaoClassName(): string;
-
-    /**
-     * Returns the base DAO class name (without the namespace).
-     *
-     * @return string
-     */
-    public function getBaseDaoClassName(): string;
-
-    /**
-     * Returns the list of properties exposed as getters and setters in this class.
-     *
-     * @return AbstractBeanPropertyDescriptor[]
-     */
-    public function getExposedProperties(): array;
+	/**
+	 * Returns the table used to build this bean.
+	 *
+	 * @return Table
+	 */
+	public function getTable() : Table;
+
+	/**
+	 * Returns the bean class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getBeanClassName(): string;
+
+	/**
+	 * Returns the base bean class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getBaseBeanClassName(): string;
+
+	/**
+	 * Returns the extended bean class name (without the namespace), or null if the bean is not extended.
+	 *
+	 * @return null|string
+	 */
+	public function getExtendedBeanClassName(): ?string;
+
+	/**
+	 * Returns the DAO class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getDaoClassName(): string;
+
+	/**
+	 * Returns the base DAO class name (without the namespace).
+	 *
+	 * @return string
+	 */
+	public function getBaseDaoClassName(): string;
+
+	/**
+	 * Returns the list of properties exposed as getters and setters in this class.
+	 *
+	 * @return AbstractBeanPropertyDescriptor[]
+	 */
+	public function getExposedProperties(): array;
 }

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      *
      * @return null|string
      */
-    public function getExtendedBeanClassName(): ?string;
+    public function getExtendedBeanClassName(): ? string;
 
     /**
      * Returns the DAO class name (without the namespace).

src/Mouf/Database/TDBM/Utils/NamingStrategyInterface.php

Indentation +34 added lines, -34 removed lines

@@ -8,42 +8,42 @@
  */
 interface NamingStrategyInterface
 {
-    /**
-     * Returns the bean class name from the table name (excluding the namespace).
-     *
-     * @param string $tableName
-     * @return string
-     */
-    public function getBeanClassName(string $tableName) : string;
+	/**
+	 * Returns the bean class name from the table name (excluding the namespace).
+	 *
+	 * @param string $tableName
+	 * @return string
+	 */
+	public function getBeanClassName(string $tableName) : string;
 
-    /**
-     * Returns the base bean class name from the table name (excluding the namespace).
-     *
-     * @param string $tableName
-     * @return string
-     */
-    public function getBaseBeanClassName(string $tableName) : string;
+	/**
+	 * Returns the base bean class name from the table name (excluding the namespace).
+	 *
+	 * @param string $tableName
+	 * @return string
+	 */
+	public function getBaseBeanClassName(string $tableName) : string;
 
-    /**
-     * Returns the name of the DAO class from the table name (excluding the namespace).
-     *
-     * @param string $tableName
-     * @return string
-     */
-    public function getDaoClassName(string $tableName) : string;
+	/**
+	 * Returns the name of the DAO class from the table name (excluding the namespace).
+	 *
+	 * @param string $tableName
+	 * @return string
+	 */
+	public function getDaoClassName(string $tableName) : string;
 
-    /**
-     * Returns the name of the base DAO class from the table name (excluding the namespace).
-     *
-     * @param string $tableName
-     * @return string
-     */
-    public function getBaseDaoClassName(string $tableName) : string;
+	/**
+	 * Returns the name of the base DAO class from the table name (excluding the namespace).
+	 *
+	 * @param string $tableName
+	 * @return string
+	 */
+	public function getBaseDaoClassName(string $tableName) : string;
 
-    /**
-     * Returns the class name for the DAO factory.
-     *
-     * @return string
-     */
-    public function getDaoFactoryClassName() : string;
+	/**
+	 * Returns the class name for the DAO factory.
+	 *
+	 * @return string
+	 */
+	public function getDaoFactoryClassName() : string;
 }

src/Mouf/Database/TDBM/Utils/GeneratorListenerInterface.php

Indentation +5 added lines, -5 removed lines

@@ -10,9 +10,9 @@
  */
 interface GeneratorListenerInterface
 {
-    /**
-     * @param ConfigurationInterface $configuration
-     * @param BeanDescriptorInterface[] $beanDescriptors
-     */
-    public function onGenerate(ConfigurationInterface $configuration, array $beanDescriptors) : void;
+	/**
+	 * @param ConfigurationInterface $configuration
+	 * @param BeanDescriptorInterface[] $beanDescriptors
+	 */
+	public function onGenerate(ConfigurationInterface $configuration, array $beanDescriptors) : void;
 }

src/Mouf/Database/TDBM/MoufConfiguration.php

Indentation +15 added lines, -15 removed lines

@@ -17,21 +17,21 @@
  */
 class MoufConfiguration extends Configuration
 {
-    private $daoFactoryInstanceName = 'daoFactory';
+	private $daoFactoryInstanceName = 'daoFactory';
 
-    /**
-     * @return string
-     */
-    public function getDaoFactoryInstanceName() : string
-    {
-        return $this->daoFactoryInstanceName;
-    }
+	/**
+	 * @return string
+	 */
+	public function getDaoFactoryInstanceName() : string
+	{
+		return $this->daoFactoryInstanceName;
+	}
 
-    /**
-     * @param string $daoFactoryInstanceName
-     */
-    public function setDaoFactoryInstanceName(string $daoFactoryInstanceName)
-    {
-        $this->daoFactoryInstanceName = $daoFactoryInstanceName;
-    }
+	/**
+	 * @param string $daoFactoryInstanceName
+	 */
+	public function setDaoFactoryInstanceName(string $daoFactoryInstanceName)
+	{
+		$this->daoFactoryInstanceName = $daoFactoryInstanceName;
+	}
 }

src/Mouf/Database/TDBM/TDBMObject.php

Indentation +34 added lines, -34 removed lines

@@ -33,42 +33,42 @@
  */
 class TDBMObject extends AbstractTDBMObject
 {
-    public function getProperty($var, $tableName = null)
-    {
-        return $this->get($var, $tableName);
-    }
+	public function getProperty($var, $tableName = null)
+	{
+		return $this->get($var, $tableName);
+	}
 
-    public function setProperty($var, $value, $tableName = null)
-    {
-        $this->set($var, $value, $tableName);
-    }
+	public function setProperty($var, $value, $tableName = null)
+	{
+		$this->set($var, $value, $tableName);
+	}
 
-    /**
-     * Specify data which should be serialized to JSON.
-     *
-     * @link http://php.net/manual/en/jsonserializable.jsonserialize.php
-     *
-     * @return mixed data which can be serialized by <b>json_encode</b>,
-     *               which is a value of any type other than a resource
-     *
-     * @since 5.4.0
-     */
-    public function jsonSerialize()
-    {
-        throw new TDBMException('Json serialization is only implemented for generated beans.');
-    }
+	/**
+	 * Specify data which should be serialized to JSON.
+	 *
+	 * @link http://php.net/manual/en/jsonserializable.jsonserialize.php
+	 *
+	 * @return mixed data which can be serialized by <b>json_encode</b>,
+	 *               which is a value of any type other than a resource
+	 *
+	 * @since 5.4.0
+	 */
+	public function jsonSerialize()
+	{
+		throw new TDBMException('Json serialization is only implemented for generated beans.');
+	}
 
-    /**
-     * Returns an array of used tables by this bean (from parent to child relationship).
-     *
-     * @return string[]
-     */
-    protected function getUsedTables() : array
-    {
-        $tableNames = array_keys($this->dbRows);
-        $tableNames = $this->tdbmService->_getLinkBetweenInheritedTables($tableNames);
-        $tableNames = array_reverse($tableNames);
+	/**
+	 * Returns an array of used tables by this bean (from parent to child relationship).
+	 *
+	 * @return string[]
+	 */
+	protected function getUsedTables() : array
+	{
+		$tableNames = array_keys($this->dbRows);
+		$tableNames = $this->tdbmService->_getLinkBetweenInheritedTables($tableNames);
+		$tableNames = array_reverse($tableNames);
 
-        return $tableNames;
-    }
+		return $tableNames;
+	}
 }

src/Mouf/Database/TDBM/ConfigurationInterface.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     /**
      * @return LoggerInterface
      */
-    public function getLogger(): ?LoggerInterface;
+    public function getLogger(): ? LoggerInterface;
 
     /**
      * @return GeneratorListenerInterface

Indentation +47 added lines, -47 removed lines

@@ -13,51 +13,51 @@
 
 interface ConfigurationInterface
 {
-    /**
-     * @return string
-     */
-    public function getBeanNamespace(): string;
-
-    /**
-     * @return string
-     */
-    public function getDaoNamespace(): string;
-
-    /**
-     * @return Connection
-     */
-    public function getConnection(): Connection;
-
-    /**
-     * @return Cache
-     */
-    public function getCache(): Cache;
-
-    /**
-     * @return NamingStrategyInterface
-     */
-    public function getNamingStrategy(): NamingStrategyInterface;
-
-    /**
-     * @return SchemaAnalyzer
-     */
-    public function getSchemaAnalyzer(): SchemaAnalyzer;
-
-    /**
-     * @return LoggerInterface
-     */
-    public function getLogger(): ?LoggerInterface;
-
-    /**
-     * @return GeneratorListenerInterface
-     */
-    public function getGeneratorEventDispatcher(): GeneratorListenerInterface;
-
-    /**
-     * Returns a class able to find the place of a PHP file based on the class name.
-     * Useful to find the path where DAOs and beans should be written to.
-     *
-     * @return PathFinderInterface
-     */
-    public function getPathFinder() : PathFinderInterface;
+	/**
+	 * @return string
+	 */
+	public function getBeanNamespace(): string;
+
+	/**
+	 * @return string
+	 */
+	public function getDaoNamespace(): string;
+
+	/**
+	 * @return Connection
+	 */
+	public function getConnection(): Connection;
+
+	/**
+	 * @return Cache
+	 */
+	public function getCache(): Cache;
+
+	/**
+	 * @return NamingStrategyInterface
+	 */
+	public function getNamingStrategy(): NamingStrategyInterface;
+
+	/**
+	 * @return SchemaAnalyzer
+	 */
+	public function getSchemaAnalyzer(): SchemaAnalyzer;
+
+	/**
+	 * @return LoggerInterface
+	 */
+	public function getLogger(): ?LoggerInterface;
+
+	/**
+	 * @return GeneratorListenerInterface
+	 */
+	public function getGeneratorEventDispatcher(): GeneratorListenerInterface;
+
+	/**
+	 * Returns a class able to find the place of a PHP file based on the class name.
+	 * Useful to find the path where DAOs and beans should be written to.
+	 *
+	 * @return PathFinderInterface
+	 */
+	public function getPathFinder() : PathFinderInterface;
 }

src/Mouf/Database/TDBM/Controllers/TdbmController.php

Spacing +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
         return $configuration->getProperty($property)->getValue();
     }
 
-    private static function setInConfiguration(MoufManager $moufManager, string $tdbmInstanceName, string $property, ?string $value)
+    private static function setInConfiguration(MoufManager $moufManager, string $tdbmInstanceName, string $property, ? string $value)
     {
         $configuration = self::getConfigurationDescriptor($moufManager, $tdbmInstanceName);
         if ($configuration === null) {

Doc Comments +3 added lines, -1 removed lines

@@ -82,7 +82,7 @@ 
      * @Action
      *
      * @param string $name
-     * @param bool   $selfedit
+     * @param string|boolean   $selfedit
      */
     public function generate($name, $daonamespace, $beannamespace, $daofactoryinstancename, /*$storeInUtc = 0,*/ $selfedit = 'false', $useCustomComposer = false, $composerFile = '')
     {
@@ -102,6 +102,8 @@ 
      * @param string      $daonamespace
      * @param string      $beannamespace
      * @param string      $selfedit
+     * @param boolean $useCustomComposer
+     * @param string $composerFile
      *
      * @throws \Mouf\MoufException
      */

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Mouf\Controllers\AbstractMoufInstanceController;
 use Mouf\Database\TDBM\TDBMService;
 use Mouf\Database\TDBM\Utils\PathFinder\PathFinder;
-use Mouf\Database\TDBM\Utils\TDBMDaoGenerator;
 use Mouf\Html\HtmlElement\HtmlBlock;
 use Mouf\MoufManager;
 use Mouf\InstanceProxy;

Indentation +130 added lines, -130 removed lines

@@ -19,134 +19,134 @@
  */
 class TdbmController extends AbstractMoufInstanceController
 {
-    /**
-     * @var HtmlBlock
-     */
-    public $content;
-
-    protected $daoNamespace;
-    protected $beanNamespace;
-    protected $daoFactoryInstanceName;
-    protected $autoloadDetected;
-    ///protected $storeInUtc;
-    protected $useCustomComposer;
-    protected $composerFile;
-
-    /**
-     * Admin page used to display the DAO generation form.
-     *
-     * @Action
-     */
-    public function defaultAction($name, $selfedit = 'false')
-    {
-        $this->initController($name, $selfedit);
-
-        // Fill variables
-        $this->daoNamespace = self::getFromConfiguration($this->moufManager, $name, 'daoNamespace');
-        $this->beanNamespace = self::getFromConfiguration($this->moufManager, $name, 'beanNamespace');
-        $this->daoFactoryInstanceName = self::getFromConfiguration($this->moufManager, $name, 'daoFactoryInstanceName');
-        //$this->storeInUtc = self::getFromConfiguration($this->moufManager, $name, 'storeInUtc');
-        $pathFinder = self::getFromConfiguration($this->moufManager, $name, 'pathFinder');
-        if ($pathFinder !== null) {
-            $this->composerFile = $pathFinder->getConstructorArgumentProperty('composerFile')->getValue();
-        } else {
-            $this->composerFile = null;
-        }
-        $this->useCustomComposer = $this->composerFile ? true : false;
-
-        if ($this->daoNamespace == null && $this->beanNamespace == null) {
-            $classNameMapper = ClassNameMapper::createFromComposerFile(__DIR__.'/../../../../../../../../composer.json');
-
-            $autoloadNamespaces = $classNameMapper->getManagedNamespaces();
-            if ($autoloadNamespaces) {
-                $this->autoloadDetected = true;
-                $rootNamespace = $autoloadNamespaces[0];
-                $this->daoNamespace = $rootNamespace.'Dao';
-                $this->beanNamespace = $rootNamespace.'Dao\\Bean';
-            } else {
-                $this->autoloadDetected = false;
-                $this->daoNamespace = 'YourApplication\\Dao';
-                $this->beanNamespace = 'YourApplication\\Dao\\Bean';
-            }
-        } else {
-            $this->autoloadDetected = true;
-        }
-
-        $this->content->addFile(__DIR__.'/../../../../views/tdbmGenerate.php', $this);
-        $this->template->toHtml();
-    }
-
-    /**
-     * This action generates the DAOs and Beans for the TDBM service passed in parameter.
-     *
-     * @Action
-     *
-     * @param string $name
-     * @param bool   $selfedit
-     */
-    public function generate($name, $daonamespace, $beannamespace, $daofactoryinstancename, /*$storeInUtc = 0,*/ $selfedit = 'false', $useCustomComposer = false, $composerFile = '')
-    {
-        $this->initController($name, $selfedit);
-
-        self::generateDaos($this->moufManager, $name, $daonamespace, $beannamespace, $daofactoryinstancename, $selfedit, /*$storeInUtc,*/ $useCustomComposer, $composerFile);
-
-        // TODO: better: we should redirect to a screen that list the number of DAOs generated, etc...
-        header('Location: '.ROOT_URL.'ajaxinstance/?name='.urlencode($name).'&selfedit='.$selfedit);
-    }
-
-    /**
-     * This function generates the DAOs and Beans for the TDBM service passed in parameter.
-     *
-     * @param MoufManager $moufManager
-     * @param string      $name
-     * @param string      $daonamespace
-     * @param string      $beannamespace
-     * @param string      $selfedit
-     *
-     * @throws \Mouf\MoufException
-     */
-    public static function generateDaos(MoufManager $moufManager, $name, $daonamespace, $beannamespace, $daofactoryinstancename, $selfedit = 'false', /*$storeInUtc = null,*/ $useCustomComposer = null, $composerFile = null)
-    {
-        self::setInConfiguration($moufManager, $name, 'daoNamespace', $daonamespace);
-        self::setInConfiguration($moufManager, $name, 'beanNamespace', $beannamespace);
-        self::setInConfiguration($moufManager, $name, 'daoFactoryInstanceName', $daofactoryinstancename);
-        //self::setInConfiguration($moufManager, $name, 'storeInUtc', $storeInUtc);
-        if ($useCustomComposer) {
-            $pathFinder = $moufManager->createInstance(PathFinder::class);
-            $pathFinder->getConstructorArgumentProperty('composerFile')->setValue($composerFile);
-            self::setInConfiguration($moufManager, $name, 'pathFinder', $pathFinder);
-        } else {
-            self::setInConfiguration($moufManager, $name, 'pathFinder', null);
-        }
-        // Let's rewrite before calling the DAO generator
-        $moufManager->rewriteMouf();
-
-
-        $tdbmService = new InstanceProxy($name);
-        /* @var $tdbmService TDBMService */
-        $tdbmService->generateAllDaosAndBeans();
-    }
-
-    private static function getConfigurationDescriptor(MoufManager $moufManager, string $tdbmInstanceName)
-    {
-        return $moufManager->getInstanceDescriptor($tdbmInstanceName)->getConstructorArgumentProperty('configuration')->getValue();
-    }
-
-    private static function getFromConfiguration(MoufManager $moufManager, string $tdbmInstanceName, string $property)
-    {
-        $configuration = self::getConfigurationDescriptor($moufManager, $tdbmInstanceName);
-        if ($configuration === null) {
-            throw new \RuntimeException('Unable to find the configuration object linked to TDBMService.');
-        }
-        return $configuration->getProperty($property)->getValue();
-    }
-
-    private static function setInConfiguration(MoufManager $moufManager, string $tdbmInstanceName, string $property, ?string $value)
-    {
-        $configuration = self::getConfigurationDescriptor($moufManager, $tdbmInstanceName);
-        if ($configuration === null) {
-            throw new \RuntimeException('Unable to find the configuration object linked to TDBMService.');
-        }
-        $configuration->getProperty($property)->setValue($value);
-    }
+	/**
+	 * @var HtmlBlock
+	 */
+	public $content;
+
+	protected $daoNamespace;
+	protected $beanNamespace;
+	protected $daoFactoryInstanceName;
+	protected $autoloadDetected;
+	///protected $storeInUtc;
+	protected $useCustomComposer;
+	protected $composerFile;
+
+	/**
+	 * Admin page used to display the DAO generation form.
+	 *
+	 * @Action
+	 */
+	public function defaultAction($name, $selfedit = 'false')
+	{
+		$this->initController($name, $selfedit);
+
+		// Fill variables
+		$this->daoNamespace = self::getFromConfiguration($this->moufManager, $name, 'daoNamespace');
+		$this->beanNamespace = self::getFromConfiguration($this->moufManager, $name, 'beanNamespace');
+		$this->daoFactoryInstanceName = self::getFromConfiguration($this->moufManager, $name, 'daoFactoryInstanceName');
+		//$this->storeInUtc = self::getFromConfiguration($this->moufManager, $name, 'storeInUtc');
+		$pathFinder = self::getFromConfiguration($this->moufManager, $name, 'pathFinder');
+		if ($pathFinder !== null) {
+			$this->composerFile = $pathFinder->getConstructorArgumentProperty('composerFile')->getValue();
+		} else {
+			$this->composerFile = null;
+		}
+		$this->useCustomComposer = $this->composerFile ? true : false;
+
+		if ($this->daoNamespace == null && $this->beanNamespace == null) {
+			$classNameMapper = ClassNameMapper::createFromComposerFile(__DIR__.'/../../../../../../../../composer.json');
+
+			$autoloadNamespaces = $classNameMapper->getManagedNamespaces();
+			if ($autoloadNamespaces) {
+				$this->autoloadDetected = true;
+				$rootNamespace = $autoloadNamespaces[0];
+				$this->daoNamespace = $rootNamespace.'Dao';
+				$this->beanNamespace = $rootNamespace.'Dao\\Bean';
+			} else {
+				$this->autoloadDetected = false;
+				$this->daoNamespace = 'YourApplication\\Dao';
+				$this->beanNamespace = 'YourApplication\\Dao\\Bean';
+			}
+		} else {
+			$this->autoloadDetected = true;
+		}
+
+		$this->content->addFile(__DIR__.'/../../../../views/tdbmGenerate.php', $this);
+		$this->template->toHtml();
+	}
+
+	/**
+	 * This action generates the DAOs and Beans for the TDBM service passed in parameter.
+	 *
+	 * @Action
+	 *
+	 * @param string $name
+	 * @param bool   $selfedit
+	 */
+	public function generate($name, $daonamespace, $beannamespace, $daofactoryinstancename, /*$storeInUtc = 0,*/ $selfedit = 'false', $useCustomComposer = false, $composerFile = '')
+	{
+		$this->initController($name, $selfedit);
+
+		self::generateDaos($this->moufManager, $name, $daonamespace, $beannamespace, $daofactoryinstancename, $selfedit, /*$storeInUtc,*/ $useCustomComposer, $composerFile);
+
+		// TODO: better: we should redirect to a screen that list the number of DAOs generated, etc...
+		header('Location: '.ROOT_URL.'ajaxinstance/?name='.urlencode($name).'&selfedit='.$selfedit);
+	}
+
+	/**
+	 * This function generates the DAOs and Beans for the TDBM service passed in parameter.
+	 *
+	 * @param MoufManager $moufManager
+	 * @param string      $name
+	 * @param string      $daonamespace
+	 * @param string      $beannamespace
+	 * @param string      $selfedit
+	 *
+	 * @throws \Mouf\MoufException
+	 */
+	public static function generateDaos(MoufManager $moufManager, $name, $daonamespace, $beannamespace, $daofactoryinstancename, $selfedit = 'false', /*$storeInUtc = null,*/ $useCustomComposer = null, $composerFile = null)
+	{
+		self::setInConfiguration($moufManager, $name, 'daoNamespace', $daonamespace);
+		self::setInConfiguration($moufManager, $name, 'beanNamespace', $beannamespace);
+		self::setInConfiguration($moufManager, $name, 'daoFactoryInstanceName', $daofactoryinstancename);
+		//self::setInConfiguration($moufManager, $name, 'storeInUtc', $storeInUtc);
+		if ($useCustomComposer) {
+			$pathFinder = $moufManager->createInstance(PathFinder::class);
+			$pathFinder->getConstructorArgumentProperty('composerFile')->setValue($composerFile);
+			self::setInConfiguration($moufManager, $name, 'pathFinder', $pathFinder);
+		} else {
+			self::setInConfiguration($moufManager, $name, 'pathFinder', null);
+		}
+		// Let's rewrite before calling the DAO generator
+		$moufManager->rewriteMouf();
+
+
+		$tdbmService = new InstanceProxy($name);
+		/* @var $tdbmService TDBMService */
+		$tdbmService->generateAllDaosAndBeans();
+	}
+
+	private static function getConfigurationDescriptor(MoufManager $moufManager, string $tdbmInstanceName)
+	{
+		return $moufManager->getInstanceDescriptor($tdbmInstanceName)->getConstructorArgumentProperty('configuration')->getValue();
+	}
+
+	private static function getFromConfiguration(MoufManager $moufManager, string $tdbmInstanceName, string $property)
+	{
+		$configuration = self::getConfigurationDescriptor($moufManager, $tdbmInstanceName);
+		if ($configuration === null) {
+			throw new \RuntimeException('Unable to find the configuration object linked to TDBMService.');
+		}
+		return $configuration->getProperty($property)->getValue();
+	}
+
+	private static function setInConfiguration(MoufManager $moufManager, string $tdbmInstanceName, string $property, ?string $value)
+	{
+		$configuration = self::getConfigurationDescriptor($moufManager, $tdbmInstanceName);
+		if ($configuration === null) {
+			throw new \RuntimeException('Unable to find the configuration object linked to TDBMService.');
+		}
+		$configuration->getProperty($property)->setValue($value);
+	}
 }

src/views/installStep2.php

Indentation +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 <input type="hidden" id="selfedit" name="selfedit" value="<?php echo plainstring_to_htmlprotected($this->selfedit) ?>" />
 
 <?php if (!$this->autoloadDetected) {
-    ?>
+	?>
 <div class="alert">Warning! TDBM could not detect the autoload section of your composer.json file.
 Unless you are developing your own autoload system, you should configure <strong>composer.json</strong> to <a href="http://getcomposer.org/doc/01-basic-usage.md#autoloading" target="_blank">define a source directory and a root namespace using PSR-0</a>.</div>
 <?php