thecodingmachine / database.tdbm

src/Mouf/Database/TDBM/Filters/OrderBySQLString.php

Indentation +3 added lines, -3 removed lines

@@ -133,14 +133,14 @@
 		$work_table = explode("'", $work_str);
 
 		if (count($work_table) == 0)
-		    return '';
+			return '';
 
 		// if we start with a ', let's remove the first text
 		if (strstr($work_str,"'") === 0)
-		    array_shift($work_table);
+			array_shift($work_table);
 			
 		if (count($work_table) == 0)
-		    return '';
+			return '';
 
 		// Now, let's take only the stuff outside the quotes.
 		$work_str2 = '';

Braces +19 added lines, -14 removed lines

@@ -87,8 +87,9 @@ 
 			while (true) {
 				$result = strrpos($phrase, "'", $result+1);
 				if ($result===false) {
-					if ($sentence!='')
-					$sentence .= ',';
+					if ($sentence!='') {
+										$sentence .= ',';
+					}
 					$sentence .= $phrase;
 
 					if ($is_inside_quotes) {
@@ -98,15 +99,15 @@ 
 						$sentence = '';
 						break;
 					}
-				}
-				else
+				} else
 				{
 					$valid_result = true;
 					if ($result>0 && $phrase{$result-1}=='\\') {
 						$valid_result = false;
 					}
-					if ($valid_result)
-					$is_inside_quotes = !$is_inside_quotes;
+					if ($valid_result) {
+										$is_inside_quotes = !$is_inside_quotes;
+					}
 				}
 			}
 
@@ -132,23 +133,27 @@ 
 		// Now, let's split the string using '
 		$work_table = explode("'", $work_str);
 
-		if (count($work_table) == 0)
-		    return '';
+		if (count($work_table) == 0) {
+				    return '';
+		}
 
 		// if we start with a ', let's remove the first text
-		if (strstr($work_str,"'") === 0)
-		    array_shift($work_table);
+		if (strstr($work_str,"'") === 0) {
+				    array_shift($work_table);
+		}
 			
-		if (count($work_table) == 0)
-		    return '';
+		if (count($work_table) == 0) {
+				    return '';
+		}
 
 		// Now, let's take only the stuff outside the quotes.
 		$work_str2 = '';
 
 		$i = 0;
 		foreach ($work_table as $str_fragment) {
-			if (($i % 2) == 0)
-			$work_str2 .= $str_fragment.' ';
+			if (($i % 2) == 0) {
+						$work_str2 .= $str_fragment.' ';
+			}
 			$i++;
 		}
 

src/Mouf/Database/TDBM/Filters/SqlStringFilter.php

Braces +12 added lines, -8 removed lines

@@ -99,23 +99,27 @@
 		// Now, let's split the string using '
 		$work_table = explode("'", $work_str);
 
-		if (count($work_table)==0)
-		return '';
+		if (count($work_table)==0) {
+				return '';
+		}
 
 		// if we start with a ', let's remove the first text
-		if (strstr($work_str,"'")===0)
-		array_shift($work_table);
+		if (strstr($work_str,"'")===0) {
+				array_shift($work_table);
+		}
 			
-		if (count($work_table)==0)
-		return '';
+		if (count($work_table)==0) {
+				return '';
+		}
 
 		// Now, let's take only the stuff outside the quotes.
 		$work_str2 = '';
 
 		$i=0;
 		foreach ($work_table as $str_fragment) {
-			if (($i % 2) == 0)
-			$work_str2 .= $str_fragment.' ';
+			if (($i % 2) == 0) {
+						$work_str2 .= $str_fragment.' ';
+			}
 			$i++;
 		}
 

src/Mouf/Database/TDBM/AmbiguityException.php

Indentation +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 	}
 
 	private function getAllPossiblePaths() {
-        return AmbiguityException::getAllPossiblePathsRec($this->paths);
+		return AmbiguityException::getAllPossiblePathsRec($this->paths);
 	}
 
 	private static function getAllPossiblePathsRec($sub_table_paths)

Braces +5 added lines, -4 removed lines

@@ -50,8 +50,9 @@ 
 
 	private static function getAllPossiblePathsRec($sub_table_paths)
 	{
-		if (count($sub_table_paths)==0)
-		return array();
+		if (count($sub_table_paths)==0) {
+				return array();
+		}
 
 		$table_path = array_shift($sub_table_paths);
 		$possible_sub_paths =  AmbiguityException::getAllPossiblePathsRec($sub_table_paths);
@@ -63,9 +64,9 @@ 
 				{
 					$return_table_paths[] = array_merge(array(array('paths'=>array($path))), $possible_sub_path);
 				}
+			} else {
+						$return_table_paths[] = array(array('paths'=>array($path)));
 			}
-			else
-			$return_table_paths[] = array(array('paths'=>array($path)));
 		}
 		return $return_table_paths;
 	}

src/Mouf/Database/TDBM/TDBMObjectArray.php

Indentation +2 added lines, -2 removed lines

@@ -65,9 +65,9 @@
 	 * @param string $func_name
 	 * @param $values
 	 * @return array|void
-     * @throws TDBMException
+	 * @throws TDBMException
 	 */
-    public function __call($func_name, $values) {
+	public function __call($func_name, $values) {
 
 		if (strpos($func_name,"getarray_") === 0) {
 			$column = substr($func_name, 9);

Braces +5 added lines, -10 removed lines

@@ -31,12 +31,10 @@ 
 		if ($cnt==1)
 		{
 			return $this[0]->__get($var);
-		}
-		elseif ($cnt>1)
+		} elseif ($cnt>1)
 		{
 			throw new TDBMException('Array contains many objects! Use getarray_'.$var.' to retrieve an array of '.$var);
-		}
-		else
+		} else
 		{
 			throw new TDBMException('Array contains no objects');
 		}
@@ -47,12 +45,10 @@ 
 		if ($cnt==1)
 		{
 			return $this[0]->__set($var, $value);
-		}
-		elseif ($cnt>1)
+		} elseif ($cnt>1)
 		{
 			throw new TDBMException('Array contains many objects! Use setarray_'.$var.' to set the array of '.$var);
-		}
-		else
+		} else
 		{
 			throw new TDBMException('Array contains no objects');
 		}
@@ -77,8 +73,7 @@ 
 			return $this->setarray($column, $values[0]);
 		} elseif (count($this)==1) {
 			$this[0]->__call($func_name, $values);
-		}
-		else
+		} else
 		{
 			throw new TDBMException("Method ".$func_name." not found");
 		}

src/Mouf/Database/TDBM/DisplayNode.php

Braces +1 added lines, -2 removed lines

@@ -67,8 +67,7 @@
 			if ($this->link_type == "*1")
 			{
 				echo "Table $this->table_name points to table ".$this->parent_node->table_name." through its foreign key on column $this->keyNode that points to column $this->keyParent<br />";
-			}
-			else if ($this->link_type == "1*")
+			} else if ($this->link_type == "1*")
 			{
 				echo "Table $this->table_name is pointed by table ".$this->parent_node->table_name." by its foreign key on column $this->keyParent that points to column $this->keyNode<br />";
 			}

src/Mouf/Database/TDBM/Filters/BetweenFilter.php

Indentation +4 added lines, -4 removed lines

@@ -98,8 +98,8 @@ 
 	 * 
 	 * @param string $tableName
 	 * @param string $columnName
-     * @param string $value1
-     * @param string $value2
+	 * @param string $value1
+	 * @param string $value2
 	 */
 	public function __construct($tableName=null, $columnName=null, $value1=null, $value2=null) {
 		$this->tableName = $tableName;
@@ -113,9 +113,9 @@ 
 	 *
 	 * @param ConnectionInterface $dbConnection
 	 * @return string
-     * @throws \Mouf\Database\TDBM\TDBMException
+	 * @throws \Mouf\Database\TDBM\TDBMException
 	 */
-    public function toSql(ConnectionInterface $dbConnection) {
+	public function toSql(ConnectionInterface $dbConnection) {
 		if ($this->enableCondition != null && !$this->enableCondition->isOk()) {
 			return "";
 		}

src/Mouf/Database/TDBM/Filters/OrFilter.php

Indentation +20 added lines, -20 removed lines

@@ -68,9 +68,9 @@ 
 	 *
 	 * @param ConnectionInterface $dbConnection
 	 * @return string
-     * @throws TDBMException
+	 * @throws TDBMException
 	 */
-    public function toSql(ConnectionInterface $dbConnection) {
+	public function toSql(ConnectionInterface $dbConnection) {
 		if ($this->enableCondition != null && !$this->enableCondition->isOk()) {
 			return "";
 		}
@@ -102,22 +102,22 @@ 
 	 *
 	 * @return array<string>
 	 */
-    public function getUsedTables() {
-        if ($this->enableCondition != null && !$this->enableCondition->isOk()) {
-            return array();
-        }
-
-        $tables = array();
-        foreach ($this->filters as $filter) {
-
-            if (!$filter instanceof FilterInterface) {
-                throw new TDBMException("Error in OrFilter: One of the parameters is not a filter.");
-            }
-
-            $tables = array_merge($tables,$filter->getUsedTables());
-        }
-        // Remove tables in double.
-        $tables = array_flip(array_flip($tables));
-        return $tables;
-    }
+	public function getUsedTables() {
+		if ($this->enableCondition != null && !$this->enableCondition->isOk()) {
+			return array();
+		}
+
+		$tables = array();
+		foreach ($this->filters as $filter) {
+
+			if (!$filter instanceof FilterInterface) {
+				throw new TDBMException("Error in OrFilter: One of the parameters is not a filter.");
+			}
+
+			$tables = array_merge($tables,$filter->getUsedTables());
+		}
+		// Remove tables in double.
+		$tables = array_flip(array_flip($tables));
+		return $tables;
+	}
 }

src/Mouf/Database/TDBM/TDBMObject.php

Indentation +57 added lines, -57 removed lines

@@ -170,26 +170,26 @@ 
 		$this->TDBMObject_state = $state;	
 	}
 
-    /**
-     * Internal TDBM method, you should not use this.
-     * Loads the db_row property of the object from the $row array.
-     * Any row having a key starting with 'tdbm_reserved_col_' is ignored.
-     *
-     * @param array $row
-     * @param array|null $colsArray A big optimization to avoid calling strpos to many times. This array should
-     *                              contain as keys the list of interesting columns. If null, this list will be initialized.
-     */
+	/**
+	 * Internal TDBM method, you should not use this.
+	 * Loads the db_row property of the object from the $row array.
+	 * Any row having a key starting with 'tdbm_reserved_col_' is ignored.
+	 *
+	 * @param array $row
+	 * @param array|null $colsArray A big optimization to avoid calling strpos to many times. This array should
+	 *                              contain as keys the list of interesting columns. If null, this list will be initialized.
+	 */
 	public function loadFromRow($row, &$colsArray) {
-        if ($colsArray === null) {
-            foreach ($row as $key=>$value) {
-                if (strpos($key, 'tdbm_reserved_col_')!==0) {
-                    $colsArray[$key] = true;
-                }
-            }
-        }
-
-        $this->db_row = array_intersect_key($row, $colsArray);
-        $this->TDBMObject_state = "loaded";
+		if ($colsArray === null) {
+			foreach ($row as $key=>$value) {
+				if (strpos($key, 'tdbm_reserved_col_')!==0) {
+					$colsArray[$key] = true;
+				}
+			}
+		}
+
+		$this->db_row = array_intersect_key($row, $colsArray);
+		$this->TDBMObject_state = "loaded";
 	}
 
 	/**
@@ -507,10 +507,10 @@ 
 	 *
 	 * @param string $func_name
 	 * @param $values
-     * @return TDBMObjectArray A TDBMObjectArray containing the resulting objects of the query.
-     * @throws TDBMException
+	 * @return TDBMObjectArray A TDBMObjectArray containing the resulting objects of the query.
+	 * @throws TDBMException
 	 */
-    public function __call($func_name, $values) {
+	public function __call($func_name, $values) {
 
 		if (strpos($func_name,"get_") === 0) {
 			$table = substr($func_name,4);
@@ -545,48 +545,48 @@ 
 	}
 	
 		/**
-	 * Implements array behaviour for our object.
-	 * 
-	 * @param string $offset
-	 * @param string $value
-	 */
+		 * Implements array behaviour for our object.
+		 * 
+		 * @param string $offset
+		 * @param string $value
+		 */
 	public function offsetSet($offset, $value) {
 		$this->__set($offset, $value);
-    }
+	}
 	/**
 	 * Implements array behaviour for our object.
 	 * 
 	 * @param string $offset
-     * @return bool
+	 * @return bool
 	 */
-    public function offsetExists($offset) {
-    	$this->_dbLoadIfNotLoaded();
-        return isset($this->db_row[$offset]);
-    }
+	public function offsetExists($offset) {
+		$this->_dbLoadIfNotLoaded();
+		return isset($this->db_row[$offset]);
+	}
 	/**
 	 * Implements array behaviour for our object.
 	 * 
 	 * @param string $offset
 	 */
-    public function offsetUnset($offset) {
+	public function offsetUnset($offset) {
 		$this->__set($offset, null);
-    }
+	}
 	/**
 	 * Implements array behaviour for our object.
 	 * 
 	 * @param string $offset
-     * @return mixed|null
+	 * @return mixed|null
 	 */
-    public function offsetGet($offset) {
-        return $this->__get($offset);
-    }
+	public function offsetGet($offset) {
+		return $this->__get($offset);
+	}
 	
 	private $_validIterator = false;
 	/**
 	 * Implements iterator behaviour for our object (so we can each column).
 	 */
 	public function rewind() {
-    	$this->_dbLoadIfNotLoaded();
+		$this->_dbLoadIfNotLoaded();
 		if (count($this->db_row)>0) {
 			$this->_validIterator = true;
 		} else {
@@ -674,21 +674,21 @@ 
 		return $sql_where;
 	}
 
-    /**
-     * Override the native php clone function for TDBMObjects
-     */
-    public function __clone(){
-        $this->_dbLoadIfNotLoaded();
-        //First lets set the status to new (to enter the save function)
-        $this->TDBMObject_state = "new";
-
-        // Add the current TDBMObject to the save object list
-        $this->tdbmService->_addToToSaveObjectList($this);
-
-        //Now unset the PK from the row
-        $pk_array = $this->getPrimaryKey();
-        foreach ($pk_array as $pk) {
-            $this->db_row[$pk] = null;
-        }
-    }
+	/**
+	 * Override the native php clone function for TDBMObjects
+	 */
+	public function __clone(){
+		$this->_dbLoadIfNotLoaded();
+		//First lets set the status to new (to enter the save function)
+		$this->TDBMObject_state = "new";
+
+		// Add the current TDBMObject to the save object list
+		$this->tdbmService->_addToToSaveObjectList($this);
+
+		//Now unset the PK from the row
+		$pk_array = $this->getPrimaryKey();
+		foreach ($pk_array as $pk) {
+			$this->db_row[$pk] = null;
+		}
+	}
 }
\ No newline at end of file

Braces +30 added lines, -23 removed lines

@@ -263,10 +263,11 @@ 
 				// Let's try to be accurate in error reporting. The checkColumnExist returns an array of closest matches.
 				$result_array = $column_exist;
 				
-				if (count($result_array)==1)
-				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant this column: '".$result_array[0]."'";
-				else
-				$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant one of those columns: '".implode("', '",$result_array)."'";
+				if (count($result_array)==1) {
+								$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant this column: '".$result_array[0]."'";
+				} else {
+								$str = "Could not find column \"$var\" in table \"$this->db_table_name\". Maybe you meant one of those columns: '".implode("', '",$result_array)."'";
+				}
 	
 	
 				throw new TDBMException($str);
@@ -348,10 +349,11 @@ 
 			if (count($pk_array)>1 && !$pk_set) {
 				$msg = "Error! You did not set the primary keys for the new object of type '$this->db_table_name'. TDBM usually assumes that the primary key is automatically set by the DB engine to the maximum value in the database. However, in this case, the '$this->db_table_name' table has a primary key on multiple columns. TDBM would be unable to find back this record after save. Please specify the primary keys for all new objects of kind '$this->db_table_name'.";
 
-				if (!$this->tdbmService->isProgramExiting())
-				throw new TDBMException($msg);
-				else
-				trigger_error($msg, E_USER_ERROR);
+				if (!$this->tdbmService->isProgramExiting()) {
+								throw new TDBMException($msg);
+				} else {
+								trigger_error($msg, E_USER_ERROR);
+				}
 			}
 			
 			$sql = 'INSERT INTO '.$this->db_connection->escapeDBItem($this->db_table_name).
@@ -360,8 +362,9 @@ 
 
 			$first = true;
 			foreach ($this->db_row as $key=>$value) {
-				if (!$first)
-				$sql .= ',';
+				if (!$first) {
+								$sql .= ',';
+				}
 				$sql .= $this->db_connection->quoteSmart($value);
 				$first=false;
 			}
@@ -378,9 +381,9 @@ 
 				//	trigger_error("program exiting");
 				trigger_error($e->getMessage(), E_USER_ERROR);
 
-				if (!$this->tdbmService->isProgramExiting())
-				throw $e;
-				else
+				if (!$this->tdbmService->isProgramExiting()) {
+								throw $e;
+				} else
 				{
 					trigger_error($e->getMessage(), E_USER_ERROR);
 				}
@@ -447,8 +450,9 @@ 
 
 			$first = true;
 			foreach ($this->db_row as $key=>$value) {
-				if (!$first)
-				$sql .= ',';
+				if (!$first) {
+								$sql .= ',';
+				}
 				$sql .= $this->db_connection->escapeDBItem($key)." = ".$this->db_connection->quoteSmart($value);
 				$first=false;
 			}
@@ -456,10 +460,11 @@ 
 			try {
 				$this->db_connection->exec($sql);
 			} catch (TDBMException $e) {
-				if (!$this->tdbmService->isProgramExiting())
-				throw $e;
-				else
-				trigger_error($e->getMessage(), E_USER_ERROR);
+				if (!$this->tdbmService->isProgramExiting()) {
+								throw $e;
+				} else {
+								trigger_error($e->getMessage(), E_USER_ERROR);
+				}
 			}
 
 			// Let's remove this object from the $new_objects static table.
@@ -490,11 +495,13 @@ 
 	 *
 	 */
 	public function discardChanges() {
-		if ($this->TDBMObject_state == "new")
-		throw new TDBMException("You cannot call discardChanges() on an object that has been created with getNewObject and that has not yet been saved.");
+		if ($this->TDBMObject_state == "new") {
+				throw new TDBMException("You cannot call discardChanges() on an object that has been created with getNewObject and that has not yet been saved.");
+		}
 
-		if ($this->TDBMObject_state == "deleted")
-		throw new TDBMException("You cannot call discardChanges() on an object that has been deleted.");
+		if ($this->TDBMObject_state == "deleted") {
+				throw new TDBMException("You cannot call discardChanges() on an object that has been deleted.");
+		}
 			
 		$this->db_modified_state = false;
 		$this->TDBMObject_state = "not loaded";

src/Mouf/Database/TDBM/TDBMObjectArrayCursorIterator.php

Indentation +3 added lines, -3 removed lines

@@ -55,7 +55,7 @@ 
 	 */
 	protected $current = false;
 
-    private $colsArray = null;
+	private $colsArray = null;
 	
 	public function __construct(\PDOStatement $pdoStatement, ConnectionInterface $dbConnection, $primary_keys, $table_name, $objectStorage, $className, TDBMService $tdbmService, $sql)
 	{
@@ -73,9 +73,9 @@ 
 	 * Casts a document to a new instance specified in the $recordClass
 	 * @param array $fullCaseRow
 	 * @return Record_Abstract|false
-     * @throws TDBMException
+	 * @throws TDBMException
 	 */
-    protected function cast($fullCaseRow)
+	protected function cast($fullCaseRow)
 	{
 		if (!is_array($fullCaseRow)) {
 			return false;

Braces +14 added lines, -12 removed lines

@@ -101,8 +101,7 @@ 
 				throw new TDBMException("Bad SQL request passed to getObjectsFromSQL. The SQL request should return all the rows from the '".$this->table_name."' table. Could not find primary key in this set of rows. SQL request passed: ".$this->sql);
 			}
 			$id = $row[$this->keysStandardCased[$this->primary_keys[0]]];
-		}
-		else
+		} else
 		{
 			// Let's generate the serialized primary key from the columns!
 			$ids = array();
@@ -181,12 +180,14 @@ 
 		if ($this->hasNext()) {
 			$this->cursor++;
 			$this->current = $this->pdoStatement->fetch(\PDO::FETCH_ASSOC);
-			if (empty($this->current))
-				$this->current = false;
-			else
-				return true;
-		}else
-			$this->current = false;
+			if (empty($this->current)) {
+							$this->current = false;
+			} else {
+							return true;
+			}
+		} else {
+					$this->current = false;
+		}
 		return false;
 	}
 	
@@ -259,10 +260,11 @@ 
 		$all = array();
 		$this->rewind();
 		foreach ($this->pdoStatement as $id => $doc) {
-			if ($asRecords)
-				$all[$id] = $this->cast($doc);
-			else
-				$all[$id] = $doc;
+			if ($asRecords) {
+							$all[$id] = $this->cast($doc);
+			} else {
+							$all[$id] = $doc;
+			}
 		}
 		return $all;
 	}