CMSUtilsServiceProvider::getFactories() - Code Metrics - thecodingmachine/cms-utils - Measure and Improve Code Quality continuously with Scrutinizer

CMSUtilsServiceProvider::getFactories() A
last analyzed 2017-11-20 09:37 UTC

↳ Parent: CMSUtilsServiceProvider

Complexity

Conditions	3
Paths	1

Size

Total Lines	58
Code Lines	35

Duplication

Lines	30
Ratio	51.72 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	35
nc	1
nop	0
dl	30
loc	58
rs	9.639
c	1
b	0
f	0

How to fix Long Method

<?php


namespace TheCodingMachine\CMS\DI;


use Interop\Container\Factories\Alias;
use Interop\Container\ServiceProviderInterface;
use Psr\Container\ContainerInterface;
use TheCodingMachine\CMS\Block\BlockRenderer;
use TheCodingMachine\CMS\Block\BlockRendererInterface;
use TheCodingMachine\CMS\Serializer\AggregateThemeUnserializer;
use TheCodingMachine\CMS\Serializer\BlockUnserializer;
use TheCodingMachine\CMS\Serializer\SubThemeUnserializer;
use TheCodingMachine\CMS\Serializer\ThemeUnserializerInterface;
use TheCodingMachine\CMS\Serializer\TwigThemeUnserializer;
use TheCodingMachine\CMS\Theme\AggregateThemeFactory;
use TheCodingMachine\CMS\Theme\SubThemeFactory;
use TheCodingMachine\CMS\Theme\ThemeFactoryInterface;
use TheCodingMachine\CMS\Theme\TwigThemeFactory;

class CMSUtilsServiceProvider implements ServiceProviderInterface
{

    public function getFactories()
    {
        $aggregateThemeFactory = null;
        $aggregateThemeUnserializer = null;
        return [
            AggregateThemeFactory::class => function(ContainerInterface $container) use (&$aggregateThemeFactory): AggregateThemeFactory

            {
                if ($aggregateThemeFactory !== null) {
                    return $aggregateThemeFactory;
                }
                $aggregateThemeFactory = new AggregateThemeFactory([]);

                $subThemeFactory = new SubThemeFactory($aggregateThemeFactory);
                $twigThemeFactory = new TwigThemeFactory($container->get(\Twig_Environment::class), $container->get(BlockRendererInterface::class), $container->get('THEMES_PATH'), $container->get('THEMES_URL'));

                $aggregateThemeFactory->addThemeFactory($twigThemeFactory);
                $aggregateThemeFactory->addThemeFactory($subThemeFactory);
                return $aggregateThemeFactory;
            },
            ThemeFactoryInterface::class => new Alias(AggregateThemeFactory::class),
            BlockRendererInterface::class => new Alias(BlockRenderer::class),
            BlockRenderer::class => function(ContainerInterface $container) use (&$aggregateThemeFactory): BlockRenderer

            {
                if ($aggregateThemeFactory === null) {
                    $aggregateThemeFactory = new AggregateThemeFactory([]);
                }

                $blockRenderer = new BlockRenderer($aggregateThemeFactory);

                $subThemeFactory = new SubThemeFactory($aggregateThemeFactory);
                $twigThemeFactory = new TwigThemeFactory($container->get(\Twig_Environment::class), $blockRenderer, $container->get('THEMES_PATH'), $container->get('THEMES_URL'));

                $aggregateThemeFactory->addThemeFactory($subThemeFactory);
                $aggregateThemeFactory->addThemeFactory($twigThemeFactory);

                return $blockRenderer;
            },

            AggregateThemeUnserializer::class => function() use (&$aggregateThemeUnserializer): AggregateThemeUnserializer
            {
                list($aggregateThemeUnserializer, $blockUnserializer) = $this->getBlockAndAggregateUnserializer();


                $subThemeFactory = new SubThemeUnserializer($blockUnserializer, $aggregateThemeUnserializer);
                $twigThemeFactory = new TwigThemeUnserializer();

                $aggregateThemeUnserializer->addUnserializer('twig', $twigThemeFactory);
                $aggregateThemeUnserializer->addUnserializer('subTheme', $subThemeFactory);
                return $aggregateThemeUnserializer;

            },
            ThemeUnserializerInterface::class => new Alias(AggregateThemeUnserializer::class),
            BlockUnserializer::class => function(ContainerInterface $container) use (&$aggregateThemeUnserializer): BlockUnserializer
            {
                list($aggregateThemeUnserializer, $blockUnserializer) = $this->getBlockAndAggregateUnserializer();

                // Force resolving the aggregateThemeUnserializer
                $container->get(AggregateThemeUnserializer::class);
                return $blockUnserializer;
            },

        ];
    }

    private $aggregateThemeUnserializer;
    private $blockUnserializer;

    /**
     * This method is needed to break the loop of dependencies.
     *
     * @return mixed[]
     */
    private function getBlockAndAggregateUnserializer(): array
    {
        if ($this->aggregateThemeUnserializer) {
            return [$this->aggregateThemeUnserializer, $this->blockUnserializer];
        }

        $this->aggregateThemeUnserializer = new AggregateThemeUnserializer();
        $this->blockUnserializer = new BlockUnserializer($this->aggregateThemeUnserializer);

        return [$this->aggregateThemeUnserializer, $this->blockUnserializer];
    }

    public function getExtensions()
    {
        return [];
    }
}


1		<?php
2
3
4		namespace TheCodingMachine\CMS\DI;
5
6
7		use Interop\Container\Factories\Alias;
8		use Interop\Container\ServiceProviderInterface;
9		use Psr\Container\ContainerInterface;
10		use TheCodingMachine\CMS\Block\BlockRenderer;
11		use TheCodingMachine\CMS\Block\BlockRendererInterface;
12		use TheCodingMachine\CMS\Serializer\AggregateThemeUnserializer;
13		use TheCodingMachine\CMS\Serializer\BlockUnserializer;
14		use TheCodingMachine\CMS\Serializer\SubThemeUnserializer;
15		use TheCodingMachine\CMS\Serializer\ThemeUnserializerInterface;
16		use TheCodingMachine\CMS\Serializer\TwigThemeUnserializer;
17		use TheCodingMachine\CMS\Theme\AggregateThemeFactory;
18		use TheCodingMachine\CMS\Theme\SubThemeFactory;
19		use TheCodingMachine\CMS\Theme\ThemeFactoryInterface;
20		use TheCodingMachine\CMS\Theme\TwigThemeFactory;
21
22		class CMSUtilsServiceProvider implements ServiceProviderInterface
23		{
24
25		public function getFactories()
26		{
27		$aggregateThemeFactory = null;
28		$aggregateThemeUnserializer = null;
29		return [
30	View Code Duplication	AggregateThemeFactory::class => function(ContainerInterface $container) use (&$aggregateThemeFactory): AggregateThemeFactory
		0 ignored issues – show Duplication introduced 2017-09-22 15:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		if ($aggregateThemeFactory !== null) {
33		return $aggregateThemeFactory;
34		}
35		$aggregateThemeFactory = new AggregateThemeFactory([]);
36
37		$subThemeFactory = new SubThemeFactory($aggregateThemeFactory);
38		$twigThemeFactory = new TwigThemeFactory($container->get(\Twig_Environment::class), $container->get(BlockRendererInterface::class), $container->get('THEMES_PATH'), $container->get('THEMES_URL'));
39
40		$aggregateThemeFactory->addThemeFactory($twigThemeFactory);
41		$aggregateThemeFactory->addThemeFactory($subThemeFactory);
42		return $aggregateThemeFactory;
43		},
44		ThemeFactoryInterface::class => new Alias(AggregateThemeFactory::class),
45		BlockRendererInterface::class => new Alias(BlockRenderer::class),
46	View Code Duplication	BlockRenderer::class => function(ContainerInterface $container) use (&$aggregateThemeFactory): BlockRenderer
		0 ignored issues – show Duplication introduced 2017-09-22 15:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		if ($aggregateThemeFactory === null) {
49		$aggregateThemeFactory = new AggregateThemeFactory([]);
50		}
51
52		$blockRenderer = new BlockRenderer($aggregateThemeFactory);
53
54		$subThemeFactory = new SubThemeFactory($aggregateThemeFactory);
55		$twigThemeFactory = new TwigThemeFactory($container->get(\Twig_Environment::class), $blockRenderer, $container->get('THEMES_PATH'), $container->get('THEMES_URL'));
56
57		$aggregateThemeFactory->addThemeFactory($subThemeFactory);
58		$aggregateThemeFactory->addThemeFactory($twigThemeFactory);
59
60		return $blockRenderer;
61		},
62
63		AggregateThemeUnserializer::class => function() use (&$aggregateThemeUnserializer): AggregateThemeUnserializer
64		{
65		list($aggregateThemeUnserializer, $blockUnserializer) = $this->getBlockAndAggregateUnserializer();
66
67
68		$subThemeFactory = new SubThemeUnserializer($blockUnserializer, $aggregateThemeUnserializer);
69		$twigThemeFactory = new TwigThemeUnserializer();
70
71		$aggregateThemeUnserializer->addUnserializer('twig', $twigThemeFactory);
72		$aggregateThemeUnserializer->addUnserializer('subTheme', $subThemeFactory);
73		return $aggregateThemeUnserializer;
		0 ignored issues – show Bug Best Practice introduced 2017-09-27 07:08 UTC by Report Bug Copy Issue Report The expression `return $aggregateThemeUnserializer` returns the type `null` which is incompatible with the type-hinted return `TheCodingMachine\CMS\Ser...regateThemeUnserializer`. Loading history...
74		},
75		ThemeUnserializerInterface::class => new Alias(AggregateThemeUnserializer::class),
76		BlockUnserializer::class => function(ContainerInterface $container) use (&$aggregateThemeUnserializer): BlockUnserializer
77		{
78		list($aggregateThemeUnserializer, $blockUnserializer) = $this->getBlockAndAggregateUnserializer();
79
80		// Force resolving the aggregateThemeUnserializer
81		$container->get(AggregateThemeUnserializer::class);
82		return $blockUnserializer;
83		},
84
85		];
86		}
87
88		private $aggregateThemeUnserializer;
89		private $blockUnserializer;
90
91		/**
92		* This method is needed to break the loop of dependencies.
93		*
94		* @return mixed[]
95		*/
96		private function getBlockAndAggregateUnserializer(): array
97		{
98		if ($this->aggregateThemeUnserializer) {
99		return [$this->aggregateThemeUnserializer, $this->blockUnserializer];
100		}
101
102		$this->aggregateThemeUnserializer = new AggregateThemeUnserializer();
103		$this->blockUnserializer = new BlockUnserializer($this->aggregateThemeUnserializer);
104
105		return [$this->aggregateThemeUnserializer, $this->blockUnserializer];
106		}
107
108		public function getExtensions()
109		{
110		return [];
111		}
112		}
113

thecodingmachine / cms-utils

CMSUtilsServiceProvider::getFactories() A last analyzed 2017-11-20 09:37 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

CMSUtilsServiceProvider::getFactories() A
last analyzed 2017-11-20 09:37 UTC