SubTheme::fromFile() - Code Metrics - Inspection of "Adding Scrutinizer conf" - thecodingmachine/cms-static-registry - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4bccec...259a7c )

by David

created 2017-11-14 15:11 UTC

SubTheme::fromFile() A

↳ Parent: SubTheme

Complexity

Conditions	4
Paths	2

Size

Total Lines	20
Code Lines	11

Duplication

Lines	5
Ratio	25 %

Importance

Changes

Metric	Value
cc	4
eloc	11
nc	2
nop	1
dl	5
loc	20
rs	9.2
c	0
b	0
f	0

<?php
namespace TheCodingMachine\CMS\StaticRegistry\Loaders;

use Barclays\Model\BaseBlock;
filter:
    dependency_paths: ["lib/*"]
use Mni\FrontYAML\Parser;
use Symfony\Component\Yaml\Yaml;
use TheCodingMachine\CMS\Block\Block;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class SubTheme
{
    /**
     * @var string
     */
    private $name;
    /**
     * @var string
     */
    private $parent;
    /**
     * @var array|string[][]
     */
    private $assignations;

    /**
     * @param string $name
     * @param string $parent
     * @param string[][] $assignations
     */
    public function __construct(string $name, string $parent, array $assignations)
    {
        $this->name = $name;
        $this->parent = $parent;
        $this->assignations = $assignations;
    }

    public static function fromFile(string $file): self
    {
        if (!is_readable($file)) {
            throw new UnableToLoadFileException('Cannot read file '.$file);
        }

        $yaml = Yaml::parse(file_get_contents($file));

        $compulsoryFields = ['name', 'parent', 'assignations'];

        foreach ($compulsoryFields as $field) {

            if (!isset($yaml[$field])) {
                throw new UnableToLoadFileException('Missing field "'.$field.'" in YAML file '.$file);
            }
        }

        return new self(
            $yaml['name'],
            $yaml['parent'],
            $yaml['assignations']
        );
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @return string
     */
    public function getParent(): string
    {
        return $this->parent;
    }

    /**
     * @return array|string[][]
     */
    public function getAssignations()
    {
        return $this->assignations;
    }
}


1		<?php
2		namespace TheCodingMachine\CMS\StaticRegistry\Loaders;
3
4		use Barclays\Model\BaseBlock;
		0 ignored issues – show Bug introduced 2017-11-14 15:12 UTC by Report Bug Copy Issue Report The type `Barclays\Model\BaseBlock` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
5		use Mni\FrontYAML\Parser;
6		use Symfony\Component\Yaml\Yaml;
7		use TheCodingMachine\CMS\Block\Block;
		0 ignored issues – show Bug introduced 2017-11-14 15:12 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `TheCodingMachine\CMS\StaticRegistry\Loaders\Block`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8
9		class SubTheme
10		{
11		/**
12		* @var string
13		*/
14		private $name;
15		/**
16		* @var string
17		*/
18		private $parent;
19		/**
20		* @var array\|string[][]
21		*/
22		private $assignations;
23
24		/**
25		* @param string $name
26		* @param string $parent
27		* @param string[][] $assignations
28		*/
29		public function __construct(string $name, string $parent, array $assignations)
30		{
31		$this->name = $name;
32		$this->parent = $parent;
33		$this->assignations = $assignations;
34		}
35
36		public static function fromFile(string $file): self
37		{
38		if (!is_readable($file)) {
39		throw new UnableToLoadFileException('Cannot read file '.$file);
40		}
41
42		$yaml = Yaml::parse(file_get_contents($file));
43
44		$compulsoryFields = ['name', 'parent', 'assignations'];
45
46	View Code Duplication	foreach ($compulsoryFields as $field) {
		0 ignored issues – show Duplication introduced 2017-11-14 13:30 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		if (!isset($yaml[$field])) {
48		throw new UnableToLoadFileException('Missing field "'.$field.'" in YAML file '.$file);
49		}
50		}
51
52		return new self(
53		$yaml['name'],
54		$yaml['parent'],
55		$yaml['assignations']
56		);
57		}
58
59		/**
60		* @return string
61		*/
62		public function getName(): string
63		{
64		return $this->name;
65		}
66
67		/**
68		* @return string
69		*/
70		public function getParent(): string
71		{
72		return $this->parent;
73		}
74
75		/**
76		* @return array\|string[][]
77		*/
78		public function getAssignations()
79		{
80		return $this->assignations;
81		}
82		}
83

thecodingmachine / cms-static-registry

Push — master ( 4bccec...259a7c )

SubTheme::fromFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like