JWTRequest::delete() - Code Metrics - Inspection of "Update JWT Service" - thecatontheflat/atlassian-connect-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bb131b...ea520a )

by Bukashk0zzz

created 2017-12-25 14:14 UTC

JWTRequest::delete() A

↳ Parent: JWTRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php declare(strict_types = 1);

namespace AtlassianConnectBundle\Service;

use AtlassianConnectBundle\Entity\TenantInterface;
use GuzzleHttp\Client;
use GuzzleHttp\Handler\CurlHandler;
use GuzzleHttp\HandlerStack;
use Symfony\Component\HttpFoundation\File\UploadedFile;

/**
 * Class JWTRequest
 */
class JWTRequest
{
    /**
     * @var TenantInterface
     */
    private $tenant;

    /**
     * @var Client
     */
    private $client;

    /**
     * JWTRequest constructor.
     *
     * @param TenantInterface $tenant
     */
    public function __construct(TenantInterface $tenant)
    {
        $this->tenant = $tenant;
        $this->client = $this->createClient();
    }

    /**
     * @param UploadedFile $file
     * @param string       $restUrl
     *
     * @return string
     */
    public function sendFile(UploadedFile $file, string $restUrl): string
    {
        $options['headers']['X-Atlassian-Token'] = 'nocheck';

        $savedFile = $file->move('/tmp/', $file->getClientOriginalName());

        $options['body'] = [
            'file' => \fopen($savedFile->getRealPath(), 'rb'),
        ];

        \unlink($savedFile->getRealPath());

        return $this->client->post($this->buildURL($restUrl), $options)->getBody()->getContents();
    }

    /**
     * @param string  $restUrl
     * @param mixed[] $json
     *
     * @return string
     */
    public function put(string $restUrl, array $json): string

    {
        $options['headers']['Content-Type'] = 'application/json';

        $options['json'] = $json;

        return $this->client->put($this->buildURL($restUrl), $options)->getBody()->getContents();
    }

    /**
     * @param string  $restUrl
     * @param mixed[] $json
     *
     * @return string
     */
    public function post(string $restUrl, array $json): string

    {
        $options['headers']['Content-Type'] = 'application/json';

        $options['json'] = $json;

        return $this->client->post($this->buildURL($restUrl), $options)->getBody()->getContents();
    }

    /**
     * @param string $restUrl
     *
     * @return string
     */
    public function get(string $restUrl): string
    {
        return $this->client->get($this->buildURL($restUrl))->getBody()->getContents();
    }

    /**
     * @param string $restUrl
     *
     * @return string
     */
    public function delete(string $restUrl): string
    {
        return $this->client->delete($this->buildURL($restUrl))->getBody()->getContents();
    }

    /**
     * @param string $restUrl
     *
     * @return string
     */
    private function buildURL(string $restUrl): string
    {
        // Jira return absolute self links, so its more easy to work with get with absolute urls in such cases
        if ((\mb_strpos($restUrl, 'http://') !== 0) && (\mb_strpos($restUrl, 'https://') !== 0)) {
            return $this->tenant->getBaseUrl().$restUrl;
        }

        return $restUrl;
    }

    /**
     * Create a HTTP client
     *
     * @return Client
     */
    private function createClient(): Client
    {
        $stack = new HandlerStack();
        $stack->setHandler(new CurlHandler());
        $stack->push(JWTMiddleware::authTokenMiddleware(
            $this->tenant->getAddonKey(),
            $this->tenant->getSharedSecret()
        ));

        return new Client(['handler' => $stack]);
    }
}


1		<?php declare(strict_types = 1);
2
3		namespace AtlassianConnectBundle\Service;
4
5		use AtlassianConnectBundle\Entity\TenantInterface;
6		use GuzzleHttp\Client;
7		use GuzzleHttp\Handler\CurlHandler;
8		use GuzzleHttp\HandlerStack;
9		use Symfony\Component\HttpFoundation\File\UploadedFile;
10
11		/**
12		* Class JWTRequest
13		*/
14		class JWTRequest
15		{
16		/**
17		* @var TenantInterface
18		*/
19		private $tenant;
20
21		/**
22		* @var Client
23		*/
24		private $client;
25
26		/**
27		* JWTRequest constructor.
28		*
29		* @param TenantInterface $tenant
30		*/
31		public function __construct(TenantInterface $tenant)
32		{
33		$this->tenant = $tenant;
34		$this->client = $this->createClient();
35		}
36
37		/**
38		* @param UploadedFile $file
39		* @param string $restUrl
40		*
41		* @return string
42		*/
43		public function sendFile(UploadedFile $file, string $restUrl): string
44		{
45		$options['headers']['X-Atlassian-Token'] = 'nocheck';
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-25 14:16 UTC by Report Bug Copy Issue Report `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Loading history...
46		$savedFile = $file->move('/tmp/', $file->getClientOriginalName());
47
48		$options['body'] = [
49		'file' => \fopen($savedFile->getRealPath(), 'rb'),
50		];
51
52		\unlink($savedFile->getRealPath());
53
54		return $this->client->post($this->buildURL($restUrl), $options)->getBody()->getContents();
55		}
56
57		/**
58		* @param string $restUrl
59		* @param mixed[] $json
60		*
61		* @return string
62		*/
63	View Code Duplication	public function put(string $restUrl, array $json): string
		0 ignored issues – show Duplication introduced 2017-12-21 11:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$options['headers']['Content-Type'] = 'application/json';
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-25 14:16 UTC by Report Bug Copy Issue Report `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Loading history...
66		$options['json'] = $json;
67
68		return $this->client->put($this->buildURL($restUrl), $options)->getBody()->getContents();
69		}
70
71		/**
72		* @param string $restUrl
73		* @param mixed[] $json
74		*
75		* @return string
76		*/
77	View Code Duplication	public function post(string $restUrl, array $json): string
		0 ignored issues – show Duplication introduced 2017-12-21 11:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$options['headers']['Content-Type'] = 'application/json';
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-25 14:16 UTC by Report Bug Copy Issue Report `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Loading history...
80		$options['json'] = $json;
81
82		return $this->client->post($this->buildURL($restUrl), $options)->getBody()->getContents();
83		}
84
85		/**
86		* @param string $restUrl
87		*
88		* @return string
89		*/
90		public function get(string $restUrl): string
91		{
92		return $this->client->get($this->buildURL($restUrl))->getBody()->getContents();
93		}
94
95		/**
96		* @param string $restUrl
97		*
98		* @return string
99		*/
100		public function delete(string $restUrl): string
101		{
102		return $this->client->delete($this->buildURL($restUrl))->getBody()->getContents();
103		}
104
105		/**
106		* @param string $restUrl
107		*
108		* @return string
109		*/
110		private function buildURL(string $restUrl): string
111		{
112		// Jira return absolute self links, so its more easy to work with get with absolute urls in such cases
113		if ((\mb_strpos($restUrl, 'http://') !== 0) && (\mb_strpos($restUrl, 'https://') !== 0)) {
114		return $this->tenant->getBaseUrl().$restUrl;
115		}
116
117		return $restUrl;
118		}
119
120		/**
121		* Create a HTTP client
122		*
123		* @return Client
124		*/
125		private function createClient(): Client
126		{
127		$stack = new HandlerStack();
128		$stack->setHandler(new CurlHandler());
129		$stack->push(JWTMiddleware::authTokenMiddleware(
130		$this->tenant->getAddonKey(),
131		$this->tenant->getSharedSecret()
132		));
133
134		return new Client(['handler' => $stack]);
135		}
136		}
137

thecatontheflat / atlassian-connect-bundle

Push — master ( bb131b...ea520a )

JWTRequest::delete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like