AtlassianConnectBundle\Service\GuzzleJWTMiddleware::middleware()

Complexity

Conditions	6
Paths	1

Size

Total Lines	27
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function middleware(ClientInterface $client): callable
    {
        return static function (callable $handler) use ($client): callable {
            return static function (RequestInterface $request, array $options) use ($handler, $client) {
                if (!\array_key_exists('tenant', $options) || !$options['tenant'] instanceof TenantInterface) {
                    throw new \RuntimeException('Tenant not provided!');
                }

                $tenant = $options['tenant'];

                if (\array_key_exists('user_id', $options) && null !== $options['user_id']) {
                    if (!$tenant->getOauthClientId()) {
                        throw new \RuntimeException('Tenant is not set up as oath application. Install the app with "ACT_AS_USER" scope.');
                    }

                    return $handler($request
                        ->withHeader('Accept', 'application/json')
                        ->withHeader(
                            'Authorization',
                            'Bearer '.self::getAuthToken($client, $tenant->getOauthClientId(), $tenant->getSharedSecret(), $tenant->getBaseUrl(), $options['user_id']),

It seems like $tenant->getBaseUrl() can also be of type null; however, parameter $baseUrl of AtlassianConnectBundle\Service\GuzzleJWTMiddleware::getAuthToken() does only seem to accept string, maybe add an additional type check?

It seems like $tenant->getSharedSecret() can also be of type null; however, parameter $secret of AtlassianConnectBundle\Service\GuzzleJWTMiddleware::getAuthToken() does only seem to accept string, maybe add an additional type check?

                        ), $options);
                }

                return $handler($request->withHeader(
                    'Authorization',
                    'JWT '.JWTGenerator::generate($request, $tenant->getAddonKey(), $tenant->getSharedSecret()),

It seems like $tenant->getSharedSecret() can also be of type null; however, parameter $secret of AtlassianConnectBundle\Service\JWTGenerator::generate() does only seem to accept string, maybe add an additional type check?

It seems like $tenant->getAddonKey() can also be of type null; however, parameter $issuer of AtlassianConnectBundle\Service\JWTGenerator::generate() does only seem to accept string, maybe add an additional type check?

                ), $options);
            };