StubbedTenant::getUserIdentifier() - Code Metrics - Inspection of "Support Symfony 6" - thecatontheflat/atlassian-connect-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#56)

by Matthieu

created 2021-12-09 12:36 UTC

StubbedTenant::getUserIdentifier() A

↳ Parent: StubbedTenant

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php declare(strict_types = 1);

namespace AtlassianConnectBundle\Tests\Security;

use AtlassianConnectBundle\Entity\TenantInterface;
use Symfony\Component\Security\Core\Role\Role;

/**
 * Class StubbedTenant
 */
class StubbedTenant implements TenantInterface
{
    /**
     * @return array<string>|array<Role>
     */
    public function getRoles(): array
    {
        return ['ROLE_USER'];
    }

    /**
     * @return string|null
     */
    public function getSharedSecret(): ?string
    {
    }

    /**
     * @return string|null
     */
    public function getOauthClientId(): ?string
    {
    }

    /**
     * @return string|null
     */
    public function getBaseUrl(): ?string
    {
    }

    /**
     * @return string|null
     */
    public function getAddonKey(): ?string
    {
    }

    /**
     * @param string $name
     *
     * @return TenantInterface
     */
    public function setUsername(string $name): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $addonKey
     *
     * @return TenantInterface
     */
    public function setAddonKey(string $addonKey): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $clientKey
     *
     * @return TenantInterface
     */
    public function setClientKey(string $clientKey): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $publicKey
     *
     * @return TenantInterface
     */
    public function setPublicKey(string $publicKey): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $sharedSecret
     *
     * @return TenantInterface
     */
    public function setSharedSecret(string $sharedSecret): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $serverVersion
     *
     * @return TenantInterface
     */
    public function setServerVersion(string $serverVersion): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $pluginsVersion
     *
     * @return TenantInterface
     */
    public function setPluginsVersion(string $pluginsVersion): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $baseUrl
     *
     * @return TenantInterface
     */
    public function setBaseUrl(string $baseUrl): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $productType
     *
     * @return TenantInterface
     */
    public function setProductType(string $productType): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $description
     *
     * @return TenantInterface
     */
    public function setDescription(string $description): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string $eventType
     *
     * @return TenantInterface
     */
    public function setEventType(string $eventType): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param string|null $oauthClientId
     *
     * @return TenantInterface
     */
    public function setOauthClientId(?string $oauthClientId): TenantInterface
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @return string|void
     */
    public function getPassword(): ?string
    {
    }

    /**
     * @return string|null
     */
    public function getSalt(): ?string
    {
    }

    /**
     * @return string|null
     */
    public function getUsername(): ?string
    {
    }

    /**
     * @return string
     */
    public function getUserIdentifier(): string
    {
        return 'tenant';
    }

    /**
     * @return void
     */
    public function eraseCredentials(): void
    {
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace AtlassianConnectBundle\Tests\Security;
4
5			use AtlassianConnectBundle\Entity\TenantInterface;
6			use Symfony\Component\Security\Core\Role\Role;
7
8			/**
9			* Class StubbedTenant
10			*/
11			class StubbedTenant implements TenantInterface
12			{
13			/**
14			* @return array<string>\|array<Role>
15			*/
16			public function getRoles(): array
17			{
18			return ['ROLE_USER'];
19			}
20
21			/**
22			* @return string\|null
23			*/
24			public function getSharedSecret(): ?string
25			{
26			}
27
28			/**
29			* @return string\|null
30			*/
31			public function getOauthClientId(): ?string
32			{
33			}
34
35			/**
36			* @return string\|null
37			*/
38			public function getBaseUrl(): ?string
39			{
40			}
41
42			/**
43			* @return string\|null
44			*/
45			public function getAddonKey(): ?string
46			{
47			}
48
49			/**
50			* @param string $name
51			*
52			* @return TenantInterface
53			*/
54			public function setUsername(string $name): TenantInterface
55			{
56			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
57
58			/**
59			* @param string $addonKey
60			*
61			* @return TenantInterface
62			*/
63			public function setAddonKey(string $addonKey): TenantInterface
64			{
65			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
66
67			/**
68			* @param string $clientKey
69			*
70			* @return TenantInterface
71			*/
72			public function setClientKey(string $clientKey): TenantInterface
73			{
74			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
75
76			/**
77			* @param string $publicKey
78			*
79			* @return TenantInterface
80			*/
81			public function setPublicKey(string $publicKey): TenantInterface
82			{
83			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
84
85			/**
86			* @param string $sharedSecret
87			*
88			* @return TenantInterface
89			*/
90			public function setSharedSecret(string $sharedSecret): TenantInterface
91			{
92			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
93
94			/**
95			* @param string $serverVersion
96			*
97			* @return TenantInterface
98			*/
99			public function setServerVersion(string $serverVersion): TenantInterface
100			{
101			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
102
103			/**
104			* @param string $pluginsVersion
105			*
106			* @return TenantInterface
107			*/
108			public function setPluginsVersion(string $pluginsVersion): TenantInterface
109			{
110			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
111
112			/**
113			* @param string $baseUrl
114			*
115			* @return TenantInterface
116			*/
117			public function setBaseUrl(string $baseUrl): TenantInterface
118			{
119			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
120
121			/**
122			* @param string $productType
123			*
124			* @return TenantInterface
125			*/
126			public function setProductType(string $productType): TenantInterface
127			{
128			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
129
130			/**
131			* @param string $description
132			*
133			* @return TenantInterface
134			*/
135			public function setDescription(string $description): TenantInterface
136			{
137			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
138
139			/**
140			* @param string $eventType
141			*
142			* @return TenantInterface
143			*/
144			public function setEventType(string $eventType): TenantInterface
145			{
146			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
147
148			/**
149			* @param string\|null $oauthClientId
150			*
151			* @return TenantInterface
152			*/
153			public function setOauthClientId(?string $oauthClientId): TenantInterface
154			{
155			}
			0 ignored issues – show Bug Best Practice introduced 2019-05-06 11:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AtlassianConnectBundle\Entity\TenantInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
156
157			/**
158			* @return string\|void
159			*/
160			public function getPassword(): ?string
161			{
162			}
163
164			/**
165			* @return string\|null
166			*/
167			public function getSalt(): ?string
168			{
169			}
170
171			/**
172			* @return string\|null
173			*/
174			public function getUsername(): ?string
175			{
176			}
177
178			/**
179			* @return string
180			*/
181			public function getUserIdentifier(): string
182			{
183			return 'tenant';
184			}
185
186			/**
187			* @return void
188			*/
189			public function eraseCredentials(): void
190			{
191			}
192			}
193

thecatontheflat / atlassian-connect-bundle

Pull Request — master (#56)

StubbedTenant::getUserIdentifier() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like