Between::isValid() - Code Metrics - the-support-group/request-validator - Measure and Improve Code Quality continuously with Scrutinizer

Between::isValid() B
last analyzed 2016-04-22 08:56 UTC

↳ Parent: Between

Complexity

Conditions	3
Paths	3

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	26
c	1
b	1
f	0
rs	8.8571
cc	3
eloc	14
nc	3
nop	0

<?php

/**
 * @author: Abdul Qureshi. <[email protected]>
 * 
 * This file has been modified from the original source.
 * See original here:
 *
 * @link: https://github.com/progsmile/request-validator
 */

namespace TheSupportGroup\Common\Validator\Rules;

use TheSupportGroup\Common\Validator\Contracts\Rules\RuleInterface;

class Between extends BaseRule implements RuleInterface
{
    private $val1;

    private $val2;

    private $isNumeric = false;

    /**
     * {@inheritdoc}
     */
    public function isValid()
    {
        if ($this->isNotRequiredAndEmpty()) {
            return true;
        }

        $values = explode(',', $this->getParams()[2]);

        $input = trim($this->getParams()[1]);

        $between = $this->Between(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            trim($values[0]), // min
            trim($values[1]), // max
            true              // inclusive
        );

        if ($this->hasRule('numeric') !== false) {
            $this->isNumeric = true;

            return $between->validate($input);
        }

        $input = mb_strlen($input);

        return $between->validate($input);
    }

    /**
     * Returns error message from rule.
     *
     * @return string
     */
    public function getMessage()
    {
        if ($this->isNumeric) {
            return 'Field :field: should be between in :param: values';
        }

        return 'Field :field: length should be between :param: characters';
    }
}


1			<?php
2
3			/**
4			* @author: Abdul Qureshi. <[email protected]>
5			*
6			* This file has been modified from the original source.
7			* See original here:
8			*
9			* @link: https://github.com/progsmile/request-validator
10			*/
11
12			namespace TheSupportGroup\Common\Validator\Rules;
13
14			use TheSupportGroup\Common\Validator\Contracts\Rules\RuleInterface;
15
16			class Between extends BaseRule implements RuleInterface
17			{
18			private $val1;
			0 ignored issues – show Unused Code introduced 2016-04-21 08:53 UTC by Report Bug Copy Issue Report The property `$val1` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19			private $val2;
			0 ignored issues – show Unused Code introduced 2016-04-21 08:53 UTC by Report Bug Copy Issue Report The property `$val2` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			private $isNumeric = false;
21
22			/**
23			* {@inheritdoc}
24			*/
25			public function isValid()
26			{
27			if ($this->isNotRequiredAndEmpty()) {
28			return true;
29			}
30
31			$values = explode(',', $this->getParams()[2]);
32
33			$input = trim($this->getParams()[1]);
34
35			$between = $this->Between(
			0 ignored issues – show Documentation Bug introduced 2016-04-21 08:53 UTC by Report Bug Copy Issue Report The method `Between` does not exist on `object<TheSupportGroup\C...alidator\Rules\Between>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
36			trim($values[0]), // min
37			trim($values[1]), // max
38			true // inclusive
39			);
40
41			if ($this->hasRule('numeric') !== false) {
42			$this->isNumeric = true;
43
44			return $between->validate($input);
45			}
46
47			$input = mb_strlen($input);
48
49			return $between->validate($input);
50			}
51
52			/**
53			* Returns error message from rule.
54			*
55			* @return string
56			*/
57			public function getMessage()
58			{
59			if ($this->isNumeric) {
60			return 'Field :field: should be between in :param: values';
61			}
62
63			return 'Field :field: length should be between :param: characters';
64			}
65			}
66

the-support-group / request-validator

Between::isValid() B last analyzed 2016-04-22 08:56 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Between::isValid() B
last analyzed 2016-04-22 08:56 UTC