Json - Code Metrics - the-support-group/request-validator - Measure and Improve Code Quality continuously with Scrutinizer

Json A
last analyzed 2016-04-22 08:56 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	16
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	16
loc	16
c	1
b	0
f	0
wmc	3
lcom	0
cbo	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isValid()	8	8	2
A	getMessage()	4	4	1

How to fix Duplicated Code

<?php

/**
 * @author: Abdul Qureshi. <[email protected]>
 * 
 * This file has been modified from the original source.
 * See original here:
 *
 * @link: https://github.com/progsmile/request-validator
 */

namespace TheSupportGroup\Common\Validator\Rules;

use TheSupportGroup\Common\Validator\Contracts\Rules\RuleInterface;

class Json extends BaseRule implements RuleInterface

{
    public function isValid()
    {
        if ($this->isNotRequiredAndEmpty()) {
            return true;
        }

        return $this->Json()->validate($this->getParams()[1]);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function getMessage()
    {
        return 'Field :field: is not json';
    }
}


1		<?php
2
3		/**
4		* @author: Abdul Qureshi. <[email protected]>
5		*
6		* This file has been modified from the original source.
7		* See original here:
8		*
9		* @link: https://github.com/progsmile/request-validator
10		*/
11
12		namespace TheSupportGroup\Common\Validator\Rules;
13
14		use TheSupportGroup\Common\Validator\Contracts\Rules\RuleInterface;
15
16	View Code Duplication	class Json extends BaseRule implements RuleInterface
		0 ignored issues – show Duplication introduced 2016-04-21 08:53 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		public function isValid()
19		{
20		if ($this->isNotRequiredAndEmpty()) {
21		return true;
22		}
23
24		return $this->Json()->validate($this->getParams()[1]);
		0 ignored issues – show Documentation Bug introduced 2016-04-21 08:53 UTC by Report Bug Copy Issue Report The method `Json` does not exist on `object<TheSupportGroup\C...n\Validator\Rules\Json>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
25		}
26
27		public function getMessage()
28		{
29		return 'Field :field: is not json';
30		}
31		}
32

the-support-group / request-validator

Json A last analyzed 2016-04-22 08:56 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Json A
last analyzed 2016-04-22 08:56 UTC