Inspection of "r" - the-real-sumsome/subrocks-2012 - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — main ( a87dfd...e3d6db )

by chief

created 2021-10-18 00:17 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@  discard block
 block discarded – undo
 <?php $__user_h = new user_helper($__db); ?>
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
-<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
+<?php if (!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
 <!DOCTYPE html>
 <html dir="ltr">
 	<head>
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
                                 ?>                    
                                 
                                 <div class="my_videos_ajax">                                  
-                                    <?php while($user = $stmt->fetch(PDO::FETCH_ASSOC)) {  ?> 
+                                    <?php while ($user = $stmt->fetch(PDO::FETCH_ASSOC)) {  ?> 
                                         <div style="width: 33%;display: inline-block;">
                                             <img style="width: 50px;height:50px;" src="/dynamic/pfp/<?php echo $__user_h->fetch_pfp($user['reciever']); ?>">
                                             <span style="display: inline-block; vertical-align:top;width: 100px;font-size: 11px;">

Please login to merge, or discard this patch.

web/public/template.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,10 +8,10 @@
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	$__server->page_embeds->page_title = "SubRocks - Replace me";
-	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
-	$__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
-	$__server->page_embeds->page_url = "https://subrock.rocks/";
+    $__server->page_embeds->page_title = "SubRocks - Replace me";
+    $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
+    $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
+    $__server->page_embeds->page_url = "https://subrock.rocks/";
 ?>
 <!DOCTYPE html>
 <html>

Please login to merge, or discard this patch.

web/public/uploaded_video.php 3 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -8,17 +8,17 @@
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	if(!$__video_h->video_exists($_GET['v']))
-		header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
+    if(!$__video_h->video_exists($_GET['v']))
+        header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
 
-	$video = $__video_h->fetch_video_rid($_GET['v']);
-	$video['video_responses'] = $__video_h->get_video_responses($video['rid']);
-	$video['age'] = $__time_h->time_elapsed_string($video['publish']);		
-	$video['duration'] = $__time_h->timestamp($video['duration']);
-	$video['views'] = $__video_h->fetch_video_views($video['rid']);
-	$video['author'] = htmlspecialchars($video['author']);		
-	$video['title'] = htmlspecialchars($video['title']);
-	$video['description'] = $__video_h->shorten_description($video['description'], 50);
+    $video = $__video_h->fetch_video_rid($_GET['v']);
+    $video['video_responses'] = $__video_h->get_video_responses($video['rid']);
+    $video['age'] = $__time_h->time_elapsed_string($video['publish']);		
+    $video['duration'] = $__time_h->timestamp($video['duration']);
+    $video['views'] = $__video_h->fetch_video_views($video['rid']);
+    $video['author'] = htmlspecialchars($video['author']);		
+    $video['title'] = htmlspecialchars($video['title']);
+    $video['description'] = $__video_h->shorten_description($video['description'], 50);
 
     if($_SESSION['siteusername'] != $video['author'])
         header("Location: /");

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@  discard block
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	if(!$__video_h->video_exists($_GET['v']))
+	if (!$__video_h->video_exists($_GET['v']))
 		header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
 
 	$video = $__video_h->fetch_video_rid($_GET['v']);
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
 	$video['title'] = htmlspecialchars($video['title']);
 	$video['description'] = $__video_h->shorten_description($video['description'], 50);
 
-    if($_SESSION['siteusername'] != $video['author'])
+    if ($_SESSION['siteusername'] != $video['author'])
         header("Location: /");
 ?>
 <!DOCTYPE html>

Please login to merge, or discard this patch.

Braces +7 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,8 +8,9 @@  discard block
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	if(!$__video_h->video_exists($_GET['v']))
-		header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
+	if(!$__video_h->video_exists($_GET['v'])) {
+			header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
+	}
 
 	$video = $__video_h->fetch_video_rid($_GET['v']);
 	$video['video_responses'] = $__video_h->get_video_responses($video['rid']);
@@ -20,9 +21,10 @@  discard block
 block discarded – undo
 	$video['title'] = htmlspecialchars($video['title']);
 	$video['description'] = $__video_h->shorten_description($video['description'], 50);
 
-    if($_SESSION['siteusername'] != $video['author'])
-        header("Location: /");
-?>
+    if($_SESSION['siteusername'] != $video['author']) {
+            header("Location: /");
+    }
+    ?>
 <!DOCTYPE html>
 <html>
 	<head>

Please login to merge, or discard this patch.

web/public/get/add_to_playlist.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,7 +11,7 @@
 block discarded – undo
 <?php
 $playlist = $__video_h->fetch_playlist_rid($_GET['playlist']);
 
-if($playlist['author'] == $_SESSION['siteusername']) {
+if ($playlist['author'] == $_SESSION['siteusername']) {
     $b = json_decode($playlist['videos']);
     array_push($b, $_GET['id']);
     $b = json_encode($b);

Please login to merge, or discard this patch.

		@@ -10,7 +10,7 @@ discard block
		block discarded – undo
10	10	<?php $__user_h = new user_helper($__db); ?>
11	11	<?php $__db_h = new db_helper(); ?>
12	12	<?php $__time_h = new time_helper(); ?>
13		-<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
	13	+<?php if (!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
14	14	<!DOCTYPE html>
15	15	<html dir="ltr">
16	16	<head>
		@@ -160,7 +160,7 @@ discard block
		block discarded – undo
160	160	?>
161	161
162	162	<div class="my_videos_ajax">
163		- <?php while($user = $stmt->fetch(PDO::FETCH_ASSOC)) { ?>
	163	+ <?php while ($user = $stmt->fetch(PDO::FETCH_ASSOC)) { ?>
164	164	<div style="width: 33%;display: inline-block;">
165	165	<img style="width: 50px;height:50px;" src="/dynamic/pfp/<?php echo $__user_h->fetch_pfp($user['reciever']); ?>">
166	166	<span style="display: inline-block; vertical-align:top;width: 100px;font-size: 11px;">

		@@ -8,10 +8,10 @@
		block discarded – undo
8	8	<?php $__db_h = new db_helper(); ?>
9	9	<?php $__time_h = new time_helper(); ?>
10	10	<?php
11		- $__server->page_embeds->page_title = "SubRocks - Replace me";
12		- $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
13		- $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
14		- $__server->page_embeds->page_url = "https://subrock.rocks/";
	11	+ $__server->page_embeds->page_title = "SubRocks - Replace me";
	12	+ $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
	13	+ $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
	14	+ $__server->page_embeds->page_url = "https://subrock.rocks/";
15	15	?>
16	16	<!DOCTYPE html>
17	17	<html>

		@@ -8,17 +8,17 @@
		block discarded – undo
8	8	<?php $__db_h = new db_helper(); ?>
9	9	<?php $__time_h = new time_helper(); ?>
10	10	<?php
11		- if(!$__video_h->video_exists($_GET['v']))
12		- header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
	11	+ if(!$__video_h->video_exists($_GET['v']))
	12	+ header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
13	13
14		- $video = $__video_h->fetch_video_rid($_GET['v']);
15		- $video['video_responses'] = $__video_h->get_video_responses($video['rid']);
16		- $video['age'] = $__time_h->time_elapsed_string($video['publish']);
17		- $video['duration'] = $__time_h->timestamp($video['duration']);
18		- $video['views'] = $__video_h->fetch_video_views($video['rid']);
19		- $video['author'] = htmlspecialchars($video['author']);
20		- $video['title'] = htmlspecialchars($video['title']);
21		- $video['description'] = $__video_h->shorten_description($video['description'], 50);
	14	+ $video = $__video_h->fetch_video_rid($_GET['v']);
	15	+ $video['video_responses'] = $__video_h->get_video_responses($video['rid']);
	16	+ $video['age'] = $__time_h->time_elapsed_string($video['publish']);
	17	+ $video['duration'] = $__time_h->timestamp($video['duration']);
	18	+ $video['views'] = $__video_h->fetch_video_views($video['rid']);
	19	+ $video['author'] = htmlspecialchars($video['author']);
	20	+ $video['title'] = htmlspecialchars($video['title']);
	21	+ $video['description'] = $__video_h->shorten_description($video['description'], 50);
22	22
23	23	if($_SESSION['siteusername'] != $video['author'])
24	24	header("Location: /");

		@@ -8,7 +8,7 @@ discard block
		block discarded – undo
8	8	<?php $__db_h = new db_helper(); ?>
9	9	<?php $__time_h = new time_helper(); ?>
10	10	<?php
11		- if(!$__video_h->video_exists($_GET['v']))
	11	+ if (!$__video_h->video_exists($_GET['v']))
12	12	header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
13	13
14	14	$video = $__video_h->fetch_video_rid($_GET['v']);
		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	$video['title'] = htmlspecialchars($video['title']);
21	21	$video['description'] = $__video_h->shorten_description($video['description'], 50);
22	22
23		- if($_SESSION['siteusername'] != $video['author'])
	23	+ if ($_SESSION['siteusername'] != $video['author'])
24	24	header("Location: /");
25	25	?>
26	26	<!DOCTYPE html>

		@@ -8,8 +8,9 @@ discard block
		block discarded – undo
8	8	<?php $__db_h = new db_helper(); ?>
9	9	<?php $__time_h = new time_helper(); ?>
10	10	<?php
11		- if(!$__video_h->video_exists($_GET['v']))
12		- header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
	11	+ if(!$__video_h->video_exists($_GET['v'])) {
	12	+ header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
	13	+ }
13	14
14	15	$video = $__video_h->fetch_video_rid($_GET['v']);
15	16	$video['video_responses'] = $__video_h->get_video_responses($video['rid']);
		@@ -20,9 +21,10 @@ discard block
		block discarded – undo
20	21	$video['title'] = htmlspecialchars($video['title']);
21	22	$video['description'] = $__video_h->shorten_description($video['description'], 50);
22	23
23		- if($_SESSION['siteusername'] != $video['author'])
24		- header("Location: /");
25		-?>
	24	+ if($_SESSION['siteusername'] != $video['author']) {
	25	+ header("Location: /");
	26	+ }
	27	+ ?>
26	28	<!DOCTYPE html>
27	29	<html>
28	30	<head>

		@@ -11,7 +11,7 @@
		block discarded – undo
11	11	<?php
12	12	$playlist = $__video_h->fetch_playlist_rid($_GET['playlist']);
13	13
14		-if($playlist['author'] == $_SESSION['siteusername']) {
	14	+if ($playlist['author'] == $_SESSION['siteusername']) {
15	15	$b = json_decode($playlist['videos']);
16	16	array_push($b, $_GET['id']);
17	17	$b = json_encode($b);

the-real-sumsome / subrocks-2012

Push — main ( a87dfd...e3d6db )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +7 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch