Inspection of "Merge pull request #31 from pixdoet/main" - the-real-sumsome/subrocks-2012 - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — main ( c0bf37...778e90 )

by chief

created 2021-11-09 04:01 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@
 block discarded – undo
 	$__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
 	$__server->page_embeds->page_url = "https://subrock.rocks/";
 ?>
-<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
+<?php if (!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
 <?php $_playlist = $__video_h->fetch_playlist_rid($_GET['id']); ?>
 <!DOCTYPE html>
 <html dir="ltr">

Please login to merge, or discard this patch.

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,10 +8,10 @@
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	$__server->page_embeds->page_title = "SubRocks - Edit Playlist";
-	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
-	$__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
-	$__server->page_embeds->page_url = "https://subrock.rocks/";
+    $__server->page_embeds->page_title = "SubRocks - Edit Playlist";
+    $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
+    $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
+    $__server->page_embeds->page_url = "https://subrock.rocks/";
 ?>
 <?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
 <?php $_playlist = $__video_h->fetch_playlist_rid($_GET['id']); ?>

Please login to merge, or discard this patch.

web/public/get/toggle_comment.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,8 +13,8 @@
 block discarded – undo
 <?php
 $video = $__video_h->fetch_video_rid($_GET['id']);
 
-if($video['author'] == $_SESSION['siteusername']) {
-    if($video['commenting'] == "a") {
+if ($video['author'] == $_SESSION['siteusername']) {
+    if ($video['commenting'] == "a") {
         $__video_u->update_row($_GET['id'], "commenting", "d");
     } else {
         $__video_u->update_row($_GET['id'], "commenting", "a");

Please login to merge, or discard this patch.

web/public/get/delete_video.php 2 patches

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -12,11 +12,11 @@
 block discarded – undo
 <?php
 
 if($video['author'] == $_SESSION['siteusername']) {
-  $stmt = $__db->prepare("DELETE FROM videos WHERE rid=:rid AND author=:author");
-  $stmt->execute(array(
+    $stmt = $__db->prepare("DELETE FROM videos WHERE rid=:rid AND author=:author");
+    $stmt->execute(array(
     ':author' => $video['author'],
     ':rid' => $video['rid'],
-  ));
+    ));
 }
 
 header('Location: /my_videos');

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,7 +11,7 @@
 block discarded – undo
 <?php $video = $__video_h->fetch_video_rid($_GET['id']); ?>
 <?php
 
-if($video['author'] == $_SESSION['siteusername']) {
+if ($video['author'] == $_SESSION['siteusername']) {
   $stmt = $__db->prepare("DELETE FROM videos WHERE rid=:rid AND author=:author");
   $stmt->execute(array(
     ':author' => $video['author'],

Please login to merge, or discard this patch.

web/public/d/edit_playlist.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@
 block discarded – undo
 <?php $__time_h = new time_helper(); ?>
 <?php
     $_playlist = $__video_h->fetch_playlist_rid($_GET['v']);
-    if($_playlist['author'] != @$_SESSION['siteusername']) {
+    if ($_playlist['author'] != @$_SESSION['siteusername']) {
         die();
     }
 

Please login to merge, or discard this patch.

web/public/d/edit_video.php 2 patches

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@  discard block
 block discarded – undo
 <?php $__time_h = new time_helper(); ?>
 <?php
     $_video = $__video_h->fetch_video_rid($_GET['v']);
-    if($_video['author'] != @$_SESSION['siteusername']) {
+    if ($_video['author'] != @$_SESSION['siteusername']) {
         die();
     }
 
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
     // $__video_u->update_row($_GET['v'], "thumbnail", $request->thumbnail);
     $__video_u->update_row($_GET['v'], "category", $request->category);
 
-    if($_SERVER['REQUEST_METHOD'] == 'POST' && @$_FILES['thumbnail']) {
-        if(!empty($_FILES["thumbnail"]["name"])) {
+    if ($_SERVER['REQUEST_METHOD'] == 'POST' && @$_FILES['thumbnail']) {
+        if (!empty($_FILES["thumbnail"]["name"])) {
             $target_dir = "dynamic/thumbs/";
             $imageFileType = strtolower(pathinfo($_FILES["thumbnail"]["name"], PATHINFO_EXTENSION));
             $target_name = md5_file($_FILES["thumbnail"]["tmp_name"]) . "." . $imageFileType;
@@ -48,8 +48,8 @@  discard block
 block discarded – undo
             $uploadOk = true;
             $movedFile = false;
     
-            if($imageFileType != "jpg" && $imageFileType != "png" && $imageFileType != "jpeg"
-                && $imageFileType != "gif" ) {
+            if ($imageFileType != "jpg" && $imageFileType != "png" && $imageFileType != "jpeg"
+                && $imageFileType != "gif") {
                 $fileerror = 'unsupported file type. must be jpg, png, jpeg, or gif';
                 $uploadOk = false;
                 goto skip;

Please login to merge, or discard this patch.

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@
 block discarded – undo
         "description" => $_POST['description'],
         "tags" => $_POST['tags'],
         "privacy" => $_POST['privacy'],
-         /* 
+            /* 
             Public   : n
             Unlisted : u
             Private  : v

Please login to merge, or discard this patch.

web/public/s/mod/sidebar.php 2 patches

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -39,8 +39,8 @@
 block discarded – undo
 ?>
 <div id="browse-side-column" class="ytg-2col ytg-last">
     <ol class="navigation-menu">
-        <?php foreach($__tabs as $_tab) { 
-            if(parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url)
+        <?php foreach ($__tabs as $_tab) { 
+            if (parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url)
                 $_tab->selected = true;
             ?>
             <li class="menu-item">

Please login to merge, or discard this patch.

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -40,8 +40,9 @@
 block discarded – undo
 <div id="browse-side-column" class="ytg-2col ytg-last">
     <ol class="navigation-menu">
         <?php foreach($__tabs as $_tab) { 
-            if(parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url)
-                $_tab->selected = true;
+            if(parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url) {
+                            $_tab->selected = true;
+            }
             ?>
             <li class="menu-item">
                 <a class="<?php echo $_tab->selected ? true : "selected"; ?>" href="<?php echo $_tab->url; ?>">

Please login to merge, or discard this patch.

web/public/uploaded_video.php 3 patches

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -12,26 +12,26 @@
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	if(!$__video_h->video_exists($_GET['v']))
-		header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
+    if(!$__video_h->video_exists($_GET['v']))
+        header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
 
-	$_video = $__video_h->fetch_video_rid($_GET['v']); 
-	$_video['video_responses'] = $__video_h->get_video_responses($_video['rid']);
-	$_video['age'] = $__time_h->time_elapsed_string($_video['publish']);		
-	$_video['duration'] = $__time_h->timestamp($_video['duration']);
-	$_video['views'] = $__video_h->fetch_video_views($_video['rid']);
-	$_video['author'] = htmlspecialchars($_video['author']);		
-	$_video['title'] = htmlspecialchars($_video['title']);
-	$_video['description'] = $__video_h->shorten_description($_video['description'], 50);
+    $_video = $__video_h->fetch_video_rid($_GET['v']); 
+    $_video['video_responses'] = $__video_h->get_video_responses($_video['rid']);
+    $_video['age'] = $__time_h->time_elapsed_string($_video['publish']);		
+    $_video['duration'] = $__time_h->timestamp($_video['duration']);
+    $_video['views'] = $__video_h->fetch_video_views($_video['rid']);
+    $_video['author'] = htmlspecialchars($_video['author']);		
+    $_video['title'] = htmlspecialchars($_video['title']);
+    $_video['description'] = $__video_h->shorten_description($_video['description'], 50);
 
     if($_SESSION['siteusername'] != $_video['author'])
         header("Location: /");
 ?>
 <?php
-	$__server->page_embeds->page_title = "SubRocks - Uploaded Video";
-	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
-	$__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
-	$__server->page_embeds->page_url = "https://subrock.rocks/";
+    $__server->page_embeds->page_title = "SubRocks - Uploaded Video";
+    $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
+    $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
+    $__server->page_embeds->page_url = "https://subrock.rocks/";
 ?>
 <!DOCTYPE html>
 <html>

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@  discard block
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	if(!$__video_h->video_exists($_GET['v']))
+	if (!$__video_h->video_exists($_GET['v']))
 		header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
 
 	$_video = $__video_h->fetch_video_rid($_GET['v']); 
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 	$_video['title'] = htmlspecialchars($_video['title']);
 	$_video['description'] = $__video_h->shorten_description($_video['description'], 50);
 
-    if($_SESSION['siteusername'] != $_video['author'])
+    if ($_SESSION['siteusername'] != $_video['author'])
         header("Location: /");
 ?>
 <?php

Please login to merge, or discard this patch.

Braces +7 added lines, -5 removed lines patch added patch discarded remove patch

@@ -12,8 +12,9 @@  discard block
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-	if(!$__video_h->video_exists($_GET['v']))
-		header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
+	if(!$__video_h->video_exists($_GET['v'])) {
+			header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
+	}
 
 	$_video = $__video_h->fetch_video_rid($_GET['v']); 
 	$_video['video_responses'] = $__video_h->get_video_responses($_video['rid']);
@@ -24,9 +25,10 @@  discard block
 block discarded – undo
 	$_video['title'] = htmlspecialchars($_video['title']);
 	$_video['description'] = $__video_h->shorten_description($_video['description'], 50);
 
-    if($_SESSION['siteusername'] != $_video['author'])
-        header("Location: /");
-?>
+    if($_SESSION['siteusername'] != $_video['author']) {
+            header("Location: /");
+    }
+    ?>
 <?php
 	$__server->page_embeds->page_title = "SubRocks - Uploaded Video";
 	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";

Please login to merge, or discard this patch.

web/public/d/signup.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@  discard block
 block discarded – undo
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
 <?php
-    if($_SERVER['REQUEST_METHOD'] == 'POST' && $_POST['password'] && $_POST['username']) {
+    if ($_SERVER['REQUEST_METHOD'] == 'POST' && $_POST['password'] && $_POST['username']) {
         $request = (object) [
             "username" => $_POST['username'],
             "password" => $_POST['password'],
@@ -22,25 +22,25 @@  discard block
 block discarded – undo
         ]; 
 
         if (!filter_var($request->email, FILTER_VALIDATE_EMAIL)) 
-            { $request->error->message = "Your email is invalid!"; $request->error->status = "";  }
-        if(strlen($request->username) > 21) 
+            { $request->error->message = "Your email is invalid!"; $request->error->status = ""; }
+        if (strlen($request->username) > 21) 
             { $request->error->message = "Your username must be shorter than 20 characters."; $request->error->status = ""; }
-        if(strlen($request->password) < 8) 
+        if (strlen($request->password) < 8) 
             { $request->error->message = "Your password must at least be 8 characters long."; $request->error->status = ""; }
-        if(!preg_match('/[A-Za-z].*[0-9]|[0-9].*[A-Za-z]/', $request->password)) 
+        if (!preg_match('/[A-Za-z].*[0-9]|[0-9].*[A-Za-z]/', $request->password)) 
             { $request->error->message = "Include numbers and letters in your password!"; $request->error->status = ""; }
-        if(!preg_match('/^\S+\w\S{1,}/', $request->username)) 
+        if (!preg_match('/^\S+\w\S{1,}/', $request->username)) 
             { $request->error->message = "Your username cannot contain any special characters!"; $request->error->status = ""; }
-        if(empty(trim($request->username))) 
+        if (empty(trim($request->username))) 
             { $request->error->message = "Your username cannot be empty!"; $request->error->status = ""; }
         
         $stmt = $__db->prepare("SELECT username FROM users WHERE username = :username");
         $stmt->bindParam(":username", $request->username);
         $stmt->execute();
-        if($stmt->rowCount()) 
+        if ($stmt->rowCount()) 
             { $request->error->message = "There's already a user with that same username!"; $request->error->status = ""; }
         
-        if($request->error->status == "OK") {
+        if ($request->error->status == "OK") {
             $stmt = $__db->prepare("INSERT INTO users (username, email, password) VALUES (:username, :email, :password)");
             $stmt->bindParam(":username", $request->username);
             $stmt->bindParam(":email", $request->email);

Please login to merge, or discard this patch.

web/public/inbox/pm.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -10,10 +10,10 @@
 block discarded – undo
 <?php $__time_h = new time_helper(); ?>
 <?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
 <?php
-	$__server->page_embeds->page_title = "SubRocks - Personal Messages";
-	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
-	$__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
-	$__server->page_embeds->page_url = "https://subrock.rocks/";
+    $__server->page_embeds->page_title = "SubRocks - Personal Messages";
+    $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
+    $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
+    $__server->page_embeds->page_url = "https://subrock.rocks/";
 ?>
 <!DOCTYPE html>
 <html dir="ltr">

Please login to merge, or discard this patch.

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@  discard block
 block discarded – undo
 <?php $__user_u = new user_update($__db); ?>
 <?php $__db_h = new db_helper(); ?>
 <?php $__time_h = new time_helper(); ?>
-<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
+<?php if (!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
 <?php
 	$__server->page_embeds->page_title = "SubRocks - Personal Messages";
 	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
@@ -169,15 +169,15 @@  discard block
 block discarded – undo
                                     $stmt->execute();
 
                                     $number_of_result = $stmt->rowCount();
-                                    $number_of_page = ceil ($number_of_result / $results_per_page);  
+                                    $number_of_page = ceil($number_of_result/$results_per_page);  
 
-                                    if (!isset ($_GET['page']) ) {  
+                                    if (!isset ($_GET['page'])) {  
                                         $page = 1;  
                                     } else {  
-                                        $page = (int)$_GET['page'];  
+                                        $page = (int) $_GET['page'];  
                                     }  
 
-                                    $page_first_result = ($page - 1) * $results_per_page;  
+                                    $page_first_result = ($page - 1)*$results_per_page;  
 
                                     $stmt6 = $__db->prepare("SELECT * FROM pms WHERE touser = :search AND type = 'nm' ORDER BY id DESC LIMIT :pfirst, :pper");
                                     $stmt6->bindParam(":search", $search);
@@ -202,8 +202,8 @@  discard block
 block discarded – undo
                                     </tr>
                                     
                                     <?php
-                                        while($inbox = $stmt->fetch(PDO::FETCH_ASSOC)) { 
-                                            if($__video_h->video_exists($inbox['video_attribute'])) {
+                                        while ($inbox = $stmt->fetch(PDO::FETCH_ASSOC)) { 
+                                            if ($__video_h->video_exists($inbox['video_attribute'])) {
                                                 $inbox['video'] = $__video_h->fetch_video_rid($inbox['video_attribute']);
                                                 $inbox['video_attr_exists'] = true;
 
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
                                     ?> 
                                     <tr style="margin-top: 5px;" id="videoslist">
                                             <!--
-                                            <?php if($inbox['readed'] == "n") { ?>
+                                            <?php if ($inbox['readed'] == "n") { ?>
                                                 <a style="position:relative;top:7px;color: white;text-decoration: none;background-color: #d54343;padding: 7px;padding-left: 10px;margin-right: 12px;display: inline;" href="/inbox/">
                                                 NEW
                                                 </a>
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
                                         <td class="video-manager-stats" style="background: none;padding-left: 8px;">
                                             <h3><?php echo htmlspecialchars($inbox['subject']); ?></h3>
                                             <?php echo $__video_h->shorten_description($inbox['message'], 300, true); ?>
-                                            <?php if($inbox['video_attr_exists']) { ?>
+                                            <?php if ($inbox['video_attr_exists']) { ?>
                                                 <hr>
                                                 <ul>
                                                     <li class="video-list-item "><a href="/watch?v=<?php echo $inbox['video']['rid']; ?>" class="video-list-item-link yt-uix-sessionlink" data-sessionlink="ei=CNLr3rbS3rICFSwSIQodSW397Q%3D%3D&amp;feature=g-sptl%26cid%3Dinp-hs-ytg"><span class="ux-thumb-wrap contains-addto "><span class="video-thumb ux-thumb yt-thumb-default-120 "><span class="yt-thumb-clip"><span class="yt-thumb-clip-inner"><img src="http://s.ytimg.com/yt/img/pixel-vfl3z5WfW.gif" alt="<?php echo $inbox['video']['title']; ?>" data-thumb="/dynamic/thumbs/<?php echo $inbox['video']['thumbnail']; ?>" width="120"><span class="vertical-align"></span></span></span></span><span class="video-time"><?php echo $inbox['video']['duration']; ?></span>
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
                                     </div>
                                 </center><br>
 
-                                <?php for($page = 1; $page<= $number_of_page; $page++) { ?>
+                                <?php for ($page = 1; $page <= $number_of_page; $page++) { ?>
                                     <button class="yt-uix-button yt-uix-button-default" onclick="ajax_fetch(<?php echo $page; ?>)"><?php echo $page; ?></button>
                                 <?php } ?>   
 
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
                                 </script>
 
                                 <?php 
-                                    if($stmt6->rowCount() == 0) { echo "
+                                    if ($stmt6->rowCount() == 0) { echo "
                                         You currently have no personal messages in your inbox.
                                     "; 
                                 } ?>

Please login to merge, or discard this patch.

		@@ -13,7 +13,7 @@
		block discarded – undo
13	13	$__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
14	14	$__server->page_embeds->page_url = "https://subrock.rocks/";
15	15	?>
16		-<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
	16	+<?php if (!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
17	17	<?php $_playlist = $__video_h->fetch_playlist_rid($_GET['id']); ?>
18	18	<!DOCTYPE html>
19	19	<html dir="ltr">

		@@ -8,10 +8,10 @@
		block discarded – undo
8	8	<?php $__db_h = new db_helper(); ?>
9	9	<?php $__time_h = new time_helper(); ?>
10	10	<?php
11		- $__server->page_embeds->page_title = "SubRocks - Edit Playlist";
12		- $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
13		- $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
14		- $__server->page_embeds->page_url = "https://subrock.rocks/";
	11	+ $__server->page_embeds->page_title = "SubRocks - Edit Playlist";
	12	+ $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
	13	+ $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
	14	+ $__server->page_embeds->page_url = "https://subrock.rocks/";
15	15	?>
16	16	<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
17	17	<?php $_playlist = $__video_h->fetch_playlist_rid($_GET['id']); ?>

		@@ -13,8 +13,8 @@
		block discarded – undo
13	13	<?php
14	14	$video = $__video_h->fetch_video_rid($_GET['id']);
15	15
16		-if($video['author'] == $_SESSION['siteusername']) {
17		- if($video['commenting'] == "a") {
	16	+if ($video['author'] == $_SESSION['siteusername']) {
	17	+ if ($video['commenting'] == "a") {
18	18	$__video_u->update_row($_GET['id'], "commenting", "d");
19	19	} else {
20	20	$__video_u->update_row($_GET['id'], "commenting", "a");

		@@ -12,11 +12,11 @@
		block discarded – undo
12	12	<?php
13	13
14	14	if($video['author'] == $_SESSION['siteusername']) {
15		- $stmt = $__db->prepare("DELETE FROM videos WHERE rid=:rid AND author=:author");
16		- $stmt->execute(array(
	15	+ $stmt = $__db->prepare("DELETE FROM videos WHERE rid=:rid AND author=:author");
	16	+ $stmt->execute(array(
17	17	':author' => $video['author'],
18	18	':rid' => $video['rid'],
19		- ));
	19	+ ));
20	20	}
21	21
22	22	header('Location: /my_videos');

		@@ -11,7 +11,7 @@
		block discarded – undo
11	11	<?php $video = $__video_h->fetch_video_rid($_GET['id']); ?>
12	12	<?php
13	13
14		-if($video['author'] == $_SESSION['siteusername']) {
	14	+if ($video['author'] == $_SESSION['siteusername']) {
15	15	$stmt = $__db->prepare("DELETE FROM videos WHERE rid=:rid AND author=:author");
16	16	$stmt->execute(array(
17	17	':author' => $video['author'],

		@@ -12,7 +12,7 @@
		block discarded – undo
12	12	<?php $__time_h = new time_helper(); ?>
13	13	<?php
14	14	$_playlist = $__video_h->fetch_playlist_rid($_GET['v']);
15		- if($_playlist['author'] != @$_SESSION['siteusername']) {
	15	+ if ($_playlist['author'] != @$_SESSION['siteusername']) {
16	16	die();
17	17	}
18	18

		@@ -12,7 +12,7 @@ discard block
		block discarded – undo
12	12	<?php $__time_h = new time_helper(); ?>
13	13	<?php
14	14	$_video = $__video_h->fetch_video_rid($_GET['v']);
15		- if($_video['author'] != @$_SESSION['siteusername']) {
	15	+ if ($_video['author'] != @$_SESSION['siteusername']) {
16	16	die();
17	17	}
18	18
		@@ -37,8 +37,8 @@ discard block
		block discarded – undo
37	37	// $__video_u->update_row($_GET['v'], "thumbnail", $request->thumbnail);
38	38	$__video_u->update_row($_GET['v'], "category", $request->category);
39	39
40		- if($_SERVER['REQUEST_METHOD'] == 'POST' && @$_FILES['thumbnail']) {
41		- if(!empty($_FILES["thumbnail"]["name"])) {
	40	+ if ($_SERVER['REQUEST_METHOD'] == 'POST' && @$_FILES['thumbnail']) {
	41	+ if (!empty($_FILES["thumbnail"]["name"])) {
42	42	$target_dir = "dynamic/thumbs/";
43	43	$imageFileType = strtolower(pathinfo($_FILES["thumbnail"]["name"], PATHINFO_EXTENSION));
44	44	$target_name = md5_file($_FILES["thumbnail"]["tmp_name"]) . "." . $imageFileType;
		@@ -48,8 +48,8 @@ discard block
		block discarded – undo
48	48	$uploadOk = true;
49	49	$movedFile = false;
50	50
51		- if($imageFileType != "jpg" && $imageFileType != "png" && $imageFileType != "jpeg"
52		- && $imageFileType != "gif" ) {
	51	+ if ($imageFileType != "jpg" && $imageFileType != "png" && $imageFileType != "jpeg"
	52	+ && $imageFileType != "gif") {
53	53	$fileerror = 'unsupported file type. must be jpg, png, jpeg, or gif';
54	54	$uploadOk = false;
55	55	goto skip;

		@@ -23,7 +23,7 @@
		block discarded – undo
23	23	"description" => $_POST['description'],
24	24	"tags" => $_POST['tags'],
25	25	"privacy" => $_POST['privacy'],
26		- /*
	26	+ /*
27	27	Public : n
28	28	Unlisted : u
29	29	Private : v

		@@ -39,8 +39,8 @@
		block discarded – undo
39	39	?>
40	40	<div id="browse-side-column" class="ytg-2col ytg-last">
41	41	<ol class="navigation-menu">
42		- <?php foreach($__tabs as $_tab) {
43		- if(parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url)
	42	+ <?php foreach ($__tabs as $_tab) {
	43	+ if (parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url)
44	44	$_tab->selected = true;
45	45	?>
46	46	<li class="menu-item">

		@@ -40,8 +40,9 @@
		block discarded – undo
40	40	<div id="browse-side-column" class="ytg-2col ytg-last">
41	41	<ol class="navigation-menu">
42	42	<?php foreach($__tabs as $_tab) {
43		- if(parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url)
44		- $_tab->selected = true;
	43	+ if(parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH) != $_tab->url) {
	44	+ $_tab->selected = true;
	45	+ }
45	46	?>
46	47	<li class="menu-item">
47	48	<a class="<?php echo $_tab->selected ? true : "selected"; ?>" href="<?php echo $_tab->url; ?>">

		@@ -12,26 +12,26 @@
		block discarded – undo
12	12	<?php $__db_h = new db_helper(); ?>
13	13	<?php $__time_h = new time_helper(); ?>
14	14	<?php
15		- if(!$__video_h->video_exists($_GET['v']))
16		- header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
	15	+ if(!$__video_h->video_exists($_GET['v']))
	16	+ header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
17	17
18		- $_video = $__video_h->fetch_video_rid($_GET['v']);
19		- $_video['video_responses'] = $__video_h->get_video_responses($_video['rid']);
20		- $_video['age'] = $__time_h->time_elapsed_string($_video['publish']);
21		- $_video['duration'] = $__time_h->timestamp($_video['duration']);
22		- $_video['views'] = $__video_h->fetch_video_views($_video['rid']);
23		- $_video['author'] = htmlspecialchars($_video['author']);
24		- $_video['title'] = htmlspecialchars($_video['title']);
25		- $_video['description'] = $__video_h->shorten_description($_video['description'], 50);
	18	+ $_video = $__video_h->fetch_video_rid($_GET['v']);
	19	+ $_video['video_responses'] = $__video_h->get_video_responses($_video['rid']);
	20	+ $_video['age'] = $__time_h->time_elapsed_string($_video['publish']);
	21	+ $_video['duration'] = $__time_h->timestamp($_video['duration']);
	22	+ $_video['views'] = $__video_h->fetch_video_views($_video['rid']);
	23	+ $_video['author'] = htmlspecialchars($_video['author']);
	24	+ $_video['title'] = htmlspecialchars($_video['title']);
	25	+ $_video['description'] = $__video_h->shorten_description($_video['description'], 50);
26	26
27	27	if($_SESSION['siteusername'] != $_video['author'])
28	28	header("Location: /");
29	29	?>
30	30	<?php
31		- $__server->page_embeds->page_title = "SubRocks - Uploaded Video";
32		- $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
33		- $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
34		- $__server->page_embeds->page_url = "https://subrock.rocks/";
	31	+ $__server->page_embeds->page_title = "SubRocks - Uploaded Video";
	32	+ $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
	33	+ $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
	34	+ $__server->page_embeds->page_url = "https://subrock.rocks/";
35	35	?>
36	36	<!DOCTYPE html>
37	37	<html>

		@@ -12,8 +12,9 @@ discard block
		block discarded – undo
12	12	<?php $__db_h = new db_helper(); ?>
13	13	<?php $__time_h = new time_helper(); ?>
14	14	<?php
15		- if(!$__video_h->video_exists($_GET['v']))
16		- header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
	15	+ if(!$__video_h->video_exists($_GET['v'])) {
	16	+ header("Location: /?error=Your video has not processed correctly. Try reuploading it with a shorter title, description, or tag.");
	17	+ }
17	18
18	19	$_video = $__video_h->fetch_video_rid($_GET['v']);
19	20	$_video['video_responses'] = $__video_h->get_video_responses($_video['rid']);
		@@ -24,9 +25,10 @@ discard block
		block discarded – undo
24	25	$_video['title'] = htmlspecialchars($_video['title']);
25	26	$_video['description'] = $__video_h->shorten_description($_video['description'], 50);
26	27
27		- if($_SESSION['siteusername'] != $_video['author'])
28		- header("Location: /");
29		-?>
	28	+ if($_SESSION['siteusername'] != $_video['author']) {
	29	+ header("Location: /");
	30	+ }
	31	+ ?>
30	32	<?php
31	33	$__server->page_embeds->page_title = "SubRocks - Uploaded Video";
32	34	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";

		@@ -8,7 +8,7 @@ discard block
		block discarded – undo
8	8	<?php $__db_h = new db_helper(); ?>
9	9	<?php $__time_h = new time_helper(); ?>
10	10	<?php
11		- if($_SERVER['REQUEST_METHOD'] == 'POST' && $_POST['password'] && $_POST['username']) {
	11	+ if ($_SERVER['REQUEST_METHOD'] == 'POST' && $_POST['password'] && $_POST['username']) {
12	12	$request = (object) [
13	13	"username" => $_POST['username'],
14	14	"password" => $_POST['password'],
		@@ -22,25 +22,25 @@ discard block
		block discarded – undo
22	22	];
23	23
24	24	if (!filter_var($request->email, FILTER_VALIDATE_EMAIL))
25		- { $request->error->message = "Your email is invalid!"; $request->error->status = ""; }
26		- if(strlen($request->username) > 21)
	25	+ { $request->error->message = "Your email is invalid!"; $request->error->status = ""; }
	26	+ if (strlen($request->username) > 21)
27	27	{ $request->error->message = "Your username must be shorter than 20 characters."; $request->error->status = ""; }
28		- if(strlen($request->password) < 8)
	28	+ if (strlen($request->password) < 8)
29	29	{ $request->error->message = "Your password must at least be 8 characters long."; $request->error->status = ""; }
30		- if(!preg_match('/[A-Za-z].[0-9]\|[0-9].[A-Za-z]/', $request->password))
	30	+ if (!preg_match('/[A-Za-z].[0-9]\|[0-9].[A-Za-z]/', $request->password))
31	31	{ $request->error->message = "Include numbers and letters in your password!"; $request->error->status = ""; }
32		- if(!preg_match('/^\S+\w\S{1,}/', $request->username))
	32	+ if (!preg_match('/^\S+\w\S{1,}/', $request->username))
33	33	{ $request->error->message = "Your username cannot contain any special characters!"; $request->error->status = ""; }
34		- if(empty(trim($request->username)))
	34	+ if (empty(trim($request->username)))
35	35	{ $request->error->message = "Your username cannot be empty!"; $request->error->status = ""; }
36	36
37	37	$stmt = $__db->prepare("SELECT username FROM users WHERE username = :username");
38	38	$stmt->bindParam(":username", $request->username);
39	39	$stmt->execute();
40		- if($stmt->rowCount())
	40	+ if ($stmt->rowCount())
41	41	{ $request->error->message = "There's already a user with that same username!"; $request->error->status = ""; }
42	42
43		- if($request->error->status == "OK") {
	43	+ if ($request->error->status == "OK") {
44	44	$stmt = $__db->prepare("INSERT INTO users (username, email, password) VALUES (:username, :email, :password)");
45	45	$stmt->bindParam(":username", $request->username);
46	46	$stmt->bindParam(":email", $request->email);

		@@ -10,10 +10,10 @@
		block discarded – undo
10	10	<?php $__time_h = new time_helper(); ?>
11	11	<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
12	12	<?php
13		- $__server->page_embeds->page_title = "SubRocks - Personal Messages";
14		- $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
15		- $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
16		- $__server->page_embeds->page_url = "https://subrock.rocks/";
	13	+ $__server->page_embeds->page_title = "SubRocks - Personal Messages";
	14	+ $__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
	15	+ $__server->page_embeds->page_image = "/yt/imgbin/full-size-logo.png";
	16	+ $__server->page_embeds->page_url = "https://subrock.rocks/";
17	17	?>
18	18	<!DOCTYPE html>
19	19	<html dir="ltr">

		@@ -8,7 +8,7 @@ discard block
		block discarded – undo
8	8	<?php $__user_u = new user_update($__db); ?>
9	9	<?php $__db_h = new db_helper(); ?>
10	10	<?php $__time_h = new time_helper(); ?>
11		-<?php if(!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
	11	+<?php if (!isset($_SESSION['siteusername'])) { header("Location: /sign_in"); } ?>
12	12	<?php
13	13	$__server->page_embeds->page_title = "SubRocks - Personal Messages";
14	14	$__server->page_embeds->page_description = "SubRocks is a site dedicated to bring back the 2012 layout of YouTube.";
		@@ -169,15 +169,15 @@ discard block
		block discarded – undo
169	169	$stmt->execute();
170	170
171	171	$number_of_result = $stmt->rowCount();
172		- $number_of_page = ceil ($number_of_result / $results_per_page);
	172	+ $number_of_page = ceil($number_of_result/$results_per_page);
173	173
174		- if (!isset ($_GET['page']) ) {
	174	+ if (!isset ($_GET['page'])) {
175	175	$page = 1;
176	176	} else {
177		- $page = (int)$_GET['page'];
	177	+ $page = (int) $_GET['page'];
178	178	}
179	179
180		- $page_first_result = ($page - 1) * $results_per_page;
	180	+ $page_first_result = ($page - 1)*$results_per_page;
181	181
182	182	$stmt6 = $__db->prepare("SELECT * FROM pms WHERE touser = :search AND type = 'nm' ORDER BY id DESC LIMIT :pfirst, :pper");
183	183	$stmt6->bindParam(":search", $search);
		@@ -202,8 +202,8 @@ discard block
		block discarded – undo
202	202	</tr>
203	203
204	204	<?php
205		- while($inbox = $stmt->fetch(PDO::FETCH_ASSOC)) {
206		- if($__video_h->video_exists($inbox['video_attribute'])) {
	205	+ while ($inbox = $stmt->fetch(PDO::FETCH_ASSOC)) {
	206	+ if ($__video_h->video_exists($inbox['video_attribute'])) {
207	207	$inbox['video'] = $__video_h->fetch_video_rid($inbox['video_attribute']);
208	208	$inbox['video_attr_exists'] = true;
209	209
		@@ -217,7 +217,7 @@ discard block
		block discarded – undo
217	217	?>
218	218	<tr style="margin-top: 5px;" id="videoslist">
219	219	<!--
220		- <?php if($inbox['readed'] == "n") { ?>
	220	+ <?php if ($inbox['readed'] == "n") { ?>
221	221	<a style="position:relative;top:7px;color: white;text-decoration: none;background-color: #d54343;padding: 7px;padding-left: 10px;margin-right: 12px;display: inline;" href="/inbox/">
222	222	NEW
223	223	</a>
		@@ -240,7 +240,7 @@ discard block
		block discarded – undo
240	240	<td class="video-manager-stats" style="background: none;padding-left: 8px;">
241	241	<h3><?php echo htmlspecialchars($inbox['subject']); ?></h3>
242	242	<?php echo $__video_h->shorten_description($inbox['message'], 300, true); ?>
243		- <?php if($inbox['video_attr_exists']) { ?>
	243	+ <?php if ($inbox['video_attr_exists']) { ?>
244	244	<hr>
245	245	<ul>
246	246	<li class="video-list-item "><a href="/watch?v=<?php echo $inbox['video']['rid']; ?>" class="video-list-item-link yt-uix-sessionlink" data-sessionlink="ei=CNLr3rbS3rICFSwSIQodSW397Q%3D%3D&feature=g-sptl%26cid%3Dinp-hs-ytg"><span class="ux-thumb-wrap contains-addto "><span class="video-thumb ux-thumb yt-thumb-default-120 "><span class="yt-thumb-clip"><span class="yt-thumb-clip-inner"><img src="http://s.ytimg.com/yt/img/pixel-vfl3z5WfW.gif" alt="<?php echo $inbox['video']['title']; ?>" data-thumb="/dynamic/thumbs/<?php echo $inbox['video']['thumbnail']; ?>" width="120"><span class="vertical-align"></span></span></span></span><span class="video-time"><?php echo $inbox['video']['duration']; ?></span>
		@@ -267,7 +267,7 @@ discard block
		block discarded – undo
267	267	</div>
268	268	</center><br>
269	269
270		- <?php for($page = 1; $page<= $number_of_page; $page++) { ?>
	270	+ <?php for ($page = 1; $page <= $number_of_page; $page++) { ?>
271	271	<button class="yt-uix-button yt-uix-button-default" onclick="ajax_fetch(<?php echo $page; ?>)"><?php echo $page; ?></button>
272	272	<?php } ?>
273	273
		@@ -291,7 +291,7 @@ discard block
		block discarded – undo
291	291	</script>
292	292
293	293	<?php
294		- if($stmt6->rowCount() == 0) { echo "
	294	+ if ($stmt6->rowCount() == 0) { echo "
295	295	You currently have no personal messages in your inbox.
296	296	";
297	297	} ?>

the-real-sumsome / subrocks-2012

Push — main ( c0bf37...778e90 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +7 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch