Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class TagVoter extends Voter |
||
18 | { |
||
19 | const VIEW = 'view'; |
||
20 | |||
21 | /** |
||
22 | * {@inheritdoc} |
||
23 | */ |
||
24 | View Code Duplication | protected function supports($attribute, $subject) |
|
36 | |||
37 | /** |
||
38 | * {@inheritdoc} |
||
39 | */ |
||
40 | View Code Duplication | protected function voteOnAttribute($attribute, $subject, TokenInterface $token) |
|
57 | |||
58 | /** |
||
59 | * Return true if the given $user can view the given $tag. |
||
60 | * The $entity can be viewed by the $user if the user is linked to that $tag. |
||
61 | * |
||
62 | * @param TagInterface $tag |
||
63 | * @param TaggableInterface $user |
||
64 | * |
||
65 | * @return bool |
||
66 | */ |
||
67 | private function canView(TagInterface $tag, TaggableInterface $user) |
||
71 | } |
||
72 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.