prompt_open_file_dialog() - Code Metrics - Inspection of "Improved dialog information" - thatsIch/sublime-rainmeter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9e5000...620833 )

by thatsIch

created 2017-01-13 17:58 UTC

prompt_open_file_dialog() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
dl	0
loc	40
rs	8.8571


class SomeClass:
    def some_method(self):
        """Do x and return foo."""
import os.path
import subprocess
import threading

import sublime

from .. import logger


def sink(message):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    logger.info(message)


def popen_and_call(callback, *popen_args, **popen_kwargs):
    """
    Runs a subprocess.Popen, and then calls the function onExit when the
    subprocess completes.

    Use it exactly the way you'd normally use subprocess.Popen, except include a
    callable to execute as the first argument. onExit is a callable object, and
    *popenArgs and **popenKWArgs are simply passed up to subprocess.Popen.
    """
    def run_in_thread(callback, popen_args, popen_kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        proc = subprocess.Popen(*popen_args, **popen_kwargs)

        output_channel, error_channel = proc.communicate()
        message = output_channel.decode("utf-8")
        message = message.replace("\r\n", "")

        proc.wait()

        # checking for errors first
        error = error_channel.decode("utf-8", errors="replace")
        if error is not None and len(error) != 0:
            error = error.replace("\r\n", "\n")
            logger.error("Error in thread for '" + str(callback) + "':" + error)
            return

        callback(message)

        return

    thread = threading.Thread(target=run_in_thread,
                              args=(callback, popen_args, popen_kwargs))
    thread.start()

    # returns immediately after the thread starts
    return thread


def call_file_and_callback(file, callback):
    """."""
    packages = sublime.packages_path()
    prompt_dir = os.path.join(packages, "User", "Rainmeter", "path")
    script_path = os.path.join(prompt_dir, file)

    popen_args = [
        'powershell.exe',
        '-NoProfile',
        '-NonInteractive',
        '-NoLogo',
        '-ExecutionPolicy', 'RemoteSigned',
        '-windowstyle', 'hidden',
        '-File', script_path
    ]

    st_inf = subprocess.STARTUPINFO()
    st_inf.dwFlags = st_inf.dwFlags | subprocess.STARTF_USESHOWWINDOW

    thread = popen_and_call(
        callback,
        popen_args,
        stdout=subprocess.PIPE,
        stderr=subprocess.PIPE,
        shell=False,
        startupinfo=st_inf
    )

    return thread


def browse_file(callback):
    """."""
    return call_file_and_callback("open_file_dialog.ps1", callback)


def browse_folder(callback):
    """."""
    return call_file_and_callback("open_folder_dialog.ps1", callback)


def prompt_open_file_dialog():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    packages = sublime.packages_path()
    prompt_dir = os.path.join(packages, "User", "Rainmeter", "path")

    open_file_dialog_bat = os.path.join(prompt_dir, "open_file_dialog.ps1")

    st_inf = subprocess.STARTUPINFO()
    st_inf.dwFlags = st_inf.dwFlags | subprocess.STARTF_USESHOWWINDOW

    dialog = subprocess.Popen(
        [
            'powershell.exe',
            '-NoProfile',
            '-NonInteractive',
            '-NoLogo',
            '-ExecutionPolicy', 'RemoteSigned',
            '-windowstyle', 'hidden',
            '-File', open_file_dialog_bat
        ],
        stdout=subprocess.PIPE,
        stderr=subprocess.PIPE,
        shell=False,
        startupinfo=st_inf
    )
    output_channel, error_channel = dialog.communicate()
    raw_output = output_channel.decode("utf-8")

    # need to wait on the powershell script to execute and user interaction
    dialog.wait()
    # TODO need to rework it with http://stackoverflow.com/a/5209746/2787159

    # concurrent callback when finished

    # checking for errors first
    error = error_channel.decode("utf-8")
    if error is not None and len(error) != 0:
        logger.error("Color Picker Error:\n" + error)
        return

    return raw_output


1
			0 ignored issues – show Coding Style introduced 2017-01-13 17:59 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			import os.path
3			import subprocess
4			import threading
5
6			import sublime
7
8			from .. import logger
9
10
11			def sink(message):
			0 ignored issues – show Coding Style introduced 2017-01-13 17:59 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
12			logger.info(message)
13
14
15			def popen_and_call(callback, popen_args, *popen_kwargs):
16			"""
17			Runs a subprocess.Popen, and then calls the function onExit when the
18			subprocess completes.
19
20			Use it exactly the way you'd normally use subprocess.Popen, except include a
21			callable to execute as the first argument. onExit is a callable object, and
22			popenArgs and *popenKWArgs are simply passed up to subprocess.Popen.
23			"""
24			def run_in_thread(callback, popen_args, popen_kwargs):
			0 ignored issues – show Coding Style introduced 2017-01-13 17:59 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
25			proc = subprocess.Popen(popen_args, *popen_kwargs)
			0 ignored issues – show Coding Style introduced 2017-01-13 17:59 UTC by Report Bug Copy Issue Report Usage of `` or `` arguments should usually be done with care. Generally, there is nothing wrong with usage of `` or `**` arguments. For readability of the code base, we suggest to not over-use these language constructs though. For more information, we can recommend this blog post from Ned Batchelder including its comments which also touches this aspect. Loading history...
26			output_channel, error_channel = proc.communicate()
27			message = output_channel.decode("utf-8")
28			message = message.replace("\r\n", "")
29
30			proc.wait()
31
32			# checking for errors first
33			error = error_channel.decode("utf-8", errors="replace")
34			if error is not None and len(error) != 0:
35			error = error.replace("\r\n", "\n")
36			logger.error("Error in thread for '" + str(callback) + "':" + error)
37			return
38
39			callback(message)
40
41			return
42
43			thread = threading.Thread(target=run_in_thread,
44			args=(callback, popen_args, popen_kwargs))
45			thread.start()
46
47			# returns immediately after the thread starts
48			return thread
49
50
51			def call_file_and_callback(file, callback):
52			"""."""
53			packages = sublime.packages_path()
54			prompt_dir = os.path.join(packages, "User", "Rainmeter", "path")
55			script_path = os.path.join(prompt_dir, file)
56
57			popen_args = [
58			'powershell.exe',
59			'-NoProfile',
60			'-NonInteractive',
61			'-NoLogo',
62			'-ExecutionPolicy', 'RemoteSigned',
63			'-windowstyle', 'hidden',
64			'-File', script_path
65			]
66
67			st_inf = subprocess.STARTUPINFO()
68			st_inf.dwFlags = st_inf.dwFlags \| subprocess.STARTF_USESHOWWINDOW
69
70			thread = popen_and_call(
71			callback,
72			popen_args,
73			stdout=subprocess.PIPE,
74			stderr=subprocess.PIPE,
75			shell=False,
76			startupinfo=st_inf
77			)
78
79			return thread
80
81
82			def browse_file(callback):
83			"""."""
84			return call_file_and_callback("open_file_dialog.ps1", callback)
85
86
87			def browse_folder(callback):
88			"""."""
89			return call_file_and_callback("open_folder_dialog.ps1", callback)
90
91
92			def prompt_open_file_dialog():
			0 ignored issues – show Coding Style introduced 2017-01-13 17:59 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
93
94			packages = sublime.packages_path()
95			prompt_dir = os.path.join(packages, "User", "Rainmeter", "path")
96
97			open_file_dialog_bat = os.path.join(prompt_dir, "open_file_dialog.ps1")
98
99			st_inf = subprocess.STARTUPINFO()
100			st_inf.dwFlags = st_inf.dwFlags \| subprocess.STARTF_USESHOWWINDOW
101
102			dialog = subprocess.Popen(
103			[
104			'powershell.exe',
105			'-NoProfile',
106			'-NonInteractive',
107			'-NoLogo',
108			'-ExecutionPolicy', 'RemoteSigned',
109			'-windowstyle', 'hidden',
110			'-File', open_file_dialog_bat
111			],
112			stdout=subprocess.PIPE,
113			stderr=subprocess.PIPE,
114			shell=False,
115			startupinfo=st_inf
116			)
117			output_channel, error_channel = dialog.communicate()
118			raw_output = output_channel.decode("utf-8")
119
120			# need to wait on the powershell script to execute and user interaction
121			dialog.wait()
122			# TODO need to rework it with http://stackoverflow.com/a/5209746/2787159
			0 ignored issues – show Coding Style introduced 2017-01-13 17:59 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
123			# concurrent callback when finished
124
125			# checking for errors first
126			error = error_channel.decode("utf-8")
127			if error is not None and len(error) != 0:
128			logger.error("Color Picker Error:\n" + error)
129			return
130
131			return raw_output
132

thatsIch / sublime-rainmeter

GitHub Access Token became invalid

Push — master ( 9e5000...620833 )

prompt_open_file_dialog() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like