AmkaValidator::isOdd() - Code Metrics - Inspection of "Refactor validators" - thanosKontos/greek-validators-symfony - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 54b905...f751d8 )

by Thanos

created 2018-03-02 17:38 UTC

AmkaValidator::isOdd() A

↳ Parent: AmkaValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace SymfonyGreekValidation;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

class AmkaValidator extends ConstraintValidator
{
    public function validate($value, Constraint $constraint)
    {
        if (empty($value)) {
            return true;
        }

        if (!preg_match('/^[0-9]{11}$/', $value) || $value === '00000000000') {
            $this->buildViolation($value, $constraint);

            return false;
        }

        $checksum = $this->calculateChecksum($value);

        if ($checksum % 10 !== 0) {
            $this->buildViolation($value, $constraint);

            return false;
        }

        return true;
    }

    private function calculateChecksum(string $amka): int
    {
        $sum = 0;
        foreach(str_split($amka) as $index => $char) {
            $tempDigit = intval($char);
            if ($this->isOdd($index)) {
                $tempDigit *= 2;
                if ($tempDigit > 9) {
                    $tempDigit -= 9;
                }
            }

            $sum += $tempDigit;
        }

        return $sum;
    }

    private function isOdd($index): bool
    {
        return $index % 2 === 1;
    }

    private function buildViolation($value, $constraint): void
    {
        $this->context->buildViolation($constraint->message)
            ->setParameter('{{ string }}', $value)
            ->addViolation();
    }
}

1		<?php
2
3		namespace SymfonyGreekValidation;
4
5		use Symfony\Component\Validator\Constraint;
6		use Symfony\Component\Validator\ConstraintValidator;
7
8		class AmkaValidator extends ConstraintValidator
9		{
10	21	public function validate($value, Constraint $constraint)
11		{
12	21	if (empty($value)) {
13	2	return true;
14		}
15
16	19	if (!preg_match('/^[0-9]{11}$/', $value) \|\| $value === '00000000000') {
17	3	$this->buildViolation($value, $constraint);
18
19	3	return false;
20		}
21
22	16	$checksum = $this->calculateChecksum($value);
23
24	16	if ($checksum % 10 !== 0) {
25	2	$this->buildViolation($value, $constraint);
26
27	2	return false;
28		}
29
30	14	return true;
31		}
32
33	16	private function calculateChecksum(string $amka): int
34		{
35	16	$sum = 0;
36	16	foreach(str_split($amka) as $index => $char) {
37	16	$tempDigit = intval($char);
38	16	if ($this->isOdd($index)) {
39	16	$tempDigit *= 2;
40	16	if ($tempDigit > 9) {
41	15	$tempDigit -= 9;
42		}
43		}
44
45	16	$sum += $tempDigit;
46		}
47
48	16	return $sum;
49		}
50
51	16	private function isOdd($index): bool
52		{
53	16	return $index % 2 === 1;
54		}
55
56	5	private function buildViolation($value, $constraint): void
57		{
58	5	$this->context->buildViolation($constraint->message)
59	5	->setParameter('{{ string }}', $value)
60	5	->addViolation();
61		}
62		}

thanosKontos / greek-validators-symfony

Push — master ( 54b905...f751d8 )

AmkaValidator::isOdd() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like