Curl::request() - Code Metrics - Inspection of "Merge pull request #11 from thallesdella/develop" - thallesdella/entregas - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 58a500...0a2fd6 )

by Thalles

created 2019-09-14 08:37 UTC

Curl::request() B

↳ Parent: Curl

Complexity

Conditions	6
Paths	9

Size

Total Lines	36
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
eloc	24
c	3
b	0
f	0
dl	0
loc	36
rs	8.9137
cc	6
nc	9
nop	4

<?php

namespace ThallesDKoester\Entregas;

use Exception;

/**
 * Thalles D. Koester | Trait Curl
 *
 * @author  Thalles D. koester <[email protected]>
 * @package ThallesDKoester\Entregas
 */
trait Curl
{

    /**
     * @param string     $path
     * @param string     $method
     * @param array|null $params
     * @param int        $port
     * @return string
     * @throws Exception
     */
    private function request(string $path, string $method, ?array $params = null, ?int $port = null): string
    {
        $conn = curl_init();

        if ($conn === false) {
            throw new Exception('Erro na inicialízação do cURL.');
        }

        curl_setopt($conn, CURLOPT_URL, $path);
        curl_setopt($conn, CURLOPT_TIMEOUT, 30);
        curl_setopt($conn, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($conn, CURLOPT_CUSTOMREQUEST, $method);
        curl_setopt($conn, CURLOPT_FORBID_REUSE, true);
        curl_setopt($conn, CURLOPT_HTTPHEADER, [
            "cache-control: no-cache",
            "content-type: application/x-www-form-urlencoded"
        ]);

        if (!empty($params) && count($params) > 0) {
            curl_setopt($conn, CURLOPT_POSTFIELDS, http_build_query($params));
        } else {
            curl_setopt($conn, CURLOPT_POSTFIELDS, null);
        }

        if ($port) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            curl_setopt($conn, CURLOPT_PORT, $port);
        }

        $data = curl_exec($conn);
        $err = curl_error($conn);
        curl_close($conn);

        if ($err) {
            throw new Exception($err);
        } else {
            return $this->validateData($data);
        }
    }

    /**
     * @param $response
     * @return string
     * @throws Exception
     */
    private function validateData($response): string
    {
        if (empty($response)) {
            throw new Exception("curl could not reach the server.");
        }

        if (!$response) {
            throw new Exception($response);
        }
        return $response;
    }
}

1			<?php
2
3			namespace ThallesDKoester\Entregas;
4
5			use Exception;
6
7			/**
8			* Thalles D. Koester \| Trait Curl
9			*
10			* @author Thalles D. koester <[email protected]>
11			* @package ThallesDKoester\Entregas
12			*/
13			trait Curl
14			{
15
16			/**
17			* @param string $path
18			* @param string $method
19			* @param array\|null $params
20			* @param int $port
21			* @return string
22			* @throws Exception
23			*/
24			private function request(string $path, string $method, ?array $params = null, ?int $port = null): string
25			{
26			$conn = curl_init();
27
28			if ($conn === false) {
29			throw new Exception('Erro na inicialízação do cURL.');
30			}
31
32			curl_setopt($conn, CURLOPT_URL, $path);
33			curl_setopt($conn, CURLOPT_TIMEOUT, 30);
34			curl_setopt($conn, CURLOPT_RETURNTRANSFER, true);
35			curl_setopt($conn, CURLOPT_CUSTOMREQUEST, $method);
36			curl_setopt($conn, CURLOPT_FORBID_REUSE, true);
37			curl_setopt($conn, CURLOPT_HTTPHEADER, [
38			"cache-control: no-cache",
39			"content-type: application/x-www-form-urlencoded"
40			]);
41
42			if (!empty($params) && count($params) > 0) {
43			curl_setopt($conn, CURLOPT_POSTFIELDS, http_build_query($params));
44			} else {
45			curl_setopt($conn, CURLOPT_POSTFIELDS, null);
46			}
47
48			if ($port) {
			0 ignored issues – show Bug Best Practice introduced 2019-09-14 08:38 UTC by Report Bug Copy Issue Report The expression `$port` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
49			curl_setopt($conn, CURLOPT_PORT, $port);
50			}
51
52			$data = curl_exec($conn);
53			$err = curl_error($conn);
54			curl_close($conn);
55
56			if ($err) {
57			throw new Exception($err);
58			} else {
59			return $this->validateData($data);
60			}
61			}
62
63			/**
64			* @param $response
65			* @return string
66			* @throws Exception
67			*/
68			private function validateData($response): string
69			{
70			if (empty($response)) {
71			throw new Exception("curl could not reach the server.");
72			}
73
74			if (!$response) {
75			throw new Exception($response);
76			}
77			return $response;
78			}
79			}

thallesdella / entregas

Push — master ( 58a500...0a2fd6 )

Curl::request() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like