MenuItem::jsonSerialize() - Code Metrics - Inspection of "Update sdk" - tgallice/fb-messenger-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Gallice

created 2016-08-13 21:45 UTC

MenuItem::jsonSerialize() A

↳ Parent: MenuItem

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	15
Ratio	100 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	15
loc	15
ccs	9
cts	9
cp	1
rs	9.4285
cc	2
eloc	9
nc	2
nop	0
crap	2

<?php

namespace Tgallice\FBMessenger\Model\ThreadSetting;

class MenuItem implements \JsonSerializable
{
    const TYPE_POSTBACK = 'postback';
    const TYPE_WEB_URL = 'web_url';

    /**
     * @var string
     */
    private $title;

    /**
     * @var string
     */
    private $type;

    /**
     * Url or payload
     *
     * @var string
     */
    protected $data;

    /**
     * @param string $type
     * @param string $title
     * @param string $data Url or payload value
     */
    public function __construct($type, $title, $data)
    {
        $this->type = $type;

        $this->validateTitleSize($title);
        $this->title = $title;

        if ($this->type === self::TYPE_POSTBACK) {
            $this->validatePayload($data);
        }

        $this->data = $data;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return $this->title;
    }

    /**
     * @return string
     */
    public function getData()
    {
        return $this->data;
    }

    /**
     * @inheritdoc
     */
    public function jsonSerialize()
    {
        $data = [
            'type' => $this->type,
            'title' => $this->title,
        ];

        if ($this->type === self::TYPE_WEB_URL) {
            $data['url'] = $this->data;
        } else {
            $data['payload'] = $this->data;
        }

        return $data;
    }

    /**
     * @param string $title
     *
     * @throws \InvalidArgumentException
     */
    private function validateTitleSize($title)
    {
        if (mb_strlen($title) > 30) {
            throw new \InvalidArgumentException('The menu item title field should not exceed 30 characters.');
        }
    }

    /**
     * @param $payload
     *
     * @throws \InvalidArgumentException
     */
    private function validatePayload($payload)
    {
        if (mb_strlen($payload) > 1000) {
            throw new \InvalidArgumentException(sprintf(
                    'Payload should not exceed 1000 characters.', $payload)
            );
        }
    }
}


1			<?php
2
3			namespace Tgallice\FBMessenger\Model\ThreadSetting;
4
5			class MenuItem implements \JsonSerializable
6			{
7			const TYPE_POSTBACK = 'postback';
8			const TYPE_WEB_URL = 'web_url';
9
10			/**
11			* @var string
12			*/
13			private $title;
14
15			/**
16			* @var string
17			*/
18			private $type;
19
20			/**
21			* Url or payload
22			*
23			* @var string
24			*/
25			protected $data;
26
27			/**
28			* @param string $type
29			* @param string $title
30			* @param string $data Url or payload value
31			*/
32	14		public function __construct($type, $title, $data)
33			{
34	14		$this->type = $type;
35
36	14		$this->validateTitleSize($title);
37	13		$this->title = $title;
38
39	13		if ($this->type === self::TYPE_POSTBACK) {
40	5		$this->validatePayload($data);
41	4		}
42
43	12		$this->data = $data;
44	12		}
45
46			/**
47			* @return string
48			*/
49	1		public function getType()
50			{
51	1		return $this->type;
52			}
53
54			/**
55			* @return string
56			*/
57	1		public function getTitle()
58			{
59	1		return $this->title;
60			}
61
62			/**
63			* @return string
64			*/
65	1		public function getData()
66			{
67	1		return $this->data;
68			}
69
70			/**
71			* @inheritdoc
72			*/
73	3	View Code Duplication	public function jsonSerialize()
74			{
75			$data = [
76	3		'type' => $this->type,
77	3		'title' => $this->title,
78	3		];
79
80	3		if ($this->type === self::TYPE_WEB_URL) {
81	2		$data['url'] = $this->data;
82	2		} else {
83	2		$data['payload'] = $this->data;
84			}
85
86	3		return $data;
87			}
88
89			/**
90			* @param string $title
91			*
92			* @throws \InvalidArgumentException
93			*/
94	14		private function validateTitleSize($title)
95			{
96	14		if (mb_strlen($title) > 30) {
97	1		throw new \InvalidArgumentException('The menu item title field should not exceed 30 characters.');
98			}
99	13		}
100
101			/**
102			* @param $payload
103			*
104			* @throws \InvalidArgumentException
105			*/
106	5		private function validatePayload($payload)
107			{
108	5		if (mb_strlen($payload) > 1000) {
109	1		throw new \InvalidArgumentException(sprintf(
110	1		'Payload should not exceed 1000 characters.', $payload)
111	1		);
112			}
113	4		}
114			}
115

tgallice / fb-messenger-sdk

GitHub Access Token became invalid

Pull Request — master (#9)

MenuItem::jsonSerialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like