Element::getImageUrl() - Code Metrics - Inspection of "Add List template (#36)" - tgallice/fb-messenger-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ac5cf0...399d31 )

by Gallice

created 2017-01-15 12:39 UTC

Element::getImageUrl() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace Tgallice\FBMessenger\Model\Attachment\Template\Generic;

use Tgallice\FBMessenger\Model\Button;
use Tgallice\FBMessenger\Model\Attachment\Template\AbstractElement;
use Tgallice\FBMessenger\Model\DefaultAction;

class Element extends AbstractElement
{
    /**
     * @var null|DefaultAction
     */
    private $defaultAction;

    /**
     * @var null|Button[]
     */
    private $buttons;

    /**
     * @param string $title
     */
    public function __construct($title, $subtitle = null, $imageUrl = null, array $buttons = null, DefaultAction $defaultAction = null)
    {
        parent::__construct($title, $subtitle, $imageUrl);

        if (count($buttons) > 3) {
            throw new \InvalidArgumentException('A generic element can not have more than 3 buttons.');
        }

        $this->buttons = $buttons;
        $this->defaultAction = $defaultAction;
    }

    /**
     * @return null|Button[]
     */
    public function getButtons()
    {
        return $this->buttons;
    }

    /**
     * @return null|DefaultAction
     */
    public function getDefaultAction()
    {
        return $this->defaultAction;
    }

    /**
     * @return array
     */
    public function jsonSerialize()

    {
        return [
            'title' => $this->getTitle(),
            'image_url' => $this->getImageUrl(),
            'subtitle' => $this->getSubtitle(),
            'buttons' => $this->buttons,
            'default_action' => $this->defaultAction,
        ];
    }
}


1			<?php
2
3			namespace Tgallice\FBMessenger\Model\Attachment\Template\Generic;
4
5			use Tgallice\FBMessenger\Model\Button;
6			use Tgallice\FBMessenger\Model\Attachment\Template\AbstractElement;
7			use Tgallice\FBMessenger\Model\DefaultAction;
8
9			class Element extends AbstractElement
10			{
11			/**
12			* @var null\|DefaultAction
13			*/
14			private $defaultAction;
15
16			/**
17			* @var null\|Button[]
18			*/
19			private $buttons;
20
21			/**
22			* @param string $title
23			*/
24	9		public function __construct($title, $subtitle = null, $imageUrl = null, array $buttons = null, DefaultAction $defaultAction = null)
25			{
26	9		parent::__construct($title, $subtitle, $imageUrl);
27
28	7		if (count($buttons) > 3) {
29	1		throw new \InvalidArgumentException('A generic element can not have more than 3 buttons.');
30			}
31
32	6		$this->buttons = $buttons;
33	6		$this->defaultAction = $defaultAction;
34	6		}
35
36			/**
37			* @return null\|Button[]
38			*/
39	1		public function getButtons()
40			{
41	1		return $this->buttons;
42			}
43
44			/**
45			* @return null\|DefaultAction
46			*/
47	1		public function getDefaultAction()
48			{
49	1		return $this->defaultAction;
50			}
51
52			/**
53			* @return array
54			*/
55	1	View Code Duplication	public function jsonSerialize()
			1 ignored issue – show Duplication introduced 2017-01-07 14:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56			{
57			return [
58	1		'title' => $this->getTitle(),
59	1		'image_url' => $this->getImageUrl(),
60	1		'subtitle' => $this->getSubtitle(),
61	1		'buttons' => $this->buttons,
62	1		'default_action' => $this->defaultAction,
63	1		];
64			}
65			}
66

tgallice / fb-messenger-sdk

GitHub Access Token became invalid

Push — master ( ac5cf0...399d31 )

Element::getImageUrl() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like