WebhookFetcher::getContents() - Code Metrics - Inspection of "updated readme and improved fetcher" - tg-bot-api/bot-api-base - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6ffd57...b56fef )

by Nikolay

created 2019-01-14 21:06 UTC

WebhookFetcher::getContents() A

↳ Parent: WebhookFetcher

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	9
c	0
b	0
f	0
ccs	5
cts	6
cp	0.8333
rs	10
cc	3
nc	3
nop	1
crap	3.0416

<?php

declare(strict_types=1);

namespace TgBotApi\BotApiBase;

use Psr\Http\Message\RequestInterface;
use TgBotApi\BotApiBase\Exception\BadRequestException;
use TgBotApi\BotApiBase\Type\UpdateType;

/**
 * Class WebhookFetcher.
 */
class WebhookFetcher implements WebhookFetcherInterface
{
    /**
     * @var BotApiNormalizer
     */
    private $normalizer;

    /**
     * WebhookFetcher constructor.
     *
     * @param NormalizerInterface $normalizer
     */
    public function __construct(NormalizerInterface $normalizer)
    {
        $this->normalizer = $normalizer;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * @param RequestInterface|string $request
     *
     * @throws BadRequestException
     *
     * @return UpdateType
     */
    public function fetch($request): UpdateType
    {
        $input = \json_decode($this->getContents($request));
        if (!($input instanceof \stdClass)) {
            throw new BadRequestException('Request content must be valid JSON object.');
        }

        return $this->normalizer->denormalize($input, UpdateType::class);
    }

    /**
     * @param $request
     *
     * @throws BadRequestException
     *
     * @return string
     */
    private function getContents($request): string
    {
        if ($request instanceof RequestInterface) {
            return $request->getBody()->getContents();
        }
        if (\is_string($request)) {
            return $request;
        }
        throw new BadRequestException('Request must be instance of Psr\Http\Message\RequestInterface or string.');
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace TgBotApi\BotApiBase;
6
7		use Psr\Http\Message\RequestInterface;
8		use TgBotApi\BotApiBase\Exception\BadRequestException;
9		use TgBotApi\BotApiBase\Type\UpdateType;
10
11		/**
12		* Class WebhookFetcher.
13		*/
14		class WebhookFetcher implements WebhookFetcherInterface
15		{
16		/**
17		* @var BotApiNormalizer
18		*/
19		private $normalizer;
20
21		/**
22		* WebhookFetcher constructor.
23		*
24		* @param NormalizerInterface $normalizer
25		*/
26	3	public function __construct(NormalizerInterface $normalizer)
27		{
28	3	$this->normalizer = $normalizer;
		0 ignored issues – show Documentation Bug introduced 2019-01-14 21:09 UTC by Report Bug Copy Issue Report `$normalizer` is of type `TgBotApi\BotApiBase\NormalizerInterface`, but the property `$normalizer` was declared to be of type `TgBotApi\BotApiBase\BotApiNormalizer`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
29	3	}
30
31		/**
32		* @param RequestInterface\|string $request
33		*
34		* @throws BadRequestException
35		*
36		* @return UpdateType
37		*/
38	3	public function fetch($request): UpdateType
39		{
40	3	$input = \json_decode($this->getContents($request));
41	3	if (!($input instanceof \stdClass)) {
42	1	throw new BadRequestException('Request content must be valid JSON object.');
43		}
44
45	2	return $this->normalizer->denormalize($input, UpdateType::class);
46		}
47
48		/**
49		* @param $request
50		*
51		* @throws BadRequestException
52		*
53		* @return string
54		*/
55	3	private function getContents($request): string
56		{
57	3	if ($request instanceof RequestInterface) {
58	2	return $request->getBody()->getContents();
59		}
60	1	if (\is_string($request)) {
61	1	return $request;
62		}
63		throw new BadRequestException('Request must be instance of Psr\Http\Message\RequestInterface or string.');
64		}
65		}
66

tg-bot-api / bot-api-base

Push — master ( 6ffd57...b56fef )

WebhookFetcher::getContents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like