TgBotApi\BotApiBase\Normalizer\SetMyCommandsNormalizer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	normalize()	0	10	1
A	__construct()	0	3	1
A	supportsNormalization()	0	3	1

<?php

declare(strict_types=1);

namespace TgBotApi\BotApiBase\Normalizer;

use Symfony\Component\Serializer\Exception\ExceptionInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
use Symfony\Component\Serializer\Serializer;
use TgBotApi\BotApiBase\Method\SetMyCommandsMethod;

class SetMyCommandsNormalizer implements NormalizerInterface
{
    /**
     * @var NormalizerInterface
     */
    private $objectNormalizer;

    /**
     * JsonSerializableNormalizer constructor.
     */
    public function __construct(NormalizerInterface $objectNormalizer)
    {
        $this->objectNormalizer = $objectNormalizer;
    }

    /**
     * @param SetMyCommandsMethod $topic
     * @param null                $format

Are you sure the doc-type for parameter $format is correct as it would always require null to be passed?

     *
     * @throws ExceptionInterface
     *
     * @return array|bool|false|float|int|string
     */
    public function normalize($topic, $format = null, array $context = [])
    {
        $serializer = new Serializer([
            new JsonSerializableNormalizer($this->objectNormalizer),
            $this->objectNormalizer,
        ]);

        $topic->commands = \json_encode($topic->commands);

It seems like json_encode($topic->commands) of type string is incompatible with the declared type TgBotApi\BotApiBase\Type\BotCommandType[] of property $commands.

        return $serializer->normalize($topic, null, ['skip_null_values' => true]);
    }

    /**
     * @param mixed $data
     * @param null  $format

Are you sure the doc-type for parameter $format is correct as it would always require null to be passed?

     */
    public function supportsNormalization($data, $format = null): bool
    {
        return $data instanceof SetMyCommandsMethod;
    }
}