InvoiceNormalizer::normalize() - Code Metrics - Inspection of "Bugfix/33" - tg-bot-api/bot-api-base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Nikolay

created 2020-05-27 21:11 UTC

InvoiceNormalizer::normalize() A

↳ Parent: InvoiceNormalizer

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	1	Features	1

Metric	Value
eloc	5
c	1
b	1
f	1
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	10
cc	1
nc	1
nop	3
crap	1

<?php

declare(strict_types=1);

namespace TgBotApi\BotApiBase\Normalizer;

use Symfony\Component\Serializer\Exception\ExceptionInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
use Symfony\Component\Serializer\Serializer;
use TgBotApi\BotApiBase\Method\SendInvoiceMethod;

class InvoiceNormalizer implements NormalizerInterface
{
    /**
     * @var NormalizerInterface
     */
    private $objectNormalizer;

    /**
     * JsonSerializableNormalizer constructor.
     */
    public function __construct(NormalizerInterface $objectNormalizer)
    {
        $this->objectNormalizer = $objectNormalizer;
    }

    /**
     * @param SendInvoiceMethod $topic
     * @param null              $format

     *
     * @throws ExceptionInterface
     *
     * @return array|bool|false|float|int|string
     */
    public function normalize($topic, $format = null, array $context = [])
    {
        $serializer = new Serializer([
            new JsonSerializableNormalizer($this->objectNormalizer),
            $this->objectNormalizer,
        ]);

        $topic->prices = \json_encode($serializer->normalize($topic->prices, null, ['skip_null_values' => true]));


        return $serializer->normalize($topic, null, ['skip_null_values' => true]);
    }

    /**
     * @param mixed $data
     * @param null  $format

     */
    public function supportsNormalization($data, $format = null): bool
    {
        return $data instanceof SendInvoiceMethod;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace TgBotApi\BotApiBase\Normalizer;
6
7		use Symfony\Component\Serializer\Exception\ExceptionInterface;
8		use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
9		use Symfony\Component\Serializer\Serializer;
10		use TgBotApi\BotApiBase\Method\SendInvoiceMethod;
11
12		class InvoiceNormalizer implements NormalizerInterface
13		{
14		/**
15		* @var NormalizerInterface
16		*/
17		private $objectNormalizer;
18
19		/**
20		* JsonSerializableNormalizer constructor.
21		*/
22	306	public function __construct(NormalizerInterface $objectNormalizer)
23		{
24	306	$this->objectNormalizer = $objectNormalizer;
25	306	}
26
27		/**
28		* @param SendInvoiceMethod $topic
29		* @param null $format
		0 ignored issues – show Documentation Bug introduced 2020-05-27 21:23 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$format` is correct as it would always require `null` to be passed? Loading history...
30		*
31		* @throws ExceptionInterface
32		*
33		* @return array\|bool\|false\|float\|int\|string
34		*/
35	3	public function normalize($topic, $format = null, array $context = [])
36		{
37	3	$serializer = new Serializer([
38	3	new JsonSerializableNormalizer($this->objectNormalizer),
39	3	$this->objectNormalizer,
40		]);
41
42	3	$topic->prices = \json_encode($serializer->normalize($topic->prices, null, ['skip_null_values' => true]));
		0 ignored issues – show Documentation Bug introduced 2020-05-27 21:23 UTC by Report Bug Copy Issue Report It seems like `json_encode($serializer-...null_values' => true)))` of type `string` is incompatible with the declared type `TgBotApi\BotApiBase\Type\LabeledPriceType[]` of property `$prices`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43
44	3	return $serializer->normalize($topic, null, ['skip_null_values' => true]);
45		}
46
47		/**
48		* @param mixed $data
49		* @param null $format
		0 ignored issues – show Documentation Bug introduced 2020-05-27 21:23 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$format` is correct as it would always require `null` to be passed? Loading history...
50		*/
51	303	public function supportsNormalization($data, $format = null): bool
52		{
53	303	return $data instanceof SendInvoiceMethod;
54		}
55		}
56

tg-bot-api / bot-api-base

Pull Request — master (#34)

InvoiceNormalizer::normalize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like