Pgsql - Code Metrics - Inspection of "Feature dbal" - tflori/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Thomas

created 2017-05-18 06:00 UTC

Pgsql A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	6
dl	0
loc	77
ccs	29
cts	29
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	insert()	15	3
B	describe()	24	3
A	getType()	8	2

<?php

namespace ORM\Dbal;

use ORM\Dbal;
use ORM\Exception;
use ORM\QueryBuilder\QueryBuilder;
use PDO;

/**
 * Database abstraction for PostgreSQL databases
 *
 * @package ORM\Dbal
 * @author  Thomas Flori <[email protected]>
 */
class Pgsql extends Dbal
{
    protected static $typeMapping = [
        'integer' => Type\Integer::class,
        'smallint' => Type\Integer::class,
        'bigint' => Type\Integer::class,

        'numeric' => Type\Double::class,
        'real' => Type\Double::class,
        'double precision' => Type\Double::class,
        'money' => Type\Double::class,

        'character varying' => Type\VarChar::class,
        'character' => Type\VarChar::class,

        'text' => Type\Text::class,

        'date' => Type\DateTime::class,
        'timestamp without time zone' => Type\DateTime::class,
        'timestamp with time zone' => Type\DateTime::class,
        'time without time zone' => Type\Time::class,
        'time with time zone' => Type\Time::class,

        'json' => Type\Json::class,
        'boolean' => Type\Boolean::class,
    ];

    public function insert($entity, $useAutoIncrement = true)
    {
        $statement = $this->buildInsertStatement($entity);
        $pdo = $this->em->getConnection();

        if ($useAutoIncrement && $entity::isAutoIncremented()) {
            $statement .= ' RETURNING ' . $entity::getColumnName($entity::getPrimaryKeyVars()[0]);
            $result = $pdo->query($statement);
            return $result->fetchColumn();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $pdo->query($statement);
        $this->em->sync($entity, true);
        return true;
    }

    public function describe($schemaTable)
    {
        $table = explode(static::$identifierDivider, $schemaTable);
        list($schema, $table) = count($table) === 2 ? $table : ['public', $table[0]];

        $query = new QueryBuilder('INFORMATION_SCHEMA.COLUMNS');
        $query->where('table_name', $table)->andWhere('table_schema', $schema);
        $query->columns([
            'column_name', 'column_default', 'data_type', 'is_nullable', 'character_maximum_length',
            'datetime_precision'
        ]);

        $result = $this->em->getConnection()->query($query->getQuery());
        $rawColumns = $result->fetchAll(PDO::FETCH_ASSOC);
        if (count($rawColumns) === 0) {
            throw new Exception('Unknown table '  . $schemaTable);
        }

        $cols = array_map(function ($columnDefinition) {
            return Column::factory($columnDefinition, $this->getType($columnDefinition));
        }, $rawColumns);

        return $cols;
    }

    protected function getType($columnDefinition)
    {
        if (isset(static::$typeMapping[$columnDefinition['data_type']])) {
            return call_user_func([static::$typeMapping[$columnDefinition['data_type']], 'factory'], $columnDefinition);
        }

        return parent::getType($columnDefinition);
    }
}


1		<?php
2
3		namespace ORM\Dbal;
4
5		use ORM\Dbal;
6		use ORM\Exception;
7		use ORM\QueryBuilder\QueryBuilder;
8		use PDO;
9
10		/**
11		* Database abstraction for PostgreSQL databases
12		*
13		* @package ORM\Dbal
14		* @author Thomas Flori <[email protected]>
15		*/
16		class Pgsql extends Dbal
17		{
18		protected static $typeMapping = [
19		'integer' => Type\Integer::class,
20		'smallint' => Type\Integer::class,
21		'bigint' => Type\Integer::class,
22
23		'numeric' => Type\Double::class,
24		'real' => Type\Double::class,
25		'double precision' => Type\Double::class,
26		'money' => Type\Double::class,
27
28		'character varying' => Type\VarChar::class,
29		'character' => Type\VarChar::class,
30
31		'text' => Type\Text::class,
32
33		'date' => Type\DateTime::class,
34		'timestamp without time zone' => Type\DateTime::class,
35		'timestamp with time zone' => Type\DateTime::class,
36		'time without time zone' => Type\Time::class,
37		'time with time zone' => Type\Time::class,
38
39		'json' => Type\Json::class,
40		'boolean' => Type\Boolean::class,
41		];
42
43	2	public function insert($entity, $useAutoIncrement = true)
44		{
45	2	$statement = $this->buildInsertStatement($entity);
46	2	$pdo = $this->em->getConnection();
47
48	2	if ($useAutoIncrement && $entity::isAutoIncremented()) {
49	1	$statement .= ' RETURNING ' . $entity::getColumnName($entity::getPrimaryKeyVars()[0]);
50	1	$result = $pdo->query($statement);
51	1	return $result->fetchColumn();
		0 ignored issues – show Bug Best Practice introduced 2017-05-18 06:03 UTC by Report Bug Copy Issue Report The return type of `return $result->fetchColumn();` (`string`) is incompatible with the return type of the parent method `ORM\Dbal::insert` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
52		}
53
54	1	$pdo->query($statement);
55	1	$this->em->sync($entity, true);
56	1	return true;
57		}
58
59	26	public function describe($schemaTable)
60		{
61	26	$table = explode(static::$identifierDivider, $schemaTable);
62	26	list($schema, $table) = count($table) === 2 ? $table : ['public', $table[0]];
63
64	26	$query = new QueryBuilder('INFORMATION_SCHEMA.COLUMNS');
65	26	$query->where('table_name', $table)->andWhere('table_schema', $schema);
66	26	$query->columns([
67	26	'column_name', 'column_default', 'data_type', 'is_nullable', 'character_maximum_length',
68		'datetime_precision'
69		]);
70
71	26	$result = $this->em->getConnection()->query($query->getQuery());
72	26	$rawColumns = $result->fetchAll(PDO::FETCH_ASSOC);
73	26	if (count($rawColumns) === 0) {
74	2	throw new Exception('Unknown table ' . $schemaTable);
75		}
76
77	24	$cols = array_map(function ($columnDefinition) {
78	24	return Column::factory($columnDefinition, $this->getType($columnDefinition));
79	24	}, $rawColumns);
80
81	24	return $cols;
82		}
83
84	24	protected function getType($columnDefinition)
85		{
86	24	if (isset(static::$typeMapping[$columnDefinition['data_type']])) {
87	17	return call_user_func([static::$typeMapping[$columnDefinition['data_type']], 'factory'], $columnDefinition);
88		}
89
90	7	return parent::getType($columnDefinition);
91		}
92		}
93

tflori / orm

Pull Request — master (#36)

Pgsql A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like