InListGuard::validateTraversableList() - Code Metrics - Inspection of "Refactoring InListGuard for smaller methods." - tfettig01/InputGuard - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 46a3b3...1cc59e )

by Travis

created 2019-04-17 03:02 UTC

InListGuard::validateTraversableList() A

↳ Parent: InListGuard

Complexity

Conditions	4
Paths	6

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	6
nop	1
dl	0
loc	18
ccs	10
cts	10
cp	1
crap	4
rs	9.9666
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace InputGuard\Guards;

use ArrayObject;
use InputGuard\Guards\Bases\SingleInput;
use InputGuard\Guards\Bases\Strict;

class InListGuard implements Guard
{
    use ErrorMessagesBase;
    use SingleInput;
    use Strict;

    /**
     * @var iterable
     */
    private $list;

    /**
     * InListVal constructor.
     *
     * @param mixed      $input
     * @param iterable   $list
     * @param mixed|null $defaultValue
     * @param bool       $defaultStrict
     *
     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
     */
    public function __construct($input, iterable $list, $defaultValue = null, bool $defaultStrict = true)
    {
        $this->input  = $input;
        $this->list   = $list;
        $this->value  = $defaultValue;
        $this->strict = $defaultStrict;
    }

    public function value()
    {
        $this->success();

        return $this->value;
    }

    protected function validation($input, &$value): bool
    {
        if ($this->isCastable() ? $this->validateCastableList($input) : $this->validateTraversableList($input)) {

            $value = $input;
            return true;
        }

        return false;
    }

    private function isCastable(): bool
    {
        return \is_array($this->list) || $this->list instanceof ArrayObject;
    }

    private function validateCastableList($input): bool
    {
        return \in_array($input, (array)$this->list, $this->strict);
    }

    private function validateTraversableList($input): bool
    {
        $validate = $this->strict
            ? static function ($value) use ($input): bool {

                return $value === $input;
            }
            : static function ($value) use ($input): bool {
                /** @noinspection TypeUnsafeComparisonInspection */
                return $value == $input;
            };

        foreach ($this->list as $item) {
            if ($validate($item)) {
                return true;
            }
        }

        return false;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace InputGuard\Guards;
5
6		use ArrayObject;
7		use InputGuard\Guards\Bases\SingleInput;
8		use InputGuard\Guards\Bases\Strict;
9
10		class InListGuard implements Guard
11		{
12		use ErrorMessagesBase;
13		use SingleInput;
14		use Strict;
15
16		/**
17		* @var iterable
18		*/
19		private $list;
20
21		/**
22		* InListVal constructor.
23		*
24		* @param mixed $input
25		* @param iterable $list
26		* @param mixed\|null $defaultValue
27		* @param bool $defaultStrict
28		*
29		* @SuppressWarnings(PHPMD.BooleanArgumentFlag)
30		*/
31	17	public function __construct($input, iterable $list, $defaultValue = null, bool $defaultStrict = true)
32		{
33	17	$this->input = $input;
34	17	$this->list = $list;
35	17	$this->value = $defaultValue;
36	17	$this->strict = $defaultStrict;
37	17	}
38
39	17	public function value()
40		{
41	17	$this->success();
42
43	17	return $this->value;
44		}
45
46	17	protected function validation($input, &$value): bool
47		{
48	17	if ($this->isCastable() ? $this->validateCastableList($input) : $this->validateTraversableList($input)) {
		0 ignored issues – show Coding Style introduced 2019-04-17 03:04 UTC by Report Bug Copy Issue Report Inline IF statements are not allowed Loading history...
49	8	$value = $input;
50	8	return true;
51		}
52
53	9	return false;
54		}
55
56	17	private function isCastable(): bool
57		{
58	17	return \is_array($this->list) \|\| $this->list instanceof ArrayObject;
59		}
60
61	12	private function validateCastableList($input): bool
62		{
63	12	return \in_array($input, (array)$this->list, $this->strict);
64		}
65
66	5	private function validateTraversableList($input): bool
67		{
68	5	$validate = $this->strict
69		? static function ($value) use ($input): bool {
		0 ignored issues – show Coding Style introduced 2019-04-17 03:04 UTC by Report Bug Copy Issue Report Inline IF statements are not allowed Loading history...
70	3	return $value === $input;
71	3	}
72		: static function ($value) use ($input): bool {
73		/** @noinspection TypeUnsafeComparisonInspection */
74	2	return $value == $input;
75	5	};
76
77	5	foreach ($this->list as $item) {
78	5	if ($validate($item)) {
79	5	return true;
80		}
81		}
82
83	3	return false;
84		}
85		}
86

tfettig01 / InputGuard

Push — master ( 46a3b3...1cc59e )

InListGuard::validateTraversableList() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like