Issues in LoadingServiceTest.php (master) - Issues in master - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (457)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Unit/Service/LoadingServiceTest.php (25 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 1/3/18
 * Time: 3:53 PM
 */

namespace Tfboe\FmLib\Tests\Unit\Service;

use Doctrine\Common\Collections\AbstractLazyCollection;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\EntityManagerInterface;
use Tfboe\FmLib\Entity\CompetitionInterface;
use Tfboe\FmLib\Entity\GameInterface;
use Tfboe\FmLib\Entity\PhaseInterface;
use Tfboe\FmLib\Entity\TournamentInterface;
use Tfboe\FmLib\Service\LoadingService;
use Tfboe\FmLib\Tests\Helpers\UnitTestCase;


/**
 * Class LoadingServiceTest
 * @package Tfboe\FmLib\Tests\Unit\Service
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class LoadingServiceTest extends UnitTestCase
{
//<editor-fold desc="Public Methods">
  /**
   * @covers \Tfboe\FmLib\Service\LoadingService::__construct
   */
  public function testConstruct()

  {
    /** @var EntityManagerInterface $entityManager */
    $entityManager = $this->getMockForAbstractClass(EntityManagerInterface::class);
    $service = new LoadingService($entityManager);
    self::assertInstanceOf(LoadingService::class, $service);
    /** @noinspection PhpUnhandledExceptionInspection */
    self::assertEquals($entityManager, self::getProperty(get_class($service), 'em')->getValue($service));
  }

  /**
   * @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
   * @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
   * @uses   \Tfboe\FmLib\Service\LoadingService::__construct
   */
  public function testLoadEntitiesAlreadyLoaded()
  {
    $service = new LoadingService($this->getEntityManagerMockForQueries([]));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    $tournament = $this->createMock(TournamentInterface::class);
    $tournament->method('getEntityId')->willReturn('t');

    $initializedCollection = new ArrayCollection();
    $initializedCollection->__isInitialized__ = true;

    $tournament->method('getCompetitions')->willReturn($initializedCollection);

    $service->loadEntities([$tournament], [TournamentInterface::class => [["competitions"]]]);
  }

  /**
   * @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
   * @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
   * @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
   * @uses   \Tfboe\FmLib\Service\LoadingService::__construct
   */
  public function testLoadEntitiesDefaultPropertiesGame()
  {
    $service = new LoadingService($this->getEntityManagerMockForQuery([],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      'SELECT t1, t2, t3 FROM Tfboe\FmLib\Entity\GameInterface t1 LEFT JOIN t1.playersA t2 LEFT JOIN '
      . 't1.playersB t3 WHERE t1.id IN(\'g\')'
    ));
    $game = $this->createMock(GameInterface::class);
    $game->method('getEntityId')->willReturn('g');


    $uninitializedLazyCollection = $this->createMock(AbstractLazyCollection::class);
    $uninitializedLazyCollection->method('isInitialized')->willReturn(false);


    $game->expects(self::exactly(2))->method('getPlayersA')->willReturnOnConsecutiveCalls($uninitializedLazyCollection,
      new ArrayCollection());
    $game->expects(self::once())->method('getPlayersB')->willReturn(new ArrayCollection());
    $service->loadEntities([$game]);
  }

  /**
   * @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
   * @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
   * @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
   * @uses   \Tfboe\FmLib\Service\LoadingService::__construct
   */
  public function testLoadEntitiesMultipleLevels()
  {
    $tournament = $this->createMock(TournamentInterface::class);
    $tournament->method('getEntityId')->willReturn('t');


    $competition1 = $this->createMock(CompetitionInterface::class);
    $competition1->method('getEntityId')->willReturn('c1');


    $competition2 = $this->createMock(CompetitionInterface::class);
    $competition2->method('getEntityId')->willReturn('c1');


    $uninitializedLazyCollection = $this->createMock(AbstractLazyCollection::class);
    $uninitializedLazyCollection->method('isInitialized')->willReturn(false);


    $tournament->method('getCompetitions')->willReturnOnConsecutiveCalls(

      $uninitializedLazyCollection,
      new ArrayCollection([$competition1, $competition2])
    );

    $phase1 = $this->createMock(PhaseInterface::class);
    $phase1->method('getEntityId')->willReturn('p1');


    $competition1->method('getPhases')->willReturn(new ArrayCollection([$phase1]));


    $phase2 = $this->createMock(PhaseInterface::class);
    $phase2->method('getEntityId')->willReturn('p2');


    $competition2->method('getPhases')->willReturn(new ArrayCollection([$phase2]));


    $entityManager = $this->getEntityManagerMockForQueries([[], []], [
      'SELECT t1, t2 FROM Tfboe\FmLib\Entity\TournamentInterface t1 LEFT JOIN t1.competitions t2 WHERE t1.id IN(\'t\')',
      'SELECT t1, t2 FROM Tfboe\FmLib\Entity\CompetitionInterface t1 LEFT JOIN t1.phases t2 WHERE t1.id IN(\'c1\')'
    ]);

    $service = new LoadingService($entityManager);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    $service->loadEntities([$tournament], [
      TournamentInterface::class => [["competitions"]],
      CompetitionInterface::class => [["phases"]]
    ]);
  }

  /**
   * @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
   * @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
   * @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
   * @uses   \Tfboe\FmLib\Service\LoadingService::__construct
   */
  public function testLoadEntitiesNullProperty()

  {
    $service = new LoadingService($this->getEntityManagerMockForQuery([],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      'SELECT t1, t2 FROM Tfboe\FmLib\Entity\TournamentInterface t1 LEFT JOIN t1.competitions t2 WHERE t1.id IN(\'t\')'
    ));
    $tournament = $this->createMock(TournamentInterface::class);
    $tournament->method('getEntityId')->willReturn('t');

    $tournament->method('getCompetitions')->willReturn(null);

    $service->loadEntities([$tournament], [TournamentInterface::class => [["competitions"]]]);
  }

  /**
   * @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
   * @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
   * @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
   * @uses   \Tfboe\FmLib\Service\LoadingService::__construct
   */
  public function testLoadEntitiesSimpleProperty()

  {
    $service = new LoadingService($this->getEntityManagerMockForQuery([],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      'SELECT t1, t2 FROM Tfboe\FmLib\Entity\CompetitionInterface t1 LEFT JOIN t1.tournament t2 WHERE t1.id IN(\'c\')'
    ));
    $competition = $this->createMock(CompetitionInterface::class);
    $competition->method('getEntityId')->willReturn('c');

    $service->loadEntities([$competition], [CompetitionInterface::class => [["tournament"]]]);
  }
//</editor-fold desc="Public Methods">
}

1		<?php
2		declare(strict_types=1);
3		/**
4		* Created by PhpStorm.
5		* User: benedikt
6		* Date: 1/3/18
7		* Time: 3:53 PM
8		*/
9
10		namespace Tfboe\FmLib\Tests\Unit\Service;
11
12		use Doctrine\Common\Collections\AbstractLazyCollection;
13		use Doctrine\Common\Collections\ArrayCollection;
14		use Doctrine\ORM\EntityManagerInterface;
15		use Tfboe\FmLib\Entity\CompetitionInterface;
16		use Tfboe\FmLib\Entity\GameInterface;
17		use Tfboe\FmLib\Entity\PhaseInterface;
18		use Tfboe\FmLib\Entity\TournamentInterface;
19		use Tfboe\FmLib\Service\LoadingService;
20		use Tfboe\FmLib\Tests\Helpers\UnitTestCase;
21
22
23		/**
24		* Class LoadingServiceTest
25		* @package Tfboe\FmLib\Tests\Unit\Service
26		* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
27		*/
28		class LoadingServiceTest extends UnitTestCase
29		{
30		//<editor-fold desc="Public Methods">
31		/**
32		* @covers \Tfboe\FmLib\Service\LoadingService::__construct
33		*/
34	View Code Duplication	public function testConstruct()
		0 ignored issues – show Duplication introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		/** @var EntityManagerInterface $entityManager */
37		$entityManager = $this->getMockForAbstractClass(EntityManagerInterface::class);
38		$service = new LoadingService($entityManager);
39		self::assertInstanceOf(LoadingService::class, $service);
40		/** @noinspection PhpUnhandledExceptionInspection */
41		self::assertEquals($entityManager, self::getProperty(get_class($service), 'em')->getValue($service));
42		}
43
44		/**
45		* @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
46		* @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
47		* @uses \Tfboe\FmLib\Service\LoadingService::__construct
48		*/
49		public function testLoadEntitiesAlreadyLoaded()
50		{
51		$service = new LoadingService($this->getEntityManagerMockForQueries([]));
		0 ignored issues – show Documentation introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getEntityManagerMockForQueries(array())` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52
53		$tournament = $this->createMock(TournamentInterface::class);
54		$tournament->method('getEntityId')->willReturn('t');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
55		$initializedCollection = new ArrayCollection();
56		$initializedCollection->__isInitialized__ = true;
		0 ignored issues – show Bug introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `__isInitialized__` does not seem to exist in `Doctrine\Common\Collections\ArrayCollection`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
57		$tournament->method('getCompetitions')->willReturn($initializedCollection);
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
58		$service->loadEntities([$tournament], [TournamentInterface::class => [["competitions"]]]);
59		}
60
61		/**
62		* @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
63		* @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
64		* @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
65		* @uses \Tfboe\FmLib\Service\LoadingService::__construct
66		*/
67		public function testLoadEntitiesDefaultPropertiesGame()
68		{
69		$service = new LoadingService($this->getEntityManagerMockForQuery([],
		0 ignored issues – show Documentation introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getEntityManagerM...WHERE t1.id IN(\'g\')')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70		'SELECT t1, t2, t3 FROM Tfboe\FmLib\Entity\GameInterface t1 LEFT JOIN t1.playersA t2 LEFT JOIN '
71		. 't1.playersB t3 WHERE t1.id IN(\'g\')'
72		));
73		$game = $this->createMock(GameInterface::class);
74		$game->method('getEntityId')->willReturn('g');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
75
76		$uninitializedLazyCollection = $this->createMock(AbstractLazyCollection::class);
77		$uninitializedLazyCollection->method('isInitialized')->willReturn(false);
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
78
79		$game->expects(self::exactly(2))->method('getPlayersA')->willReturnOnConsecutiveCalls($uninitializedLazyCollection,
80		new ArrayCollection());
81		$game->expects(self::once())->method('getPlayersB')->willReturn(new ArrayCollection());
82		$service->loadEntities([$game]);
83		}
84
85		/**
86		* @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
87		* @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
88		* @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
89		* @uses \Tfboe\FmLib\Service\LoadingService::__construct
90		*/
91		public function testLoadEntitiesMultipleLevels()
92		{
93		$tournament = $this->createMock(TournamentInterface::class);
94		$tournament->method('getEntityId')->willReturn('t');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
95
96		$competition1 = $this->createMock(CompetitionInterface::class);
97		$competition1->method('getEntityId')->willReturn('c1');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
98
99		$competition2 = $this->createMock(CompetitionInterface::class);
100		$competition2->method('getEntityId')->willReturn('c1');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
101
102		$uninitializedLazyCollection = $this->createMock(AbstractLazyCollection::class);
103		$uninitializedLazyCollection->method('isInitialized')->willReturn(false);
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
104
105		$tournament->method('getCompetitions')->willReturnOnConsecutiveCalls(
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
106		$uninitializedLazyCollection,
107		new ArrayCollection([$competition1, $competition2])
108		);
109
110		$phase1 = $this->createMock(PhaseInterface::class);
111		$phase1->method('getEntityId')->willReturn('p1');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
112
113		$competition1->method('getPhases')->willReturn(new ArrayCollection([$phase1]));
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
114
115		$phase2 = $this->createMock(PhaseInterface::class);
116		$phase2->method('getEntityId')->willReturn('p2');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
117
118		$competition2->method('getPhases')->willReturn(new ArrayCollection([$phase2]));
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
119
120		$entityManager = $this->getEntityManagerMockForQueries([[], []], [
121		'SELECT t1, t2 FROM Tfboe\FmLib\Entity\TournamentInterface t1 LEFT JOIN t1.competitions t2 WHERE t1.id IN(\'t\')',
122		'SELECT t1, t2 FROM Tfboe\FmLib\Entity\CompetitionInterface t1 LEFT JOIN t1.phases t2 WHERE t1.id IN(\'c1\')'
123		]);
124
125		$service = new LoadingService($entityManager);
		0 ignored issues – show Documentation introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$entityManager` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
126		$service->loadEntities([$tournament], [
127		TournamentInterface::class => [["competitions"]],
128		CompetitionInterface::class => [["phases"]]
129		]);
130		}
131
132		/**
133		* @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
134		* @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
135		* @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
136		* @uses \Tfboe\FmLib\Service\LoadingService::__construct
137		*/
138	View Code Duplication	public function testLoadEntitiesNullProperty()
		0 ignored issues – show Duplication introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		{
140		$service = new LoadingService($this->getEntityManagerMockForQuery([],
		0 ignored issues – show Documentation introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getEntityManagerM...WHERE t1.id IN(\'t\')')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
141		'SELECT t1, t2 FROM Tfboe\FmLib\Entity\TournamentInterface t1 LEFT JOIN t1.competitions t2 WHERE t1.id IN(\'t\')'
142		));
143		$tournament = $this->createMock(TournamentInterface::class);
144		$tournament->method('getEntityId')->willReturn('t');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
145		$tournament->method('getCompetitions')->willReturn(null);
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
146		$service->loadEntities([$tournament], [TournamentInterface::class => [["competitions"]]]);
147		}
148
149		/**
150		* @covers \Tfboe\FmLib\Service\LoadingService::loadEntities
151		* @covers \Tfboe\FmLib\Service\LoadingService::loadProperties
152		* @covers \Tfboe\FmLib\Service\LoadingService::keyOfPropertyMap
153		* @uses \Tfboe\FmLib\Service\LoadingService::__construct
154		*/
155	View Code Duplication	public function testLoadEntitiesSimpleProperty()
		0 ignored issues – show Duplication introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
156		{
157		$service = new LoadingService($this->getEntityManagerMockForQuery([],
		0 ignored issues – show Documentation introduced 2018-06-17 13:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getEntityManagerM...WHERE t1.id IN(\'c\')')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
158		'SELECT t1, t2 FROM Tfboe\FmLib\Entity\CompetitionInterface t1 LEFT JOIN t1.tournament t2 WHERE t1.id IN(\'c\')'
159		));
160		$competition = $this->createMock(CompetitionInterface::class);
161		$competition->method('getEntityId')->willReturn('c');
		0 ignored issues – show Bug introduced 2020-01-01 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
162		$service->loadEntities([$competition], [CompetitionInterface::class => [["tournament"]]]);
163		}
164		//</editor-fold desc="Public Methods">
165		}

tfboe / fm-lib

Issues (457)

Security Analysis not enabled

tests/Unit/Service/LoadingServiceTest.php (25 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like