Issues in EloRanking.php (master) - Issues in master - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (457)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Service/RankingSystem/EloRanking.php (9 issues)

Labels

Bug 9

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 3/7/17
 * Time: 4:31 PM
 */

namespace Tfboe\FmLib\Service\RankingSystem;

use Doctrine\Common\Collections\Collection;
use Tfboe\FmLib\Entity\GameInterface;
use Tfboe\FmLib\Entity\Helpers\Result;
use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity;
use Tfboe\FmLib\Entity\PlayerInterface;
use Tfboe\FmLib\Entity\RankingSystemChangeInterface;
use Tfboe\FmLib\Entity\RankingSystemInterface;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Tfboe\FmLib\Entity\RankingSystemListEntryInterface;
use Tfboe\FmLib\Entity\RankingSystemListInterface;

/**
 * Class EloRanking
 * @package Tfboe\FmLib\Service\TournamentRanking
 */
class EloRanking extends GameRankingSystemService implements EloRankingInterface
{
//<editor-fold desc="Fields">
  const EXP_DIFF = 400;
  const K = 20;
  const MAX_DIFF_TO_OPPONENT_FOR_PROVISORY = 400;
  const NO_NEG = true;
  const NUM_PROVISORY_GAMES = 20;
  const PROVISORY_PARTNER_FACTOR = 0.5;
  const START = 1200.0;
//</editor-fold desc="Fields">

//<editor-fold desc="Protected Methods">
  /**
   * Gets additional fields for this ranking type
   * @return string[] list of additional fields
   */
  protected function getAdditionalFields(): array
  {
    return ['playedGames' => 0, 'ratedGames' => 0, 'provisoryRanking' => self::START];
  }

  /**
   * @inheritDoc
   */
  protected function getChanges(TournamentHierarchyEntity $entity, RankingSystemListInterface $list): array
  {
    /** @var GameInterface $game */
    $game = $entity;
    $changes = [];

    if (!$game->isPlayed() || $game->getResult() === Result::NOT_YET_FINISHED ||
      $game->getResult() === Result::NULLED) {
      //game gets not elo rated
      $this->addNotRatedChanges($changes, $game->getPlayersA(), $entity, $list->getRankingSystem());

      $this->addNotRatedChanges($changes, $game->getPlayersB(), $entity, $list->getRankingSystem());

      return $changes;
    }

    $entriesA = $this->getEntriesOfPlayers($game->getPlayersA(), $list);

    $entriesB = $this->getEntriesOfPlayers($game->getPlayersB(), $list);


    $isAProvisory = $this->hasProvisoryEntry($entriesA);
    $isBProvisory = $this->hasProvisoryEntry($entriesB);

    $averageA = $this->getEloAverage($entriesA);
    $averageB = $this->getEloAverage($entriesB);

    $expectationA = 1 / (1 + 10 ** (($averageB - $averageA) / self::EXP_DIFF));
    $expectationB = 1 - $expectationA;

    $resultA = 0.0;

    switch ($game->getResult()) {
      case Result::TEAM_A_WINS:
        $resultA = 1.0;
        break;
      case Result::DRAW:
        $resultA = 0.5;
        break;
    }
    $resultB = 1 - $resultA;

    $expectationDiffA = $resultA - $expectationA;
    $expectationDiffB = $resultB - $expectationB;


    $this->computeChanges($changes, $entriesA, $resultA, $expectationDiffA, $game, $averageA, $averageB,
      $isAProvisory, $isBProvisory);
    $this->computeChanges($changes, $entriesB, $resultB, $expectationDiffB, $game, $averageB, $averageA,
      $isBProvisory, $isAProvisory);
    return $changes;
  }

  /** @noinspection PhpMissingParentCallCommonInspection */
  /**
   * @inheritDoc
   */
  protected function startPoints(): float
  {
    return 0.0;
  }
//</editor-fold desc="Protected Methods">


//<editor-fold desc="Private Methods">
  /**
   * @param RankingSystemChangeInterface[] $changes
   * @param Collection|PlayerInterface[] $players
   * @param TournamentHierarchyEntity $entity
   * @param RankingSystemInterface $ranking
   */
  private function addNotRatedChanges(array &$changes, Collection $players, TournamentHierarchyEntity $entity,
                                      RankingSystemInterface $ranking)
  {
    foreach ($players as $player) {
      $change = $this->getOrCreateChange($entity, $ranking, $player);
      $change->setTeamElo(0.0);

      $change->setOpponentElo(0.0);

      $change->setPointsChange(0.0);
      $change->setPlayedGames(0);
      $change->setRatedGames(0);
      $change->setProvisoryRanking(0.0);
      $changes[] = $change;
    }
  }

  /**
   * @inheritDoc
   */
  protected function getAdditionalChangeFields(): array
  {
    return ['teamElo', 'opponentElo'];
  }

  /** @noinspection PhpTooManyParametersInspection */ //TODO refactor this method
  /**
   * @param array $changes
   * @param RankingSystemListEntryInterface[] $entries
   * @param float $result
   * @param float $expectationDiff
   * @param GameInterface $game
   * @param float $teamAverage
   * @param float $opponentAverage
   * @param bool $teamHasProvisory
   * @param bool $opponentHasProvisory
   */
  private function computeChanges(array &$changes, array $entries, float $result, float $expectationDiff,
                                  GameInterface $game, float $teamAverage, float $opponentAverage,
                                  bool $teamHasProvisory, bool $opponentHasProvisory)
  {
    foreach ($entries as $entry) {
      $change = $this->getOrCreateChange($game, $entry->getRankingSystemList()->getRankingSystem(),
        $entry->getPlayer());
      $change->setPlayedGames(1);
      $change->setTeamElo($teamHasProvisory ? 0.0 : $teamAverage);

      $change->setOpponentElo($opponentHasProvisory ? 0.0 : $opponentAverage);

      $factor = 2 * $result - 1;
      if ($entry->getPlayedGames() < self::NUM_PROVISORY_GAMES) {
        //provisory entry => recalculate
        if (count($entries) > 1) {
          $teamMatesAverage = ($teamAverage * count($entries) - $entry->getProvisoryRanking()) /
            (count($entries) - 1);
          if ($teamMatesAverage > $opponentAverage + self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY) {
            $teamMatesAverage = $opponentAverage + self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY;
          }
          if ($teamMatesAverage < $opponentAverage - self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY) {
            $teamMatesAverage = $opponentAverage - self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY;
          }
          $performance = $opponentAverage * (1 + self::PROVISORY_PARTNER_FACTOR) -
            $teamMatesAverage * self::PROVISORY_PARTNER_FACTOR;
        } else {
          $performance = $opponentAverage;
        }
        if ($performance < self::START) {
          $performance = self::START;
        }
        $performance += self::EXP_DIFF * $factor;
        //old average performance = $entry->getProvisoryRating()
        //=> new average performance = ($entry->getProvisoryRating() * $entry->getRatedGames() + $performance) /
        //                             ($entry->getRatedGames() + 1)
        //=> performance change = ($entry->getProvisoryRating() * $entry->getRatedGames() + $performance) /
        //                        ($entry->getRatedGames() + 1) - $entry->getProvisoryRating()
        //                      = ($performance - $entry->getProvisoryRating()) / ($entry->getRatedGames() + 1)
        $change->setProvisoryRanking(($performance - $entry->getProvisoryRanking()) / ($entry->getRatedGames() + 1));
        $change->setPointsChange(0.0);
        $change->setRatedGames(1);
        if ($entry->getPlayedGames() == self::NUM_PROVISORY_GAMES - 1) {
          $change->setPointsChange(max(self::START, $entry->getProvisoryRanking() + $change->getProvisoryRanking())
            - $entry->getPoints());
        }
      } else if (!$teamHasProvisory && !$opponentHasProvisory) {
        //real elo ranking
        $change->setProvisoryRanking(0.0);
        $change->setPointsChange(max(self::K * $expectationDiff, self::START - $entry->getPoints()));
        $change->setRatedGames(1);

      } else {
        //does not get rated
        $change->setProvisoryRanking(0.0);
        $change->setPointsChange(0.0);
        $change->setRatedGames(0);
      }
      $changes[] = $change;
    }
  }

  /**
   * Computes the average rating of the given entries
   * @param RankingSystemListEntryInterface[] $entries must be nonempty
   * @return float
   */
  private function getEloAverage(array $entries): float
  {
    $sum = 0;
    foreach ($entries as $entry) {
      $sum += $entry->getRatedGames() < self::NUM_PROVISORY_GAMES ? $entry->getProvisoryRanking() : $entry->getPoints();
    }
    return $sum / count($entries);
  }

  /**
   * Checks if the given list of entries has at least one provisory entry
   * @param RankingSystemListEntryInterface[] $entries
   * @return bool
   */
  private function hasProvisoryEntry(array $entries): bool
  {
    foreach ($entries as $entry) {
      if ($entry->getPlayedGames() < self::NUM_PROVISORY_GAMES) {
        return true;
      }
    }
    return false;
  }
//</editor-fold desc="Private Methods">
}

1			<?php
2			declare(strict_types=1);
3			/**
4			* Created by PhpStorm.
5			* User: benedikt
6			* Date: 3/7/17
7			* Time: 4:31 PM
8			*/
9
10			namespace Tfboe\FmLib\Service\RankingSystem;
11
12			use Doctrine\Common\Collections\Collection;
13			use Tfboe\FmLib\Entity\GameInterface;
14			use Tfboe\FmLib\Entity\Helpers\Result;
15			use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity;
16			use Tfboe\FmLib\Entity\PlayerInterface;
17			use Tfboe\FmLib\Entity\RankingSystemChangeInterface;
18			use Tfboe\FmLib\Entity\RankingSystemInterface;
			0 ignored issues – show Bug introduced 2018-01-31 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Tfboe\FmLib\Service\Rank...\RankingSystemInterface`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
19			use Tfboe\FmLib\Entity\RankingSystemListEntryInterface;
20			use Tfboe\FmLib\Entity\RankingSystemListInterface;
21
22			/**
23			* Class EloRanking
24			* @package Tfboe\FmLib\Service\TournamentRanking
25			*/
26			class EloRanking extends GameRankingSystemService implements EloRankingInterface
27			{
28			//<editor-fold desc="Fields">
29			const EXP_DIFF = 400;
30			const K = 20;
31			const MAX_DIFF_TO_OPPONENT_FOR_PROVISORY = 400;
32			const NO_NEG = true;
33			const NUM_PROVISORY_GAMES = 20;
34			const PROVISORY_PARTNER_FACTOR = 0.5;
35			const START = 1200.0;
36			//</editor-fold desc="Fields">
37
38			//<editor-fold desc="Protected Methods">
39			/**
40			* Gets additional fields for this ranking type
41			* @return string[] list of additional fields
42			*/
43			protected function getAdditionalFields(): array
44			{
45			return ['playedGames' => 0, 'ratedGames' => 0, 'provisoryRanking' => self::START];
46			}
47
48			/**
49			* @inheritDoc
50			*/
51			protected function getChanges(TournamentHierarchyEntity $entity, RankingSystemListInterface $list): array
52			{
53			/** @var GameInterface $game */
54			$game = $entity;
55			$changes = [];
56
57			if (!$game->isPlayed() \|\| $game->getResult() === Result::NOT_YET_FINISHED \|\|
58			$game->getResult() === Result::NULLED) {
59			//game gets not elo rated
60			$this->addNotRatedChanges($changes, $game->getPlayersA(), $entity, $list->getRankingSystem());
			0 ignored issues – show Bug introduced 2018-01-31 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$game->getPlayersA()` targeting `Tfboe\FmLib\Entity\GameInterface::getPlayersA()` can also be of type `array<integer,object<Tfb...ntity\PlayerInterface>>`; however, `Tfboe\FmLib\Service\Rank...g::addNotRatedChanges()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
61			$this->addNotRatedChanges($changes, $game->getPlayersB(), $entity, $list->getRankingSystem());
			0 ignored issues – show Bug introduced 2018-01-31 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$game->getPlayersB()` targeting `Tfboe\FmLib\Entity\GameInterface::getPlayersB()` can also be of type `array<integer,object<Tfb...ntity\PlayerInterface>>`; however, `Tfboe\FmLib\Service\Rank...g::addNotRatedChanges()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
62			return $changes;
63			}
64
65			$entriesA = $this->getEntriesOfPlayers($game->getPlayersA(), $list);
			0 ignored issues – show Bug introduced 2018-01-31 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$game->getPlayersA()` targeting `Tfboe\FmLib\Entity\GameInterface::getPlayersA()` can also be of type `array<integer,object<Tfb...ntity\PlayerInterface>>`; however, `Tfboe\FmLib\Service\Rank...::getEntriesOfPlayers()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
66			$entriesB = $this->getEntriesOfPlayers($game->getPlayersB(), $list);
			0 ignored issues – show Bug introduced 2018-01-31 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$game->getPlayersB()` targeting `Tfboe\FmLib\Entity\GameInterface::getPlayersB()` can also be of type `array<integer,object<Tfb...ntity\PlayerInterface>>`; however, `Tfboe\FmLib\Service\Rank...::getEntriesOfPlayers()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
67
68			$isAProvisory = $this->hasProvisoryEntry($entriesA);
69			$isBProvisory = $this->hasProvisoryEntry($entriesB);
70
71			$averageA = $this->getEloAverage($entriesA);
72			$averageB = $this->getEloAverage($entriesB);
73
74			$expectationA = 1 / (1 + 10 ** (($averageB - $averageA) / self::EXP_DIFF));
75			$expectationB = 1 - $expectationA;
76
77			$resultA = 0.0;
78
79			switch ($game->getResult()) {
80			case Result::TEAM_A_WINS:
81			$resultA = 1.0;
82			break;
83			case Result::DRAW:
84			$resultA = 0.5;
85			break;
86			}
87			$resultB = 1 - $resultA;
88
89			$expectationDiffA = $resultA - $expectationA;
90			$expectationDiffB = $resultB - $expectationB;
91
92
93			$this->computeChanges($changes, $entriesA, $resultA, $expectationDiffA, $game, $averageA, $averageB,
94			$isAProvisory, $isBProvisory);
95			$this->computeChanges($changes, $entriesB, $resultB, $expectationDiffB, $game, $averageB, $averageA,
96			$isBProvisory, $isAProvisory);
97			return $changes;
98			}
99
100			/** @noinspection PhpMissingParentCallCommonInspection */
101			/**
102			* @inheritDoc
103			*/
104			protected function startPoints(): float
105			{
106			return 0.0;
107			}
108			//</editor-fold desc="Protected Methods">
109
110
111			//<editor-fold desc="Private Methods">
112			/**
113			* @param RankingSystemChangeInterface[] $changes
114			* @param Collection\|PlayerInterface[] $players
115			* @param TournamentHierarchyEntity $entity
116			* @param RankingSystemInterface $ranking
117			*/
118			private function addNotRatedChanges(array &$changes, Collection $players, TournamentHierarchyEntity $entity,
119			RankingSystemInterface $ranking)
120			{
121			foreach ($players as $player) {
122			$change = $this->getOrCreateChange($entity, $ranking, $player);
123			$change->setTeamElo(0.0);
			0 ignored issues – show Bug introduced 2018-06-26 21:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setTeamElo()` does not seem to exist on `object<Tfboe\FmLib\Entit...gSystemChangeInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
124			$change->setOpponentElo(0.0);
			0 ignored issues – show Bug introduced 2018-06-26 21:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setOpponentElo()` does not seem to exist on `object<Tfboe\FmLib\Entit...gSystemChangeInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
125			$change->setPointsChange(0.0);
126			$change->setPlayedGames(0);
127			$change->setRatedGames(0);
128			$change->setProvisoryRanking(0.0);
129			$changes[] = $change;
130			}
131			}
132
133			/**
134			* @inheritDoc
135			*/
136			protected function getAdditionalChangeFields(): array
137			{
138			return ['teamElo', 'opponentElo'];
139			}
140
141			/** @noinspection PhpTooManyParametersInspection */ //TODO refactor this method
142			/**
143			* @param array $changes
144			* @param RankingSystemListEntryInterface[] $entries
145			* @param float $result
146			* @param float $expectationDiff
147			* @param GameInterface $game
148			* @param float $teamAverage
149			* @param float $opponentAverage
150			* @param bool $teamHasProvisory
151			* @param bool $opponentHasProvisory
152			*/
153			private function computeChanges(array &$changes, array $entries, float $result, float $expectationDiff,
154			GameInterface $game, float $teamAverage, float $opponentAverage,
155			bool $teamHasProvisory, bool $opponentHasProvisory)
156			{
157			foreach ($entries as $entry) {
158			$change = $this->getOrCreateChange($game, $entry->getRankingSystemList()->getRankingSystem(),
159			$entry->getPlayer());
160			$change->setPlayedGames(1);
161			$change->setTeamElo($teamHasProvisory ? 0.0 : $teamAverage);
			0 ignored issues – show Bug introduced 2018-06-26 21:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setTeamElo()` does not seem to exist on `object<Tfboe\FmLib\Entit...gSystemChangeInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
162			$change->setOpponentElo($opponentHasProvisory ? 0.0 : $opponentAverage);
			0 ignored issues – show Bug introduced 2018-06-26 21:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setOpponentElo()` does not seem to exist on `object<Tfboe\FmLib\Entit...gSystemChangeInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
163			$factor = 2 * $result - 1;
164			if ($entry->getPlayedGames() < self::NUM_PROVISORY_GAMES) {
165			//provisory entry => recalculate
166			if (count($entries) > 1) {
167			$teamMatesAverage = ($teamAverage * count($entries) - $entry->getProvisoryRanking()) /
168			(count($entries) - 1);
169			if ($teamMatesAverage > $opponentAverage + self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY) {
170			$teamMatesAverage = $opponentAverage + self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY;
171			}
172			if ($teamMatesAverage < $opponentAverage - self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY) {
173			$teamMatesAverage = $opponentAverage - self::MAX_DIFF_TO_OPPONENT_FOR_PROVISORY;
174			}
175			$performance = $opponentAverage * (1 + self::PROVISORY_PARTNER_FACTOR) -
176			$teamMatesAverage * self::PROVISORY_PARTNER_FACTOR;
177			} else {
178			$performance = $opponentAverage;
179			}
180			if ($performance < self::START) {
181			$performance = self::START;
182			}
183			$performance += self::EXP_DIFF * $factor;
184			//old average performance = $entry->getProvisoryRating()
185			//=> new average performance = ($entry->getProvisoryRating() * $entry->getRatedGames() + $performance) /
186			// ($entry->getRatedGames() + 1)
187			//=> performance change = ($entry->getProvisoryRating() * $entry->getRatedGames() + $performance) /
188			// ($entry->getRatedGames() + 1) - $entry->getProvisoryRating()
189			// = ($performance - $entry->getProvisoryRating()) / ($entry->getRatedGames() + 1)
190			$change->setProvisoryRanking(($performance - $entry->getProvisoryRanking()) / ($entry->getRatedGames() + 1));
191			$change->setPointsChange(0.0);
192			$change->setRatedGames(1);
193			if ($entry->getPlayedGames() == self::NUM_PROVISORY_GAMES - 1) {
194			$change->setPointsChange(max(self::START, $entry->getProvisoryRanking() + $change->getProvisoryRanking())
195			- $entry->getPoints());
196			}
197			} else if (!$teamHasProvisory && !$opponentHasProvisory) {
198			//real elo ranking
199			$change->setProvisoryRanking(0.0);
200			$change->setPointsChange(max(self::K * $expectationDiff, self::START - $entry->getPoints()));
201			$change->setRatedGames(1);
202
203			} else {
204			//does not get rated
205			$change->setProvisoryRanking(0.0);
206			$change->setPointsChange(0.0);
207			$change->setRatedGames(0);
208			}
209			$changes[] = $change;
210			}
211			}
212
213			/**
214			* Computes the average rating of the given entries
215			* @param RankingSystemListEntryInterface[] $entries must be nonempty
216			* @return float
217			*/
218			private function getEloAverage(array $entries): float
219			{
220			$sum = 0;
221			foreach ($entries as $entry) {
222			$sum += $entry->getRatedGames() < self::NUM_PROVISORY_GAMES ? $entry->getProvisoryRanking() : $entry->getPoints();
223			}
224			return $sum / count($entries);
225			}
226
227			/**
228			* Checks if the given list of entries has at least one provisory entry
229			* @param RankingSystemListEntryInterface[] $entries
230			* @return bool
231			*/
232			private function hasProvisoryEntry(array $entries): bool
233			{
234			foreach ($entries as $entry) {
235			if ($entry->getPlayedGames() < self::NUM_PROVISORY_GAMES) {
236			return true;
237			}
238			}
239			return false;
240			}
241			//</editor-fold desc="Private Methods">
242			}

tfboe / fm-lib

Issues (457)

Security Analysis not enabled

src/Service/RankingSystem/EloRanking.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like