Issues in Tournament.php (master) - Issues in master - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (457)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entity/Traits/Tournament.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 9/17/17
 * Time: 11:35 AM
 */

namespace Tfboe\FmLib\Entity\Traits;


use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;
use Tfboe\FmLib\Entity\CompetitionInterface;
use Tfboe\FmLib\Entity\Helpers\NameEntity;
use Tfboe\FmLib\Entity\Helpers\TimestampableEntity;
use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyInterface;
use Tfboe\FmLib\Entity\TournamentInterface;
use Tfboe\FmLib\Entity\UserInterface;
use Tfboe\FmLib\Helpers\Level;

/**
 * Trait Tournament
 * @package Tfboe\FmLib\Entity\Traits
 */
trait Tournament
{
  use TimestampableEntity;
  use NameEntity;

//<editor-fold desc="Fields">

  /**
   * @ORM\Column(type="string")
   * @var string
   */
  private $tournamentListId;
  /**
   * @ORM\ManyToOne(targetEntity="\Tfboe\FmLib\Entity\UserInterface")
   * @var UserInterface
   */
  private $creator;
  /**
   * @ORM\OneToMany(targetEntity="\Tfboe\FmLib\Entity\CompetitionInterface", mappedBy="tournament",indexBy="name")
   * @var Collection|CompetitionInterface[]
   */
  private $competitions;
//</editor-fold desc="Fields">

//<editor-fold desc="Public Methods">
  /**
   * @inheritDoc
   */
  public function getChildren(): Collection
  {
    return $this->getCompetitions();
  }

  /**
   * @return CompetitionInterface[]|Collection
   */
  public function getCompetitions()
  {
    return $this->competitions;
  }

  /**
   * @return UserInterface
   */
  public function getCreator(): UserInterface
  {
    return $this->creator;
  }

  /**
   * @inheritDoc
   */
  public function getLevel(): int
  {
    return Level::TOURNAMENT;
  }

  /**
   * @inheritDoc
   */
  public function getLocalIdentifier()
  {
    return $this->getId();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
  }

  /**
   * @inheritDoc
   */
  public function getParent(): ?TournamentHierarchyInterface
  {
    return null;
  }

  /**
   * @return string
   */
  public function getTournamentListId(): string
  {
    return $this->tournamentListId;
  }

  /**
   * Tournament constructor.
   */
  protected final function init()
  {
    $this->tournamentListId = "";
    $this->competitions = new ArrayCollection();
  }

  /**
   * @param UserInterface $creator
   * @return TournamentInterface|Tournament
   */
  public function setCreator(UserInterface $creator)
  {
    $this->creator = $creator;
    return $this;
  }

  /**
   * @param string $tournamentListId
   * @return TournamentInterface|Tournament
   */
  public function setTournamentListId(string $tournamentListId)
  {
    $this->tournamentListId = $tournamentListId;
    return $this;
  }
//</editor-fold desc="Public Methods">
}

1			<?php
2			declare(strict_types=1);
3			/**
4			* Created by PhpStorm.
5			* User: benedikt
6			* Date: 9/17/17
7			* Time: 11:35 AM
8			*/
9
10			namespace Tfboe\FmLib\Entity\Traits;
11
12
13			use Doctrine\Common\Collections\ArrayCollection;
14			use Doctrine\Common\Collections\Collection;
15			use Doctrine\ORM\Mapping as ORM;
16			use Tfboe\FmLib\Entity\CompetitionInterface;
17			use Tfboe\FmLib\Entity\Helpers\NameEntity;
18			use Tfboe\FmLib\Entity\Helpers\TimestampableEntity;
19			use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyInterface;
20			use Tfboe\FmLib\Entity\TournamentInterface;
21			use Tfboe\FmLib\Entity\UserInterface;
22			use Tfboe\FmLib\Helpers\Level;
23
24			/**
25			* Trait Tournament
26			* @package Tfboe\FmLib\Entity\Traits
27			*/
28			trait Tournament
29			{
30			use TimestampableEntity;
31			use NameEntity;
32
33			//<editor-fold desc="Fields">
34
35			/**
36			* @ORM\Column(type="string")
37			* @var string
38			*/
39			private $tournamentListId;
40			/**
41			* @ORM\ManyToOne(targetEntity="\Tfboe\FmLib\Entity\UserInterface")
42			* @var UserInterface
43			*/
44			private $creator;
45			/**
46			* @ORM\OneToMany(targetEntity="\Tfboe\FmLib\Entity\CompetitionInterface", mappedBy="tournament",indexBy="name")
47			* @var Collection\|CompetitionInterface[]
48			*/
49			private $competitions;
50			//</editor-fold desc="Fields">
51
52			//<editor-fold desc="Public Methods">
53			/**
54			* @inheritDoc
55			*/
56			public function getChildren(): Collection
57			{
58			return $this->getCompetitions();
59			}
60
61			/**
62			* @return CompetitionInterface[]\|Collection
63			*/
64			public function getCompetitions()
65			{
66			return $this->competitions;
67			}
68
69			/**
70			* @return UserInterface
71			*/
72			public function getCreator(): UserInterface
73			{
74			return $this->creator;
75			}
76
77			/**
78			* @inheritDoc
79			*/
80			public function getLevel(): int
81			{
82			return Level::TOURNAMENT;
83			}
84
85			/**
86			* @inheritDoc
87			*/
88			public function getLocalIdentifier()
89			{
90			return $this->getId();
			0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getId()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
91			}
92
93			/**
94			* @inheritDoc
95			*/
96			public function getParent(): ?TournamentHierarchyInterface
97			{
98			return null;
99			}
100
101			/**
102			* @return string
103			*/
104			public function getTournamentListId(): string
105			{
106			return $this->tournamentListId;
107			}
108
109			/**
110			* Tournament constructor.
111			*/
112			protected final function init()
113			{
114			$this->tournamentListId = "";
115			$this->competitions = new ArrayCollection();
116			}
117
118			/**
119			* @param UserInterface $creator
120			* @return TournamentInterface\|Tournament
121			*/
122			public function setCreator(UserInterface $creator)
123			{
124			$this->creator = $creator;
125			return $this;
126			}
127
128			/**
129			* @param string $tournamentListId
130			* @return TournamentInterface\|Tournament
131			*/
132			public function setTournamentListId(string $tournamentListId)
133			{
134			$this->tournamentListId = $tournamentListId;
135			return $this;
136			}
137			//</editor-fold desc="Public Methods">
138			}

tfboe / fm-lib

Issues (457)

Security Analysis not enabled

src/Entity/Traits/Tournament.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like