Issues in RankingSystemChange.php (master) - Issues in master - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (457)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entity/Traits/RankingSystemChange.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 1/5/18
 * Time: 10:54 PM
 */

namespace Tfboe\FmLib\Entity\Traits;


use Doctrine\ORM\Mapping as ORM;
use Tfboe\FmLib\Entity\Helpers\SubClassData;
use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity;
use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyInterface;
use Tfboe\FmLib\Entity\Helpers\UUIDEntity;
use Tfboe\FmLib\Entity\PlayerInterface;
use Tfboe\FmLib\Entity\RankingSystemInterface;

/**
 * Trait RankingSystemChange
 * @package Tfboe\FmLib\Entity\Traits
 */
trait RankingSystemChange
{
  use UUIDEntity;
  use SubClassData;

//<editor-fold desc="Fields">
  /**
   * @ORM\ManyToOne(targetEntity="\Tfboe\FmLib\Entity\RankingSystemInterface", inversedBy="changes")
   * @var RankingSystemInterface
   */
  private $rankingSystem;

  /**
   * @ORM\Column(type="float")
   * @var float
   */
  private $pointsChange;

  /**
   * @ORM\Column(type="float")
   * @var float
   */
  private $pointsAfterwards;

  /**
   * @ORM\ManyToOne(targetEntity="\Tfboe\FmLib\Entity\PlayerInterface")
   * @var PlayerInterface
   */
  private $player;

  /**
   * @ORM\ManyToOne(
   *   targetEntity="\Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity",
   *   inversedBy="rankingSystemChanges"
   * )
   * @var TournamentHierarchyEntity
   */
  private $hierarchyEntity;
//</editor-fold desc="Fields">

//<editor-fold desc="Constructor">
//</editor-fold desc="Constructor">

//<editor-fold desc="Public Methods">
  /**
   * @return TournamentHierarchyEntity
   */
  public function getHierarchyEntity(): TournamentHierarchyEntity
  {
    return $this->hierarchyEntity;
  }

  /**
   * @return PlayerInterface
   */
  public function getPlayer(): PlayerInterface
  {
    return $this->player;
  }

  /**
   * @return float
   */
  public function getPointsAfterwards(): float
  {
    return $this->pointsAfterwards;
  }

  /**
   * @return float
   */
  public function getPointsChange(): float
  {
    return $this->pointsChange;
  }

  /**
   * @return RankingSystemInterface
   */
  public function getRankingSystem(): RankingSystemInterface
  {
    return $this->rankingSystem;
  }

  /**
   * @param TournamentHierarchyInterface $hierarchyEntity
   */
  public function setHierarchyEntity(TournamentHierarchyInterface $hierarchyEntity)
  {
    $this->hierarchyEntity = $hierarchyEntity;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
  }

  /**
   * @param PlayerInterface $player
   */
  public function setPlayer(PlayerInterface $player)
  {
    $this->player = $player;
  }

  /**
   * @param float $pointsAfterwards
   */
  public function setPointsAfterwards(float $pointsAfterwards)
  {
    $this->pointsAfterwards = $pointsAfterwards;
  }

  /**
   * @param float $pointsChange
   */
  public function setPointsChange(float $pointsChange)
  {
    $this->pointsChange = $pointsChange;
  }

  /**
   * @param RankingSystemInterface $rankingSystem
   */
  public function setRankingSystem(RankingSystemInterface $rankingSystem)
  {
    $this->rankingSystem = $rankingSystem;
  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Protected Final Methods">
  /**
   * RankingSystemChange init
   * @param string[] $keys list of additional fields
   */
  protected final function init(array $keys)
  {
    $this->initSubClassData($keys);
  }
//</editor-fold desc="Protected Final Methods">

}

1			<?php
2			declare(strict_types=1);
3			/**
4			* Created by PhpStorm.
5			* User: benedikt
6			* Date: 1/5/18
7			* Time: 10:54 PM
8			*/
9
10			namespace Tfboe\FmLib\Entity\Traits;
11
12
13			use Doctrine\ORM\Mapping as ORM;
14			use Tfboe\FmLib\Entity\Helpers\SubClassData;
15			use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity;
16			use Tfboe\FmLib\Entity\Helpers\TournamentHierarchyInterface;
17			use Tfboe\FmLib\Entity\Helpers\UUIDEntity;
18			use Tfboe\FmLib\Entity\PlayerInterface;
19			use Tfboe\FmLib\Entity\RankingSystemInterface;
20
21			/**
22			* Trait RankingSystemChange
23			* @package Tfboe\FmLib\Entity\Traits
24			*/
25			trait RankingSystemChange
26			{
27			use UUIDEntity;
28			use SubClassData;
29
30			//<editor-fold desc="Fields">
31			/**
32			* @ORM\ManyToOne(targetEntity="\Tfboe\FmLib\Entity\RankingSystemInterface", inversedBy="changes")
33			* @var RankingSystemInterface
34			*/
35			private $rankingSystem;
36
37			/**
38			* @ORM\Column(type="float")
39			* @var float
40			*/
41			private $pointsChange;
42
43			/**
44			* @ORM\Column(type="float")
45			* @var float
46			*/
47			private $pointsAfterwards;
48
49			/**
50			* @ORM\ManyToOne(targetEntity="\Tfboe\FmLib\Entity\PlayerInterface")
51			* @var PlayerInterface
52			*/
53			private $player;
54
55			/**
56			* @ORM\ManyToOne(
57			* targetEntity="\Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity",
58			* inversedBy="rankingSystemChanges"
59			* )
60			* @var TournamentHierarchyEntity
61			*/
62			private $hierarchyEntity;
63			//</editor-fold desc="Fields">
64
65			//<editor-fold desc="Constructor">
66			//</editor-fold desc="Constructor">
67
68			//<editor-fold desc="Public Methods">
69			/**
70			* @return TournamentHierarchyEntity
71			*/
72			public function getHierarchyEntity(): TournamentHierarchyEntity
73			{
74			return $this->hierarchyEntity;
75			}
76
77			/**
78			* @return PlayerInterface
79			*/
80			public function getPlayer(): PlayerInterface
81			{
82			return $this->player;
83			}
84
85			/**
86			* @return float
87			*/
88			public function getPointsAfterwards(): float
89			{
90			return $this->pointsAfterwards;
91			}
92
93			/**
94			* @return float
95			*/
96			public function getPointsChange(): float
97			{
98			return $this->pointsChange;
99			}
100
101			/**
102			* @return RankingSystemInterface
103			*/
104			public function getRankingSystem(): RankingSystemInterface
105			{
106			return $this->rankingSystem;
107			}
108
109			/**
110			* @param TournamentHierarchyInterface $hierarchyEntity
111			*/
112			public function setHierarchyEntity(TournamentHierarchyInterface $hierarchyEntity)
113			{
114			$this->hierarchyEntity = $hierarchyEntity;
			0 ignored issues – show Documentation Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$hierarchyEntity` is of type `object<Tfboe\FmLib\Entit...mentHierarchyInterface>`, but the property `$hierarchyEntity` was declared to be of type `object<Tfboe\FmLib\Entit...rnamentHierarchyEntity>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
115			}
116
117			/**
118			* @param PlayerInterface $player
119			*/
120			public function setPlayer(PlayerInterface $player)
121			{
122			$this->player = $player;
123			}
124
125			/**
126			* @param float $pointsAfterwards
127			*/
128			public function setPointsAfterwards(float $pointsAfterwards)
129			{
130			$this->pointsAfterwards = $pointsAfterwards;
131			}
132
133			/**
134			* @param float $pointsChange
135			*/
136			public function setPointsChange(float $pointsChange)
137			{
138			$this->pointsChange = $pointsChange;
139			}
140
141			/**
142			* @param RankingSystemInterface $rankingSystem
143			*/
144			public function setRankingSystem(RankingSystemInterface $rankingSystem)
145			{
146			$this->rankingSystem = $rankingSystem;
147			}
148			//</editor-fold desc="Public Methods">
149
150			//<editor-fold desc="Protected Final Methods">
151			/**
152			* RankingSystemChange init
153			* @param string[] $keys list of additional fields
154			*/
155			protected final function init(array $keys)
156			{
157			$this->initSubClassData($keys);
158			}
159			//</editor-fold desc="Protected Final Methods">
160
161			}

tfboe / fm-lib

Issues (457)

Security Analysis not enabled

src/Entity/Traits/RankingSystemChange.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like