Issues in TimeEntity.php (master) - Issues in master - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (457)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entity/Helpers/TimeEntity.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 1/2/18
 * Time: 2:57 PM
 */

namespace Tfboe\FmLib\Entity\Helpers;

/**
 * Trait TimeEntity
 * @package Tfboe\FmLib\Entity\Helpers
 */
trait TimeEntity
{
//<editor-fold desc="Fields">
  /**
   * @ORM\Column(type="datetime", nullable=true)
   * @var \DateTime|null
   */
  private $startTime = null;

  /**
   * @ORM\Column(type="datetime", nullable=true)
   * @var \DateTime|null
   */
  private $endTime = null;

  /**
   * @ORM\Column(type="string")
   * @var string
   */
  private $startTimezone = "";

  /**
   * @ORM\Column(type="string")
   * @var string
   */
  private $endTimezone = "";

  /**
   * @var bool
   */
  private $startLocalized = false;

  /**
   * @var bool
   */
  private $endLocalized = false;
//</editor-fold desc="Fields">

//<editor-fold desc="Public Methods">
  /**
   * @return \DateTime|null
   */
  public function getEndTime(): ?\DateTime
  {
    if ($this->endTime !== null && !$this->endLocalized) {
      $this->endTime->setTimezone(new \DateTimeZone($this->endTimezone));
      $this->endLocalized = true;
    }
    return $this->endTime;
  }

  /**
   * @return \DateTime|null
   */
  public function getStartTime(): ?\DateTime
  {
    if ($this->startTime !== null && !$this->startLocalized) {
      $this->startTime->setTimezone(new \DateTimeZone($this->startTimezone));
      $this->startLocalized = true;
    }
    return $this->startTime;
  }


  /**
   * @param \DateTime|null $endTime
   * @return $this|TimeEntity

   */
  public function setEndTime(?\DateTime $endTime)
  {
    $this->endTime = $endTime;
    $this->endTimezone = $endTime === null ? "" : $endTime->getTimezone()->getName();
    $this->endLocalized = true;
    return $this;
  }

  /**
   * @param \DateTime|null $startTime
   * @return $this|TimeEntity

   */
  public function setStartTime(?\DateTime $startTime)
  {
    $this->startTime = $startTime;
    $this->startTimezone = $startTime === null ? "" : $startTime->getTimezone()->getName();
    $this->startLocalized = true;
    return $this;
  }
//</editor-fold desc="Public Methods">
}

1			<?php
2			declare(strict_types=1);
3			/**
4			* Created by PhpStorm.
5			* User: benedikt
6			* Date: 1/2/18
7			* Time: 2:57 PM
8			*/
9
10			namespace Tfboe\FmLib\Entity\Helpers;
11
12			/**
13			* Trait TimeEntity
14			* @package Tfboe\FmLib\Entity\Helpers
15			*/
16			trait TimeEntity
17			{
18			//<editor-fold desc="Fields">
19			/**
20			* @ORM\Column(type="datetime", nullable=true)
21			* @var \DateTime\|null
22			*/
23			private $startTime = null;
24
25			/**
26			* @ORM\Column(type="datetime", nullable=true)
27			* @var \DateTime\|null
28			*/
29			private $endTime = null;
30
31			/**
32			* @ORM\Column(type="string")
33			* @var string
34			*/
35			private $startTimezone = "";
36
37			/**
38			* @ORM\Column(type="string")
39			* @var string
40			*/
41			private $endTimezone = "";
42
43			/**
44			* @var bool
45			*/
46			private $startLocalized = false;
47
48			/**
49			* @var bool
50			*/
51			private $endLocalized = false;
52			//</editor-fold desc="Fields">
53
54			//<editor-fold desc="Public Methods">
55			/**
56			* @return \DateTime\|null
57			*/
58			public function getEndTime(): ?\DateTime
59			{
60			if ($this->endTime !== null && !$this->endLocalized) {
61			$this->endTime->setTimezone(new \DateTimeZone($this->endTimezone));
62			$this->endLocalized = true;
63			}
64			return $this->endTime;
65			}
66
67			/**
68			* @return \DateTime\|null
69			*/
70			public function getStartTime(): ?\DateTime
71			{
72			if ($this->startTime !== null && !$this->startLocalized) {
73			$this->startTime->setTimezone(new \DateTimeZone($this->startTimezone));
74			$this->startLocalized = true;
75			}
76			return $this->startTime;
77			}
78
79
80			/**
81			* @param \DateTime\|null $endTime
82			* @return $this\|TimeEntity
			0 ignored issues – show Comprehensibility Bug introduced 2018-01-27 10:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type `TimeEntity` is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting? In PHP traits cannot be used for type-hinting as they do not define a well-defined structure. This is because any class that uses a trait can rename that trait’s methods. If you would like to return an object that has a guaranteed set of methods, you could create a companion interface that lists these methods explicitly. Loading history...
83			*/
84			public function setEndTime(?\DateTime $endTime)
85			{
86			$this->endTime = $endTime;
87			$this->endTimezone = $endTime === null ? "" : $endTime->getTimezone()->getName();
88			$this->endLocalized = true;
89			return $this;
90			}
91
92			/**
93			* @param \DateTime\|null $startTime
94			* @return $this\|TimeEntity
			0 ignored issues – show Comprehensibility Bug introduced 2018-01-27 10:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type `TimeEntity` is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting? In PHP traits cannot be used for type-hinting as they do not define a well-defined structure. This is because any class that uses a trait can rename that trait’s methods. If you would like to return an object that has a guaranteed set of methods, you could create a companion interface that lists these methods explicitly. Loading history...
95			*/
96			public function setStartTime(?\DateTime $startTime)
97			{
98			$this->startTime = $startTime;
99			$this->startTimezone = $startTime === null ? "" : $startTime->getTimezone()->getName();
100			$this->startLocalized = true;
101			return $this;
102			}
103			//</editor-fold desc="Public Methods">
104			}

tfboe / fm-lib

Issues (457)

Security Analysis not enabled

src/Entity/Helpers/TimeEntity.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like