tfboe / fm-lib

src/TestHelpers/OnlyTestLogging.php

Indentation +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
    */
   public function setTestingTrue()
   {
-    Logging::$testing = true;
+	Logging::$testing = true;
   }
 //</editor-fold desc="Public Methods">
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt

Braces +2 added lines, -4 removed lines

@@ -16,15 +16,13 @@
  * Trait OnlyTestLogging
  * @package Tests\Helpers
  */
-trait OnlyTestLogging
-{
+trait OnlyTestLogging {
 //<editor-fold desc="Public Methods">
   /**
    * Sets the logging value testing to true
    * @before
    */
-  public function setTestingTrue()
-  {
+  public function setTestingTrue() {
     Logging::$testing = true;
   }
 //</editor-fold desc="Public Methods">

src/TestHelpers/TestEnum.php

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
  * Class TestEnum
  * @package Tests\Helpers
  */
-abstract class TestEnum extends BasicEnum
-{
+abstract class TestEnum extends BasicEnum {
 //<editor-fold desc="Fields">
   const INT_KEY = 1;
   const KEY = "value";

src/Service/RankingSystemServiceInterface.php

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt
@@ -24,7 +24,7 @@ 
    * @param Tournament $tournament The tournament to analyze
    * @param mixed[][] $influences the earliest influences of the tournament before the change
    */
-  public function adaptOpenSyncFromValues(Tournament $tournament, array $influences): void;
+  public function adaptOpenSyncFromValues( Tournament $tournament, array $influences ): void;
 
   /**
    * Gets all ranking systems of a tournament and its earliest influences as time.
@@ -32,7 +32,7 @@ 
    * @param Tournament $tournament the tournament to analyze
    * @return mixed[][]
    */
-  public function getRankingSystemsEarliestInfluences(Tournament $tournament): array;
+  public function getRankingSystemsEarliestInfluences( Tournament $tournament ): array;
 
   /**
    * Recalculates all ranking systems which have an open sync from value.

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
  * Interface RankingSystemServiceInterface
  * @package Tfboe\FmLib\Service
  */
-interface RankingSystemServiceInterface
-{
+interface RankingSystemServiceInterface {
 //<editor-fold desc="Public Methods">
   /**
    * Adapts the open sync from property of all relevant ranking systems

src/Service/DynamicServiceLoadingService.php

Indentation +10 added lines, -10 removed lines

@@ -30,7 +30,7 @@ 
    */
   public function __construct(Container $app)
   {
-    $this->app = $app;
+	$this->app = $app;
   }
 //</editor-fold desc="Constructor">
 
@@ -40,7 +40,7 @@ 
    */
   public function loadRankingSystemService(string $name): RankingSystemInterface
   {
-    return $this->app->make($this->getClassWithNamespace($name, 'Tfboe\FmLib\Service\RankingSystem'));
+	return $this->app->make($this->getClassWithNamespace($name, 'Tfboe\FmLib\Service\RankingSystem'));
   }
 //</editor-fold desc="Public Methods">
 
@@ -53,14 +53,14 @@ 
    */
   protected function getClassWithNamespace(string $class, string $namespace): string
   {
-    if (strpos($class, 'Interface') === false) {
-      $class .= 'Interface';
-    }
-    if (strpos($class, '\\') === false) {
-      return $namespace . '\\' . $class;
-    } else {
-      return $class;
-    }
+	if (strpos($class, 'Interface') === false) {
+	  $class .= 'Interface';
+	}
+	if (strpos($class, '\\') === false) {
+	  return $namespace . '\\' . $class;
+	} else {
+	  return $class;
+	}
   }
 //</editor-fold desc="Protected Methods">
 //<editor-fold desc="Private Methods">

Spacing +7 added lines, -7 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt
@@ -28,7 +28,7 @@ 
    * DynamicServiceLoadingService constructor.
    * @param Container $app
    */
-  public function __construct(Container $app)
+  public function __construct( Container $app )
   {
     $this->app = $app;
   }
@@ -38,7 +38,7 @@ 
   /**
    * @inheritdoc
    */
-  public function loadRankingSystemService(string $name): RankingSystemInterface
+  public function loadRankingSystemService( string $name ): RankingSystemInterface
   {
     return $this->app->make($this->getClassWithNamespace($name, 'Tfboe\FmLib\Service\RankingSystem'));
   }
@@ -51,13 +51,13 @@ 
    * @param string $namespace the namespace
    * @return string the full class name (with namespace) and with interface
    */
-  protected function getClassWithNamespace(string $class, string $namespace): string
+  protected function getClassWithNamespace( string $class, string $namespace ): string
   {
-    if (strpos($class, 'Interface') === false) {
+    if ( strpos($class, 'Interface') === false ) {
       $class .= 'Interface';
     }
-    if (strpos($class, '\\') === false) {
-      return $namespace . '\\' . $class;
+    if ( strpos($class, '\\') === false ) {
+      return $namespace.'\\'.$class;
     } else {
       return $class;
     }

Braces +2 added lines, -4 removed lines

@@ -16,8 +16,7 @@ 
  * Class DynamicLoadingService
  * @package Tfboe\FmLib\Service
  */
-class DynamicServiceLoadingService implements DynamicServiceLoadingServiceInterface
-{
+class DynamicServiceLoadingService implements DynamicServiceLoadingServiceInterface {
 //<editor-fold desc="Fields">
   /** @var Container */
   private $app;
@@ -28,8 +27,7 @@ 
    * DynamicServiceLoadingService constructor.
    * @param Container $app
    */
-  public function __construct(Container $app)
-  {
+  public function __construct(Container $app) {
     $this->app = $app;
   }
 //</editor-fold desc="Constructor">

src/Service/RankingSystem/TimeServiceInterface.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt
@@ -30,6 +30,6 @@ 
    * @param TournamentHierarchyInterface $entity
    * @return \DateTime
    */
-  public function getTime(TournamentHierarchyInterface $entity);
+  public function getTime( TournamentHierarchyInterface $entity );
 //</editor-fold desc="Public Methods">
 }
\ No newline at end of file

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
  * Interface TimeService
  * @package Tfboe\FmLib\Service\RankingSystemService\TimeService
  */
-interface TimeServiceInterface
-{
+interface TimeServiceInterface {
 //<editor-fold desc="Public Methods">
   /**
    * If the service has a memory clears all remembered times. This needs to be called when times of some entities

src/Service/RankingSystem/EntityComparerInterface.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt
@@ -26,6 +26,6 @@ 
    * @return int returns -1 if entity1 should be before entity2, 1 if it should be after entity2 and 0 if they are
    *             equal.
    */
-  public function compareEntities(TournamentHierarchyInterface $entity1, TournamentHierarchyInterface $entity2): int;
+  public function compareEntities( TournamentHierarchyInterface $entity1, TournamentHierarchyInterface $entity2 ): int;
 //</editor-fold desc="Public Methods">
 }
\ No newline at end of file

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
  * Interface EntityComparerInterface
  * @package Tfboe\FmLib\Service\RankingSystemService
  */
-interface EntityComparerInterface
-{
+interface EntityComparerInterface {
 //<editor-fold desc="Public Methods">
   /**
    * Compares two entities.

src/Service/RankingSystem/EloRankingInterface.php

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt

Braces +1 added lines, -2 removed lines

@@ -14,7 +14,6 @@
  * Interface EloRankingInterface
  * @package Tfboe\FmLib\Service\TournamentRanking
  */
-interface EloRankingInterface extends GameRankingSystemInterface
-{
+interface EloRankingInterface extends GameRankingSystemInterface {
 
 }
\ No newline at end of file

src/Service/RankingSystem/EntityComparerByTimeStartTimeAndLocalIdentifier.php

Indentation +45 added lines, -45 removed lines

@@ -31,7 +31,7 @@ 
    */
   public function __construct(TimeServiceInterface $timeService)
   {
-    $this->timeService = $timeService;
+	$this->timeService = $timeService;
   }
 //</editor-fold desc="Constructor">
 
@@ -42,18 +42,18 @@ 
    */
   public function compareEntities(TournamentHierarchyInterface $entity1, TournamentHierarchyInterface $entity2): int
   {
-    $tmpE1 = $entity1;
-    $tmpE2 = $entity2;
-    while ($tmpE1 !== null && $tmpE2 !== null && $tmpE1->getId() !== $tmpE2->getId()) {
-      $comparison = $this->compareEntityTimes($tmpE1, $tmpE2);
-      if ($comparison !== 0) {
-        return $comparison;
-      }
-      $tmpE1 = $tmpE1->getParent();
-      $tmpE2 = $tmpE2->getParent();
-    }
+	$tmpE1 = $entity1;
+	$tmpE2 = $entity2;
+	while ($tmpE1 !== null && $tmpE2 !== null && $tmpE1->getId() !== $tmpE2->getId()) {
+	  $comparison = $this->compareEntityTimes($tmpE1, $tmpE2);
+	  if ($comparison !== 0) {
+		return $comparison;
+	  }
+	  $tmpE1 = $tmpE1->getParent();
+	  $tmpE2 = $tmpE2->getParent();
+	}
 
-    return $this->compareLocalIdentifiersWithinTournament($entity1, $entity2);
+	return $this->compareLocalIdentifiersWithinTournament($entity1, $entity2);
   }
 //</editor-fold desc="Public Methods">
 
@@ -66,23 +66,23 @@ 
    *             entity2 are before the times of entity1 and 0 if they have the same times
    */
   protected function compareEntityTimes(TournamentHierarchyInterface $entity1,
-                                        TournamentHierarchyInterface $entity2)
+										TournamentHierarchyInterface $entity2)
   {
-    $time1 = $this->timeService->getTime($entity1);
-    $time2 = $this->timeService->getTime($entity2);
-    if ($time1 < $time2) {
-      return -1;
-    } else if ($time1 > $time2) {
-      return 1;
-    }
-    if ($entity1->getStartTime() !== null && $entity2->getStartTime() !== null) {
-      if ($entity1->getStartTime() < $entity2->getStartTime()) {
-        return -1;
-      } else if ($entity1->getStartTime() > $entity2->getStartTime()) {
-        return 1;
-      }
-    }
-    return 0;
+	$time1 = $this->timeService->getTime($entity1);
+	$time2 = $this->timeService->getTime($entity2);
+	if ($time1 < $time2) {
+	  return -1;
+	} else if ($time1 > $time2) {
+	  return 1;
+	}
+	if ($entity1->getStartTime() !== null && $entity2->getStartTime() !== null) {
+	  if ($entity1->getStartTime() < $entity2->getStartTime()) {
+		return -1;
+	  } else if ($entity1->getStartTime() > $entity2->getStartTime()) {
+		return 1;
+	  }
+	}
+	return 0;
   }
 
   /**
@@ -93,20 +93,20 @@ 
    *             and 0 if the two entities are equal (<=> all predecessors have same local identifiers)
    */
   protected function compareLocalIdentifiersWithinTournament(TournamentHierarchyInterface $entity1,
-                                                             TournamentHierarchyInterface $entity2)
+															 TournamentHierarchyInterface $entity2)
   {
-    //compare unique identifiers within tournament
-    $predecessors1 = $this->getPredecessors($entity1);
-    $predecessors2 = $this->getPredecessors($entity2);
+	//compare unique identifiers within tournament
+	$predecessors1 = $this->getPredecessors($entity1);
+	$predecessors2 = $this->getPredecessors($entity2);
 
-    for ($i = count($predecessors1) - 1; $i >= 0; $i--) {
-      if ($predecessors1[$i]->getLocalIdentifier() !== $predecessors2[$i]->getLocalIdentifier()) {
-        return $predecessors1[$i]->getLocalIdentifier() <=> $predecessors2[$i]->getLocalIdentifier();
-      }
-    }
+	for ($i = count($predecessors1) - 1; $i >= 0; $i--) {
+	  if ($predecessors1[$i]->getLocalIdentifier() !== $predecessors2[$i]->getLocalIdentifier()) {
+		return $predecessors1[$i]->getLocalIdentifier() <=> $predecessors2[$i]->getLocalIdentifier();
+	  }
+	}
 
-    //the two entities are equal
-    return 0;
+	//the two entities are equal
+	return 0;
   }
 //</editor-fold desc="Protected Methods">
 
@@ -118,12 +118,12 @@ 
    */
   private function getPredecessors(TournamentHierarchyInterface $entity): array
   {
-    $res = [];
-    while ($entity !== null) {
-      $res[] = $entity;
-      $entity = $entity->getParent();
-    }
-    return $res;
+	$res = [];
+	while ($entity !== null) {
+	  $res[] = $entity;
+	  $entity = $entity->getParent();
+	}
+	return $res;
   }
 //</editor-fold desc="Private Methods">
 }
\ No newline at end of file

Spacing +18 added lines, -18 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt
@@ -29,7 +29,7 @@ 
    * EntityComparerByTimeStartTimeAndLocalIdentifier constructor.
    * @param TimeServiceInterface $timeService
    */
-  public function __construct(TimeServiceInterface $timeService)
+  public function __construct( TimeServiceInterface $timeService )
   {
     $this->timeService = $timeService;
   }
@@ -40,13 +40,13 @@ 
   /**
    * @inheritDoc
    */
-  public function compareEntities(TournamentHierarchyInterface $entity1, TournamentHierarchyInterface $entity2): int
+  public function compareEntities( TournamentHierarchyInterface $entity1, TournamentHierarchyInterface $entity2 ): int
   {
     $tmpE1 = $entity1;
     $tmpE2 = $entity2;
-    while ($tmpE1 !== null && $tmpE2 !== null && $tmpE1->getId() !== $tmpE2->getId()) {
+    while ( $tmpE1 !== null && $tmpE2 !== null && $tmpE1->getId() !== $tmpE2->getId() ) {
       $comparison = $this->compareEntityTimes($tmpE1, $tmpE2);
-      if ($comparison !== 0) {
+      if ( $comparison !== 0 ) {
         return $comparison;
       }
       $tmpE1 = $tmpE1->getParent();
@@ -65,20 +65,20 @@ 
    * @return int returns -1 if the relevant times of entity1 are before the relevant times of entity2, 1 if the times of
    *             entity2 are before the times of entity1 and 0 if they have the same times
    */
-  protected function compareEntityTimes(TournamentHierarchyInterface $entity1,
-                                        TournamentHierarchyInterface $entity2)
+  protected function compareEntityTimes( TournamentHierarchyInterface $entity1,
+                                        TournamentHierarchyInterface $entity2 )
   {
     $time1 = $this->timeService->getTime($entity1);
     $time2 = $this->timeService->getTime($entity2);
-    if ($time1 < $time2) {
+    if ( $time1 < $time2 ) {
       return -1;
-    } else if ($time1 > $time2) {
+    } else if ( $time1 > $time2 ) {
       return 1;
     }
-    if ($entity1->getStartTime() !== null && $entity2->getStartTime() !== null) {
-      if ($entity1->getStartTime() < $entity2->getStartTime()) {
+    if ( $entity1->getStartTime() !== null && $entity2->getStartTime() !== null ) {
+      if ( $entity1->getStartTime() < $entity2->getStartTime() ) {
         return -1;
-      } else if ($entity1->getStartTime() > $entity2->getStartTime()) {
+      } else if ( $entity1->getStartTime() > $entity2->getStartTime() ) {
         return 1;
       }
     }
@@ -92,15 +92,15 @@ 
    * @return int returns -1 if the first predecessor with a lower local identifier is of entity1, 1 if it is of entity2
    *             and 0 if the two entities are equal (<=> all predecessors have same local identifiers)
    */
-  protected function compareLocalIdentifiersWithinTournament(TournamentHierarchyInterface $entity1,
-                                                             TournamentHierarchyInterface $entity2)
+  protected function compareLocalIdentifiersWithinTournament( TournamentHierarchyInterface $entity1,
+                                                             TournamentHierarchyInterface $entity2 )
   {
     //compare unique identifiers within tournament
     $predecessors1 = $this->getPredecessors($entity1);
     $predecessors2 = $this->getPredecessors($entity2);
 
-    for ($i = count($predecessors1) - 1; $i >= 0; $i--) {
-      if ($predecessors1[$i]->getLocalIdentifier() !== $predecessors2[$i]->getLocalIdentifier()) {
+    for ( $i = count($predecessors1) - 1; $i >= 0; $i-- ) {
+      if ( $predecessors1[$i]->getLocalIdentifier() !== $predecessors2[$i]->getLocalIdentifier() ) {
         return $predecessors1[$i]->getLocalIdentifier() <=> $predecessors2[$i]->getLocalIdentifier();
       }
     }
@@ -116,10 +116,10 @@ 
    * @param TournamentHierarchyInterface $entity the entity for which to get the predecessors
    * @return TournamentHierarchyInterface[] the predecessors of $entity inclusive $entity
    */
-  private function getPredecessors(TournamentHierarchyInterface $entity): array
+  private function getPredecessors( TournamentHierarchyInterface $entity ): array
   {
     $res = [];
-    while ($entity !== null) {
+    while ( $entity !== null ) {
       $res[] = $entity;
       $entity = $entity->getParent();
     }

Braces +4 added lines, -8 removed lines

@@ -17,8 +17,7 @@ 
  * Class EntityComparerByTimeStartTimeAndLocalIdentifier
  * @package Tfboe\FmLib\Service\RankingSystemListService
  */
-class EntityComparerByTimeStartTimeAndLocalIdentifier implements EntityComparerInterface
-{
+class EntityComparerByTimeStartTimeAndLocalIdentifier implements EntityComparerInterface {
 //<editor-fold desc="Fields">
   /** @var TimeServiceInterface */
   private $timeService;
@@ -29,8 +28,7 @@ 
    * EntityComparerByTimeStartTimeAndLocalIdentifier constructor.
    * @param TimeServiceInterface $timeService
    */
-  public function __construct(TimeServiceInterface $timeService)
-  {
+  public function __construct(TimeServiceInterface $timeService) {
     $this->timeService = $timeService;
   }
 //</editor-fold desc="Constructor">
@@ -66,8 +64,7 @@ 
    *             entity2 are before the times of entity1 and 0 if they have the same times
    */
   protected function compareEntityTimes(TournamentHierarchyInterface $entity1,
-                                        TournamentHierarchyInterface $entity2)
-  {
+                                        TournamentHierarchyInterface $entity2) {
     $time1 = $this->timeService->getTime($entity1);
     $time2 = $this->timeService->getTime($entity2);
     if ($time1 < $time2) {
@@ -93,8 +90,7 @@ 
    *             and 0 if the two entities are equal (<=> all predecessors have same local identifiers)
    */
   protected function compareLocalIdentifiersWithinTournament(TournamentHierarchyInterface $entity1,
-                                                             TournamentHierarchyInterface $entity2)
-  {
+                                                             TournamentHierarchyInterface $entity2) {
     //compare unique identifiers within tournament
     $predecessors1 = $this->getPredecessors($entity1);
     $predecessors2 = $this->getPredecessors($entity2);

src/Service/RankingSystem/RankingSystemInterface.php

Indentation +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
    *                       tournament before the change
    */
   public function updateRankingForTournament(RankingSystem $ranking, Tournament $tournament,
-                                             ?\DateTime $oldInfluence);
+											 ?\DateTime $oldInfluence);
 
   /**
    * Updates the rankings assuming all changes happened after $from.

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Created by PhpStorm.
  * User: benedikt
@@ -29,7 +29,7 @@ 
    * @return \DateTime|null the earliest influence or null iff no entity above the level of this ranking has the ranking
    *                        in its rankingSystems
    */
-  public function getEarliestInfluence(RankingSystem $ranking, Tournament $tournament): ?\DateTime;
+  public function getEarliestInfluence( RankingSystem $ranking, Tournament $tournament ): ?\DateTime;
 
   /**
    * Updates the rankings for this tournament
@@ -38,14 +38,14 @@ 
    * @param \DateTime|null $oldInfluence if the tournament changed this is the earliest influence of the
    *                       tournament before the change
    */
-  public function updateRankingForTournament(RankingSystem $ranking, Tournament $tournament,
-                                             ?\DateTime $oldInfluence);
+  public function updateRankingForTournament( RankingSystem $ranking, Tournament $tournament,
+                                             ?\DateTime $oldInfluence );
 
   /**
    * Updates the rankings assuming all changes happened after $from.
    * @param RankingSystem $ranking
    * @param \DateTime $from
    */
-  public function updateRankingFrom(RankingSystem $ranking, \DateTime $from);
+  public function updateRankingFrom( RankingSystem $ranking, \DateTime $from );
 //</editor-fold desc="Public Methods">
 }
\ No newline at end of file

Braces +1 added lines, -2 removed lines

@@ -17,8 +17,7 @@
  * Interface RankingSystemInterface
  * @package Tfboe\FmLib\Service\RankingSystemService
  */
-interface RankingSystemInterface
-{
+interface RankingSystemInterface {
 //<editor-fold desc="Public Methods">
   /**
    * The earliest influence date of the given tournament for the ranking system.