Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 29 | class RankingSystemTest extends UnitTestCase |
||
| 30 | { |
||
| 31 | //<editor-fold desc="Public Methods"> |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::setGenerationInterval |
||
| 35 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::getGenerationInterval |
||
| 36 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 37 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 38 | * @uses \Tfboe\FmLib\Helpers\BasicEnum |
||
| 39 | */ |
||
| 40 | public function testAutomaticInstanceGeneration() |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 50 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 51 | * @uses \Tfboe\FmLib\Helpers\BasicEnum |
||
| 52 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::getGenerationInterval |
||
| 53 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::getDefaultForLevel |
||
| 54 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::getLists |
||
| 55 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::getOpenSyncFrom |
||
| 56 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::getHierarchyEntries |
||
| 57 | */ |
||
| 58 | public function testConstructor() |
||
| 70 | |||
| 71 | /** |
||
| 72 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::setDefaultForLevel |
||
| 73 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::getDefaultForLevel |
||
| 74 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 75 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 76 | * @uses \Tfboe\FmLib\Helpers\BasicEnum |
||
| 77 | */ |
||
| 78 | public function testDefaultForLevel() |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::getLists |
||
| 89 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 90 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 91 | */ |
||
| 92 | View Code Duplication | public function testLists() |
|
| 101 | |||
| 102 | /** |
||
| 103 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::setOpenSyncFrom |
||
| 104 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::getOpenSyncFrom |
||
| 105 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 106 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 107 | */ |
||
| 108 | public function testOpenSyncFrom() |
||
| 114 | |||
| 115 | /** |
||
| 116 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::setServiceName |
||
| 117 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::getServiceName |
||
| 118 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 119 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 120 | */ |
||
| 121 | public function testServiceName() |
||
| 127 | |||
| 128 | /** |
||
| 129 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystem::getHierarchyEntries |
||
| 130 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
| 131 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystem::init |
||
| 132 | */ |
||
| 133 | View Code Duplication | public function testTournamentRankingEntities() |
|
| 142 | //</editor-fold desc="Public Methods"> |
||
| 143 | |||
| 144 | //<editor-fold desc="Private Methods"> |
||
| 145 | /** |
||
| 146 | * @return RankingSystemInterface |
||
| 147 | */ |
||
| 148 | private function instance(): RankingSystemInterface |
||
| 152 | //</editor-fold desc="Private Methods"> |
||
| 153 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.