Tfboe\FmLib\Http\Controllers\UserController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	162
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
B	login()	0	25	3
A	register()	0	23	1
A	newUser()	0	4	1
A	getRegisterResponse()	0	6	1
A	userId()	0	5	1
A	addAdditionalLoginSpecifications()	0	4	1
A	addAdditionalRegisterSpecifications()	0	4	1
A	createAdditionalRegisterEntities()	0	4	1
A	getLoginResponse()	0	5	1
A	getCredentialSpecification()	0	11	1

<?php
declare(strict_types=1);

namespace Tfboe\FmLib\Http\Controllers;

use Illuminate\Contracts\Hashing\Hasher;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Laravel\Lumen\Application;
use Tfboe\FmLib\Entity\User;
use Tfboe\FmLib\Exceptions\AuthenticationException;
use Tymon\JWTAuth\Exceptions\JWTException;

/**
 * Class UserController
 * @package App\Http\Controllers
 */
class UserController extends BaseController
{
//<editor-fold desc="Public Methods">
  /**
   * login action, checks credentials and returns token
   * @param Request $request the http request
   * @param Application $app
   * @return JsonResponse
   * @throws AuthenticationException wrong credentials or errors during creating a token
   */
  public function login(Request $request, Application $app): JsonResponse
  {
    $specification = $this->getCredentialSpecification($app);
    $this->addAdditionalLoginSpecifications($specification);
    $this->validateBySpecification($request, $specification);


    // grab credentials from the request
    $credentials = $request->only('email', 'password');

    /** @var string $token */
    $token = null;
    try {
      // attempt to verify the credentials and create a token for the user
      $token = Auth::attempt($credentials);
      if (!$token) {
        throw new AuthenticationException('invalid credentials');
      }
    } /** @noinspection PhpRedundantCatchClauseInspection */ catch (JWTException $e) {
      // something went wrong whilst attempting to encode the token
      throw new AuthenticationException('could not create token');
    }
    return $this->getLoginResponse($request, $token);

$token is of type boolean, but the function expects a string.

  }

  /**
   * register action, registers a new user with email and password
   *
   * @param Request $request the http request
   * @param Application $app
   * @return JsonResponse
   */
  public function register(Request $request, Application $app): JsonResponse
  {
    $specification = [];
    $specification['user'] = $this->getCredentialSpecification($app);
    $specification['user']['email']['validation'] .= '|unique:Tfboe\FmLib\Entity\User,email';
    $specification['user']['confirmedAGBVersion'] = ['validation' => 'integer|min:0'];

    $this->addAdditionalRegisterSpecifications($specification);

    $this->validateBySpecification($request, array_merge(...array_values($specification)));

    $input = $request->input();
    /** @var User $user */

    $user = $this->setFromSpecification($this->newUser(), $specification['user'], $input);

It seems like $input defined by $request->input() on line 73 can also be of type string; however, Tfboe\FmLib\Http\Controllers\BaseController::setFromSpecification() does only seem to accept array, maybe add an additional type check?

    $this->getEntityManager()->persist($user); //sets the user id

    $this->createAdditionalRegisterEntities($user, $specification, $input);

It seems like $input defined by $request->input() on line 73 can also be of type string; however, Tfboe\FmLib\Http\Controllers\UserController::createAdditionalRegisterEntities() does only seem to accept array, maybe add an additional type check?

    $this->getEntityManager()->flush();

    return $this->getRegisterResponse($request, $app, $user);
  }

  /**
   * Creates a new user
   * @return User
   */
  protected function newUser(): User
  {
    return new User();
  }

  /**
   * Gets the response for a successful register action
   * @param Request $request the request
   * @param Application $app the application
   * @param User $user the newly registered user
   * @return JsonResponse the json response
   */
  protected function getRegisterResponse(/** @noinspection PhpUnusedParameterInspection */
    Request $request, /** @noinspection PhpUnusedParameterInspection */

The parameter $request is not used and could be removed.

    Application $app, User $user)

The parameter $app is not used and could be removed.

  {
    return response()->json(['id' => $user->getId()]);

The method json does only exist in Laravel\Lumen\Http\ResponseFactory, but not in Illuminate\Http\Response.

  }

  /**
   * @return JsonResponse
   */
  public function userId(): JsonResponse
  {
    /** @noinspection PhpUnhandledExceptionInspection */
    return response()->json(['id' => Auth::user()->getAuthIdentifier()]);

The method json does only exist in Laravel\Lumen\Http\ResponseFactory, but not in Illuminate\Http\Response.

  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Protected Methods">
  /**
   * Gets additional input specifications for the login action
   * @param array $specification the specification to add to / modify
   */
  protected function addAdditionalLoginSpecifications(array &$specification)

The parameter $specification is not used and could be removed.

  {
    //do nothing by default
  }

  /**
   * adds additional register specifications
   * @param array $specification the specification to add to / modify
   */
  protected function addAdditionalRegisterSpecifications(array &$specification)

The parameter $specification is not used and could be removed.

  {
    //do nothing by default
  }

  /**
   * creates additional entities after registration using the specification and the given input
   * @param User $user the newly registered user
   * @param array $specification the specification
   * @param array $input the given request input
   */
  protected function createAdditionalRegisterEntities(User $user, array $specification, array $input)

The parameter $user is not used and could be removed.

The parameter $specification is not used and could be removed.

The parameter $input is not used and could be removed.

  {
    //do nothing by default
  }

  /**
   * Gets the response for a successful login action
   * @param Request $request the request
   * @param string $token the login token
   * @return JsonResponse the response
   */
  protected function getLoginResponse(Request $request, string $token): JsonResponse
  {
    $user = $request->user();
    return response()->json(['id' => $user->getId()], 200, ['jwt-token' => $token]);

The method json does only exist in Laravel\Lumen\Http\ResponseFactory, but not in Illuminate\Http\Response.

  }
//</editor-fold desc="Protected Methods">

//<editor-fold desc="Private Methods">
  /**
   * Gets the specification for the login credentials
   * @param Application $app
   * @return array
   */
  private function getCredentialSpecification(Application $app)
  {
    /** @var Hasher $hasher */
    return [
      'email' => ['validation' => 'required|email'],
      'password' => ['validation' => 'required|string|min:8',
        'transformer' => function ($value) use ($app) {
          return $app['hash']->make($value);
        }]
    ];
  }
//</editor-fold desc="Private Methods">
}