Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
37 | class PhaseTest extends UnitTestCase |
||
|
|||
38 | { |
||
39 | //<editor-fold desc="Public Methods"> |
||
40 | /** |
||
41 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::setCompetition |
||
42 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getCompetition |
||
43 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getParent |
||
44 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::getPhaseNumber |
||
45 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::setPhaseNumber |
||
46 | */ |
||
47 | public function testCompetitionAndParent() |
||
69 | |||
70 | /** |
||
71 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::init |
||
72 | * @uses \Tfboe\FmLib\Entity\Helpers\NameEntity::getName |
||
73 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::getPostQualifications |
||
74 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::getPreQualifications |
||
75 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::getRankings |
||
76 | */ |
||
77 | View Code Duplication | public function testInit() |
|
89 | |||
90 | /** |
||
91 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getLevel |
||
92 | */ |
||
93 | public function testLevel() |
||
97 | |||
98 | /** |
||
99 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getMatches |
||
100 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getChildren |
||
101 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::init |
||
102 | */ |
||
103 | View Code Duplication | public function testMatchesAndChildren() |
|
115 | |||
116 | /** |
||
117 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getPostQualifications |
||
118 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::init |
||
119 | * @uses \Tfboe\FmLib\Entity\QualificationSystem |
||
120 | * @uses \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct |
||
121 | */ |
||
122 | View Code Duplication | public function testNextQualificationSystems() |
|
131 | |||
132 | /** |
||
133 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::setPhaseNumber |
||
134 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getPhaseNumber |
||
135 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getLocalIdentifier |
||
136 | */ |
||
137 | public function testPhaseNumberAndLocalIdentifier() |
||
144 | |||
145 | /** |
||
146 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getPreQualifications |
||
147 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::init |
||
148 | * @uses \Tfboe\FmLib\Entity\QualificationSystem |
||
149 | */ |
||
150 | View Code Duplication | public function testPreviousQualificationSystems() |
|
159 | |||
160 | /** |
||
161 | * @covers \Tfboe\FmLib\Entity\Traits\Phase::getRankings |
||
162 | * @uses \Tfboe\FmLib\Entity\Traits\Phase::init |
||
163 | * @uses \Tfboe\FmLib\Entity\Ranking |
||
164 | * @uses \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct |
||
165 | */ |
||
166 | View Code Duplication | public function testRankings() |
|
176 | //</editor-fold desc="Public Methods"> |
||
177 | |||
178 | //<editor-fold desc="Private Methods"> |
||
179 | /** |
||
180 | * @return Phase|MockObject a new phase |
||
181 | */ |
||
182 | private function phase(): MockObject |
||
186 | //</editor-fold desc="Private Methods"> |
||
187 | } |
Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule.