GameTest - Code Metrics - Inspection of "changes tournament hierarchy entities to traits wi..." - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 685463...a3ac99 )

by Benedikt

created 2018-01-29 17:26 UTC

GameTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	130
Duplicated Lines	20.77 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	27
loc	130
c	0
b	0
f	0
rs	10
wmc	8
lcom	1
cbo	4

8 Methods

Rating	Name	Duplication	Size	Complexity
A	testChildren()	0	6	1
A	testGameNumberAndLocalIdentifier()	0	8	1
A	testInit()	0	9	1
A	testLevel()	0	4	1
B	testMatchAndParent()	27	27	1
A	testPlayersA()	0	10	1
A	testPlayersB()	0	10	1
A	game()	0	4	1

How to fix Duplicated Code

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 10/1/17
 * Time: 1:11 PM
 */

namespace Tfboe\FmLib\Tests\Unit\Entity\Traits;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use PHPUnit\Framework\MockObject\MockObject;
use Tfboe\FmLib\Entity\MatchInterface;
use Tfboe\FmLib\Entity\Player;
use Tfboe\FmLib\Entity\Traits\Game;
use Tfboe\FmLib\Helpers\Level;
use Tfboe\FmLib\TestHelpers\UnitTestCase;


/**
 * Class GameTest
 * @package Tfboe\FmLib\Tests\Unit\Entity
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class GameTest extends UnitTestCase
{
//<editor-fold desc="Public Methods">
  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getChildren
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::init
   */
  public function testChildren()
  {
    $game = $this->game();
    $game->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEmpty($game->getChildren());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::setGameNumber
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getGameNumber
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getLocalIdentifier
   * @uses   \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
   */
  public function testGameNumberAndLocalIdentifier()
  {
    $game = $this->game();
    $gameNumber = 1;
    $game->setGameNumber($gameNumber);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($gameNumber, $game->getGameNumber());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($game->getGameNumber(), $game->getLocalIdentifier());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::init
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::getPlayersA
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::getPlayersB
   */
  public function testInit()
  {
    $game = $this->game();
    $game->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertInstanceOf(Collection::class, $game->getPlayersA());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertInstanceOf(Collection::class, $game->getPlayersB());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(0, $game->getPlayersA()->count());
    self::assertEquals(0, $game->getPlayersB()->count());
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getLevel
   */
  public function testLevel()
  {
    self::assertEquals(Level::GAME, $this->game()->getLevel());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::setMatch
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getMatch
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getParent
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::getGameNumber
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::setGameNumber
   */
  public function testMatchAndParent()

  {
    $game = $this->game();
    $match = $this->createMock(MatchInterface::class);
    $games = new ArrayCollection();
    $match->method('getGames')->willReturn($games);
    $game->setGameNumber(1);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    /** @var MatchInterface $match */
    $game->setMatch($match);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($match, $game->getMatch());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(1, $game->getMatch()->getGames()->count());
    self::assertEquals($game, $game->getMatch()->getGames()[$game->getGameNumber()]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($game->getMatch(), $game->getParent());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    $match2 = $this->createMock(MatchInterface::class);
    $games2 = new ArrayCollection();
    $match2->method('getGames')->willReturn($games2);

    /** @var MatchInterface $match2 */
    $game->setMatch($match2);
    self::assertEquals($match2, $game->getMatch());
    self::assertEquals(1, $game->getMatch()->getGames()->count());
    self::assertEquals(0, $match->getGames()->count());
    self::assertEquals($game, $game->getMatch()->getGames()[$game->getGameNumber()]);
    self::assertEquals($game->getMatch(), $game->getParent());
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getPlayersA
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::init
   * @uses   \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
   */
  public function testPlayersA()
  {
    $game = $this->game();
    $game->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    /** @var Player $player */
    $player = $this->createStubWithId(Player::class, 1, 'getPlayerId');
    $game->getPlayersA()->set($player->getPlayerId(), $player);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(1, $game->getPlayersA()->count());
    self::assertEquals($player, $game->getPlayersA()[$player->getPlayerId()]);
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Game::getPlayersB
   * @uses   \Tfboe\FmLib\Entity\Traits\Game::init
   * @uses   \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
   */
  public function testPlayersB()
  {
    $game = $this->game();
    $game->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    /** @var Player $player */
    $player = $this->createStubWithId(Player::class, 1, 'getPlayerId');
    $game->getPlayersB()->set($player->getPlayerId(), $player);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(1, $game->getPlayersB()->count());
    self::assertEquals($player, $game->getPlayersB()[$player->getPlayerId()]);
  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Private Methods">
  /**
   * @return Game|MockObject a new game
   */
  private function game(): MockObject
  {
    return $this->getMockForTrait(Game::class);
  }
//</editor-fold desc="Private Methods">
}

1		<?php
2		declare(strict_types=1);
3		/**
4		* Created by PhpStorm.
5		* User: benedikt
6		* Date: 10/1/17
7		* Time: 1:11 PM
8		*/
9
10		namespace Tfboe\FmLib\Tests\Unit\Entity\Traits;
11
12		use Doctrine\Common\Collections\ArrayCollection;
13		use Doctrine\Common\Collections\Collection;
14		use PHPUnit\Framework\MockObject\MockObject;
15		use Tfboe\FmLib\Entity\MatchInterface;
16		use Tfboe\FmLib\Entity\Player;
17		use Tfboe\FmLib\Entity\Traits\Game;
18		use Tfboe\FmLib\Helpers\Level;
19		use Tfboe\FmLib\TestHelpers\UnitTestCase;
20
21
22		/**
23		* Class GameTest
24		* @package Tfboe\FmLib\Tests\Unit\Entity
25		* @SuppressWarnings(PHPMD.TooManyPublicMethods)
26		*/
27		class GameTest extends UnitTestCase
28		{
29		//<editor-fold desc="Public Methods">
30		/**
31		* @covers \Tfboe\FmLib\Entity\Traits\Game::getChildren
32		* @uses \Tfboe\FmLib\Entity\Traits\Game::init
33		*/
34		public function testChildren()
35		{
36		$game = $this->game();
37		$game->init();
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `init` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38		self::assertEmpty($game->getChildren());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getChildren` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
39		}
40
41		/**
42		* @covers \Tfboe\FmLib\Entity\Traits\Game::setGameNumber
43		* @covers \Tfboe\FmLib\Entity\Traits\Game::getGameNumber
44		* @covers \Tfboe\FmLib\Entity\Traits\Game::getLocalIdentifier
45		* @uses \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
46		*/
47		public function testGameNumberAndLocalIdentifier()
48		{
49		$game = $this->game();
50		$gameNumber = 1;
51		$game->setGameNumber($gameNumber);
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `setGameNumber` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
52		self::assertEquals($gameNumber, $game->getGameNumber());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getGameNumber` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53		self::assertEquals($game->getGameNumber(), $game->getLocalIdentifier());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getLocalIdentifier` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
54		}
55
56		/**
57		* @covers \Tfboe\FmLib\Entity\Traits\Game::init
58		* @uses \Tfboe\FmLib\Entity\Traits\Game::getPlayersA
59		* @uses \Tfboe\FmLib\Entity\Traits\Game::getPlayersB
60		*/
61		public function testInit()
62		{
63		$game = $this->game();
64		$game->init();
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `init` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
65		self::assertInstanceOf(Collection::class, $game->getPlayersA());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getPlayersA` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
66		self::assertInstanceOf(Collection::class, $game->getPlayersB());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getPlayersB` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67		self::assertEquals(0, $game->getPlayersA()->count());
68		self::assertEquals(0, $game->getPlayersB()->count());
69		}
70
71		/**
72		* @covers \Tfboe\FmLib\Entity\Traits\Game::getLevel
73		*/
74		public function testLevel()
75		{
76		self::assertEquals(Level::GAME, $this->game()->getLevel());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getLevel` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
77		}
78
79		/**
80		* @covers \Tfboe\FmLib\Entity\Traits\Game::setMatch
81		* @covers \Tfboe\FmLib\Entity\Traits\Game::getMatch
82		* @covers \Tfboe\FmLib\Entity\Traits\Game::getParent
83		* @uses \Tfboe\FmLib\Entity\Traits\Game::getGameNumber
84		* @uses \Tfboe\FmLib\Entity\Traits\Game::setGameNumber
85		*/
86	View Code Duplication	public function testMatchAndParent()
		0 ignored issues – show Duplication introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$game = $this->game();
89		$match = $this->createMock(MatchInterface::class);
90		$games = new ArrayCollection();
91		$match->method('getGames')->willReturn($games);
92		$game->setGameNumber(1);
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `setGameNumber` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
93
94		/** @var MatchInterface $match */
95		$game->setMatch($match);
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `setMatch` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
96		self::assertEquals($match, $game->getMatch());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getMatch` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
97		self::assertEquals(1, $game->getMatch()->getGames()->count());
98		self::assertEquals($game, $game->getMatch()->getGames()[$game->getGameNumber()]);
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getGameNumber` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
99		self::assertEquals($game->getMatch(), $game->getParent());
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getParent` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
100
101		$match2 = $this->createMock(MatchInterface::class);
102		$games2 = new ArrayCollection();
103		$match2->method('getGames')->willReturn($games2);
104
105		/** @var MatchInterface $match2 */
106		$game->setMatch($match2);
107		self::assertEquals($match2, $game->getMatch());
108		self::assertEquals(1, $game->getMatch()->getGames()->count());
109		self::assertEquals(0, $match->getGames()->count());
110		self::assertEquals($game, $game->getMatch()->getGames()[$game->getGameNumber()]);
111		self::assertEquals($game->getMatch(), $game->getParent());
112		}
113
114		/**
115		* @covers \Tfboe\FmLib\Entity\Traits\Game::getPlayersA
116		* @uses \Tfboe\FmLib\Entity\Traits\Game::init
117		* @uses \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
118		*/
119		public function testPlayersA()
120		{
121		$game = $this->game();
122		$game->init();
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `init` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
123		/** @var Player $player */
124		$player = $this->createStubWithId(Player::class, 1, 'getPlayerId');
125		$game->getPlayersA()->set($player->getPlayerId(), $player);
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getPlayersA` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
126		self::assertEquals(1, $game->getPlayersA()->count());
127		self::assertEquals($player, $game->getPlayersA()[$player->getPlayerId()]);
128		}
129
130		/**
131		* @covers \Tfboe\FmLib\Entity\Traits\Game::getPlayersB
132		* @uses \Tfboe\FmLib\Entity\Traits\Game::init
133		* @uses \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
134		*/
135		public function testPlayersB()
136		{
137		$game = $this->game();
138		$game->init();
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `init` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
139		/** @var Player $player */
140		$player = $this->createStubWithId(Player::class, 1, 'getPlayerId');
141		$game->getPlayersB()->set($player->getPlayerId(), $player);
		0 ignored issues – show Bug introduced 2018-01-29 17:40 UTC by Report Bug Copy Issue Report The method `getPlayersB` does only exist in `Tfboe\FmLib\Entity\Traits\Game`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
142		self::assertEquals(1, $game->getPlayersB()->count());
143		self::assertEquals($player, $game->getPlayersB()[$player->getPlayerId()]);
144		}
145		//</editor-fold desc="Public Methods">
146
147		//<editor-fold desc="Private Methods">
148		/**
149		* @return Game\|MockObject a new game
150		*/
151		private function game(): MockObject
152		{
153		return $this->getMockForTrait(Game::class);
154		}
155		//</editor-fold desc="Private Methods">
156		}

tfboe / fm-lib

Push — master ( 685463...a3ac99 )

GameTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like