CompetitionTest - Code Metrics - Inspection of "changes tournament hierarchy entities to traits wi..." - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 685463...a3ac99 )

by Benedikt

created 2018-01-29 17:26 UTC

CompetitionTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	123
Duplicated Lines	21.95 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	27
loc	123
c	0
b	0
f	0
rs	10
wmc	7
lcom	1
cbo	5

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetLocalIdentifier()	0	6	1
A	testInit()	0	9	1
A	testLevel()	0	4	1
A	testPhasesAndChildren()	0	13	1
A	testTeams()	0	10	1
B	testTournamentAndParent()	27	27	1
A	competition()	0	4	1

How to fix Duplicated Code

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 10/1/17
 * Time: 1:11 PM
 */

namespace Tfboe\FmLib\Tests\Unit\Entity\Traits;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use PHPUnit\Framework\MockObject\MockObject;
use Tfboe\FmLib\Entity\Team;
use Tfboe\FmLib\Entity\TournamentInterface;
use Tfboe\FmLib\Entity\Traits\Competition;
use Tfboe\FmLib\Entity\Traits\Phase;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Tfboe\FmLib\Helpers\Level;
use Tfboe\FmLib\TestHelpers\UnitTestCase;

/**
 * Class TournamentTest
 * @package Tfboe\FmLib\Tests\Unit\Entity
 */
class CompetitionTest extends UnitTestCase
{
//<editor-fold desc="Public Methods">
  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getLocalIdentifier
   * @uses   \Tfboe\FmLib\Entity\Helpers\NameEntity::getName
   * @uses   \Tfboe\FmLib\Entity\Helpers\NameEntity::setName
   */
  public function testGetLocalIdentifier()
  {
    $entity = $this->competition();
    $entity->setName("Name");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($entity->getName(), $entity->getLocalIdentifier());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::init
   * @uses   \Tfboe\FmLib\Entity\Traits\Competition::getPhases
   * @uses   \Tfboe\FmLib\Entity\Traits\Competition::getTeams
   */
  public function testInit()
  {
    $competition = $this->competition();
    $competition->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertInstanceOf(Collection::class, $competition->getTeams());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertInstanceOf(Collection::class, $competition->getPhases());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(0, $competition->getTeams()->count());
    self::assertEquals(0, $competition->getPhases()->count());
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getLevel()
   */
  public function testLevel()
  {
    self::assertEquals(Level::COMPETITION, $this->competition()->getLevel());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getPhases
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getChildren
   * @uses   \Tfboe\FmLib\Entity\Traits\Phase
   * @uses   \Tfboe\FmLib\Entity\Traits\Competition::init
   * @uses   \Tfboe\FmLib\Entity\Traits\Competition::init
   */
  public function testPhasesAndChildren()
  {
    $competition = $this->competition();
    $competition->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    /** @var Phase $phase */
    $phase = $this->getMockForTrait(Phase::class);
    $phase->setPhaseNumber(1);
    self::assertEquals($competition->getPhases(), $competition->getChildren());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    $competition->getPhases()->set($phase->getPhaseNumber(), $phase);
    self::assertEquals(1, $competition->getPhases()->count());
    self::assertEquals($phase, $competition->getPhases()[1]);
    self::assertEquals($competition->getPhases(), $competition->getChildren());
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getTeams
   * @uses   \Tfboe\FmLib\Entity\Traits\Competition::init
   * @uses   \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
   * @uses   \Tfboe\FmLib\Entity\Team
   */
  public function testTeams()
  {
    $competition = $this->competition();
    $competition->init();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    $team = new Team();
    $team->setStartNumber(1);
    $competition->getTeams()->set($team->getStartNumber(), $team);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(1, $competition->getTeams()->count());
    self::assertEquals($team, $competition->getTeams()[1]);
  }

  /**
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::setTournament()
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getTournament()
   * @covers \Tfboe\FmLib\Entity\Traits\Competition::getParent()
   * @uses   \Tfboe\FmLib\Entity\Helpers\TournamentHierarchyEntity::__construct
   * @uses   \Tfboe\FmLib\Entity\Helpers\NameEntity::getName
   * @uses   \Tfboe\FmLib\Entity\Helpers\NameEntity::setName
   */
  public function testTournamentAndParent()

  {
    $competition = $this->competition();
    $tournament = $this->createMock(TournamentInterface::class);
    $competitions = new ArrayCollection();
    $tournament->method('getCompetitions')->willReturn($competitions);
    $competition->setName('test competition');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    /** @var TournamentInterface $tournament */
    $competition->setTournament($tournament);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($tournament, $competition->getTournament());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals($competition->getTournament(), $competition->getParent());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertEquals(1, $competition->getTournament()->getCompetitions()->count());
    self::assertEquals($competition, $competition->getTournament()->getCompetitions()[$competition->getName()]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    $tournament2 = $this->createMock(TournamentInterface::class);
    $competitions2 = new ArrayCollection();
    $tournament2->method('getCompetitions')->willReturn($competitions2);
    /** @var TournamentInterface $tournament2 */
    $competition->setTournament($tournament2);

    self::assertEquals($tournament2, $competition->getTournament());
    self::assertEquals($competition->getTournament(), $competition->getParent());
    self::assertEquals(1, $competition->getTournament()->getCompetitions()->count());
    self::assertEquals(0, $tournament->getCompetitions()->count());
    self::assertEquals($competition, $competition->getTournament()->getCompetitions()[$competition->getName()]);
  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Private Methods">
  /**
   * @return Competition|MockObject a new competition
   */
  private function competition(): MockObject
  {
    return $this->getMockForTrait(Competition::class);
  }
//</editor-fold desc="Private Methods">
}

Push — master ( 685463...a3ac99 )

CompetitionTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

tfboe / fm-lib

Push — master ( 685463...a3ac99 )

CompetitionTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like