PlayerServiceTest::testMergePlayer() - Code Metrics - Inspection of "adds basic services from fdm-backend to this lib t..." - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f572e...bf04a1 )

by Benedikt

created 2018-06-17 13:34 UTC

PlayerServiceTest::testMergePlayer() A

↳ Parent: PlayerServiceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	65
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	65
c	0
b	0
f	0
cc	1
eloc	41
nc	1
nop	0
rs	9.3571

How to fix Long Method

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 1/3/18
 * Time: 3:53 PM
 */

namespace Tfboe\FmLib\Tests\Unit\Service;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\MockObject\MockObject;
use Tfboe\FmLib\Entity\CompetitionInterface;
use Tfboe\FmLib\Entity\GameInterface;
use Tfboe\FmLib\Entity\MatchInterface;
use Tfboe\FmLib\Entity\PhaseInterface;
use Tfboe\FmLib\Entity\PlayerInterface;
use Tfboe\FmLib\Entity\TeamInterface;
use Tfboe\FmLib\Entity\TeamMembershipInterface;
use Tfboe\FmLib\Entity\TournamentInterface;
use Tfboe\FmLib\Service\DeletionServiceInterface;
use Tfboe\FmLib\Service\LoadingServiceInterface;
use Tfboe\FmLib\Service\PlayerService;
use Tfboe\FmLib\Service\RankingSystemServiceInterface;
use Tfboe\FmLib\Tests\Helpers\UnitTestCase;


/**
 * Class DeletionServiceTest
 * @package Tfboe\FmLib\Tests\Unit\Service
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class PlayerServiceTest extends UnitTestCase
{
//<editor-fold desc="Public Methods">
  /**
   * @covers \Tfboe\FmLib\Service\PlayerService::__construct
   */
  public function testConstruct()
  {
    /** @var EntityManagerInterface $em */
    $em = $this->createMock(EntityManagerInterface::class);
    /** @var LoadingServiceInterface $ls */
    $ls = $this->createMock(LoadingServiceInterface::class);
    /** @var DeletionServiceInterface $deletionService */
    $deletionService = $this->createMock(DeletionServiceInterface::class);
    /** @var RankingSystemServiceInterface $rankingSystemService */
    $rankingSystemService = $this->createMock(RankingSystemServiceInterface::class);
    $service = new PlayerService($em, $ls, $deletionService, $rankingSystemService);
    self::assertInstanceOf(PlayerService::class, $service);
  }

  /**
   * @covers \Tfboe\FmLib\Service\PlayerService::mergePlayers
   * @uses   \Tfboe\FmLib\Service\PlayerService::__construct
   */
  public function testMergeBothPlayersInSameTournament()
  {
    $player1 = $this->createStubWithId(PlayerInterface::class, "p1");
    $player2 = $this->createStubWithId(PlayerInterface::class, "p2");
    $team1 = $this->createStub(TeamInterface::class, [
      'getMemberships' => new ArrayCollection([$this->createStub(TeamMembershipInterface::class, [
        'getPlayer' => $player1
      ])])
    ]);
    $team2 = $this->createStub(TeamInterface::class, [
      'getMemberships' => new ArrayCollection([$this->createStub(TeamMembershipInterface::class, [
        'getPlayer' => $player2
      ])])
    ]);

    $competition = $this->createStub(CompetitionInterface::class, [
      'getTeams' => new ArrayCollection([$team1, $team2])
    ]);

    $tournament = $this->createStub(TournamentInterface::class, [
      'getCompetitions' => new ArrayCollection([$competition]),
      'getName' => 'Tournament',
      'getId' => 't',
      'getStartTime' => new \DateTime("2000-01-01")
    ]);

    /** @var EntityManagerInterface $em */
    $em = $this->getEntityManagerMockForQuery([$tournament],
      'SELECT t FROM Tfboe\FmLib\Entity\TournamentInterface t INNER JOIN t.competitions c INNER JOIN c.teams te ' .
      'INNER JOIN te.memberships m WHERE m.player = (:id)');

    $service = new PlayerService($em,
      $this->createStub(LoadingServiceInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      $this->createStub(DeletionServiceInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      $this->createStub(RankingSystemServiceInterface::class)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    );

    self::assertEquals('Player 1 and player 2 both attended the tournament Tournament(01.01.2000 12:01, id=\'t\')',
      $service->mergePlayers($player1, $player2));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
  }

  /**
   * @covers \Tfboe\FmLib\Service\PlayerService::mergePlayers
   * @uses   \Tfboe\FmLib\Service\PlayerService::__construct
   */
  public function testMergeIdenticalPlayer()
  {
    $player1 = $this->createStubWithId(PlayerInterface::class, "p1");
    $player2 = $this->createStubWithId(PlayerInterface::class, "p1");


    $service = new PlayerService(
      $this->createStub(EntityManagerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      $this->createStub(LoadingServiceInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      $this->createStub(DeletionServiceInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      $this->createStub(RankingSystemServiceInterface::class)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    );

    self::assertEquals('Players are identical!', $service->mergePlayers($player1, $player2));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
  }

  /**
   * @covers \Tfboe\FmLib\Service\PlayerService::mergePlayers
   * @uses   \Tfboe\FmLib\Service\PlayerService::__construct
   */
  public function testMergePlayer()
  {
    $tournament = $this->createStub(TournamentInterface::class);
    $player1 = $this->createStubWithId(PlayerInterface::class, "p1");
    $player2 = $this->createStubWithId(PlayerInterface::class, "p2");
    $otherPlayer = $this->createStubWithId(PlayerInterface::class, "oP");
    $team1Membership = $this->createStub(TeamMembershipInterface::class, ['getPlayer' => $player2]);
    $team1Membership->method('setPlayer')->with($player1);
    $team1 = $this->createStub(TeamInterface::class, [
      'getMemberships' => new ArrayCollection([$team1Membership])
    ]);
    $otherTeam = $this->createStub(TeamInterface::class, [
      'getMemberships' => new ArrayCollection([$this->createStub(TeamMembershipInterface::class, [
        'getPlayer' => $otherPlayer
      ])])
    ]);

    $game1PlayersB = new ArrayCollection([$player2->getId() => $player2]);
    $game1 = $this->createStub(GameInterface::class, [
      'getPlayersA' => new ArrayCollection([$otherPlayer->getId() => $otherPlayer]),
      'getPlayersB' => $game1PlayersB
    ]);

    $game2PlayersA = new ArrayCollection([$player2->getId() => $player2]);
    $game2 = $this->createStub(GameInterface::class, [
      'getPlayersA' => $game2PlayersA,
      'getPlayersB' => new ArrayCollection([$otherPlayer->getId() => $otherPlayer])
    ]);

    $competition = $this->createStub(CompetitionInterface::class, [
      'getTeams' => new ArrayCollection([$team1, $otherTeam]),
      'getPhases' => new ArrayCollection([$this->createStub(PhaseInterface::class, [
        'getMatches' => new ArrayCollection([$this->createStub(MatchInterface::class, [
          'getGames' => new ArrayCollection([$game1, $game2])
        ])])
      ])])
    ]);


    /** @var EntityManagerInterface $em */
    $em = $this->getEntityManagerMockForQuery([$tournament],
      'SELECT t FROM Tfboe\FmLib\Entity\TournamentInterface t INNER JOIN t.competitions c INNER JOIN c.teams te ' .
      'INNER JOIN te.memberships m WHERE m.player = (:id)');
    /** @var LoadingServiceInterface|MockObject $ls */
    $ls = $this->createMock(LoadingServiceInterface::class);
    $ls->expects(self::once())->method('loadEntities')->with([$tournament])->willReturnCallback(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
      function ($a) use ($competition) {
        /** @var TournamentInterface|MockObject $t */
        $t = $a[0];
        $t->method('getCompetitions')->willReturn(new ArrayCollection([$competition]));
      });
    /** @var DeletionServiceInterface|MockObject $deletionService */
    $deletionService = $this->createMock(DeletionServiceInterface::class);
    $deletionService->expects(self::once())->method('deletePlayer')->with($player2);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    /** @var RankingSystemServiceInterface|MockObject $rankingSystemService */
    $rankingSystemService = $this->createMock(RankingSystemServiceInterface::class);
    $rankingSystemService->method('adaptOpenSyncFromValues')->with($tournament, []);

    $service = new PlayerService($em, $ls, $deletionService, $rankingSystemService);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

    self::assertEquals(true, $service->mergePlayers($player1, $player2));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    self::assertEquals($game1PlayersB, new ArrayCollection([$player1->getId() => $player1]));
    self::assertEquals($game2PlayersA, new ArrayCollection([$player1->getId() => $player1]));
  }
//</editor-fold desc="Public Methods">
}

Push — master ( 7f572e...bf04a1 )

PlayerServiceTest::testMergePlayer() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

1			<?php
2			declare(strict_types=1);
3			/**
4			* Created by PhpStorm.
5			* User: benedikt
6			* Date: 1/3/18
7			* Time: 3:53 PM
8			*/
9
10			namespace Tfboe\FmLib\Tests\Unit\Service;
11
12			use Doctrine\Common\Collections\ArrayCollection;
13			use Doctrine\ORM\EntityManagerInterface;
14			use PHPUnit\Framework\MockObject\MockObject;
15			use Tfboe\FmLib\Entity\CompetitionInterface;
16			use Tfboe\FmLib\Entity\GameInterface;
17			use Tfboe\FmLib\Entity\MatchInterface;
18			use Tfboe\FmLib\Entity\PhaseInterface;
19			use Tfboe\FmLib\Entity\PlayerInterface;
20			use Tfboe\FmLib\Entity\TeamInterface;
21			use Tfboe\FmLib\Entity\TeamMembershipInterface;
22			use Tfboe\FmLib\Entity\TournamentInterface;
23			use Tfboe\FmLib\Service\DeletionServiceInterface;
24			use Tfboe\FmLib\Service\LoadingServiceInterface;
25			use Tfboe\FmLib\Service\PlayerService;
26			use Tfboe\FmLib\Service\RankingSystemServiceInterface;
27			use Tfboe\FmLib\Tests\Helpers\UnitTestCase;
28
29
30			/**
31			* Class DeletionServiceTest
32			* @package Tfboe\FmLib\Tests\Unit\Service
33			* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
34			*/
35			class PlayerServiceTest extends UnitTestCase
36			{
37			//<editor-fold desc="Public Methods">
38			/**
39			* @covers \Tfboe\FmLib\Service\PlayerService::__construct
40			*/

tfboe / fm-lib

Push — master ( 7f572e...bf04a1 )

PlayerServiceTest::testMergePlayer() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like