tfboe /
fm-lib
| Conditions | 19 |
| Paths | 343 |
| Total Lines | 74 |
| Code Lines | 44 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 67 | public function mergePlayers(PlayerInterface $player, PlayerInterface $toMerge) |
||
| 68 | { |
||
| 69 | if ($player->getId() == $toMerge->getId()) { |
||
| 70 | return "Players are identical!"; |
||
| 71 | } |
||
| 72 | |||
| 73 | /** @var TournamentInterface[] $ts */ |
||
| 74 | $ts = $this->em->createQueryBuilder() |
||
| 75 | ->select("t") |
||
| 76 | ->from(TournamentInterface::class, 't') |
||
| 77 | ->innerJoin('t.competitions', 'c') |
||
| 78 | ->innerJoin('c.teams', 'te') |
||
| 79 | ->innerJoin('te.memberships', 'm') |
||
| 80 | ->where('m.player = (:id)')->setParameter('id', $toMerge->getId()) |
||
| 81 | ->getQuery()->getResult(); |
||
| 82 | |||
| 83 | $tMap = []; |
||
| 84 | foreach ($ts as $tournament) { |
||
| 85 | $tMap[$tournament->getId()] = $tournament; |
||
| 86 | } |
||
| 87 | $ts = array_values($tMap); |
||
| 88 | |||
| 89 | $this->ls->loadEntities($ts); |
||
| 90 | |||
| 91 | //check if player is attendant in one of the tournaments of toMerge |
||
| 92 | foreach ($ts as $tournament) { |
||
| 93 | foreach ($tournament->getCompetitions() as $competition) { |
||
| 94 | foreach ($competition->getTeams() as $team) { |
||
| 95 | foreach ($team->getMemberships() as $membership) { |
||
| 96 | if ($membership->getPlayer()->getId() == $player->getId()) { |
||
| 97 | return "Player 1 and player 2 both attended the tournament " . $tournament->getName() . |
||
| 98 | "(" . $tournament->getStartTime()->format('d.m.Y h:m') . ", id='" . $tournament->getId() . "')"; |
||
| 99 | } |
||
| 100 | } |
||
| 101 | } |
||
| 102 | } |
||
| 103 | } |
||
| 104 | |||
| 105 | //change players |
||
| 106 | foreach ($ts as $tournament) { |
||
| 107 | foreach ($tournament->getCompetitions() as $competition) { |
||
| 108 | $isMember = false; |
||
| 109 | foreach ($competition->getTeams() as $team) { |
||
| 110 | foreach ($team->getMemberships() as $membership) { |
||
| 111 | if ($membership->getPlayer()->getId() == $toMerge->getId()) { |
||
| 112 | $this->rankingSystemService->adaptOpenSyncFromValues($tournament, []); |
||
| 113 | $membership->setPlayer($player); |
||
| 114 | $isMember = true; |
||
| 115 | } |
||
| 116 | } |
||
| 117 | } |
||
| 118 | if ($isMember) { |
||
| 119 | foreach ($competition->getPhases() as $phase) { |
||
| 120 | foreach ($phase->getMatches() as $match) { |
||
| 121 | foreach ($match->getGames() as $game) { |
||
| 122 | if ($game->getPlayersA()->containsKey($toMerge->getId())) { |
||
| 123 | $game->getPlayersA()->remove($toMerge->getId()); |
||
| 124 | $game->getPlayersA()->set($player->getId(), $player); |
||
| 125 | } |
||
| 126 | if ($game->getPlayersB()->containsKey($toMerge->getId())) { |
||
| 127 | $game->getPlayersB()->remove($toMerge->getId()); |
||
| 128 | $game->getPlayersB()->set($player->getId(), $player); |
||
| 129 | } |
||
| 130 | } |
||
| 131 | } |
||
| 132 | } |
||
| 133 | } |
||
| 134 | } |
||
| 135 | } |
||
| 136 | |||
| 137 | $this->deletionService->deletePlayer($toMerge); |
||
| 138 | |||
| 139 | return true; |
||
| 140 | } |
||
| 141 | //</editor-fold desc="Public Methods"> |
||
| 142 | } |
