ServiceProviderTest::provider() - Code Metrics - Inspection of "100% unit test coverage :)" - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — merging-leagues-tournaments (46817d)

by Benedikt

created 2019-10-19 09:37 UTC

ServiceProviderTest::provider() A

↳ Parent: ServiceProviderTest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 9/17/17
 * Time: 12:33 AM
 */

namespace Tfboe\FmLib\Tests\Unit\Providers;

use Illuminate\Contracts\Foundation\Application;
use PHPUnit\Framework\MockObject\MockObject;
use ReflectionException;
use Tfboe\FmLib\Providers\ServiceProvider;
use Tfboe\FmLib\TestHelpers\UnitTestCase;

/**
 * Class BaseControllerTest
 * @package Tests\Unit\App\Http\Controllers
 */
class ServiceProviderTest extends UnitTestCase
{
  //tests also private method disable this tests as soon as all are used in public interfaces
//<editor-fold desc="Public Methods">

  /**
   * @covers \Tfboe\FmLib\Providers\ServiceProvider::register
   * @throws ReflectionException
   * @throws ReflectionException
   */
  public function testRegister()
  {
    $app = $this->createMock(Application::class);

    $app->expects(self::exactly(3))->method('singleton')->withConsecutive(
      ['Interface', 'Implementation'],
      ['ClassInterface', 'Class'],
      ['OtherClass']
    );

    $provider = $this->provider($app);
    $prop = static::getProperty(ServiceProvider::class, 'singletons');
    $prop->setValue($provider, ['Interface' => 'Implementation', 'ClassInterface', 'OtherClass']);

    $provider->register();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Private Methods">
  /**
   * @param null|Application|MockObject $app
   * @return MockObject|ServiceProvider
   * @throws ReflectionException
   */
  private function provider($app = null): MockObject
  {
    if ($app === null) {
      $app = $this->createMock(Application::class);
    }
    return $this->getMockForAbstractClass(ServiceProvider::class, [$app]);
  }
//</editor-fold desc="Private Methods">
}

1			<?php
2			declare(strict_types=1);
3
4			/**
5			* Created by PhpStorm.
6			* User: benedikt
7			* Date: 9/17/17
8			* Time: 12:33 AM
9			*/
10
11			namespace Tfboe\FmLib\Tests\Unit\Providers;
12
13			use Illuminate\Contracts\Foundation\Application;
14			use PHPUnit\Framework\MockObject\MockObject;
15			use ReflectionException;
16			use Tfboe\FmLib\Providers\ServiceProvider;
17			use Tfboe\FmLib\TestHelpers\UnitTestCase;
18
19			/**
20			* Class BaseControllerTest
21			* @package Tests\Unit\App\Http\Controllers
22			*/
23			class ServiceProviderTest extends UnitTestCase
24			{
25			//tests also private method disable this tests as soon as all are used in public interfaces
26			//<editor-fold desc="Public Methods">
27
28			/**
29			* @covers \Tfboe\FmLib\Providers\ServiceProvider::register
30			* @throws ReflectionException
31			* @throws ReflectionException
32			*/
33			public function testRegister()
34			{
35			$app = $this->createMock(Application::class);
36
37			$app->expects(self::exactly(3))->method('singleton')->withConsecutive(
38			['Interface', 'Implementation'],
39			['ClassInterface', 'Class'],
40			['OtherClass']
41			);
42
43			$provider = $this->provider($app);
44			$prop = static::getProperty(ServiceProvider::class, 'singletons');
45			$prop->setValue($provider, ['Interface' => 'Implementation', 'ClassInterface', 'OtherClass']);
46
47			$provider->register();
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report The method `register` does only exist in `Tfboe\FmLib\Providers\ServiceProvider`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48			}
49			//</editor-fold desc="Public Methods">
50
51			//<editor-fold desc="Private Methods">
52			/**
53			* @param null\|Application\|MockObject $app
54			* @return MockObject\|ServiceProvider
55			* @throws ReflectionException
56			*/
57			private function provider($app = null): MockObject
58			{
59			if ($app === null) {
60			$app = $this->createMock(Application::class);
61			}
62			return $this->getMockForAbstractClass(ServiceProvider::class, [$app]);
63			}
64			//</editor-fold desc="Private Methods">
65			}

tfboe / fm-lib

Branch — merging-leagues-tournaments (46817d)

ServiceProviderTest::provider() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like