Tfboe\FmLib\Tests\Unit\Service\TermsServiceTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testConstructor()	0	5	1
A	testGetLatestTerms()	0	8	1
A	service()	0	4	1

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 1/3/18
 * Time: 3:53 PM
 */

namespace Tfboe\FmLib\Tests\Unit\Service;

use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\MockObject\MockObject;
use ReflectionException;
use Tfboe\FmLib\Entity\TermsInterface;
use Tfboe\FmLib\Service\TermsService;
use Tfboe\FmLib\Tests\Helpers\UnitTestCase;


/**
 * Class PlayerServiceTest
 * @package Tfboe\FmLib\Tests\Unit\Service
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class TermsServiceTest extends UnitTestCase
{
//<editor-fold desc="Public Methods">
  /**
   * @covers \Tfboe\FmLib\Service\TermsService::__construct
   */
  public function testConstructor()
  {
    $service = $this->service($this->createStub(EntityManagerInterface::class));
    self::assertInstanceOf(TermsService::class, $service);
  }

  /**
   * @covers \Tfboe\FmLib\Service\TermsService::getLatestTerms
   * @throws ReflectionException
   * @uses   \Tfboe\FmLib\Service\TermsService::__construct
   */
  public function testGetLatestTerms()
  {
    $terms = $this->createStub(TermsInterface::class);
    $em = $this->getEntityManagerMockForQuery([$terms], /** @lang DQL */
      'SELECT e FROM Tfboe\FmLib\Entity\TermsInterface e ORDER BY e.majorVersion DESC, e.minorVersion DESC');
    $service = $this->service($em);
    self::assertTrue($terms === $service->getLatestTerms());
  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Private Methods">
  /**
   * @param EntityManagerInterface|MockObject $em
   * @return TermsService
   */
  private function service($em)
  {
    return new TermsService($em);

It seems like $em defined by parameter $em on line 57 can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Tfboe\FmLib\Service\TermsService::__construct() does only seem to accept object<Doctrine\ORM\EntityManagerInterface>, maybe add an additional type check?

  }
//</editor-fold desc="Private Methods">
}