AuthenticateTest - Code Metrics - Inspection of "100% unit test coverage :)" - tfboe/fm-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — merging-leagues-tournaments (46817d)

by Benedikt

created 2019-10-19 09:37 UTC

AuthenticateTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	162
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	162
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	3

8 Methods

Rating	Name	Size	Complexity
A	testConstruct()	5	1
A	testHandleGuest()	10	1
A	testHandleNoVer()	10	1
A	testHandleOldVersion()	10	1
A	testHandleSuccess()	18	1
A	testHandleWrongUser()	10	1
A	authenticate()	9	2
A	getAuth()	23	2

<?php
declare(strict_types=1);

/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 9/17/17
 * Time: 12:33 AM
 */

namespace Tfboe\FmLib\Tests\Unit\Http\Middleware;

use Illuminate\Contracts\Auth\Factory;
use Illuminate\Http\Request;
use PHPUnit\Framework\MockObject\MockObject;
use ReflectionException;
use Tfboe\FmLib\Entity\UserInterface;
use Tfboe\FmLib\Exceptions\AuthenticationException;
use Tfboe\FmLib\Http\Middleware\Authenticate;
use Tfboe\FmLib\Tests\Helpers\UnitTestCase;
use Tymon\JWTAuth\Contracts\JWTSubject;
use Tymon\JWTAuth\JWTGuard;
use Tymon\JWTAuth\Payload;

/**
 * Class BaseControllerTest
 * @package Tests\Unit\App\Http\Controllers
 */
class AuthenticateTest extends UnitTestCase
{
  //tests also private method disable this tests as soon as all are used in public interfaces
//<editor-fold desc="Public Methods">

  /**
   * @covers \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
   * @throws ReflectionException
   */
  public function testConstruct()
  {
    $authenticate = $this->authenticate();
    self::assertInstanceOf(Authenticate::class, $authenticate);
  }

  /**
   * @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
   * @throws AuthenticationException
   * @throws ReflectionException
   * @uses   \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
   * @uses   \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
   */
  public function testHandleGuest()
  {
    $this->expectException(AuthenticationException::class);
    $this->expectExceptionMessage('Not logged in!');

    $auth = $this->getAuth(true, true, UserInterface::class, 6);
    $authenticate = $this->authenticate($auth);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    $authenticate->handle(null, function () {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }, "guardName");
  }

  /**
   * @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
   * @throws AuthenticationException
   * @throws ReflectionException
   * @uses   \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
   * @uses   \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
   */
  public function testHandleNoVer()
  {
    $this->expectException(AuthenticationException::class);
    $this->expectExceptionMessage('Payload version expired!');

    $auth = $this->getAuth(false, false, UserInterface::class, 6);
    $authenticate = $this->authenticate($auth);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    $authenticate->handle(null, function () {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }, "guardName");
  }

  /**
   * @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
   * @throws AuthenticationException
   * @throws ReflectionException
   * @uses   \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
   * @uses   \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
   */
  public function testHandleOldVersion()
  {
    $this->expectException(AuthenticationException::class);
    $this->expectExceptionMessage('Payload version expired!');

    $auth = $this->getAuth(false, true, UserInterface::class, 8);
    $authenticate = $this->authenticate($auth);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    $authenticate->handle(null, function () {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }, "guardName");
  }

  /**
   * @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
   * @throws AuthenticationException
   * @throws ReflectionException
   * @uses   \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
   */
  public function testHandleSuccess()
  {
    $auth = $this->getAuth(false, true, UserInterface::class, 6);
    /** @var Request $request */
    $request = $this->createMock(Request::class);

    $called = false;
    $next = function ($req) use (&$called, $request) {
      self::assertTrue($request === $req);
      self::assertFalse($called);
      $called = true;
    };

    $authenticate = $this->authenticate($auth);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    self::assertFalse($called);
    $authenticate->handle($request, $next, "guardName");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    self::assertTrue($called);
  }

  /**
   * @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
   * @throws AuthenticationException
   * @throws ReflectionException
   * @uses   \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
   * @uses   \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
   */
  public function testHandleWrongUser()
  {
    $this->expectException(AuthenticationException::class);
    $this->expectExceptionMessage('Payload version expired!');

    $auth = $this->getAuth(false, true, JWTSubject::class, 6);
    $authenticate = $this->authenticate($auth);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    $authenticate->handle(null, function () {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }, "guardName");
  }
//</editor-fold desc="Public Methods">

//<editor-fold desc="Private Methods">
  /**
   * @param Factory|null $auth
   * @param array $stubbedMethods
   * @return Authenticate|MockObject
   * @throws ReflectionException
   */
  private function authenticate(?Factory $auth = null,
                                array $stubbedMethods = []): MockObject
  {
    if ($auth === null) {
      $auth = $this->createMock(Factory::class);
    }
    return $this->getMockForAbstractClass(Authenticate::class, [$auth], '', true,
      true, true, $stubbedMethods);
  }

  /**
   * @param bool $guest
   * @param bool $hasVer
   * @param string $userClass
   * @param int $userConfirmedVersion
   * @return MockObject|Factory
   */
  private function getAuth(bool $guest, bool $hasVer, string $userClass, int $userConfirmedVersion): MockObject
  {
    $guard = $this->createMock(JWTGuard::class);
    $auth = $this->createMock(Factory::class);
    $payload = $this->createMock(Payload::class);
    $user = $this->createMock($userClass);


    $auth->expects(self::once())->method("guard")->with("guardName")->willReturn($guard);

    $guard->method('guest')->willReturn($guest);
    $guard->method('getPayload')->willReturn($payload);
    $guard->method('getUser')->willReturn($user);

    $payload->method('hasKey')->with('ver')->willReturn($hasVer);
    $payload->method('get')->with(['ver'])->willReturn([7]);

    if ($userClass === UserInterface::class) {
      $user->method('getJwtVersion')->willReturn($userConfirmedVersion);
    }

    return $auth;
  }
//</editor-fold desc="Private Methods">
}

1			<?php
2			declare(strict_types=1);
3
4			/**
5			* Created by PhpStorm.
6			* User: benedikt
7			* Date: 9/17/17
8			* Time: 12:33 AM
9			*/
10
11			namespace Tfboe\FmLib\Tests\Unit\Http\Middleware;
12
13			use Illuminate\Contracts\Auth\Factory;
14			use Illuminate\Http\Request;
15			use PHPUnit\Framework\MockObject\MockObject;
16			use ReflectionException;
17			use Tfboe\FmLib\Entity\UserInterface;
18			use Tfboe\FmLib\Exceptions\AuthenticationException;
19			use Tfboe\FmLib\Http\Middleware\Authenticate;
20			use Tfboe\FmLib\Tests\Helpers\UnitTestCase;
21			use Tymon\JWTAuth\Contracts\JWTSubject;
22			use Tymon\JWTAuth\JWTGuard;
23			use Tymon\JWTAuth\Payload;
24
25			/**
26			* Class BaseControllerTest
27			* @package Tests\Unit\App\Http\Controllers
28			*/
29			class AuthenticateTest extends UnitTestCase
30			{
31			//tests also private method disable this tests as soon as all are used in public interfaces
32			//<editor-fold desc="Public Methods">
33
34			/**
35			* @covers \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
36			* @throws ReflectionException
37			*/
38			public function testConstruct()
39			{
40			$authenticate = $this->authenticate();
41			self::assertInstanceOf(Authenticate::class, $authenticate);
42			}
43
44			/**
45			* @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
46			* @throws AuthenticationException
47			* @throws ReflectionException
48			* @uses \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
49			* @uses \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
50			*/
51			public function testHandleGuest()
52			{
53			$this->expectException(AuthenticationException::class);
54			$this->expectExceptionMessage('Not logged in!');
55
56			$auth = $this->getAuth(true, true, UserInterface::class, 6);
57			$authenticate = $this->authenticate($auth);
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report It seems like `$auth` defined by `$this->getAuth(true, tru...serInterface::class, 6)` on line `56` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tfboe\FmLib\Tests\Unit\H...ateTest::authenticate()` does only seem to accept `object<Illuminate\Contracts\Auth\Factory>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
58			$authenticate->handle(null, function () {
			0 ignored issues – show Documentation introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report The method `handle` does only exist in `Tfboe\FmLib\Http\Middleware\Authenticate`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
59			}, "guardName");
60			}
61
62			/**
63			* @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
64			* @throws AuthenticationException
65			* @throws ReflectionException
66			* @uses \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
67			* @uses \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
68			*/
69			public function testHandleNoVer()
70			{
71			$this->expectException(AuthenticationException::class);
72			$this->expectExceptionMessage('Payload version expired!');
73
74			$auth = $this->getAuth(false, false, UserInterface::class, 6);
75			$authenticate = $this->authenticate($auth);
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report It seems like `$auth` defined by `$this->getAuth(false, fa...serInterface::class, 6)` on line `74` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tfboe\FmLib\Tests\Unit\H...ateTest::authenticate()` does only seem to accept `object<Illuminate\Contracts\Auth\Factory>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
76			$authenticate->handle(null, function () {
			0 ignored issues – show Documentation introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report The method `handle` does only exist in `Tfboe\FmLib\Http\Middleware\Authenticate`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
77			}, "guardName");
78			}
79
80			/**
81			* @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
82			* @throws AuthenticationException
83			* @throws ReflectionException
84			* @uses \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
85			* @uses \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
86			*/
87			public function testHandleOldVersion()
88			{
89			$this->expectException(AuthenticationException::class);
90			$this->expectExceptionMessage('Payload version expired!');
91
92			$auth = $this->getAuth(false, true, UserInterface::class, 8);
93			$authenticate = $this->authenticate($auth);
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report It seems like `$auth` defined by `$this->getAuth(false, tr...serInterface::class, 8)` on line `92` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tfboe\FmLib\Tests\Unit\H...ateTest::authenticate()` does only seem to accept `object<Illuminate\Contracts\Auth\Factory>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
94			$authenticate->handle(null, function () {
			0 ignored issues – show Documentation introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report The method `handle` does only exist in `Tfboe\FmLib\Http\Middleware\Authenticate`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
95			}, "guardName");
96			}
97
98			/**
99			* @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
100			* @throws AuthenticationException
101			* @throws ReflectionException
102			* @uses \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
103			*/
104			public function testHandleSuccess()
105			{
106			$auth = $this->getAuth(false, true, UserInterface::class, 6);
107			/** @var Request $request */
108			$request = $this->createMock(Request::class);
109
110			$called = false;
111			$next = function ($req) use (&$called, $request) {
112			self::assertTrue($request === $req);
113			self::assertFalse($called);
114			$called = true;
115			};
116
117			$authenticate = $this->authenticate($auth);
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report It seems like `$auth` defined by `$this->getAuth(false, tr...serInterface::class, 6)` on line `106` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tfboe\FmLib\Tests\Unit\H...ateTest::authenticate()` does only seem to accept `object<Illuminate\Contracts\Auth\Factory>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
118			self::assertFalse($called);
119			$authenticate->handle($request, $next, "guardName");
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report The method `handle` does only exist in `Tfboe\FmLib\Http\Middleware\Authenticate`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
120			self::assertTrue($called);
121			}
122
123			/**
124			* @covers \Tfboe\FmLib\Http\Middleware\Authenticate::handle
125			* @throws AuthenticationException
126			* @throws ReflectionException
127			* @uses \Tfboe\FmLib\Exceptions\AuthenticationException::__construct
128			* @uses \Tfboe\FmLib\Http\Middleware\Authenticate::__construct
129			*/
130			public function testHandleWrongUser()
131			{
132			$this->expectException(AuthenticationException::class);
133			$this->expectExceptionMessage('Payload version expired!');
134
135			$auth = $this->getAuth(false, true, JWTSubject::class, 6);
136			$authenticate = $this->authenticate($auth);
			0 ignored issues – show Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report It seems like `$auth` defined by `$this->getAuth(false, tr...s\JWTSubject::class, 6)` on line `135` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Tfboe\FmLib\Tests\Unit\H...ateTest::authenticate()` does only seem to accept `object<Illuminate\Contracts\Auth\Factory>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
137			$authenticate->handle(null, function () {
			0 ignored issues – show Documentation introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2019-10-19 09:39 UTC by Report Bug Copy Issue Report The method `handle` does only exist in `Tfboe\FmLib\Http\Middleware\Authenticate`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
138			}, "guardName");
139			}
140			//</editor-fold desc="Public Methods">
141
142			//<editor-fold desc="Private Methods">
143			/**
144			* @param Factory\|null $auth
145			* @param array $stubbedMethods
146			* @return Authenticate\|MockObject
147			* @throws ReflectionException
148			*/
149			private function authenticate(?Factory $auth = null,
150			array $stubbedMethods = []): MockObject
151			{
152			if ($auth === null) {
153			$auth = $this->createMock(Factory::class);
154			}
155			return $this->getMockForAbstractClass(Authenticate::class, [$auth], '', true,
156			true, true, $stubbedMethods);
157			}
158
159			/**
160			* @param bool $guest
161			* @param bool $hasVer
162			* @param string $userClass
163			* @param int $userConfirmedVersion
164			* @return MockObject\|Factory
165			*/
166			private function getAuth(bool $guest, bool $hasVer, string $userClass, int $userConfirmedVersion): MockObject
167			{
168			$guard = $this->createMock(JWTGuard::class);
169			$auth = $this->createMock(Factory::class);
170			$payload = $this->createMock(Payload::class);
171			$user = $this->createMock($userClass);
172
173
174			$auth->expects(self::once())->method("guard")->with("guardName")->willReturn($guard);
175
176			$guard->method('guest')->willReturn($guest);
177			$guard->method('getPayload')->willReturn($payload);
178			$guard->method('getUser')->willReturn($user);
179
180			$payload->method('hasKey')->with('ver')->willReturn($hasVer);
181			$payload->method('get')->with(['ver'])->willReturn([7]);
182
183			if ($userClass === UserInterface::class) {
184			$user->method('getJwtVersion')->willReturn($userConfirmedVersion);
185			}
186
187			return $auth;
188			}
189			//</editor-fold desc="Private Methods">
190			}

tfboe / fm-lib

Branch — merging-leagues-tournaments (46817d)

AuthenticateTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like