Tfboe\FmLib\Tests\Unit\Service\RankingSystem\EloRankingTest::testGetChanges()

Complexity

Conditions	10
Paths	144

Size

Total Lines

68

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
  public function testGetChanges(bool $isPlayed, int $gameResult, array $playerInfos)
  {
    $repository = $this->createStub(ObjectRepository::class, ['findBy' => []]);
    $entityManager = $this->createStub(EntityManagerInterface::class, ['getRepository' => $repository]);
    $service = $this->service($entityManager, $this->getObjectCreator());

$entityManager is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a object<Doctrine\ORM\EntityManagerInterface>|null.

    /** @var EloRanking $player1 */

    /** @var Player[] $players */
    $players = [];
    $playersAArray = [];
    $playersBArray = [];
    for ($i = 0; $i < count($playerInfos); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

      $players[$i] = $this->createStub(Player::class, ['getId' => $i]);
      if ($i < count($playerInfos) / 2) {
        $playersAArray[] = $players[$i];
      } else {
        $playersBArray[] = $players[$i];
      }
    }

    $playersA = new ArrayCollection($playersAArray);
    $playersB = new ArrayCollection($playersBArray);
    $game = $this->createStub(Game::class, [
      'getPlayersA' => $playersA,
      'getPlayersB' => $playersB,
    ]);

    $entriesArray = [];
    for ($i = 0; $i < count($playerInfos); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

      $entriesArray[$i] = $this->getRankingSystemListEntry($service, $players[$i]);

It seems like $players[$i] can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Tfboe\FmLib\Tests\Unit\Service\RankingSystem\EloRankingTest::getRankingSystemListEntry() does only seem to accept object<Tfboe\FmLib\Tests\Entity\Player>, maybe add an additional type check?

    }
    $entries = new ArrayCollection($entriesArray);
    $list = $this->createStub(RankingSystemList::class, ['getEntries' => $entries]);
    /** @var $list RankingSystemListInterface */
    foreach ($entries as $entry) {
      /** @var $entry RankingSystemListEntryInterface */
      $entry->setRankingSystemList($list);
    }
    for ($i = 0; $i < count($playerInfos); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

      $info = $playerInfos[$i];
      $entry = $list->getEntries()[$i];
      $entry->setPoints($info['points']);
      $entry->setPlayedGames($info['played']);
      $entry->setNumberRankedEntities($info['ranked']);
      $entry->setRatedGames($info['rated']);
      if (array_key_exists('provisoryRanking', $info)) {
        $list->getEntries()[$i]->setProvisoryRanking($info['provisoryRanking']);
      }
    }
    $game->method('isPlayed')->willReturn($isPlayed);

The method method() does not seem to exist on object<PHPUnit\Framework\MockObject\MockObject>.

    $game->method('getResult')->willReturn($gameResult);

The method method() does not seem to exist on object<PHPUnit\Framework\MockObject\MockObject>.

    /** @var RankingSystemChangeInterface[] $changes */
    $changes = static::callProtectedMethod($service, 'getChanges', [$game, $list]);
    self::assertEquals(count($playerInfos), count($changes));
    foreach ($players as $player) {
      $exists = false;
      foreach ($changes as $change) {
        if ($change->getPlayer() === $player) {
          $exists = true;
          break;
        }
      }
      self::assertTrue($exists);
    }
    /** @var Game $game */
    $this->assertChanges($changes, $playerInfos, $game);
  }

}