tfboe /
fm-lib
| Conditions | 19 |
| Paths | 343 |
| Total Lines | 72 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 61 | public function mergePlayers(PlayerInterface $player, PlayerInterface $toMerge) |
||
| 62 | { |
||
| 63 | if ($player->getId() == $toMerge->getId()) { |
||
| 64 | return "Players are identical!"; |
||
| 65 | } |
||
| 66 | |||
| 67 | /** @var TournamentInterface[] $ts */ |
||
| 68 | $ts = $this->em->createQueryBuilder() |
||
| 69 | ->select("t") |
||
| 70 | ->from(TournamentInterface::class, 't') |
||
| 71 | ->innerJoin('t.competitions', 'c') |
||
| 72 | ->innerJoin('c.teams', 'te') |
||
| 73 | ->innerJoin('te.memberships', 'm') |
||
| 74 | ->where('m.player = (:id)')->setParameter('id', $toMerge->getId()) |
||
| 75 | ->getQuery()->getResult(); |
||
| 76 | |||
| 77 | $tMap = []; |
||
| 78 | foreach ($ts as $tournament) { |
||
| 79 | $tMap[$tournament->getId()] = $tournament; |
||
| 80 | } |
||
| 81 | $ts = array_values($tMap); |
||
| 82 | |||
| 83 | $this->ls->loadEntities($ts); |
||
| 84 | |||
| 85 | //check if player is attendant in one of the tournaments of toMerge |
||
| 86 | foreach ($ts as $tournament) { |
||
| 87 | foreach ($tournament->getCompetitions() as $competition) { |
||
| 88 | foreach ($competition->getTeams() as $team) { |
||
| 89 | foreach ($team->getMemberships() as $membership) { |
||
| 90 | if ($membership->getPlayer()->getId() == $player->getId()) { |
||
| 91 | return "Player 1 and player 2 both attended the tournament " . $tournament->getName() . |
||
| 92 | "(" . $tournament->getStartTime()->format('d.m.Y H:i') . ", id='" . $tournament->getId() . "')"; |
||
| 93 | } |
||
| 94 | } |
||
| 95 | } |
||
| 96 | } |
||
| 97 | } |
||
| 98 | |||
| 99 | //change players |
||
| 100 | foreach ($ts as $tournament) { |
||
| 101 | foreach ($tournament->getCompetitions() as $competition) { |
||
| 102 | $isMember = false; |
||
| 103 | foreach ($competition->getTeams() as $team) { |
||
| 104 | foreach ($team->getMemberships() as $membership) { |
||
| 105 | if ($membership->getPlayer()->getId() == $toMerge->getId()) { |
||
| 106 | $this->rankingSystemService->adaptOpenSyncFromValues($tournament, []); |
||
| 107 | $membership->setPlayer($player); |
||
| 108 | $isMember = true; |
||
| 109 | } |
||
| 110 | } |
||
| 111 | } |
||
| 112 | if ($isMember) { |
||
| 113 | foreach ($competition->getPhases() as $phase) { |
||
| 114 | foreach ($phase->getMatches() as $match) { |
||
| 115 | foreach ($match->getGames() as $game) { |
||
| 116 | if ($game->getPlayersA()->containsKey($toMerge->getId())) { |
||
| 117 | $game->getPlayersA()->remove($toMerge->getId()); |
||
| 118 | $game->getPlayersA()->set($player->getId(), $player); |
||
| 119 | } |
||
| 120 | if ($game->getPlayersB()->containsKey($toMerge->getId())) { |
||
| 121 | $game->getPlayersB()->remove($toMerge->getId()); |
||
| 122 | $game->getPlayersB()->set($player->getId(), $player); |
||
| 123 | } |
||
| 124 | } |
||
| 125 | } |
||
| 126 | } |
||
| 127 | } |
||
| 128 | } |
||
| 129 | } |
||
| 130 | |||
| 131 | return true; |
||
| 132 | } |
||
| 133 | //</editor-fold desc="Public Methods"> |
||
| 134 | } |
