Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
27 | class BaseControllerTest extends UnitTestCase |
||
28 | { |
||
29 | //tests also private method disable this tests as soon as all are used in public interfaces |
||
30 | //<editor-fold desc="Public Methods"> |
||
31 | |||
32 | /** |
||
33 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
34 | */ |
||
35 | View Code Duplication | public function testConstruct() |
|
46 | |||
47 | /** |
||
48 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::datetimetzTransformer() |
||
49 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
50 | */ |
||
51 | public function testDatetimetzTransformer() |
||
64 | |||
65 | /** |
||
66 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::enumTransformer |
||
67 | * @uses \Tfboe\FmLib\Helpers\BasicEnum |
||
68 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
69 | */ |
||
70 | public function testEnumTransformer() |
||
78 | |||
79 | /** |
||
80 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::setFromSpecification |
||
81 | * @uses \Tfboe\FmLib\Entity\Helpers\BaseEntity::methodExists |
||
82 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
83 | */ |
||
84 | View Code Duplication | public function testSetFromSpecificationWithDefault() |
|
95 | |||
96 | /** |
||
97 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::setFromSpecification |
||
98 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
99 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::transformValue |
||
100 | */ |
||
101 | View Code Duplication | public function testSetFromSpecificationWithProperty() |
|
112 | |||
113 | /** |
||
114 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::transformValue |
||
115 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
116 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::getEntityManager |
||
117 | */ |
||
118 | public function testTransformValueByReference() |
||
133 | |||
134 | /** |
||
135 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::transformValue |
||
136 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
137 | */ |
||
138 | View Code Duplication | public function testTransformValueByTransformer() |
|
154 | |||
155 | /** |
||
156 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::transformValue |
||
157 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::transformByType |
||
158 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
159 | */ |
||
160 | View Code Duplication | public function testTransformValueByTypeDateTime() |
|
173 | |||
174 | /** |
||
175 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::transformValue |
||
176 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::transformByType |
||
177 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
178 | */ |
||
179 | public function testTransformValueByTypeDefault() |
||
191 | |||
192 | /** |
||
193 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::validateBySpecification |
||
194 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
195 | */ |
||
196 | public function testValidateBySpecification() |
||
212 | |||
213 | /** |
||
214 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::getDatetimetzFormat |
||
215 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
216 | */ |
||
217 | public function testGetDatetimetzFormat() |
||
223 | |||
224 | /** |
||
225 | * @covers \Tfboe\FmLib\Http\Controllers\BaseController::getEntityManager |
||
226 | * @uses \Tfboe\FmLib\Http\Controllers\BaseController::__construct |
||
227 | */ |
||
228 | public function testGetEntityManager() |
||
235 | //</editor-fold desc="Public Methods"> |
||
236 | |||
237 | //<editor-fold desc="Private Methods"> |
||
238 | /** |
||
239 | * @return MockObject|BaseController |
||
240 | */ |
||
241 | private function controller(): MockObject |
||
247 | //</editor-fold desc="Private Methods"> |
||
248 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.