Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
27 | class RankingSystemChangeTest extends UnitTestCase |
||
28 | { |
||
29 | //<editor-fold desc="Public Methods"> |
||
30 | |||
31 | /** |
||
32 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
33 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
34 | */ |
||
35 | public function testConstructor() |
||
40 | |||
41 | /** |
||
42 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
43 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
44 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::hasProperty |
||
45 | */ |
||
46 | public function testConstructorWithAdditionalKeys() |
||
52 | |||
53 | /** |
||
54 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::getPlayer |
||
55 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::setPlayer |
||
56 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
57 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
58 | */ |
||
59 | View Code Duplication | public function testPlayer() |
|
67 | |||
68 | /** |
||
69 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::setPointsAfterwards |
||
70 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::getPointsAfterwards |
||
71 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
72 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
73 | */ |
||
74 | public function testPointsAfterwards() |
||
81 | |||
82 | /** |
||
83 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::setPointsChange |
||
84 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::getPointsChange |
||
85 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
86 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
87 | */ |
||
88 | public function testPointsChange() |
||
95 | |||
96 | /** |
||
97 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::setRankingSystem |
||
98 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::getRankingSystem |
||
99 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
100 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
101 | */ |
||
102 | public function testRankingSystem() |
||
110 | |||
111 | /** |
||
112 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::setHierarchyEntity |
||
113 | * @covers \Tfboe\FmLib\Entity\Traits\RankingSystemChange::getHierarchyEntity |
||
114 | * @uses \Tfboe\FmLib\Entity\Helpers\SubClassData::initSubClassData |
||
115 | * @uses \Tfboe\FmLib\Entity\Traits\RankingSystemChange::init |
||
116 | */ |
||
117 | public function testTournamentHierarchyEntity() |
||
125 | //</editor-fold desc="Public Methods"> |
||
126 | |||
127 | //<editor-fold desc="Private Methods"> |
||
128 | /** |
||
129 | * @return RankingSystemChangeInterface |
||
130 | */ |
||
131 | private function instance(): RankingSystemChangeInterface |
||
135 | //</editor-fold desc="Private Methods"> |
||
136 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.